@barefootjs/mojolicious 0.30.4 → 0.30.6

package/dist/adapter/expr/operand.d.ts

@@ -11,13 +11,22 @@
  * `isStringTypedOperand` (#2176); `emitIndexAccessPerl` stays Mojo-specific
  * (Perl's `->[]` vs `->{}` split has no Kolon equivalent).
  */
-import { type ParsedExpr } from '@barefootjs/jsx';
+import type { ParsedExpr } from '@barefootjs/jsx';
 /**
- * Lower `arr[index]` to a Perl deref. Perl distinguishes array
- * (`->[$i]`) from hash (`->{$k}`) access, which JS's single `[]` does
- * not — so we pick by the index expression's type: a string-typed key
- * derefs the hash, anything else (the common loop-index / arithmetic
- * case, e.g. `selected()[index]`) derefs the array. #1897.
+ * Lower `arr[index]` to the runtime's polymorphic `bf->get` accessor
+ * (`BarefootJS.pm`, adapter-perl) rather than guessing at compile time
+ * whether `index` is a string key or a numeric index (#2491). Perl
+ * distinguishes array (`->[$i]`) from hash (`->{$k}`) access, which
+ * JS's single `[]` does not — the previous compile-time guess (string-
+ * typed key → hash deref, else → array deref) FAILS FATALLY
+ * ("Not an ARRAY reference") whenever a dynamic key of unknowable type
+ * (e.g. a destructured `.map()` param used as a key, `tone[k]` — the
+ * shared analyzer types it `{kind:'unknown'}`) is applied to a hash-
+ * shaped row, because the guess defaults to the array branch. `bf->get`
+ * dispatches on the receiver's RUNTIME `ref` instead, so it's a strict
+ * superset of the two hand-picked deref forms this used to emit — the
+ * common loop-index case (`selected()[index]`, #1897) keeps working
+ * unchanged.
  */
 export declare function emitIndexAccessPerl(object: ParsedExpr, index: ParsedExpr, emit: (e: ParsedExpr) => string, isStringName: (n: string) => boolean): string;
 //# sourceMappingURL=operand.d.ts.map

package/dist/adapter/expr/operand.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"operand.d.ts","sourceRoot":"","sources":["../../../src/adapter/expr/operand.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,EAAwB,KAAK,UAAU,EAAE,MAAM,iBAAiB,CAAA;AAEvE;;;;;;GAMG;AACH,wBAAgB,mBAAmB,CACjC,MAAM,EAAE,UAAU,EAClB,KAAK,EAAE,UAAU,EACjB,IAAI,EAAE,CAAC,CAAC,EAAE,UAAU,KAAK,MAAM,EAC/B,YAAY,EAAE,CAAC,CAAC,EAAE,MAAM,KAAK,OAAO,GACnC,MAAM,CAKR"}
+{"version":3,"file":"operand.d.ts","sourceRoot":"","sources":["../../../src/adapter/expr/operand.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAA;AAEjD;;;;;;;;;;;;;;;GAeG;AACH,wBAAgB,mBAAmB,CACjC,MAAM,EAAE,UAAU,EAClB,KAAK,EAAE,UAAU,EACjB,IAAI,EAAE,CAAC,CAAC,EAAE,UAAU,KAAK,MAAM,EAC/B,YAAY,EAAE,CAAC,CAAC,EAAE,MAAM,KAAK,OAAO,GACnC,MAAM,CAER"}

package/dist/adapter/index.js

@@ -384,7 +384,7 @@ function staticValueToPerl(value) {
 // src/adapter/expr/emitters.ts
 import {
   groupBinaryOperand,
-  isStringTypedOperand as isStringTypedOperand2,
+  isStringTypedOperand,
   isStringConcatBinary,
   emitParsedExpr,
   identifierPath,
@@ -394,10 +394,8 @@ import {
 } from "@barefootjs/jsx";
 
 // src/adapter/expr/operand.ts
-import { isStringTypedOperand } from "@barefootjs/jsx";
 function emitIndexAccessPerl(object, index, emit, isStringName) {
-  const i = emit(index);
-  return isStringTypedOperand(index, isStringName) ? `${emit(object)}->{${i}}` : `${emit(object)}->[${i}]`;
+  return `bf->get(${emit(object)}, ${emit(index)})`;
 }
 
 // src/adapter/expr/emitters.ts
@@ -467,7 +465,7 @@ class MojoFilterEmitter {
   binary(op, left, right, emit) {
     const l = groupBinaryOperand(left, emit(left));
     const r = groupBinaryOperand(right, emit(right));
-    const isStr = (e) => isStringTypedOperand2(e, this.isStringName);
+    const isStr = (e) => isStringTypedOperand(e, this.isStringName);
     const stringCmp = isStr(left) || isStr(right);
     if ((op === "===" || op === "==") && stringCmp) {
       return `${l} eq ${r}`;
@@ -585,7 +583,7 @@ class MojoTopLevelEmitter {
     }
     const obj = emit(object);
     if (property === "length") {
-      const isStr = (e) => isStringTypedOperand2(e, (n) => this.ctx._isStringValueName(n));
+      const isStr = (e) => isStringTypedOperand(e, (n) => this.ctx._isStringValueName(n));
       const isStringReceiver = isStr(object) || object.kind === "identifier" && this.ctx._isStringValueName(object.name);
       if (isStringReceiver)
         return `bf->length(${obj})`;
@@ -628,7 +626,7 @@ class MojoTopLevelEmitter {
   binary(op, left, right, emit) {
     const l = groupBinaryOperand(left, emit(left));
     const r = groupBinaryOperand(right, emit(right));
-    const isStr = (e) => isStringTypedOperand2(e, (n) => this.ctx._isStringValueName(n));
+    const isStr = (e) => isStringTypedOperand(e, (n) => this.ctx._isStringValueName(n));
     const stringCmp = isStr(left) || isStr(right);
     if ((op === "===" || op === "==") && stringCmp) {
       return `${l} eq ${r}`;

package/dist/build.js

@@ -384,7 +384,7 @@ function staticValueToPerl(value) {
 // src/adapter/expr/emitters.ts
 import {
   groupBinaryOperand,
-  isStringTypedOperand as isStringTypedOperand2,
+  isStringTypedOperand,
   isStringConcatBinary,
   emitParsedExpr,
   identifierPath,
@@ -394,10 +394,8 @@ import {
 } from "@barefootjs/jsx";
 
 // src/adapter/expr/operand.ts
-import { isStringTypedOperand } from "@barefootjs/jsx";
 function emitIndexAccessPerl(object, index, emit, isStringName) {
-  const i = emit(index);
-  return isStringTypedOperand(index, isStringName) ? `${emit(object)}->{${i}}` : `${emit(object)}->[${i}]`;
+  return `bf->get(${emit(object)}, ${emit(index)})`;
 }
 
 // src/adapter/expr/emitters.ts
@@ -467,7 +465,7 @@ class MojoFilterEmitter {
   binary(op, left, right, emit) {
     const l = groupBinaryOperand(left, emit(left));
     const r = groupBinaryOperand(right, emit(right));
-    const isStr = (e) => isStringTypedOperand2(e, this.isStringName);
+    const isStr = (e) => isStringTypedOperand(e, this.isStringName);
     const stringCmp = isStr(left) || isStr(right);
     if ((op === "===" || op === "==") && stringCmp) {
       return `${l} eq ${r}`;
@@ -585,7 +583,7 @@ class MojoTopLevelEmitter {
     }
     const obj = emit(object);
     if (property === "length") {
-      const isStr = (e) => isStringTypedOperand2(e, (n) => this.ctx._isStringValueName(n));
+      const isStr = (e) => isStringTypedOperand(e, (n) => this.ctx._isStringValueName(n));
       const isStringReceiver = isStr(object) || object.kind === "identifier" && this.ctx._isStringValueName(object.name);
       if (isStringReceiver)
         return `bf->length(${obj})`;
@@ -628,7 +626,7 @@ class MojoTopLevelEmitter {
   binary(op, left, right, emit) {
     const l = groupBinaryOperand(left, emit(left));
     const r = groupBinaryOperand(right, emit(right));
-    const isStr = (e) => isStringTypedOperand2(e, (n) => this.ctx._isStringValueName(n));
+    const isStr = (e) => isStringTypedOperand(e, (n) => this.ctx._isStringValueName(n));
     const stringCmp = isStr(left) || isStr(right);
     if ((op === "===" || op === "==") && stringCmp) {
       return `${l} eq ${r}`;

package/dist/index.js

@@ -384,7 +384,7 @@ function staticValueToPerl(value) {
 // src/adapter/expr/emitters.ts
 import {
   groupBinaryOperand,
-  isStringTypedOperand as isStringTypedOperand2,
+  isStringTypedOperand,
   isStringConcatBinary,
   emitParsedExpr,
   identifierPath,
@@ -394,10 +394,8 @@ import {
 } from "@barefootjs/jsx";
 
 // src/adapter/expr/operand.ts
-import { isStringTypedOperand } from "@barefootjs/jsx";
 function emitIndexAccessPerl(object, index, emit, isStringName) {
-  const i = emit(index);
-  return isStringTypedOperand(index, isStringName) ? `${emit(object)}->{${i}}` : `${emit(object)}->[${i}]`;
+  return `bf->get(${emit(object)}, ${emit(index)})`;
 }
 
 // src/adapter/expr/emitters.ts
@@ -467,7 +465,7 @@ class MojoFilterEmitter {
   binary(op, left, right, emit) {
     const l = groupBinaryOperand(left, emit(left));
     const r = groupBinaryOperand(right, emit(right));
-    const isStr = (e) => isStringTypedOperand2(e, this.isStringName);
+    const isStr = (e) => isStringTypedOperand(e, this.isStringName);
     const stringCmp = isStr(left) || isStr(right);
     if ((op === "===" || op === "==") && stringCmp) {
       return `${l} eq ${r}`;
@@ -585,7 +583,7 @@ class MojoTopLevelEmitter {
     }
     const obj = emit(object);
     if (property === "length") {
-      const isStr = (e) => isStringTypedOperand2(e, (n) => this.ctx._isStringValueName(n));
+      const isStr = (e) => isStringTypedOperand(e, (n) => this.ctx._isStringValueName(n));
       const isStringReceiver = isStr(object) || object.kind === "identifier" && this.ctx._isStringValueName(object.name);
       if (isStringReceiver)
         return `bf->length(${obj})`;
@@ -628,7 +626,7 @@ class MojoTopLevelEmitter {
   binary(op, left, right, emit) {
     const l = groupBinaryOperand(left, emit(left));
     const r = groupBinaryOperand(right, emit(right));
-    const isStr = (e) => isStringTypedOperand2(e, (n) => this.ctx._isStringValueName(n));
+    const isStr = (e) => isStringTypedOperand(e, (n) => this.ctx._isStringValueName(n));
     const stringCmp = isStr(left) || isStr(right);
     if ((op === "===" || op === "==") && stringCmp) {
       return `${l} eq ${r}`;
@@ -1936,9 +1934,8 @@ var conformancePins = {
 };
 // src/render-divergences.ts
 var renderDivergences = {
-  "aliased-destructured-prop": "aliased destructured prop `{ n: count }` loses its rename — template vars, ssr-defaults, and the props bridge all key off the local name, so the prop is always undefined (https://github.com/piconic-ai/barefootjs/issues/2460)",
-  "composite-row-child-aliased-prop": "same #2460 defect as `aliased-destructured-prop`, inside a keyed `.map()` loop row: the nested child's renamed prop (`{ n: count }`) is always undefined, so both rows render an empty count (https://github.com/piconic-ai/barefootjs/issues/2460)",
-  "loop-param-shadows-record-template-span": "a dynamic-key element access on a loop row (`tone[k]`) diverges on real Mojolicious at render time (same silent-empty family as ERB/Go/Twig; the Perl-side mechanism needs a dig) (https://github.com/piconic-ai/barefootjs/issues/2491)"
+  "aliased-destructured-prop": "aliased destructured prop `{ n: count }` loses its rename — template vars, ssr-defaults, and the props bridge all key off the local name, so the prop is always undefined (https://github.com/piconic-ai/barefootjs/issues/2524)",
+  "composite-row-child-aliased-prop": "same defect as `aliased-destructured-prop` (#2524), inside a keyed `.map()` loop row: the nested child's renamed prop (`{ n: count }`) is always undefined, so both rows render an empty count (https://github.com/piconic-ai/barefootjs/issues/2524)"
 };
 export {
   renderDivergences,

package/dist/render-divergences.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"render-divergences.d.ts","sourceRoot":"","sources":["../src/render-divergences.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,iBAAiB,CAAA;AAExD,eAAO,MAAM,iBAAiB,EAAE,iBAqB/B,CAAA"}
+{"version":3,"file":"render-divergences.d.ts","sourceRoot":"","sources":["../src/render-divergences.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,iBAAiB,CAAA;AAExD,eAAO,MAAM,iBAAiB,EAAE,iBAsB/B,CAAA"}

package/lib/BarefootJS/Backend/Mojo.pm

@@ -1,5 +1,5 @@
 package BarefootJS::Backend::Mojo;
-our $VERSION = "0.30.2";
+our $VERSION = "0.30.5";
 use Mojo::Base -base, -signatures;
 
 use Mojo::ByteStream qw(b);

package/lib/Mojolicious/Plugin/BarefootJS/DevReload.pm

@@ -1,5 +1,5 @@
 package Mojolicious::Plugin::BarefootJS::DevReload;
-our $VERSION = "0.30.2";
+our $VERSION = "0.30.5";
 use Mojo::Base 'Mojolicious::Plugin', -signatures;
 
 =head1 NAME

package/lib/Mojolicious/Plugin/BarefootJS.pm

@@ -1,5 +1,5 @@
 package Mojolicious::Plugin::BarefootJS;
-our $VERSION = "0.30.2";
+our $VERSION = "0.30.5";
 use Mojo::Base 'Mojolicious::Plugin', -signatures;
 
 use Mojo::File qw(path);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barefootjs/mojolicious",
-  "version": "0.30.4",
+  "version": "0.30.6",
   "description": "Mojolicious EP template adapter for BarefootJS - generates .html.ep files from IR",
   "type": "module",
   "main": "./dist/index.js",
@@ -52,7 +52,7 @@
     "directory": "packages/adapter-mojolicious"
   },
   "dependencies": {
-    "@barefootjs/shared": "0.30.4"
+    "@barefootjs/shared": "0.30.6"
   },
   "peerDependencies": {
     "@barefootjs/jsx": ">=0.2.0",
@@ -60,6 +60,6 @@
   },
   "devDependencies": {
     "@barefootjs/adapter-tests": "0.1.0",
-    "@barefootjs/jsx": "0.30.4"
+    "@barefootjs/jsx": "0.30.6"
   }
 }

package/src/adapter/expr/operand.ts

@@ -12,14 +12,23 @@
  * (Perl's `->[]` vs `->{}` split has no Kolon equivalent).
  */
 
-import { isStringTypedOperand, type ParsedExpr } from '@barefootjs/jsx'
+import type { ParsedExpr } from '@barefootjs/jsx'
 
 /**
- * Lower `arr[index]` to a Perl deref. Perl distinguishes array
- * (`->[$i]`) from hash (`->{$k}`) access, which JS's single `[]` does
- * not — so we pick by the index expression's type: a string-typed key
- * derefs the hash, anything else (the common loop-index / arithmetic
- * case, e.g. `selected()[index]`) derefs the array. #1897.
+ * Lower `arr[index]` to the runtime's polymorphic `bf->get` accessor
+ * (`BarefootJS.pm`, adapter-perl) rather than guessing at compile time
+ * whether `index` is a string key or a numeric index (#2491). Perl
+ * distinguishes array (`->[$i]`) from hash (`->{$k}`) access, which
+ * JS's single `[]` does not — the previous compile-time guess (string-
+ * typed key → hash deref, else → array deref) FAILS FATALLY
+ * ("Not an ARRAY reference") whenever a dynamic key of unknowable type
+ * (e.g. a destructured `.map()` param used as a key, `tone[k]` — the
+ * shared analyzer types it `{kind:'unknown'}`) is applied to a hash-
+ * shaped row, because the guess defaults to the array branch. `bf->get`
+ * dispatches on the receiver's RUNTIME `ref` instead, so it's a strict
+ * superset of the two hand-picked deref forms this used to emit — the
+ * common loop-index case (`selected()[index]`, #1897) keeps working
+ * unchanged.
  */
 export function emitIndexAccessPerl(
   object: ParsedExpr,
@@ -27,8 +36,5 @@ export function emitIndexAccessPerl(
   emit: (e: ParsedExpr) => string,
   isStringName: (n: string) => boolean,
 ): string {
-  const i = emit(index)
-  return isStringTypedOperand(index, isStringName)
-    ? `${emit(object)}->{${i}}`
-    : `${emit(object)}->[${i}]`
+  return `bf->get(${emit(object)}, ${emit(index)})`
 }

package/src/render-divergences.ts

@@ -20,19 +20,20 @@ export const renderDivergences: RenderDivergences = {
   // instead of a fixed regex-shape catalogue) now correctly seeds `todos`
   // from `(props.initialTodos ?? []).map(t => ({ ...t, editing: false }))`.
 
-  // Onboarding TSX-fidelity fixtures (PR #2461): `expectedHtml` is
-  // hand-authored to the CORRECT output because the emission bug lives in
+  // Onboarding TSX-fidelity fixtures (PR #2461): `expectedHtml` was
+  // hand-authored to the CORRECT output while the emission bug lived in
   // the shared compiler layer — every adapter, including the Hono
-  // reference, currently emits the broken form (verified against this
-  // adapter's emitted template; see each fixture's docstring). Graduate
-  // by fixing the shared emission, regenerating `expectedHtml` from the
-  // fixed reference, and deleting these lines (and the matching hono
-  // `skipJsx` entries).
+  // reference, used to emit the broken form. That shared-layer defect
+  // (#2460) is now FIXED (b4f5075): `expectedHtml` is generated from the
+  // Hono reference like any other fixture. The remaining gap is
+  // per-template-adapter — this adapter still keys its template vars /
+  // ssr-defaults / props bridge off the local binding instead of
+  // `sourceName ?? name` — tracked by #2524 (the 7 silent template
+  // adapters). Graduate by applying the same `sourceName ?? name` fix to
+  // this adapter's emission path and deleting these lines (and the
+  // matching hono `skipJsx` entries, already gone).
   'aliased-destructured-prop':
-    'aliased destructured prop `{ n: count }` loses its rename — template vars, ssr-defaults, and the props bridge all key off the local name, so the prop is always undefined (https://github.com/piconic-ai/barefootjs/issues/2460)',
+    'aliased destructured prop `{ n: count }` loses its rename — template vars, ssr-defaults, and the props bridge all key off the local name, so the prop is always undefined (https://github.com/piconic-ai/barefootjs/issues/2524)',
   'composite-row-child-aliased-prop':
-    'same #2460 defect as `aliased-destructured-prop`, inside a keyed `.map()` loop row: the nested child\'s renamed prop (`{ n: count }`) is always undefined, so both rows render an empty count (https://github.com/piconic-ai/barefootjs/issues/2460)',
-
-  'loop-param-shadows-record-template-span':
-    'a dynamic-key element access on a loop row (`tone[k]`) diverges on real Mojolicious at render time (same silent-empty family as ERB/Go/Twig; the Perl-side mechanism needs a dig) (https://github.com/piconic-ai/barefootjs/issues/2491)',
+    'same defect as `aliased-destructured-prop` (#2524), inside a keyed `.map()` loop row: the nested child\'s renamed prop (`{ n: count }`) is always undefined, so both rows render an empty count (https://github.com/piconic-ai/barefootjs/issues/2524)',
 }