@barefootjs/jsx 0.37.1 → 0.39.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/action-accessor.d.ts +159 -0
- package/dist/action-accessor.d.ts.map +1 -0
- package/dist/adapters/env-signal.d.ts +0 -8
- package/dist/adapters/env-signal.d.ts.map +1 -1
- package/dist/adapters/interface.d.ts +12 -0
- package/dist/adapters/interface.d.ts.map +1 -1
- package/dist/adapters/jsx-adapter.d.ts.map +1 -1
- package/dist/analyzer.d.ts +61 -1
- package/dist/analyzer.d.ts.map +1 -1
- package/dist/async-action-refusal.d.ts +45 -0
- package/dist/async-action-refusal.d.ts.map +1 -0
- package/dist/builtin-lowering-plugins.d.ts.map +1 -1
- package/dist/compiler.d.ts.map +1 -1
- package/dist/component-root-scope-comment.d.ts +36 -0
- package/dist/component-root-scope-comment.d.ts.map +1 -0
- package/dist/debug.d.ts +61 -5
- package/dist/debug.d.ts.map +1 -1
- package/dist/errors.d.ts +7 -0
- package/dist/errors.d.ts.map +1 -1
- package/dist/event-handler-name.d.ts +13 -0
- package/dist/event-handler-name.d.ts.map +1 -0
- package/dist/expression-parser.d.ts +9 -0
- package/dist/expression-parser.d.ts.map +1 -1
- package/dist/format-date-refusal.d.ts +33 -0
- package/dist/format-date-refusal.d.ts.map +1 -0
- package/dist/index.d.ts +6 -4
- package/dist/index.d.ts.map +1 -1
- package/dist/index.js +3260 -1914
- package/dist/ir-to-client-js/build-references.d.ts.map +1 -1
- package/dist/ir-to-client-js/collect-elements.d.ts.map +1 -1
- package/dist/ir-to-client-js/compute-inlinability.d.ts.map +1 -1
- package/dist/ir-to-client-js/compute-scope.d.ts.map +1 -1
- package/dist/ir-to-client-js/control-flow/plan/build-branch-loop.d.ts.map +1 -1
- package/dist/ir-to-client-js/control-flow/plan/build-component-loop.d.ts.map +1 -1
- package/dist/ir-to-client-js/control-flow/plan/build-composite-loop.d.ts.map +1 -1
- package/dist/ir-to-client-js/control-flow/plan/build-loop-child-arm.d.ts.map +1 -1
- package/dist/ir-to-client-js/control-flow/plan/build-loop.d.ts.map +1 -1
- package/dist/ir-to-client-js/control-flow/plan/insert.d.ts +2 -0
- package/dist/ir-to-client-js/control-flow/plan/insert.d.ts.map +1 -1
- package/dist/ir-to-client-js/control-flow/plan/lazy-row-eligibility.d.ts +1 -1
- package/dist/ir-to-client-js/control-flow/plan/loop.d.ts +57 -12
- package/dist/ir-to-client-js/control-flow/plan/loop.d.ts.map +1 -1
- package/dist/ir-to-client-js/control-flow/shared.d.ts +44 -3
- package/dist/ir-to-client-js/control-flow/shared.d.ts.map +1 -1
- package/dist/ir-to-client-js/control-flow/stringify/component-loop.d.ts +7 -5
- package/dist/ir-to-client-js/control-flow/stringify/component-loop.d.ts.map +1 -1
- package/dist/ir-to-client-js/csr-substitute.d.ts.map +1 -1
- package/dist/ir-to-client-js/declaration-sort.d.ts +2 -1
- package/dist/ir-to-client-js/declaration-sort.d.ts.map +1 -1
- package/dist/ir-to-client-js/emit-module-level.d.ts.map +1 -1
- package/dist/ir-to-client-js/emit-reactive.d.ts +43 -2
- package/dist/ir-to-client-js/emit-reactive.d.ts.map +1 -1
- package/dist/ir-to-client-js/emit-registration.d.ts.map +1 -1
- package/dist/ir-to-client-js/html-template.d.ts.map +1 -1
- package/dist/ir-to-client-js/plan/declaration-emit.d.ts +7 -5
- package/dist/ir-to-client-js/plan/declaration-emit.d.ts.map +1 -1
- package/dist/ir-to-client-js/prop-handling.d.ts.map +1 -1
- package/dist/ir-to-client-js/reactivity.d.ts +9 -1
- package/dist/ir-to-client-js/reactivity.d.ts.map +1 -1
- package/dist/ir-to-client-js/source-map.d.ts.map +1 -1
- package/dist/ir-to-client-js/types.d.ts +4 -0
- package/dist/ir-to-client-js/types.d.ts.map +1 -1
- package/dist/ir-to-client-js/utils.d.ts +66 -1
- package/dist/ir-to-client-js/utils.d.ts.map +1 -1
- package/dist/jsx-to-ir.d.ts.map +1 -1
- package/dist/opaque-local-accessor.d.ts +27 -0
- package/dist/opaque-local-accessor.d.ts.map +1 -0
- package/dist/signal-initializer.d.ts +24 -0
- package/dist/signal-initializer.d.ts.map +1 -0
- package/dist/template-position-walk.d.ts +68 -0
- package/dist/template-position-walk.d.ts.map +1 -0
- package/dist/to-locale-date-lowering.d.ts +7 -4
- package/dist/to-locale-date-lowering.d.ts.map +1 -1
- package/dist/types.d.ts +104 -17
- package/dist/types.d.ts.map +1 -1
- package/package.json +2 -2
- package/src/__tests__/__snapshots__/doc-examples.test.ts.snap +878 -4528
- package/src/__tests__/action-accessor.test.ts +166 -0
- package/src/__tests__/binding-scope-ratchet.test.ts +21 -10
- package/src/__tests__/branch-local-in-raw-capture.test.ts +1 -1
- package/src/__tests__/branch-local-same-name-collision.test.ts +9 -9
- package/src/__tests__/client-js-generation.test.ts +175 -0
- package/src/__tests__/component-root-scope-comment.test.ts +106 -0
- package/src/__tests__/create-mutation.test.ts +220 -0
- package/src/__tests__/create-query.test.ts +644 -0
- package/src/__tests__/csr-fragment-root-scope-shape.test.ts +156 -0
- package/src/__tests__/debug.test.ts +222 -0
- package/src/__tests__/doc-examples.test.ts +78 -25
- package/src/__tests__/event-handler-name.test.ts +74 -0
- package/src/__tests__/flatmap-segments.test.ts +11 -9
- package/src/__tests__/format-date-refusal.test.ts +134 -0
- package/src/__tests__/fragment-wrapped-conditional-return-branch.test.ts +132 -0
- package/src/__tests__/hydrate-template.test.ts +9 -1
- package/src/__tests__/issue-2798-static-nested-loop-bindings.test.ts +2 -2
- package/src/__tests__/issue-3009-loop-branch-ref.test.ts +2 -2
- package/src/__tests__/issue-3044-nested-prop-object-array-not-static.test.ts +213 -0
- package/src/__tests__/issue-3113-init-fn-name-collision.test.ts +133 -0
- package/src/__tests__/jsx-return-type-assertion.test.ts +2 -2
- package/src/__tests__/lazy-row-eligibility.test.ts +5 -4
- package/src/__tests__/loop-row-child-children-reactive-attrs.test.ts +108 -0
- package/src/__tests__/loop-row-child-text-children-markers.test.ts +158 -0
- package/src/__tests__/opaque-local-accessor.test.ts +90 -0
- package/src/__tests__/profiler-e2e.test.ts +13 -8
- package/src/__tests__/props-destructuring.test.ts +79 -4
- package/src/__tests__/reactive-factory-arity.test.ts +311 -0
- package/src/__tests__/ref-attr-absent-at-ssr.test.ts +472 -0
- package/src/__tests__/ssr-portal-ref-callback.test.ts +219 -0
- package/src/action-accessor.ts +289 -0
- package/src/adapters/env-signal.ts +2 -21
- package/src/adapters/interface.ts +13 -0
- package/src/adapters/jsx-adapter.ts +17 -0
- package/src/analyzer.ts +589 -60
- package/src/async-action-refusal.ts +254 -0
- package/src/builtin-lowering-plugins.ts +0 -2
- package/src/compiler.ts +27 -0
- package/src/component-root-scope-comment.ts +59 -0
- package/src/debug.ts +318 -103
- package/src/errors.ts +83 -1
- package/src/event-handler-name.ts +14 -0
- package/src/expression-parser.ts +41 -17
- package/src/format-date-refusal.ts +147 -0
- package/src/index.ts +14 -3
- package/src/ir-to-client-js/build-references.ts +6 -2
- package/src/ir-to-client-js/child-components.ts +8 -3
- package/src/ir-to-client-js/collect-elements.ts +28 -13
- package/src/ir-to-client-js/compute-inlinability.ts +2 -1
- package/src/ir-to-client-js/compute-scope.ts +3 -1
- package/src/ir-to-client-js/control-flow/plan/build-branch-loop.ts +2 -4
- package/src/ir-to-client-js/control-flow/plan/build-component-loop.ts +67 -5
- package/src/ir-to-client-js/control-flow/plan/build-composite-loop.ts +3 -6
- package/src/ir-to-client-js/control-flow/plan/build-insert.ts +1 -0
- package/src/ir-to-client-js/control-flow/plan/build-loop-child-arm.ts +2 -1
- package/src/ir-to-client-js/control-flow/plan/build-loop.ts +23 -11
- package/src/ir-to-client-js/control-flow/plan/insert.ts +2 -0
- package/src/ir-to-client-js/control-flow/plan/lazy-row-eligibility.ts +3 -3
- package/src/ir-to-client-js/control-flow/plan/loop.ts +51 -10
- package/src/ir-to-client-js/control-flow/shared.ts +78 -5
- package/src/ir-to-client-js/control-flow/stringify/component-loop.ts +25 -12
- package/src/ir-to-client-js/control-flow/stringify/insert.ts +1 -1
- package/src/ir-to-client-js/csr-substitute.ts +11 -3
- package/src/ir-to-client-js/declaration-sort.ts +7 -3
- package/src/ir-to-client-js/emit-module-level.ts +7 -4
- package/src/ir-to-client-js/emit-reactive.ts +140 -10
- package/src/ir-to-client-js/emit-registration.ts +6 -11
- package/src/ir-to-client-js/generate-init.ts +2 -2
- package/src/ir-to-client-js/html-template.ts +41 -19
- package/src/ir-to-client-js/index.ts +9 -3
- package/src/ir-to-client-js/phases/ref-callbacks.ts +1 -1
- package/src/ir-to-client-js/plan/build-declaration-emit.ts +16 -15
- package/src/ir-to-client-js/plan/declaration-emit.ts +7 -5
- package/src/ir-to-client-js/prop-handling.ts +4 -0
- package/src/ir-to-client-js/reactivity.ts +21 -16
- package/src/ir-to-client-js/source-map.ts +2 -1
- package/src/ir-to-client-js/stringify/declaration-emit.ts +14 -7
- package/src/ir-to-client-js/types.ts +4 -0
- package/src/ir-to-client-js/utils.ts +89 -7
- package/src/jsx-to-ir.ts +772 -50
- package/src/opaque-local-accessor.ts +44 -0
- package/src/rich-type-refusal.ts +1 -1
- package/src/signal-initializer.ts +36 -0
- package/src/template-position-walk.ts +203 -0
- package/src/to-locale-date-lowering.ts +7 -4
- package/src/types.ts +103 -15
- package/dist/format-date-lowering.d.ts +0 -30
- package/dist/format-date-lowering.d.ts.map +0 -1
- package/src/__tests__/create-selector.test.ts +0 -124
- package/src/__tests__/format-date-lowering.test.ts +0 -125
- package/src/format-date-lowering.ts +0 -55
|
@@ -0,0 +1,311 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* BF115 / BF116 (#3159): `createSignal`/`createMemo` called with a
|
|
3
|
+
* destructure arity or argument count the primitive doesn't support.
|
|
4
|
+
*
|
|
5
|
+
* Context: `validateReactiveFactoryCalls` (BF110) exists to diagnose a
|
|
6
|
+
* destructure of an UNRECOGNISED callee — it unconditionally `continue`s
|
|
7
|
+
* past `createSignal`/`createMemo`, so a RECOGNISED callee used with a bad
|
|
8
|
+
* shape fell through with no diagnostic:
|
|
9
|
+
*
|
|
10
|
+
* - `const [user, setUser, extra] = createSignal(props.user)` — a
|
|
11
|
+
* 3-element destructure of `createSignal` (which returns a 2-element
|
|
12
|
+
* `[getter, setter]` tuple) was not recognised as a signal at all.
|
|
13
|
+
* `user` fell through to the "same-name prop" fallback and silently
|
|
14
|
+
* became the raw prop accessor `_p.user()` instead of the signal
|
|
15
|
+
* getter — a real read/write split whose failure mode is "the UI just
|
|
16
|
+
* doesn't update," not a compile error.
|
|
17
|
+
* - `createSignal(props.user, { from: 'router' })` / `createMemo(fn, x)`
|
|
18
|
+
* — an extra argument was silently dropped from the emitted client JS.
|
|
19
|
+
*
|
|
20
|
+
* Both are now loud, per CLAUDE.md's known-limitation policy (`silent` →
|
|
21
|
+
* `refusal`/compile error).
|
|
22
|
+
*/
|
|
23
|
+
|
|
24
|
+
import { describe, test, expect } from 'bun:test'
|
|
25
|
+
import { compileJSX } from '../compiler'
|
|
26
|
+
import { TestAdapter } from '../adapters/test-adapter'
|
|
27
|
+
|
|
28
|
+
const adapter = new TestAdapter()
|
|
29
|
+
|
|
30
|
+
describe('BF115: createSignal/createMemo tuple-destructure arity (#3159)', () => {
|
|
31
|
+
test('a 3-element destructure of createSignal is a compile error, not a silent prop fallback', () => {
|
|
32
|
+
const source = `
|
|
33
|
+
'use client'
|
|
34
|
+
import { createSignal } from '@barefootjs/client'
|
|
35
|
+
|
|
36
|
+
export function Profile({ user }: { user: string }) {
|
|
37
|
+
const [user2, setUser, extra] = createSignal(user)
|
|
38
|
+
return <button onClick={() => setUser('x')}>{user2()}</button>
|
|
39
|
+
}
|
|
40
|
+
`
|
|
41
|
+
const result = compileJSX(source, 'Profile.tsx', { adapter })
|
|
42
|
+
const bf115 = result.errors.find(e => e.code === 'BF115')
|
|
43
|
+
expect(bf115).toBeDefined()
|
|
44
|
+
expect(bf115!.severity).toBe('error')
|
|
45
|
+
expect(bf115!.message).toContain('createSignal')
|
|
46
|
+
})
|
|
47
|
+
|
|
48
|
+
test('the exact same-name-prop collision shape from the issue is caught', () => {
|
|
49
|
+
// `user` names both a prop AND the over-arity destructure's first
|
|
50
|
+
// binding — the shape that silently mis-seeds `user` as `_p.user()`.
|
|
51
|
+
const source = `
|
|
52
|
+
'use client'
|
|
53
|
+
import { createSignal } from '@barefootjs/client'
|
|
54
|
+
|
|
55
|
+
export function Profile({ user }: { user: string }) {
|
|
56
|
+
const [user, setUser, extra] = createSignal(user)
|
|
57
|
+
return <button onClick={() => setUser('x')}>{user()}</button>
|
|
58
|
+
}
|
|
59
|
+
`
|
|
60
|
+
const result = compileJSX(source, 'Profile.tsx', { adapter })
|
|
61
|
+
const bf115 = result.errors.find(e => e.code === 'BF115')
|
|
62
|
+
expect(bf115).toBeDefined()
|
|
63
|
+
})
|
|
64
|
+
|
|
65
|
+
test('a 1-element destructure (getter-only) is still valid — no BF115', () => {
|
|
66
|
+
const source = `
|
|
67
|
+
'use client'
|
|
68
|
+
import { createSignal } from '@barefootjs/client'
|
|
69
|
+
|
|
70
|
+
export function Counter() {
|
|
71
|
+
const [count] = createSignal(0)
|
|
72
|
+
return <span>{count()}</span>
|
|
73
|
+
}
|
|
74
|
+
`
|
|
75
|
+
const result = compileJSX(source, 'Counter.tsx', { adapter })
|
|
76
|
+
expect(result.errors.find(e => e.code === 'BF115')).toBeUndefined()
|
|
77
|
+
})
|
|
78
|
+
|
|
79
|
+
test('a normal 2-element destructure is still valid — no BF115', () => {
|
|
80
|
+
const source = `
|
|
81
|
+
'use client'
|
|
82
|
+
import { createSignal } from '@barefootjs/client'
|
|
83
|
+
|
|
84
|
+
export function Counter() {
|
|
85
|
+
const [count, setCount] = createSignal(0)
|
|
86
|
+
return <button onClick={() => setCount(count() + 1)}>{count()}</button>
|
|
87
|
+
}
|
|
88
|
+
`
|
|
89
|
+
const result = compileJSX(source, 'Counter.tsx', { adapter })
|
|
90
|
+
expect(result.errors.find(e => e.code === 'BF115')).toBeUndefined()
|
|
91
|
+
})
|
|
92
|
+
|
|
93
|
+
test('an array-pattern destructure of createMemo (which returns a single getter) is BF115', () => {
|
|
94
|
+
const source = `
|
|
95
|
+
'use client'
|
|
96
|
+
import { createSignal, createMemo } from '@barefootjs/client'
|
|
97
|
+
|
|
98
|
+
export function Doubled() {
|
|
99
|
+
const [count, setCount] = createSignal(1)
|
|
100
|
+
const [doubled] = createMemo(() => count() * 2)
|
|
101
|
+
return <span onClick={() => setCount(2)}>{doubled()}</span>
|
|
102
|
+
}
|
|
103
|
+
`
|
|
104
|
+
const result = compileJSX(source, 'Doubled.tsx', { adapter })
|
|
105
|
+
const bf115 = result.errors.find(e => e.code === 'BF115')
|
|
106
|
+
expect(bf115).toBeDefined()
|
|
107
|
+
expect(bf115!.message).toContain('createMemo')
|
|
108
|
+
})
|
|
109
|
+
|
|
110
|
+
test('the getter-elided form `const [, setActive]` is still valid — no BF115', () => {
|
|
111
|
+
const source = `
|
|
112
|
+
'use client'
|
|
113
|
+
import { createSignal } from '@barefootjs/client'
|
|
114
|
+
|
|
115
|
+
export function Toggle() {
|
|
116
|
+
const [, setActive] = createSignal(false)
|
|
117
|
+
return <button onClick={() => setActive(true)}>Go</button>
|
|
118
|
+
}
|
|
119
|
+
`
|
|
120
|
+
const result = compileJSX(source, 'Toggle.tsx', { adapter })
|
|
121
|
+
expect(result.errors.find(e => e.code === 'BF115')).toBeUndefined()
|
|
122
|
+
})
|
|
123
|
+
|
|
124
|
+
test('a 0-element destructure gets an accurate message, not the "extra binding(s)" text', () => {
|
|
125
|
+
const source = `
|
|
126
|
+
'use client'
|
|
127
|
+
import { createSignal } from '@barefootjs/client'
|
|
128
|
+
|
|
129
|
+
export function Counter() {
|
|
130
|
+
const [] = createSignal(0)
|
|
131
|
+
return <span>static</span>
|
|
132
|
+
}
|
|
133
|
+
`
|
|
134
|
+
const result = compileJSX(source, 'Counter.tsx', { adapter })
|
|
135
|
+
const bf115 = result.errors.find(e => e.code === 'BF115')
|
|
136
|
+
expect(bf115).toBeDefined()
|
|
137
|
+
// The old wording ("extra binding(s) are silently dropped") makes no
|
|
138
|
+
// sense when nothing at all is bound — nothing is "extra".
|
|
139
|
+
expect(bf115!.message).not.toContain('extra binding')
|
|
140
|
+
expect(bf115!.message).toContain('0 elements')
|
|
141
|
+
})
|
|
142
|
+
|
|
143
|
+
test('a bad-arity createSignal destructure inside a conditional-return branch is still caught (#1414 branch signals)', () => {
|
|
144
|
+
// `collectBranchSignals` gives a top-level `if` whose then-branch returns
|
|
145
|
+
// JSX its own signal-collection scope — the same silent-drop bug BF115
|
|
146
|
+
// exists for at the top level reproduces here too if the diagnostic only
|
|
147
|
+
// ever looks at the component's own top-level statements.
|
|
148
|
+
const source = `
|
|
149
|
+
'use client'
|
|
150
|
+
import { createSignal } from '@barefootjs/client'
|
|
151
|
+
|
|
152
|
+
export function Profile({ flag, user }: { flag: boolean; user: string }) {
|
|
153
|
+
if (flag) {
|
|
154
|
+
const [user2, setUser, extra] = createSignal(user)
|
|
155
|
+
return <button onClick={() => setUser('x')}>{user2()}</button>
|
|
156
|
+
}
|
|
157
|
+
return <div>static</div>
|
|
158
|
+
}
|
|
159
|
+
`
|
|
160
|
+
const result = compileJSX(source, 'Profile.tsx', { adapter })
|
|
161
|
+
const bf115 = result.errors.find(e => e.code === 'BF115')
|
|
162
|
+
expect(bf115).toBeDefined()
|
|
163
|
+
expect(bf115!.message).toContain('createSignal')
|
|
164
|
+
})
|
|
165
|
+
|
|
166
|
+
// Alias resolution itself (`import { createSignal as sig }`) is covered by
|
|
167
|
+
// `primitive-resolver-alias.test.ts`, which requires a real `ts.Program`
|
|
168
|
+
// to exercise the TypeChecker-backed slow path. This check delegates to
|
|
169
|
+
// the same `resolvePrimitiveKind` those tests pin, rather than a bespoke
|
|
170
|
+
// bare-text match — see the doc comment on `validateReactiveFactoryArity`.
|
|
171
|
+
})
|
|
172
|
+
|
|
173
|
+
describe('BF116: createSignal/createMemo extra call arguments (#3159)', () => {
|
|
174
|
+
test('an extra argument to createSignal is a compile error, not a silent drop', () => {
|
|
175
|
+
const source = `
|
|
176
|
+
'use client'
|
|
177
|
+
import { createSignal } from '@barefootjs/client'
|
|
178
|
+
|
|
179
|
+
export function Profile({ user }: { user: string }) {
|
|
180
|
+
const [value, setValue] = createSignal(user, { from: 'router' })
|
|
181
|
+
return <button onClick={() => setValue('x')}>{value()}</button>
|
|
182
|
+
}
|
|
183
|
+
`
|
|
184
|
+
const result = compileJSX(source, 'Profile.tsx', { adapter })
|
|
185
|
+
const bf116 = result.errors.find(e => e.code === 'BF116')
|
|
186
|
+
expect(bf116).toBeDefined()
|
|
187
|
+
expect(bf116!.severity).toBe('error')
|
|
188
|
+
expect(bf116!.message).toContain('createSignal')
|
|
189
|
+
})
|
|
190
|
+
|
|
191
|
+
test('an extra argument to createMemo is a compile error', () => {
|
|
192
|
+
const source = `
|
|
193
|
+
'use client'
|
|
194
|
+
import { createSignal, createMemo } from '@barefootjs/client'
|
|
195
|
+
|
|
196
|
+
export function Doubled() {
|
|
197
|
+
const [count, setCount] = createSignal(1)
|
|
198
|
+
const doubled = createMemo(() => count() * 2, { deep: true })
|
|
199
|
+
return <span onClick={() => setCount(2)}>{doubled()}</span>
|
|
200
|
+
}
|
|
201
|
+
`
|
|
202
|
+
const result = compileJSX(source, 'Doubled.tsx', { adapter })
|
|
203
|
+
const bf116 = result.errors.find(e => e.code === 'BF116')
|
|
204
|
+
expect(bf116).toBeDefined()
|
|
205
|
+
expect(bf116!.message).toContain('createMemo')
|
|
206
|
+
})
|
|
207
|
+
|
|
208
|
+
test('createSignal with zero arguments is still valid — no BF116', () => {
|
|
209
|
+
const source = `
|
|
210
|
+
'use client'
|
|
211
|
+
import { createSignal } from '@barefootjs/client'
|
|
212
|
+
|
|
213
|
+
export function Counter() {
|
|
214
|
+
const [count, setCount] = createSignal<number>()
|
|
215
|
+
return <button onClick={() => setCount(1)}>{count()}</button>
|
|
216
|
+
}
|
|
217
|
+
`
|
|
218
|
+
const result = compileJSX(source, 'Counter.tsx', { adapter })
|
|
219
|
+
expect(result.errors.find(e => e.code === 'BF116')).toBeUndefined()
|
|
220
|
+
})
|
|
221
|
+
|
|
222
|
+
test('createSignal with exactly one argument is still valid — no BF116', () => {
|
|
223
|
+
const source = `
|
|
224
|
+
'use client'
|
|
225
|
+
import { createSignal } from '@barefootjs/client'
|
|
226
|
+
|
|
227
|
+
export function Counter() {
|
|
228
|
+
const [count, setCount] = createSignal(0)
|
|
229
|
+
return <button onClick={() => setCount(count() + 1)}>{count()}</button>
|
|
230
|
+
}
|
|
231
|
+
`
|
|
232
|
+
const result = compileJSX(source, 'Counter.tsx', { adapter })
|
|
233
|
+
expect(result.errors.find(e => e.code === 'BF116')).toBeUndefined()
|
|
234
|
+
})
|
|
235
|
+
|
|
236
|
+
// `createSearchParams` resolves to kind 'signal' too, but takes no
|
|
237
|
+
// arguments at all — its value comes from the request env — so the
|
|
238
|
+
// 1-argument allowance `createSignal` gets must not cover it.
|
|
239
|
+
test('any argument to createSearchParams is a compile error', () => {
|
|
240
|
+
const source = `
|
|
241
|
+
'use client'
|
|
242
|
+
import { createSearchParams } from '@barefootjs/client'
|
|
243
|
+
|
|
244
|
+
export function Sort() {
|
|
245
|
+
const [sp, setSp] = createSearchParams('sort=date')
|
|
246
|
+
return <button onClick={() => setSp({ sort: 'price' })}>{sp().get('sort')}</button>
|
|
247
|
+
}
|
|
248
|
+
`
|
|
249
|
+
const result = compileJSX(source, 'Sort.tsx', { adapter })
|
|
250
|
+
const bf116 = result.errors.find(e => e.code === 'BF116')
|
|
251
|
+
expect(bf116).toBeDefined()
|
|
252
|
+
expect(bf116!.severity).toBe('error')
|
|
253
|
+
expect(bf116!.message).toContain('createSearchParams')
|
|
254
|
+
expect(bf116!.message).toContain('takes no arguments')
|
|
255
|
+
})
|
|
256
|
+
|
|
257
|
+
test('createSearchParams with zero arguments is still valid — no BF116', () => {
|
|
258
|
+
const source = `
|
|
259
|
+
'use client'
|
|
260
|
+
import { createSearchParams } from '@barefootjs/client'
|
|
261
|
+
|
|
262
|
+
export function Sort() {
|
|
263
|
+
const [sp, setSp] = createSearchParams()
|
|
264
|
+
return <button onClick={() => setSp({ sort: 'price' })}>{sp().get('sort')}</button>
|
|
265
|
+
}
|
|
266
|
+
`
|
|
267
|
+
const result = compileJSX(source, 'Sort.tsx', { adapter })
|
|
268
|
+
expect(result.errors.find(e => e.code === 'BF116')).toBeUndefined()
|
|
269
|
+
})
|
|
270
|
+
})
|
|
271
|
+
|
|
272
|
+
// Async factories (`createQuery` #3165, `createMutation` #3210) return
|
|
273
|
+
// `[value, action]` and take a request function plus options, so the same
|
|
274
|
+
// pass checks them against 2 elements and 2 arguments.
|
|
275
|
+
describe('BF115 / BF116: async factories (#3165, #3210)', () => {
|
|
276
|
+
const compileWith = (factory: string, binding: string, args: string) =>
|
|
277
|
+
compileJSX(
|
|
278
|
+
`
|
|
279
|
+
'use client'
|
|
280
|
+
import { ${factory}, http } from '@barefootjs/client'
|
|
281
|
+
|
|
282
|
+
export function C() {
|
|
283
|
+
const ${binding} = ${factory}(${args})
|
|
284
|
+
return <p>x</p>
|
|
285
|
+
}
|
|
286
|
+
`,
|
|
287
|
+
'C.tsx',
|
|
288
|
+
{ adapter },
|
|
289
|
+
)
|
|
290
|
+
|
|
291
|
+
for (const factory of ['createQuery', 'createMutation']) {
|
|
292
|
+
test(`${factory}: a 3-element destructure is BF115, naming the [value, action] shape`, () => {
|
|
293
|
+
const result = compileWith(factory, '[a, b, c]', "() => http.post('/x')")
|
|
294
|
+
const bf115 = result.errors.find(e => e.code === 'BF115')
|
|
295
|
+
expect(bf115).toBeDefined()
|
|
296
|
+
expect(bf115!.message).toContain(`'${factory}(...)' returns a 2-element tuple '[value, action]'`)
|
|
297
|
+
})
|
|
298
|
+
|
|
299
|
+
test(`${factory}: a third argument is BF116`, () => {
|
|
300
|
+
const result = compileWith(factory, '[a]', "() => http.post('/x'), {}, 'extra'")
|
|
301
|
+
expect(result.errors.map(e => e.code)).toEqual(['BF116'])
|
|
302
|
+
})
|
|
303
|
+
|
|
304
|
+
test(`${factory}: [value, action], [value] and [, action] with two arguments are valid`, () => {
|
|
305
|
+
for (const binding of ['[a, b]', '[a]', '[, b]']) {
|
|
306
|
+
const result = compileWith(factory, binding, "() => http.post('/x'), {}")
|
|
307
|
+
expect(result.errors.map(e => e.code)).toEqual([])
|
|
308
|
+
}
|
|
309
|
+
})
|
|
310
|
+
}
|
|
311
|
+
})
|