@barefootjs/go-template 0.35.0 → 0.35.2

package/dist/index.js

@@ -876,21 +876,38 @@ function lowerUrlGuard(ctx, g) {
   if (isBoolShape) {
     return ctx.convertConditionToGo(stringifyParsedExpr(g), g).condition;
   }
-  const valueGo = wrapIfMultiToken(ctx.convertExpressionToGo(stringifyParsedExpr(g), undefined, g));
+  const valueGo = lowerValueOperand(ctx, g);
   return `ne ${valueGo} ""`;
 }
 function lowerTernary(ctx, test, consequent, alternate) {
   const t = lowerTernaryTest(ctx, test);
-  return `(bf_ternary ${t} ${lowerTernaryOperand(ctx, consequent)} ${lowerTernaryOperand(ctx, alternate)})`;
+  return `(bf_ternary ${t} ${lowerValueOperand(ctx, consequent)} ${lowerValueOperand(ctx, alternate)})`;
 }
-function lowerTernaryOperand(ctx, n) {
+function lowerTemplateLiteralValue(ctx, parts) {
+  const terms = [];
+  for (const part of parts) {
+    if (part.type === "string") {
+      if (part.value !== "")
+        terms.push(`"${escapeGoString(part.value)}"`);
+    } else {
+      terms.push(lowerValueOperand(ctx, part.expr));
+    }
+  }
+  if (terms.length === 0)
+    return '""';
+  return terms.slice(1).reduce((acc, t) => `(bf_concat_str ${acc} ${t})`, terms[0]);
+}
+function lowerValueOperand(ctx, n) {
   if (n.kind === "conditional") {
     return lowerTernary(ctx, n.test, n.consequent, n.alternate);
   }
+  if (n.kind === "template-literal") {
+    return wrapIfMultiToken(lowerTemplateLiteralValue(ctx, n.parts));
+  }
   return wrapIfMultiToken(ctx.convertExpressionToGo(stringifyParsedExpr(n), undefined, n));
 }
 function lowerTernaryTest(ctx, test) {
-  const go = wrapIfMultiToken(ctx.convertExpressionToGo(stringifyParsedExpr(test), undefined, test));
+  const go = lowerValueOperand(ctx, test);
   const isBoolShape = test.kind === "binary" && BOOL_COMPARISON_OPS.has(test.op) || test.kind === "unary" && test.op === "!" || test.kind === "literal" && test.literalType === "boolean";
   return isBoolShape ? go : `(bf_truthy ${go})`;
 }
@@ -951,18 +968,16 @@ function renderLoweringNode(ctx, node) {
   const helper = goHelperName(node.helper);
   if (!helper)
     return null;
-  const lowerExpr = (n) => ctx.convertExpressionToGo(stringifyParsedExpr(n), undefined, n);
-  const lowerArg = (n) => n.kind === "conditional" ? lowerTernary(ctx, n.test, n.consequent, n.alternate) : wrapIfMultiToken(lowerExpr(n));
   if (node.kind === "helper-call") {
-    const args = node.args.map((a) => lowerArg(a));
+    const args = node.args.map((a) => lowerValueOperand(ctx, a));
     return [helper, ...args].join(" ");
   }
-  const parts = [wrapIfMultiToken(lowerExpr(node.base))];
+  const parts = [lowerValueOperand(ctx, node.base)];
   for (const t of node.triples) {
     const includeGo = t.guard === null ? "true" : lowerUrlGuard(ctx, t.guard);
     parts.push(`(${includeGo})`);
     parts.push(JSON.stringify(t.key));
-    parts.push(wrapIfMultiToken(lowerExpr(t.value)));
+    parts.push(lowerValueOperand(ctx, t.value));
   }
   return `${helper} ${parts.join(" ")}`;
 }
@@ -1210,12 +1225,9 @@ function convertInitialValue(ctx, value, _typeInfo, propsParams, preParsed) {
     const inlinedStr = ctx.resolveModuleStringConst(value);
     if (inlinedStr !== null)
       return inlinedStr;
-    const inlinedNum = ctx.resolveModuleNumericConst(value);
-    if (inlinedNum !== null)
-      return inlinedNum;
-    const inlinedBool = ctx.resolveModuleBooleanConst(value);
-    if (inlinedBool !== null)
-      return inlinedBool;
+    const inlinedConst = ctx.resolveModuleConstAsGo(value, { kind: "go-source", bakeType: typeInfo });
+    if (inlinedConst !== null)
+      return inlinedConst;
   }
   const propName = ctx.extractPropNameFromInitialValue(value, preParsed);
   const param = propName ? propsParams?.find((p) => p.name === propName) : undefined;
@@ -2937,8 +2949,7 @@ class GoTemplateAdapter extends BaseAdapter {
     extractPropFallback: (initialValue, preParsed) => this.extractPropFallback(initialValue, preParsed),
     extractCollisionDerivation: (parsed) => this.extractCollisionDerivation(parsed),
     resolveModuleStringConst: (name) => this.resolveModuleStringConst(name),
-    resolveModuleNumericConst: (name) => this.resolveModuleNumericConst(name),
-    resolveModuleBooleanConst: (name) => this.resolveModuleBooleanConst(name)
+    resolveModuleConstAsGo: (name, target) => this.resolveModuleConstAsGo(name, target)
   };
   get errors() {
     return this.state.errors;
@@ -5136,9 +5147,9 @@ ${goFields.join(`
     const inlined = this.resolveModuleStringConst(name);
     if (inlined !== null)
       return inlined;
-    const inlinedNum = this.resolveModuleNumericConst(name);
-    if (inlinedNum !== null)
-      return inlinedNum;
+    const inlinedScalar = this.resolveModuleConstAsGo(name, { kind: "template-action" });
+    if (inlinedScalar !== null)
+      return inlinedScalar;
     if (this.isCurrentLoopItem(name))
       return ".";
     if (this.isOuterLoopParam(name))
@@ -5215,11 +5226,18 @@ ${goFields.join(`
     return hit !== null && hit.depth > 0 && hit.binding.source === "item";
   }
   rootFieldRef(name) {
-    const resolved = this.state.getterAliases.get(name) ?? this.state.propDestructureAliases.get(name) ?? name;
+    const resolved = this.resolveRootFieldAlias(name);
     this.state.templateReadRootFields.add(resolved);
     const prefix = this.inLoop ? "$." : ".";
     return `${prefix}${capitalizeFieldName(resolved)}`;
   }
+  resolveRootFieldAlias(name) {
+    return this.state.getterAliases.get(name) ?? this.state.propDestructureAliases.get(name) ?? name;
+  }
+  filterRootFieldRef(name) {
+    this.rootFieldRef(name);
+    return `$.${capitalizeFieldName(this.resolveRootFieldAlias(name))}`;
+  }
   searchParamsFieldRef(name) {
     return this.state.searchParamsLocals.has(name) ? this.rootFieldRef("searchParams") : null;
   }
@@ -5241,20 +5259,7 @@ ${goFields.join(`
   findModuleConst(name) {
     return this.state.localConstants.find((k) => k.name === name && k.isModule && !k.containsArrow);
   }
-  resolveModuleNumericConst(name) {
-    if (this.isCurrentLoopItem(name))
-      return null;
-    if (this.loopVarRefCount.has(name))
-      return null;
-    if (this.isOuterLoopParam(name))
-      return null;
-    const c = this.findModuleConst(name);
-    if (!c || c.value === undefined)
-      return null;
-    const v = c.value.trim().replace(/(?<=\d)_(?=\d)/g, "");
-    return /^-?\d+(\.\d+)?$/.test(v) ? v : null;
-  }
-  resolveModuleBooleanConst(name) {
+  resolveModuleConstAsGo(name, target) {
     if (this.isCurrentLoopItem(name))
       return null;
     if (this.loopVarRefCount.has(name))
@@ -5262,10 +5267,13 @@ ${goFields.join(`
     if (this.isOuterLoopParam(name))
       return null;
     const c = this.findModuleConst(name);
-    if (!c || c.value === undefined)
+    if (!c?.parsed)
       return null;
-    const v = c.value.trim();
-    return v === "true" || v === "false" ? v : null;
+    if (target.kind === "template-action") {
+      return c.parsed.kind === "literal" || c.parsed.kind === "unary" ? parsedLiteralToGo(this.emitCtx, c.parsed) : null;
+    }
+    const bakeType = target.bakeType.kind !== "unknown" ? target.bakeType : c.type ?? undefined;
+    return parsedLiteralToGo(this.emitCtx, c.parsed, bakeType);
   }
   literal(value, literalType) {
     if (literalType === "string")
@@ -5354,11 +5362,17 @@ ${goFields.join(`
     return `${obj}.${goFieldNameForKey(property)}`;
   }
   indexAccess(object, index, emit) {
-    return `bf_get ${wrapIfMultiToken(emit(object))} ${wrapIfMultiToken(emit(index))}`;
+    return `bf_get ${wrapIfMultiToken(this.emitOperand(object, emit))} ${wrapIfMultiToken(this.emitOperand(index, emit))}`;
+  }
+  emitOperand(n, emit) {
+    if (n.kind === "template-literal") {
+      return wrapIfMultiToken(lowerTemplateLiteralValue(this.emitCtx, n.parts));
+    }
+    return emit(n);
   }
   binary(op, left, right, emit) {
-    const l = emit(left);
-    const r = emit(right);
+    const l = this.emitOperand(left, emit);
+    const r = this.emitOperand(right, emit);
     const wl = wrapIfMultiToken(l);
     const wr = wrapIfMultiToken(r);
     switch (op) {
@@ -5404,7 +5418,7 @@ ${goFields.join(`
     return this.state.stringValueNames.has(name);
   }
   unary(op, argument, emit) {
-    const arg = emit(argument);
+    const arg = this.emitOperand(argument, emit);
     if (op === "!")
       return `not ${wrapIfMultiToken(arg)}`;
     if (op === "-")
@@ -5412,8 +5426,8 @@ ${goFields.join(`
     return arg;
   }
   logical(op, left, right, emit) {
-    const wrapLeft = wrapIfMultiToken(emit(left));
-    const wrapRight = wrapIfMultiToken(emit(right));
+    const wrapLeft = wrapIfMultiToken(this.emitOperand(left, emit));
+    const wrapRight = wrapIfMultiToken(this.emitOperand(right, emit));
     if (op === "&&")
       return `and ${wrapLeft} ${wrapRight}`;
     if (op === "??" && this.nillablePropNameOf(left) !== null) {
@@ -5578,7 +5592,8 @@ ${goFields.join(`
     }
     return this.pushCallbackBF101(method, true);
   }
-  arrayMethod(method, object, args, emit) {
+  arrayMethod(method, object, args, rawEmit) {
+    const emit = (e) => this.emitOperand(e, rawEmit);
     switch (method) {
       case "join": {
         const obj = emit(object);
@@ -5907,11 +5922,9 @@ ${goFields.join(`
         }
         const signal = localVarMap.get(expr.name);
         if (signal) {
-          this.rootFieldRef(signal);
-          return `$.${capitalizeFieldName(signal)}`;
+          return this.filterRootFieldRef(signal);
         }
-        this.rootFieldRef(expr.name);
-        return `.${capitalizeFieldName(expr.name)}`;
+        return this.filterRootFieldRef(expr.name);
       }
       case "literal":
         if (expr.literalType === "string") {
@@ -5925,6 +5938,9 @@ ${goFields.join(`
         if (expr.object.kind === "identifier" && expr.object.name === param) {
           return `${paramPrefix}.${capitalizeFieldName(expr.property)}`;
         }
+        if (expr.object.kind === "identifier" && this.state.propsObjectName && expr.object.name === this.state.propsObjectName) {
+          return this.filterRootFieldRef(expr.property);
+        }
         if (expr.property === "length") {
           const innerHO = this.higherOrderShapeOf(expr.object);
           if (innerHO && innerHO.method === "filter") {
@@ -5943,8 +5959,7 @@ ${goFields.join(`
           return `${paramPrefix}.${capitalizeFieldName(expr.callee.property)}`;
         }
         if (expr.callee.kind === "identifier" && expr.args.length === 0) {
-          this.rootFieldRef(expr.callee.name);
-          return `$.${capitalizeFieldName(expr.callee.name)}`;
+          return this.filterRootFieldRef(expr.callee.name);
         }
         if (asCallbackMethodCall4(expr) !== null) {
           return this.refuseFilterExprNode(expr);
@@ -5974,29 +5989,33 @@ ${goFields.join(`
         const right = this.renderFilterExpr(expr.right, param, localVarMap, datumField);
         if (this.filterExprUnsupported)
           return "false";
+        const wl = wrapIfMultiToken(left);
+        const wr = wrapIfMultiToken(right);
         switch (expr.op) {
           case "===":
           case "==":
-            return `eq ${left} ${right}`;
+            return `eq ${wl} ${wr}`;
           case "!==":
           case "!=":
-            return `ne ${left} ${right}`;
+            return `ne ${wl} ${wr}`;
           case ">":
-            return `gt ${left} ${right}`;
+            return `gt ${wl} ${wr}`;
           case "<":
-            return `lt ${left} ${right}`;
+            return `lt ${wl} ${wr}`;
           case ">=":
-            return `ge ${left} ${right}`;
+            return `ge ${wl} ${wr}`;
           case "<=":
-            return `le ${left} ${right}`;
+            return `le ${wl} ${wr}`;
           case "+":
-            return this._emitPlus(expr.left, expr.right, left, right);
+            return this._emitPlus(expr.left, expr.right, wl, wr);
           case "-":
-            return `bf_sub ${left} ${right}`;
+            return `bf_sub ${wl} ${wr}`;
           case "*":
-            return `bf_mul ${left} ${right}`;
+            return `bf_mul ${wl} ${wr}`;
           case "/":
-            return `bf_div ${left} ${right}`;
+            return `bf_div ${wl} ${wr}`;
+          case "%":
+            return `bf_mod ${wl} ${wr}`;
           default:
             return `${left} ${expr.op} ${right}`;
         }
@@ -6168,11 +6187,9 @@ ${goFields.join(`
         }
         continue;
       }
-      const singlePartTemplateLiteral = exprOut.parsed?.kind === "template-literal" && exprOut.parsed.parts.length === 1 && exprOut.parsed.parts[0].type !== "string" && go.startsWith("{{") && go.endsWith("}}");
-      if (singlePartTemplateLiteral) {
-        go = go.slice(2, -2);
-      }
-      if (!singlePartTemplateLiteral && this.isTemplateFragment(go, exprOut.parsed?.kind)) {
+      if (exprOut.parsed?.kind === "template-literal" || exprOut.parsed?.kind === "conditional") {
+        go = lowerValueOperand(this.emitCtx, exprOut.parsed);
+      } else if (this.isTemplateFragment(go, exprOut.parsed?.kind)) {
         this.state.errors.push({
           code: "BF101",
           severity: "error",
@@ -6449,6 +6466,9 @@ ${goFields.join(`
           case "/":
             result = `bf_div ${left} ${right}`;
             break;
+          case "%":
+            result = `bf_mod ${left} ${right}`;
+            break;
           default:
             result = `${left} ${expr.op} ${right}`;
         }
@@ -6475,7 +6495,7 @@ ${goFields.join(`
         return plain(lowerTernary(this.emitCtx, expr.test, expr.consequent, expr.alternate));
       }
       case "template-literal":
-        return plain(this.renderParsedExpr(expr));
+        return plain(lowerTemplateLiteralValue(this.emitCtx, expr.parts));
       case "arrow":
         return plain("[ARROW-FN]");
       case "regex":
@@ -7076,8 +7096,8 @@ var conformancePins = {
   "filter-nested-find-predicate": [{ code: "BF101", severity: "error", issue: "https://github.com/piconic-ai/barefootjs/issues/2320" }],
   "date-method-uncatalogued": [{ code: "BF021", severity: "error", issue: "https://github.com/piconic-ai/barefootjs/issues/2356" }],
   "rich-prop-client-read": [{ code: "BF049", severity: "error", issue: "https://github.com/piconic-ai/barefootjs/issues/2648" }],
-  "jsx-element-prop-ternary": [{ code: "BF021", severity: "error", issue: "https://github.com/piconic-ai/barefootjs/issues/2667" }],
-  "jsx-element-prop-array": [{ code: "BF021", severity: "error", issue: "https://github.com/piconic-ai/barefootjs/issues/2667" }],
+  "jsx-element-prop-ternary": [{ code: "BF021", severity: "error" }],
+  "jsx-element-prop-array": [{ code: "BF021", severity: "error" }],
   "jsx-element-prop-rest-bag-dynamic": [{
     code: "BF101",
     severity: "error",
@@ -7089,7 +7109,7 @@ var conformancePins = {
     severity: "error",
     issue: "https://github.com/piconic-ai/barefootjs/issues/2700"
   }],
-  "namespace-import-primitive": [{ code: "BF013", severity: "error", issue: "https://github.com/piconic-ai/barefootjs/issues/2771" }]
+  "namespace-import-primitive": [{ code: "BF013", severity: "error" }]
 };
 // src/render-divergences.ts
 var renderDivergences = {};