@barchart/portfolio-api-common 2.0.0 → 2.1.1

package/lib/processing/PositionContainer.js

@@ -35,6 +35,8 @@ module.exports = (() => {
 		Currency.EUR,
 		Currency.HKD,
 		Currency.JPY,
+		Currency.NOK,
+		Currency.SEK,
 		Currency.USD
 	];
 
@@ -452,9 +454,21 @@ module.exports = (() => {
 			assert.argumentIsRequired(position, 'position', Object);
 			assert.argumentIsRequired(position.position, 'position.position', String);
 
-			removePositionItem.call(this, this._items.find(item => item.position.position === position.position));
+			const positionItemToRemove = this._items.find(item => item.position.position === position.position);
+			const positionToRemove = positionItemToRemove ? positionItemToRemove.position || null : null;
+
+			removePositionItem.call(this, positionItemToRemove);
 
 			recalculatePercentages.call(this);
+
+			if (positionToRemove) {
+				const existingBarchartSymbols = this.getPositionSymbols(false, false);
+				const removedBarchartSymbol = extractSymbolForBarchart(positionToRemove);
+
+				if (removedBarchartSymbol !== null && !existingBarchartSymbols.some(existingBarchartSymbol => existingBarchartSymbol === removedBarchartSymbol)) {
+					this._positionSymbolRemovedEvent.fire(removedBarchartSymbol);
+				}
+			}
 		}
 
 		/**

package/lib/processing/PositionGroup.js

@@ -540,7 +540,6 @@ module.exports = (() => {
 					this._dataFormat.quoteLow = formatFraction(this._dataActual.quoteLow, currency, instrument, this._useBarchartPriceFormattingRules);
 
 					this._dataFormat.quoteChange = formatFraction(this._dataActual.quoteChange, currency, instrument, this._useBarchartPriceFormattingRules);
-
 				}
 			}
 		}

package/lib/serialization/TransactionSchema.js

@@ -224,7 +224,7 @@ module.exports = (() => {
 		.withField('type', DataType.forEnum(TransactionType, 'TransactionType'))
 		.withField('instrument.name', DataType.STRING, true)
 		.withField('instrument.exchange', DataType.STRING, true)
-		.withField('instrument.code', DataType.NUMBER, true)
+		.withField('instrument.code', DataType.NUMBER, true) // Not intended to be the unit code. Same value as [profile] table [type] column. See `InstrumentType.fromSymbolType` function.
 		.withField('instrument.type', DataType.forEnum(InstrumentType, 'InstrumentType'), true)
 		.withField('instrument.currency', DataType.forEnum(Currency, 'Currency'), true)
 		.withField('instrument.symbol.barchart', DataType.STRING, true)
@@ -274,7 +274,7 @@ module.exports = (() => {
 		.withField('type', DataType.forEnum(TransactionType, 'TransactionType'))
 		.withField('instrument.name', DataType.STRING, true)
 		.withField('instrument.exchange', DataType.STRING, true)
-		.withField('instrument.code', DataType.NUMBER, true)
+		.withField('instrument.code', DataType.NUMBER, true) // Not intended to be the unit code. Same value as [profile] table [type] column. See `InstrumentType.fromSymbolType` function.
 		.withField('instrument.type', DataType.forEnum(InstrumentType, 'InstrumentType'), true)
 		.withField('instrument.currency', DataType.forEnum(Currency, 'Currency'), true)
 		.withField('instrument.symbol.barchart', DataType.STRING, true)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "2.0.0",
+  "version": "2.1.1",
   "description": "Common JavaScript code used by Barchart's Portfolio Service",
   "author": {
     "name": "Bryan Ingle",
@@ -15,7 +15,7 @@
     "url": "git+ssh://git@github.com/barchart/portfolio-api-common.git"
   },
   "dependencies": {
-    "@barchart/common-js": "^4.46.1",
+    "@barchart/common-js": "^4.51.0",
     "@barchart/marketdata-api-js": "^6.2.1",
     "uuid": "9.0.1"
   },