@barchart/portfolio-api-common 1.5.0 → 1.7.0

package/.releases/1.5.1.md

@@ -0,0 +1,3 @@
+**Configuration Changes**
+
+* The failure message for corrupt corporate actions (e.g. two instruments with same symbol) was updated to indicate an expected time to correction (of 24 to 48 hours).

package/.releases/1.5.2.md

@@ -0,0 +1,4 @@
+**Technical Enhancements**
+
+* Added a `transaction` field into `basicFormatter` function for the `TransactionFormatter` class.
+* Changed the way to add and remove a portfolio in `PositionContainer` to support reactive changes.

package/.releases/1.6.0.md

@@ -0,0 +1,3 @@
+**New Features**
+
+* Added a new `PortfolioFailureType` for attempting to edit a transaction's type.

package/.releases/1.7.0.md

@@ -0,0 +1,3 @@
+**New Features**
+
+* Added a new `PortfolioFailureType` for attempting to reinvest a dividend when the position is short.

package/lib/api/failures/PortfolioFailureType.js

@@ -212,6 +212,18 @@ module.exports = (() => {
 			return transactionCreateFailedReinvestPriceUnavailable;
 		}
 
+		/**
+		 * The transaction failed because a dividends cannot be re-invested
+		 * for short positions.
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get TRANSACTION_CREATE_FAILED_REINVEST_INVALID() {
+			return transactionCreateFailedReinvestInvalid;
+		}
+
 		/**
 		 * The transaction failed because a related position is locked.
 		 *
@@ -326,6 +338,18 @@ module.exports = (() => {
 			return transactionEditFailedTypeReserved;
 		}
 
+		/**
+		 * A transaction's type cannot be changed.
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get TRANSACTION_EDIT_FAILED_TYPE_CHANGED() {
+			return transactionEditFailedTypeChanged;
+		}
+
+
 		toString() {
 			return '[PortfolioFailureType]';
 		}
@@ -352,8 +376,9 @@ module.exports = (() => {
 
 	const transactionCreateFailedTypeReserved = new FailureType('TRANSACTION_CREATE_FAILED_TYPE_RESERVED', 'Unable to create {U|type.description} transaction, this type of transaction is managed by the system.');
 	const transactionCreateFailedReinvestPriceUnavailable = new FailureType('TRANSACTION_CREATE_FAILED_REINVEST_PRICE_UNAVAILABLE', 'Unable to create transaction, a dividend was paid on {L|day}; however no historical price is available for this day. To successfully create this transaction, please turn off dividend reinvestment for this position.');
+	const transactionCreateFailedReinvestInvalid = new FailureType('TRANSACTION_CREATE_FAILED_REINVEST_INVALID', 'Unable to create transaction, short positions do not allow dividends to be reinvested.');
 	const transactionCreateFailedPositionLocked = new FailureType('TRANSACTION_CREATE_FAILED_POSITION_LOCKED', 'Unable to create transaction, your {L|description} history is being recalculated. Please re-enter this transaction in a minute or two.');
-	const transactionCreateFailedInstrumentCorrupt = new FailureType('TRANSACTION_CREATE_FAILED_INSTRUMENT_CORRUPT', 'Unable to create transaction, corporate action history for {U|symbol} cannot be located.');
+	const transactionCreateFailedInstrumentCorrupt = new FailureType('TRANSACTION_CREATE_FAILED_INSTRUMENT_CORRUPT', 'Unable to create transaction, corporate action history for {U|symbol} cannot be located. The issue should be corrected within 24 to 48 hours.');
 
 	const transactionDeleteFailedOutOfSequence = new FailureType('TRANSACTION_DELETE_FAILED_OUT_OF_SEQUENCE', 'Deleting any transaction, except for the most recent, will cause transaction history to be re-written. Please confirm your intent to re-write transaction history (which could take some time and alter the historical results for this position).');
 	const transactionDeleteFailedNoTransaction = new FailureType('TRANSACTION_DELETE_FAILED_NO_TRANSACTION', 'Unable to delete transaction. The referenced transaction does not exist.', false);
@@ -364,6 +389,7 @@ module.exports = (() => {
 	const transactionEditFailedInvalidDate = new FailureType('TRANSACTION_EDIT_FAILED_INVALID_DATE', 'Unable to edit transaction with given date.');
 	const transactionEditFailedNoTransaction = new FailureType('TRANSACTION_EDIT_FAILED_NO_TRANSACTION', 'Unable to edit transaction. The referenced transaction does not exist.', false);
 	const transactionEditFailedTypeReserved = new FailureType('TRANSACTION_EDIT_FAILED_TYPE_RESERVED', 'Unable to edit {U|type.description} transaction, this type of transaction is managed by the system.');
+	const transactionEditFailedTypeChanged = new FailureType('TRANSACTION_EDIT_FAILED_TYPE_CHANGED', 'Changing a transaction type is forbidden. You must delete the existing transaction then recreate it.');
 
 	return PortfolioFailureType;
 })();

package/lib/data/TransactionValidator.js

@@ -1,7 +1,6 @@
 const assert = require('@barchart/common-js/lang/assert'),
 	array = require('@barchart/common-js/lang/array'),
-	is = require('@barchart/common-js/lang/is'),
-	Day = require('@barchart/common-js/lang/Day');
+	is = require('@barchart/common-js/lang/is');
 
 const InstrumentType = require('./InstrumentType'),
 	PositionDirection = require('./PositionDirection'),

package/lib/formatters/TransactionFormatter.js

@@ -127,6 +127,7 @@ module.exports = (() => {
 		f.sequence = t.sequence;
 		f.position = t.position;
 		f.open = t.snapshot.open;
+		f.transaction = t.transaction;
 	};
 
 	const averageCostFormatter = (t, f) => {

package/lib/processing/PositionContainer.js

@@ -234,7 +234,7 @@ module.exports = (() => {
 			const key = portfolio.portfolio;
 
 			if (!this._portfolios.hasOwnProperty(key)) {
-				this._portfolios[key] = portfolio;
+				this._portfolios = Object.assign({}, this._portfolios, { [key]: portfolio });
 
 				this._definitions.forEach((treeDefinition) => {
 					const tree = this._trees[treeDefinition.name];
@@ -314,6 +314,8 @@ module.exports = (() => {
 
 			delete this._portfolios[portfolio.portfolio];
 
+			this._portfolios = Object.assign({}, this._portfolios);
+
 			Object.keys(this._trees).forEach((key) => {
 				this._trees[key].walk((group, groupNode) => {
 					if (group.definition.type === PositionLevelType.PORTFOLIO && group.key === PositionLevelDefinition.getKeyForPortfolioGroup(portfolio)) {

package/lib/processing/PositionItem.js

@@ -40,14 +40,14 @@ module.exports = (() => {
 
 			this._reporting = reporting;
 
-			this._data = { };
-
-			this._data.basis = null;
-
 			this._currentQuote = null;
 			this._previousQuote = null;
 			this._currentPrice = null;
 
+			this._data = { };
+
+			this._data.basis = null;
+
 			this._data.currentPrice = null;
 			this._data.currentPricePrevious = null;
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.5.0",
+  "version": "1.7.0",
   "description": "Common code used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -1291,8 +1291,7 @@ module.exports = (() => {
 },{"@barchart/common-js/lang/Enum":26,"@barchart/common-js/lang/assert":31}],5:[function(require,module,exports){
 const assert = require('@barchart/common-js/lang/assert'),
 	array = require('@barchart/common-js/lang/array'),
-	is = require('@barchart/common-js/lang/is'),
-	Day = require('@barchart/common-js/lang/Day');
+	is = require('@barchart/common-js/lang/is');
 
 const InstrumentType = require('./InstrumentType'),
 	PositionDirection = require('./PositionDirection'),
@@ -1595,7 +1594,7 @@ module.exports = (() => {
 	return TransactionValidator;
 })();
 
-},{"./InstrumentType":1,"./PositionDirection":2,"./TransactionType":4,"@barchart/common-js/lang/Day":23,"@barchart/common-js/lang/array":30,"@barchart/common-js/lang/assert":31,"@barchart/common-js/lang/is":35}],6:[function(require,module,exports){
+},{"./InstrumentType":1,"./PositionDirection":2,"./TransactionType":4,"@barchart/common-js/lang/array":30,"@barchart/common-js/lang/assert":31,"@barchart/common-js/lang/is":35}],6:[function(require,module,exports){
 const Enum = require('@barchart/common-js/lang/Enum');
 
 module.exports = (() => {
@@ -1893,7 +1892,7 @@ module.exports = (() => {
 			const key = portfolio.portfolio;
 
 			if (!this._portfolios.hasOwnProperty(key)) {
-				this._portfolios[key] = portfolio;
+				this._portfolios = Object.assign({}, this._portfolios, { [key]: portfolio });
 
 				this._definitions.forEach((treeDefinition) => {
 					const tree = this._trees[treeDefinition.name];
@@ -1973,6 +1972,8 @@ module.exports = (() => {
 
 			delete this._portfolios[portfolio.portfolio];
 
+			this._portfolios = Object.assign({}, this._portfolios);
+
 			Object.keys(this._trees).forEach((key) => {
 				this._trees[key].walk((group, groupNode) => {
 					if (group.definition.type === PositionLevelType.PORTFOLIO && group.key === PositionLevelDefinition.getKeyForPortfolioGroup(portfolio)) {
@@ -3865,14 +3866,14 @@ module.exports = (() => {
 
 			this._reporting = reporting;
 
-			this._data = { };
-
-			this._data.basis = null;
-
 			this._currentQuote = null;
 			this._previousQuote = null;
 			this._currentPrice = null;
 
+			this._data = { };
+
+			this._data.basis = null;
+
 			this._data.currentPrice = null;
 			this._data.currentPricePrevious = null;