@barchart/portfolio-api-common 1.5.0 → 1.5.1

package/.releases/1.5.1.md

@@ -0,0 +1,3 @@
+**Configuration Changes**
+
+* The failure message for corrupt corporate actions (e.g. two instruments with same symbol) was updated to indicate an expected time to correction (of 24 to 48 hours).

package/lib/api/failures/PortfolioFailureType.js

@@ -353,7 +353,7 @@ module.exports = (() => {
 	const transactionCreateFailedTypeReserved = new FailureType('TRANSACTION_CREATE_FAILED_TYPE_RESERVED', 'Unable to create {U|type.description} transaction, this type of transaction is managed by the system.');
 	const transactionCreateFailedReinvestPriceUnavailable = new FailureType('TRANSACTION_CREATE_FAILED_REINVEST_PRICE_UNAVAILABLE', 'Unable to create transaction, a dividend was paid on {L|day}; however no historical price is available for this day. To successfully create this transaction, please turn off dividend reinvestment for this position.');
 	const transactionCreateFailedPositionLocked = new FailureType('TRANSACTION_CREATE_FAILED_POSITION_LOCKED', 'Unable to create transaction, your {L|description} history is being recalculated. Please re-enter this transaction in a minute or two.');
-	const transactionCreateFailedInstrumentCorrupt = new FailureType('TRANSACTION_CREATE_FAILED_INSTRUMENT_CORRUPT', 'Unable to create transaction, corporate action history for {U|symbol} cannot be located.');
+	const transactionCreateFailedInstrumentCorrupt = new FailureType('TRANSACTION_CREATE_FAILED_INSTRUMENT_CORRUPT', 'Unable to create transaction, corporate action history for {U|symbol} cannot be located. The issue should be corrected within 24 to 48 hours.');
 
 	const transactionDeleteFailedOutOfSequence = new FailureType('TRANSACTION_DELETE_FAILED_OUT_OF_SEQUENCE', 'Deleting any transaction, except for the most recent, will cause transaction history to be re-written. Please confirm your intent to re-write transaction history (which could take some time and alter the historical results for this position).');
 	const transactionDeleteFailedNoTransaction = new FailureType('TRANSACTION_DELETE_FAILED_NO_TRANSACTION', 'Unable to delete transaction. The referenced transaction does not exist.', false);

package/lib/processing/PositionItem.js

@@ -40,14 +40,14 @@ module.exports = (() => {
 
 			this._reporting = reporting;
 
-			this._data = { };
-
-			this._data.basis = null;
-
 			this._currentQuote = null;
 			this._previousQuote = null;
 			this._currentPrice = null;
 
+			this._data = { };
+
+			this._data.basis = null;
+
 			this._data.currentPrice = null;
 			this._data.currentPricePrevious = null;
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "Common code used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -3865,14 +3865,14 @@ module.exports = (() => {
 
 			this._reporting = reporting;
 
-			this._data = { };
-
-			this._data.basis = null;
-
 			this._currentQuote = null;
 			this._previousQuote = null;
 			this._currentPrice = null;
 
+			this._data = { };
+
+			this._data.basis = null;
+
 			this._data.currentPrice = null;
 			this._data.currentPricePrevious = null;