@barchart/portfolio-api-common 1.29.0 → 1.29.2

package/lib/processing/PositionContainer.js

@@ -463,10 +463,17 @@ module.exports = (() => {
 		 *
 		 * @public
 		 * @param {Boolean} display - If true, all "display" symbols are returned; otherwise Barchart symbols are returned.
+		 * @param {Boolean} excludeExpired - If true, only non-expired symbols are filtered.
 		 * @returns {String[]}
 		 */
-		getPositionSymbols(display) {
-			const symbols = this._items.reduce((symbols, item) => {
+		getPositionSymbols(display, excludeExpired) {
+			let items = this._items;
+
+			if (excludeExpired) {
+				items = items.filter(item => !item.data.expired);
+			}
+
+			const symbols = items.reduce((symbols, item) => {
 				const position = item.position;
 
 				let symbol;

package/lib/providers/InstrumentProvider.js

@@ -12,15 +12,19 @@ const EndpointBuilder = require('@barchart/common-js/api/http/builders/EndpointB
 module.exports = (() => {
 	'use strict';
 
-	const MAXIMUM_WAIT_BEFORE_TIMEOUT_IN_MILLISECONDS = 3 * 1000;
+	const DEFAULT_MAXIMUM_WAIT_BEFORE_TIMEOUT_IN_MILLISECONDS = 3 * 1000;
 
 	/**
 	 * A utility that downloads instrument metadata (i.e. instrument "profile" data).
 	 *
 	 * @public
+	 * @param {Number=} waitInMilliseconds - The maximum amount of time to wait for the response from server.
 	 */
 	class InstrumentProvider {
-		constructor() {
+		constructor(waitInMilliseconds) {
+			assert.argumentIsOptional(waitInMilliseconds, 'waitInMillis', Number);
+
+			this._waitInMilliseconds = waitInMilliseconds || DEFAULT_MAXIMUM_WAIT_BEFORE_TIMEOUT_IN_MILLISECONDS;
 		}
 
 		/**
@@ -37,7 +41,7 @@ module.exports = (() => {
 				.then(() => {
 					assert.argumentIsRequired(symbol, 'symbol', String);
 
-					return promise.timeout(Gateway.invoke(instrumentLookupEndpoint, { symbol }), MAXIMUM_WAIT_BEFORE_TIMEOUT_IN_MILLISECONDS, 'instrument lookup')
+					return promise.timeout(Gateway.invoke(instrumentLookupEndpoint, { symbol }), this._waitInMilliseconds, 'instrument lookup')
 							.catch((e) => {
 								let message;
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.29.0",
+  "version": "1.29.2",
   "description": "Common JavaScript code used by Barchart's Portfolio Service",
   "author": {
     "name": "Bryan Ingle",