@barchart/portfolio-api-common 1.27.0 → 1.27.2

package/lib/processing/PositionContainer.js

@@ -583,7 +583,14 @@ module.exports = (() => {
 
 					if (symbol) {
 						const rate = Rate.fromPair(quote.lastPrice, symbol);
-						const index = this._forexQuotes.findIndex(existing => existing.formatPair() === rate.formatPair());
+
+						let index = this._forexQuotes.findIndex(existing => existing.formatPair() === rate.formatPair());
+
+						if (index < 0) {
+							const inverted = rate.invert();
+
+							index = this._forexQuotes.findIndex(existing => existing.formatPair() === inverted.formatPair());
+						}
 
 						if (index < 0) {
 							this._forexQuotes.push(rate);
@@ -591,13 +598,13 @@ module.exports = (() => {
 							this._forexQuotes[index] = rate;
 						}
 
-						Object.keys(this._trees).forEach((key) => {
-							this._trees[key].walk(group => group.setForexRates(this._forexQuotes), true, false);
-						});
-
 						recalculatePercentages.call(this);
 					}
 				});
+
+				Object.keys(this._trees).forEach((key) => {
+					this._trees[key].walk(group => group.setForexRates(this._forexQuotes), true, false);
+				});
 			}
 
 			if (positionQuotes.length !== 0 || forexQuotes.length !== 0) {

package/lib/processing/PositionGroup.js

@@ -292,7 +292,7 @@ module.exports = (() => {
 		}
 
 		/**
-		 * Indicates if the group will only contain one {@link PositionItem} -- that is,
+		 * Indicates if the group will only contain one {@link PositionItem} — that is,
 		 * indicates if the group represents a single position.
 		 *
 		 * @public
@@ -585,7 +585,7 @@ module.exports = (() => {
 								if (summary.count > 0) {
 									averageFormat = formatPercent(new Decimal(summary.total / summary.count), 2, true);
 								} else {
-									averageFormat = '--';
+									averageFormat = '—';
 								}
 
 								summary.averageFormat = averageFormat;
@@ -595,7 +595,7 @@ module.exports = (() => {
 
 					return sums;
 				}, fundamentalFields.reduce((sums, fieldName) => {
-					sums[fieldName] = { total: 0, count: 0, averageFormat: '--' };
+					sums[fieldName] = { total: 0, count: 0, averageFormat: '—' };
 
 					return sums;
 				}, { }));

package/lib/providers/InstrumentProvider.js

@@ -14,8 +14,6 @@ module.exports = (() => {
 
 	const MAXIMUM_WAIT_BEFORE_TIMEOUT_IN_MILLISECONDS = 3 * 1000;
 
-	const cache = { };
-
 	/**
 	 * A utility that downloads instrument metadata (i.e. instrument "profile" data).
 	 *
@@ -39,10 +37,8 @@ module.exports = (() => {
 				.then(() => {
 					assert.argumentIsRequired(symbol, 'symbol', String);
 
-					return promise.timeout(Gateway.invoke(getInstrumentLookupEndpoint(), {symbol}), MAXIMUM_WAIT_BEFORE_TIMEOUT_IN_MILLISECONDS, 'instrument lookup')
+					return promise.timeout(Gateway.invoke(instrumentLookupEndpoint, { symbol }), MAXIMUM_WAIT_BEFORE_TIMEOUT_IN_MILLISECONDS, 'instrument lookup')
 							.catch((e) => {
-								delete cache[symbol];
-
 								let message;
 
 								if (is.string(e) && e === 'timeout') {
@@ -67,32 +63,18 @@ module.exports = (() => {
 		}
 	}
 
-	function buildInstrumentLookupEndpoint(host) {
-		return EndpointBuilder.for('query-instrument', 'query instrument')
-			.withVerb(VerbType.GET)
-			.withProtocol(ProtocolType.HTTPS)
-			.withHost(host)
-			.withPort(443)
-			.withPathBuilder((pb) => {
-				pb.withLiteralParameter('instruments', 'instruments')
-					.withVariableParameter('symbol', 'symbol', 'symbol');
-			})
-			.withResponseInterceptor(ResponseInterceptor.DATA)
-			.withErrorInterceptor(ErrorInterceptor.GENERAL)
-			.endpoint;
-	}
-
-	const instrumentLookupEndpoints = new Map();
-
-	function getInstrumentLookupEndpoint() {
-		const host = 'instruments-prod.aws.barchart.com';
-
-		if (!instrumentLookupEndpoints.has(host)) {
-			instrumentLookupEndpoints.set(host, buildInstrumentLookupEndpoint(host));
-		}
-
-		return instrumentLookupEndpoints.get(host);
-	}
+	const instrumentLookupEndpoint = EndpointBuilder.for('query-instrument', 'query instrument')
+		.withVerb(VerbType.GET)
+		.withProtocol(ProtocolType.HTTPS)
+		.withHost('instruments-prod.aws.barchart.com')
+		.withPort(443)
+		.withPathBuilder((pb) => {
+			pb.withLiteralParameter('instruments', 'instruments')
+				.withVariableParameter('symbol', 'symbol', 'symbol');
+		})
+		.withResponseInterceptor(ResponseInterceptor.DATA)
+		.withErrorInterceptor(ErrorInterceptor.GENERAL)
+		.endpoint;
 
 	return InstrumentProvider;
 })();

package/lib/providers/InstrumentProviderCache.js

@@ -13,7 +13,7 @@ module.exports = (() => {
 	 *
 	 * @public
 	 * @param {InstrumentProvider} provider
-	 * @param {Number} cacheDuration - The maximum number of milliseconds to cache an instrument.
+	 * @param {Number=} cacheDuration - The maximum number of milliseconds to cache an instrument.
 	 */
 	class InstrumentProviderCache {
 		constructor(provider, cacheDuration) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.27.0",
+  "version": "1.27.2",
   "description": "Common JavaScript code used by Barchart's Portfolio Service",
   "author": {
     "name": "Bryan Ingle",