@barchart/portfolio-api-common 1.2.80 → 1.2.84

package/lib/processing/PositionContainer.js

@@ -276,7 +276,7 @@ module.exports = (() => {
 
 			const existingBarchartSymbols = this.getPositionSymbols(false);
 
-			removePositionItem.call(this, this._items.find((item) => item.position.position === position.position));
+			removePositionItem.call(this, this._items.find(item => item.position.position === position.position));
 
 			summaries.forEach((summary) => {
 				addSummaryCurrent(this._summariesCurrent, summary, this._currentSummaryFrame, this._currentSummaryRange);
@@ -336,7 +336,7 @@ module.exports = (() => {
 			assert.argumentIsRequired(position, 'position', Object);
 			assert.argumentIsRequired(position.position, 'position.position', String);
 
-			removePositionItem.call(this, this._items.find((item) => item.position.position === position.position));
+			removePositionItem.call(this, this._items.find(item => item.position.position === position.position));
 
 			recalculatePercentages.call(this);
 		}
@@ -382,14 +382,30 @@ module.exports = (() => {
 				assert.argumentIsRequired(position, 'position', Object);
 				assert.argumentIsRequired(position.position, 'position.position', String);
 
-				const item = this._items.find((i) => i.position.position === position.position);
+				const item = this._items.find(i => i.position.position === position.position);
 
 				if (item) {
-					item.setPositionLock(PositionItem.getIsLocked(position));
+					item.setPositionLock(position);
 				}
 			}
 		}
 
+		/**
+		 * Returns a position's lock status.
+		 *
+		 * @public
+		 * @param {Object} position
+		 * @return {Boolean}
+		 */
+		getPositionLock(position) {
+			assert.argumentIsRequired(position, 'position', Object);
+			assert.argumentIsRequired(position.position, 'position.position', String);
+
+			const item = this._items.find(i => i.position.position === position.position);
+
+			return is.object(item) && item.locked;
+		}
+
 		/**
 		 * Performs a batch update of both position quotes and forex quotes,
 		 * triggering updates to position(s) and data aggregation(s).

package/lib/processing/PositionItem.js

@@ -70,7 +70,7 @@ module.exports = (() => {
 
 			this._data.newsExists = false;
 			this._data.fundamental = { };
-			this._data.locked = PositionItem.getIsLocked(position);
+			this._data.locked = getIsLocked(position);
 
 			calculateStaticData(this);
 			calculatePriceData(this, null);
@@ -242,18 +242,20 @@ module.exports = (() => {
 		}
 
 		/**
-		 * Sets position lock status.
+		 * Sets a position's lock status.
 		 *
 		 * @public
-		 * @param {Boolean} value
+		 * @param {Object} position
 		 */
-		setPositionLock(value) {
-			assert.argumentIsRequired(value, 'value', Boolean);
+		setPositionLock(position) {
+			assert.argumentIsRequired(position, 'position');
 
 			if (this.getIsDisposed()) {
 				return;
 			}
 
+			const value = getIsLocked(position);
+
 			if (this._data.locked !== value) {
 				this._lockChangedEvent.fire(this._data.locked = value);
 			}
@@ -337,19 +339,6 @@ module.exports = (() => {
 			this._positionItemDisposeEvent.clear();
 		}
 
-		/**
-		 * Given a position object, returns its lock (for editing) status.
-		 *
-		 * @public
-		 * @param {Object{}} position
-		 * @returns {Boolean}
-		 */
-		static getIsLocked(position) {
-			assert.argumentIsRequired(position, 'position');
-
-			return is.object(position.system) && is.boolean(position.system.locked) && position.system.locked
-		}
-
 		toString() {
 			return '[PositionItem]';
 		}
@@ -538,5 +527,11 @@ module.exports = (() => {
 		return summary;
 	}
 
+	function getIsLocked(position) {
+		assert.argumentIsRequired(position, 'position');
+
+		return is.object(position.system) && is.boolean(position.system.locked) && position.system.locked;
+	}
+
 	return PositionItem;
 })();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.2.80",
+  "version": "1.2.84",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -1655,7 +1655,7 @@ module.exports = (() => {
 
 			const existingBarchartSymbols = this.getPositionSymbols(false);
 
-			removePositionItem.call(this, this._items.find((item) => item.position.position === position.position));
+			removePositionItem.call(this, this._items.find(item => item.position.position === position.position));
 
 			summaries.forEach((summary) => {
 				addSummaryCurrent(this._summariesCurrent, summary, this._currentSummaryFrame, this._currentSummaryRange);
@@ -1715,7 +1715,7 @@ module.exports = (() => {
 			assert.argumentIsRequired(position, 'position', Object);
 			assert.argumentIsRequired(position.position, 'position.position', String);
 
-			removePositionItem.call(this, this._items.find((item) => item.position.position === position.position));
+			removePositionItem.call(this, this._items.find(item => item.position.position === position.position));
 
 			recalculatePercentages.call(this);
 		}
@@ -1761,14 +1761,30 @@ module.exports = (() => {
 				assert.argumentIsRequired(position, 'position', Object);
 				assert.argumentIsRequired(position.position, 'position.position', String);
 
-				const item = this._items.find((i) => i.position.position === position.position);
+				const item = this._items.find(i => i.position.position === position.position);
 
 				if (item) {
-					item.setPositionLock(PositionItem.getIsLocked(position));
+					item.setPositionLock(position);
 				}
 			}
 		}
 
+		/**
+		 * Returns a position's lock status.
+		 *
+		 * @public
+		 * @param {Object} position
+		 * @return {Boolean}
+		 */
+		getPositionLock(position) {
+			assert.argumentIsRequired(position, 'position', Object);
+			assert.argumentIsRequired(position.position, 'position.position', String);
+
+			const item = this._items.find(i => i.position.position === position.position);
+
+			return is.object(item) && item.locked;
+		}
+
 		/**
 		 * Performs a batch update of both position quotes and forex quotes,
 		 * triggering updates to position(s) and data aggregation(s).
@@ -3282,7 +3298,7 @@ module.exports = (() => {
 
 			this._data.newsExists = false;
 			this._data.fundamental = { };
-			this._data.locked = PositionItem.getIsLocked(position);
+			this._data.locked = getIsLocked(position);
 
 			calculateStaticData(this);
 			calculatePriceData(this, null);
@@ -3454,18 +3470,20 @@ module.exports = (() => {
 		}
 
 		/**
-		 * Sets position lock status.
+		 * Sets a position's lock status.
 		 *
 		 * @public
-		 * @param {Boolean} value
+		 * @param {Object} position
 		 */
-		setPositionLock(value) {
-			assert.argumentIsRequired(value, 'value', Boolean);
+		setPositionLock(position) {
+			assert.argumentIsRequired(position, 'position');
 
 			if (this.getIsDisposed()) {
 				return;
 			}
 
+			const value = getIsLocked(position);
+
 			if (this._data.locked !== value) {
 				this._lockChangedEvent.fire(this._data.locked = value);
 			}
@@ -3549,19 +3567,6 @@ module.exports = (() => {
 			this._positionItemDisposeEvent.clear();
 		}
 
-		/**
-		 * Given a position object, returns its lock (for editing) status.
-		 *
-		 * @public
-		 * @param {Object{}} position
-		 * @returns {Boolean}
-		 */
-		static getIsLocked(position) {
-			assert.argumentIsRequired(position, 'position');
-
-			return is.object(position.system) && is.boolean(position.system.locked) && position.system.locked
-		}
-
 		toString() {
 			return '[PositionItem]';
 		}
@@ -3750,6 +3755,12 @@ module.exports = (() => {
 		return summary;
 	}
 
+	function getIsLocked(position) {
+		assert.argumentIsRequired(position, 'position');
+
+		return is.object(position.system) && is.boolean(position.system.locked) && position.system.locked;
+	}
+
 	return PositionItem;
 })();