@barchart/portfolio-api-common 1.2.143 → 1.2.147

package/lib/processing/PositionGroup.js

@@ -145,6 +145,7 @@ module.exports = (() => {
 			this._dataFormat.currentPrice = null;
 			this._dataFormat.basis = null;
 			this._dataFormat.realized = null;
+			this._dataFormat.realizedPercent = null;
 			this._dataFormat.income = null;
 			this._dataFormat.market = null;
 			this._dataFormat.marketPercent = null;
@@ -690,9 +691,9 @@ module.exports = (() => {
 			updates.marketPrevious = updates.marketPrevious.add(translate(item, item.data.marketPrevious));
 			updates.marketPrevious2 = updates.marketPrevious2.add(translate(item, item.data.marketPrevious2));
 
+			updates.periodIncome = updates.periodIncome.add(translate(item, item.data.periodIncome));
 			updates.periodRealized = updates.periodRealized.add(translate(item, item.data.periodRealized));
 			updates.periodUnrealized = updates.periodUnrealized.add(translate(item, item.data.periodUnrealized));
-			updates.periodIncome = updates.periodIncome.add(translate(item, item.data.periodIncome));
 
 			if (item.position.instrument.type === InstrumentType.CASH) {
 				updates.cashTotal = updates.cashTotal.add(translate(item, item.data.market));
@@ -714,9 +715,9 @@ module.exports = (() => {
 			summaryTotalPrevious2: Decimal.ZERO,
 			marketPrevious: Decimal.ZERO,
 			marketPrevious2: Decimal.ZERO,
+			periodIncome: Decimal.ZERO,
 			periodRealized: Decimal.ZERO,
 			periodUnrealized: Decimal.ZERO,
-			periodIncome: Decimal.ZERO,
 			cashTotal: Decimal.ZERO,
 			totalDivisor: Decimal.ZERO,
 			periodDivisorCurrent: Decimal.ZERO,
@@ -733,9 +734,9 @@ module.exports = (() => {
 		actual.summaryTotalPrevious2 = updates.summaryTotalPrevious2;
 		actual.marketPrevious = updates.marketPrevious;
 		actual.marketPrevious2 = updates.marketPrevious2;
+		actual.periodIncome = updates.periodIncome;
 		actual.periodRealized = updates.periodRealized;
 		actual.periodUnrealized = updates.periodUnrealized;
-		actual.periodIncome = updates.periodIncome;
 		actual.cashTotal = updates.cashTotal;
 		actual.totalDivisor = updates.totalDivisor;
 		actual.periodDivisorCurrent = updates.periodDivisorCurrent;
@@ -754,11 +755,12 @@ module.exports = (() => {
 		format.summaryTotalPrevious2Negative = updates.summaryTotalPrevious2.getIsNegative();
 		format.marketPrevious = formatCurrency(updates.marketPrevious, currency);
 		format.marketPrevious2 = formatCurrency(updates.marketPrevious2, currency);
+		format.periodIncome = formatCurrency(updates.periodIncome, currency);
 		format.periodRealized = formatCurrency(updates.periodRealized, currency);
 		format.periodUnrealized = formatCurrency(updates.periodUnrealized, currency);
-		format.periodIncome = formatCurrency(updates.periodIncome, currency);
 		format.cashTotal = formatCurrency(updates.cashTotal, currency);
 
+		calculateRealizedPercent(group);
 		calculateUnrealizedPercent(group);
 
 		actual.periodPercent = calculateGainPercent(actual.summaryTotalCurrent, actual.periodDivisorCurrent);
@@ -844,6 +846,7 @@ module.exports = (() => {
 				updates.unrealized = updates.unrealized.add(translate(item, item.data.unrealized));
 				updates.unrealizedToday = updates.unrealizedToday.add(translate(item, item.data.unrealizedToday));
 				updates.summaryTotalCurrent = updates.summaryTotalCurrent.add(translate(item, item.data.periodGain));
+				updates.periodUnrealized = updates.periodUnrealized.add(translate(item, item.data.periodUnrealized));
 
 				return updates;
 			}, {
@@ -852,7 +855,8 @@ module.exports = (() => {
 				marketDirection: unchanged,
 				unrealized: Decimal.ZERO,
 				unrealizedToday: Decimal.ZERO,
-				summaryTotalCurrent: Decimal.ZERO
+				summaryTotalCurrent: Decimal.ZERO,
+				periodUnrealized: Decimal.ZERO
 			});
 		} else {
 			updates = {
@@ -861,7 +865,8 @@ module.exports = (() => {
 				marketDirection: { up: item.data.marketChange.getIsPositive(), down: item.data.marketChange.getIsNegative() },
 				unrealized: actual.unrealized.add(translate(item, item.data.unrealizedChange)),
 				unrealizedToday: actual.unrealizedToday.add(translate(item, item.data.unrealizedTodayChange)),
-				summaryTotalCurrent: actual.summaryTotalCurrent.add(translate(item, item.data.periodGainChange))
+				summaryTotalCurrent: actual.summaryTotalCurrent.add(translate(item, item.data.periodGainChange)),
+				periodUnrealized: actual.periodUnrealized.add(translate(item, item.data.periodUnrealizedChange))
 			};
 		}
 
@@ -870,6 +875,7 @@ module.exports = (() => {
 		actual.unrealized = updates.unrealized;
 		actual.unrealizedToday = updates.unrealizedToday;
 		actual.summaryTotalCurrent = updates.summaryTotalCurrent;
+		actual.periodUnrealized = updates.periodUnrealized;
 
 		actual.total = updates.unrealized.add(actual.realized).add(actual.income);
 		actual.totalPercent = calculateGainPercent(actual.total, actual.totalDivisor);
@@ -908,6 +914,8 @@ module.exports = (() => {
 		format.summaryTotalCurrent = formatCurrency(actual.summaryTotalCurrent, currency);
 		format.summaryTotalCurrentNegative = actual.summaryTotalCurrent.getIsNegative();
 
+		format.periodUnrealized = formatCurrency(actual.periodUnrealized, currency);
+
 		format.total = formatCurrency(actual.total, currency);
 		format.totalNegative = actual.total.getIsNegative();
 		format.totalPercent = formatPercent(actual.totalPercent, 2);
@@ -915,14 +923,11 @@ module.exports = (() => {
 		format.marketChange = formatCurrency(actual.marketChange, currency);
 		format.marketChangePercent = formatPercent(actual.marketChangePercent, 2);
 
+		calculateRealizedPercent(group);
 		calculateUnrealizedPercent(group);
 
 		actual.periodPercent = calculateGainPercent(actual.summaryTotalCurrent, actual.periodDivisorCurrent);
 		format.periodPercent = formatPercent(actual.periodPercent, 2);
-
-		if (group.single && item) {
-			actual.periodUnrealized = item.data.periodUnrealized;
-		}
 	}
 
 	function calculateMarketPercent(group, rates, parentGroup, portfolioGroup) {
@@ -968,17 +973,39 @@ module.exports = (() => {
 		}
 	}
 
+	function calculateRealizedPercent(group) {
+		const actual = group._dataActual;
+		const format = group._dataFormat;
+
+		const openBasis = actual.basis;
+		const totalBasis = actual.totalDivisor;
+
+		const numerator = actual.realized;
+		const denominator = totalBasis.subtract(openBasis);
+
+		if (denominator.getIsZero()) {
+			actual.realizedPercent = Decimal.ZERO;
+		} else {
+			actual.realizedPercent = numerator.divide(denominator);
+		}
+
+		format.realizedPercent = formatPercent(actual.realizedPercent, 2);
+	}
+
 	function calculateUnrealizedPercent(group) {
 		const actual = group._dataActual;
 		const format = group._dataFormat;
 
-		if (actual.basis.getIsZero()) {
-			actual.unrealizedPercent = null;
-			format.unrealizedPercent = '—';
+		const numerator = actual.unrealized;
+		const denominator = actual.basis;
+
+		if (denominator.getIsZero()) {
+			actual.unrealizedPercent = Decimal.ZERO;
 		} else {
-			actual.unrealizedPercent = actual.unrealized.divide(actual.basis);
-			format.unrealizedPercent = formatPercent(actual.unrealizedPercent, 2);
+			actual.unrealizedPercent = numerator.divide(denominator);
 		}
+
+		format.unrealizedPercent = formatPercent(actual.unrealizedPercent, 2);
 	}
 
 	function calculateGainPercent(gain, basis) {

package/lib/processing/PositionItem.js

@@ -75,7 +75,9 @@ module.exports = (() => {
 
 			this._data.periodIncome = null;
 			this._data.periodRealized = null;
+
 			this._data.periodUnrealized = null;
+			this._data.periodUnrealizedChange = null;
 
 			this._data.periodPrice = null;
 			this._data.periodPricePrevious = null;
@@ -420,14 +422,14 @@ module.exports = (() => {
 		data.marketPrevious2 = previousSummary2 === null ? Decimal.ZERO : previousSummary2.end.value;
 		data.quantityPrevious = previousSummary1 === null ? Decimal.ZERO : previousSummary1.end.open;
 
-		data.periodIncome = currentSummary !== null ? currentSummary.period.income : Decimal.ZERO;
-		data.periodRealized = currentSummary !== null ? currentSummary.period.realized : Decimal.ZERO;
-		data.periodUnrealized = currentSummary !== null ? currentSummary.period.unrealized : Decimal.ZERO;
-
 		data.periodGain = calculatePeriodGain(position.instrument.type, data.initiate, currentSummary, previousSummary1);
 		data.periodGainPrevious = calculatePeriodGain(position.instrument.type, data.initiate, previousSummary1, previousSummary2);
 		data.periodGainPrevious2 = calculatePeriodGain(position.instrument.type, data.initiate, previousSummary2, previousSummary3);
 
+		data.periodIncome = currentSummary !== null ? currentSummary.period.income : Decimal.ZERO;
+		data.periodRealized = currentSummary !== null ? currentSummary.period.realized : Decimal.ZERO;
+		data.periodUnrealized = calculatePeriodUnrealized(position.instrument.type, data.periodGain, data.periodRealized, data.periodIncome);
+
 		data.periodDivisor = calculatePeriodDivisor(position.instrument.type, data.initiate, currentSummary, previousSummary1);
 		data.periodDivisorPrevious = calculatePeriodDivisor(position.instrument.type, data.initiate, previousSummary1, previousSummary2);
 		data.periodDivisorPrevious2 = calculatePeriodDivisor(position.instrument.type, data.initiate, previousSummary2, previousSummary3);
@@ -450,7 +452,7 @@ module.exports = (() => {
 			data.periodPricePrevious = null;
 		}
 
-		data.totalDivisor = calculateTotalDivisor(position.instrument.type, data.initiate, currentSummary);
+		data.totalDivisor = calculateTotalDivisor(position.instrument.type, data.initiate, currentSummary, position);
 	}
 
 	function calculatePriceData(item, price) {
@@ -555,6 +557,18 @@ module.exports = (() => {
 
 				data.periodGain = periodGain;
 				data.periodGainChange = periodGainChange;
+
+				let periodUnrealized = calculatePeriodUnrealized(position.instrument.type, data.periodGain, data.periodRealized, data.periodIncome);
+				let periodUnrealizedChange;
+
+				if (data.periodUnrealized !== null) {
+					periodUnrealizedChange = periodUnrealized.subtract(data.periodUnrealized);
+				} else {
+					periodUnrealizedChange = Decimal.ZERO;
+				}
+
+				data.periodUnrealized = periodUnrealized;
+				data.periodUnrealizedChange = periodUnrealizedChange;
 			} else {
 				data.unrealized = Decimal.ZERO;
 				data.unrealizedChange = Decimal.ZERO;
@@ -645,14 +659,30 @@ module.exports = (() => {
 		return returnRef;
 	}
 
-	function calculateTotalDivisor(type, direction, finalSummary) {
+	function calculatePeriodUnrealized(type, periodGain, periodRealized, periodIncome) {
 		let returnRef;
 
+		if (type !== InstrumentType.CASH) {
+			returnRef = periodRealized.add(periodIncome).subtract(periodGain).opposite();
+		} else {
+			returnRef = Decimal.ZERO;
+		}
+
+		return returnRef;
+	}
+
+	function calculateTotalDivisor(type, direction, finalSummary, position) {
+		let returnRef;
+
+		// 2019-06-05, BRI. We should be reading from the summary -- in case we are
+		// running for a previous period. However, the summary does not have buy and
+		// sell totals for the entire history. Could be added.
+
 		if (finalSummary && type !== InstrumentType.CASH) {
 			if (direction === PositionDirection.SHORT) {
-				returnRef = finalSummary.period.sells;
+				returnRef = position.snapshot.sells;
 			} else {
-				returnRef = finalSummary.period.buys.opposite();
+				returnRef = position.snapshot.buys.opposite();
 			}
 		} else {
 			returnRef = Decimal.ZERO;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.2.143",
+  "version": "1.2.147",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -2667,6 +2667,7 @@ module.exports = (() => {
 			this._dataFormat.currentPrice = null;
 			this._dataFormat.basis = null;
 			this._dataFormat.realized = null;
+			this._dataFormat.realizedPercent = null;
 			this._dataFormat.income = null;
 			this._dataFormat.market = null;
 			this._dataFormat.marketPercent = null;
@@ -3212,9 +3213,9 @@ module.exports = (() => {
 			updates.marketPrevious = updates.marketPrevious.add(translate(item, item.data.marketPrevious));
 			updates.marketPrevious2 = updates.marketPrevious2.add(translate(item, item.data.marketPrevious2));
 
+			updates.periodIncome = updates.periodIncome.add(translate(item, item.data.periodIncome));
 			updates.periodRealized = updates.periodRealized.add(translate(item, item.data.periodRealized));
 			updates.periodUnrealized = updates.periodUnrealized.add(translate(item, item.data.periodUnrealized));
-			updates.periodIncome = updates.periodIncome.add(translate(item, item.data.periodIncome));
 
 			if (item.position.instrument.type === InstrumentType.CASH) {
 				updates.cashTotal = updates.cashTotal.add(translate(item, item.data.market));
@@ -3236,9 +3237,9 @@ module.exports = (() => {
 			summaryTotalPrevious2: Decimal.ZERO,
 			marketPrevious: Decimal.ZERO,
 			marketPrevious2: Decimal.ZERO,
+			periodIncome: Decimal.ZERO,
 			periodRealized: Decimal.ZERO,
 			periodUnrealized: Decimal.ZERO,
-			periodIncome: Decimal.ZERO,
 			cashTotal: Decimal.ZERO,
 			totalDivisor: Decimal.ZERO,
 			periodDivisorCurrent: Decimal.ZERO,
@@ -3255,9 +3256,9 @@ module.exports = (() => {
 		actual.summaryTotalPrevious2 = updates.summaryTotalPrevious2;
 		actual.marketPrevious = updates.marketPrevious;
 		actual.marketPrevious2 = updates.marketPrevious2;
+		actual.periodIncome = updates.periodIncome;
 		actual.periodRealized = updates.periodRealized;
 		actual.periodUnrealized = updates.periodUnrealized;
-		actual.periodIncome = updates.periodIncome;
 		actual.cashTotal = updates.cashTotal;
 		actual.totalDivisor = updates.totalDivisor;
 		actual.periodDivisorCurrent = updates.periodDivisorCurrent;
@@ -3276,11 +3277,12 @@ module.exports = (() => {
 		format.summaryTotalPrevious2Negative = updates.summaryTotalPrevious2.getIsNegative();
 		format.marketPrevious = formatCurrency(updates.marketPrevious, currency);
 		format.marketPrevious2 = formatCurrency(updates.marketPrevious2, currency);
+		format.periodIncome = formatCurrency(updates.periodIncome, currency);
 		format.periodRealized = formatCurrency(updates.periodRealized, currency);
 		format.periodUnrealized = formatCurrency(updates.periodUnrealized, currency);
-		format.periodIncome = formatCurrency(updates.periodIncome, currency);
 		format.cashTotal = formatCurrency(updates.cashTotal, currency);
 
+		calculateRealizedPercent(group);
 		calculateUnrealizedPercent(group);
 
 		actual.periodPercent = calculateGainPercent(actual.summaryTotalCurrent, actual.periodDivisorCurrent);
@@ -3366,6 +3368,7 @@ module.exports = (() => {
 				updates.unrealized = updates.unrealized.add(translate(item, item.data.unrealized));
 				updates.unrealizedToday = updates.unrealizedToday.add(translate(item, item.data.unrealizedToday));
 				updates.summaryTotalCurrent = updates.summaryTotalCurrent.add(translate(item, item.data.periodGain));
+				updates.periodUnrealized = updates.periodUnrealized.add(translate(item, item.data.periodUnrealized));
 
 				return updates;
 			}, {
@@ -3374,7 +3377,8 @@ module.exports = (() => {
 				marketDirection: unchanged,
 				unrealized: Decimal.ZERO,
 				unrealizedToday: Decimal.ZERO,
-				summaryTotalCurrent: Decimal.ZERO
+				summaryTotalCurrent: Decimal.ZERO,
+				periodUnrealized: Decimal.ZERO
 			});
 		} else {
 			updates = {
@@ -3383,7 +3387,8 @@ module.exports = (() => {
 				marketDirection: { up: item.data.marketChange.getIsPositive(), down: item.data.marketChange.getIsNegative() },
 				unrealized: actual.unrealized.add(translate(item, item.data.unrealizedChange)),
 				unrealizedToday: actual.unrealizedToday.add(translate(item, item.data.unrealizedTodayChange)),
-				summaryTotalCurrent: actual.summaryTotalCurrent.add(translate(item, item.data.periodGainChange))
+				summaryTotalCurrent: actual.summaryTotalCurrent.add(translate(item, item.data.periodGainChange)),
+				periodUnrealized: actual.periodUnrealized.add(translate(item, item.data.periodUnrealizedChange))
 			};
 		}
 
@@ -3392,6 +3397,7 @@ module.exports = (() => {
 		actual.unrealized = updates.unrealized;
 		actual.unrealizedToday = updates.unrealizedToday;
 		actual.summaryTotalCurrent = updates.summaryTotalCurrent;
+		actual.periodUnrealized = updates.periodUnrealized;
 
 		actual.total = updates.unrealized.add(actual.realized).add(actual.income);
 		actual.totalPercent = calculateGainPercent(actual.total, actual.totalDivisor);
@@ -3430,6 +3436,8 @@ module.exports = (() => {
 		format.summaryTotalCurrent = formatCurrency(actual.summaryTotalCurrent, currency);
 		format.summaryTotalCurrentNegative = actual.summaryTotalCurrent.getIsNegative();
 
+		format.periodUnrealized = formatCurrency(actual.periodUnrealized, currency);
+
 		format.total = formatCurrency(actual.total, currency);
 		format.totalNegative = actual.total.getIsNegative();
 		format.totalPercent = formatPercent(actual.totalPercent, 2);
@@ -3437,14 +3445,11 @@ module.exports = (() => {
 		format.marketChange = formatCurrency(actual.marketChange, currency);
 		format.marketChangePercent = formatPercent(actual.marketChangePercent, 2);
 
+		calculateRealizedPercent(group);
 		calculateUnrealizedPercent(group);
 
 		actual.periodPercent = calculateGainPercent(actual.summaryTotalCurrent, actual.periodDivisorCurrent);
 		format.periodPercent = formatPercent(actual.periodPercent, 2);
-
-		if (group.single && item) {
-			actual.periodUnrealized = item.data.periodUnrealized;
-		}
 	}
 
 	function calculateMarketPercent(group, rates, parentGroup, portfolioGroup) {
@@ -3490,17 +3495,39 @@ module.exports = (() => {
 		}
 	}
 
+	function calculateRealizedPercent(group) {
+		const actual = group._dataActual;
+		const format = group._dataFormat;
+
+		const openBasis = actual.basis;
+		const totalBasis = actual.totalDivisor;
+
+		const numerator = actual.realized;
+		const denominator = totalBasis.subtract(openBasis);
+
+		if (denominator.getIsZero()) {
+			actual.realizedPercent = Decimal.ZERO;
+		} else {
+			actual.realizedPercent = numerator.divide(denominator);
+		}
+
+		format.realizedPercent = formatPercent(actual.realizedPercent, 2);
+	}
+
 	function calculateUnrealizedPercent(group) {
 		const actual = group._dataActual;
 		const format = group._dataFormat;
 
-		if (actual.basis.getIsZero()) {
-			actual.unrealizedPercent = null;
-			format.unrealizedPercent = '—';
+		const numerator = actual.unrealized;
+		const denominator = actual.basis;
+
+		if (denominator.getIsZero()) {
+			actual.unrealizedPercent = Decimal.ZERO;
 		} else {
-			actual.unrealizedPercent = actual.unrealized.divide(actual.basis);
-			format.unrealizedPercent = formatPercent(actual.unrealizedPercent, 2);
+			actual.unrealizedPercent = numerator.divide(denominator);
 		}
+
+		format.unrealizedPercent = formatPercent(actual.unrealizedPercent, 2);
 	}
 
 	function calculateGainPercent(gain, basis) {
@@ -3590,7 +3617,9 @@ module.exports = (() => {
 
 			this._data.periodIncome = null;
 			this._data.periodRealized = null;
+
 			this._data.periodUnrealized = null;
+			this._data.periodUnrealizedChange = null;
 
 			this._data.periodPrice = null;
 			this._data.periodPricePrevious = null;
@@ -3935,14 +3964,14 @@ module.exports = (() => {
 		data.marketPrevious2 = previousSummary2 === null ? Decimal.ZERO : previousSummary2.end.value;
 		data.quantityPrevious = previousSummary1 === null ? Decimal.ZERO : previousSummary1.end.open;
 
-		data.periodIncome = currentSummary !== null ? currentSummary.period.income : Decimal.ZERO;
-		data.periodRealized = currentSummary !== null ? currentSummary.period.realized : Decimal.ZERO;
-		data.periodUnrealized = currentSummary !== null ? currentSummary.period.unrealized : Decimal.ZERO;
-
 		data.periodGain = calculatePeriodGain(position.instrument.type, data.initiate, currentSummary, previousSummary1);
 		data.periodGainPrevious = calculatePeriodGain(position.instrument.type, data.initiate, previousSummary1, previousSummary2);
 		data.periodGainPrevious2 = calculatePeriodGain(position.instrument.type, data.initiate, previousSummary2, previousSummary3);
 
+		data.periodIncome = currentSummary !== null ? currentSummary.period.income : Decimal.ZERO;
+		data.periodRealized = currentSummary !== null ? currentSummary.period.realized : Decimal.ZERO;
+		data.periodUnrealized = calculatePeriodUnrealized(position.instrument.type, data.periodGain, data.periodRealized, data.periodIncome);
+
 		data.periodDivisor = calculatePeriodDivisor(position.instrument.type, data.initiate, currentSummary, previousSummary1);
 		data.periodDivisorPrevious = calculatePeriodDivisor(position.instrument.type, data.initiate, previousSummary1, previousSummary2);
 		data.periodDivisorPrevious2 = calculatePeriodDivisor(position.instrument.type, data.initiate, previousSummary2, previousSummary3);
@@ -3965,7 +3994,7 @@ module.exports = (() => {
 			data.periodPricePrevious = null;
 		}
 
-		data.totalDivisor = calculateTotalDivisor(position.instrument.type, data.initiate, currentSummary);
+		data.totalDivisor = calculateTotalDivisor(position.instrument.type, data.initiate, currentSummary, position);
 	}
 
 	function calculatePriceData(item, price) {
@@ -4070,6 +4099,18 @@ module.exports = (() => {
 
 				data.periodGain = periodGain;
 				data.periodGainChange = periodGainChange;
+
+				let periodUnrealized = calculatePeriodUnrealized(position.instrument.type, data.periodGain, data.periodRealized, data.periodIncome);
+				let periodUnrealizedChange;
+
+				if (data.periodUnrealized !== null) {
+					periodUnrealizedChange = periodUnrealized.subtract(data.periodUnrealized);
+				} else {
+					periodUnrealizedChange = Decimal.ZERO;
+				}
+
+				data.periodUnrealized = periodUnrealized;
+				data.periodUnrealizedChange = periodUnrealizedChange;
 			} else {
 				data.unrealized = Decimal.ZERO;
 				data.unrealizedChange = Decimal.ZERO;
@@ -4160,14 +4201,30 @@ module.exports = (() => {
 		return returnRef;
 	}
 
-	function calculateTotalDivisor(type, direction, finalSummary) {
+	function calculatePeriodUnrealized(type, periodGain, periodRealized, periodIncome) {
 		let returnRef;
 
+		if (type !== InstrumentType.CASH) {
+			returnRef = periodRealized.add(periodIncome).subtract(periodGain).opposite();
+		} else {
+			returnRef = Decimal.ZERO;
+		}
+
+		return returnRef;
+	}
+
+	function calculateTotalDivisor(type, direction, finalSummary, position) {
+		let returnRef;
+
+		// 2019-06-05, BRI. We should be reading from the summary -- in case we are
+		// running for a previous period. However, the summary does not have buy and
+		// sell totals for the entire history. Could be added.
+
 		if (finalSummary && type !== InstrumentType.CASH) {
 			if (direction === PositionDirection.SHORT) {
-				returnRef = finalSummary.period.sells;
+				returnRef = position.snapshot.sells;
 			} else {
-				returnRef = finalSummary.period.buys.opposite();
+				returnRef = position.snapshot.buys.opposite();
 			}
 		} else {
 			returnRef = Decimal.ZERO;
@@ -18444,7 +18501,9 @@ describe('When a position container data is gathered', () => {
 				value: new Decimal(456),
 				open: new Decimal(1),
 				income: new Decimal(0),
-				gain: new Decimal(0)
+				gain: new Decimal(0),
+				buys: new Decimal(50),
+				sells: new Decimal(0)
 			}
 		};
 	}

package/test/specs/processing/PositionContainerSpec.js

@@ -30,7 +30,9 @@ describe('When a position container data is gathered', () => {
 				value: new Decimal(456),
 				open: new Decimal(1),
 				income: new Decimal(0),
-				gain: new Decimal(0)
+				gain: new Decimal(0),
+				buys: new Decimal(50),
+				sells: new Decimal(0)
 			}
 		};
 	}