@barchart/portfolio-api-common 1.2.136 → 1.2.140

package/lib/api/failures/PortfolioFailureType.js

@@ -176,7 +176,18 @@ module.exports = (() => {
 		static get TRANSACTION_CREATE_FAILED_POSITION_LOCKED() {
 			return transactionCreateFailedPositionLocked;
 		}
-		
+
+		/**
+		 * The transaction failed because corporate action history is corrupt.
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get TRANSACTION_CREATE_FAILED_INSTRUMENT_CORRUPT() {
+			return transactionCreateFailedInstrumentCorrupt;
+		}
+
 		/**
 		 * The transaction (of this type) cannot be deleted by a user, instead,
 		 * it is created and managed by the system (e.g. dividends).
@@ -292,6 +303,7 @@ module.exports = (() => {
 	const transactionCreateFailedTypeReserved = new FailureType('TRANSACTION_CREATE_FAILED_TYPE_RESERVED', 'Unable to create {U|type.description} transaction, this type of transaction is managed by the system.');
 	const transactionCreateFailedReinvestPriceUnavailable = new FailureType('TRANSACTION_CREATE_FAILED_REINVEST_PRICE_UNAVAILABLE', 'Unable to create transaction, a dividend was paid on {L|day}; however no historical price is available for this day. To successfully create this transaction, please turn off dividend reinvestment for this position.');
 	const transactionCreateFailedPositionLocked = new FailureType('TRANSACTION_CREATE_FAILED_POSITION_LOCKED', 'Unable to create transaction, your {L|description} history is being recalculated. Please re-enter this transaction in a minute or two.');
+	const transactionCreateFailedInstrumentCorrupt = new FailureType('TRANSACTION_CREATE_FAILED_INSTRUMENT_CORRUPT', 'Unable to create transaction, corporate action history for {U|symbol} cannot be located.');
 
 	const transactionDeleteFailedOutOfSequence = new FailureType('TRANSACTION_DELETE_FAILED_OUT_OF_SEQUENCE', 'Deleting any transaction, except for the most recent, will cause transaction history to be re-written. Please confirm your intent to re-write transaction history (which could take some time and alter the historical results for this position).');
 	const transactionDeleteFailedNoTransaction = new FailureType('TRANSACTION_DELETE_FAILED_NO_TRANSACTION', 'Unable to delete transaction. The referenced transaction does not exist.');

package/lib/processing/PositionItem.js

@@ -571,11 +571,11 @@ module.exports = (() => {
 		const direction = summaries.reduce((accumulator, summary) => {
 			let returnRef = accumulator;
 
-			if (summary === null && summary.start.direction !== PositionDirection.EVEN) {
+			if (summary !== null && summary.start.direction !== PositionDirection.EVEN) {
 				returnRef = summary.start.direction;
 			}
 
-			if (summary === null && summary.start.direction !== PositionDirection.EVEN) {
+			if (summary !== null && summary.end.direction !== PositionDirection.EVEN) {
 				returnRef = summary.end.direction;
 			}
 
@@ -589,31 +589,27 @@ module.exports = (() => {
 		let returnRef;
 
 		if (currentSummary) {
-			if (direction === PositionDirection.LONG) {
-				let startValue;
+			let startValue;
 
-				if (previousSummary) {
-					startValue = previousSummary.end.value;
-				} else {
-					startValue = Decimal.ZERO;
-				}
-
-				let endValue;
-
-				if (overridePrice) {
-					endValue = currentSummary.end.open.multiply(overridePrice);
-				} else {
-					endValue = currentSummary.end.value;
-				}
+			if (previousSummary) {
+				startValue = previousSummary.end.value;
+			} else {
+				startValue = Decimal.ZERO;
+			}
 
-				const valueChange = endValue.subtract(startValue);
-				const tradeChange = currentSummary.period.sells.subtract(currentSummary.period.buys.opposite());
-				const incomeChange = currentSummary.period.income;
+			let endValue;
 
-				returnRef = valueChange.add(tradeChange).add(incomeChange);
+			if (overridePrice) {
+				endValue = currentSummary.end.open.multiply(overridePrice);
 			} else {
-				returnRef = Decimal.ZERO;
+				endValue = currentSummary.end.value;
 			}
+
+			const valueChange = endValue.subtract(startValue);
+			const tradeChange = currentSummary.period.sells.subtract(currentSummary.period.buys.opposite());
+			const incomeChange = currentSummary.period.income;
+
+			returnRef = valueChange.add(tradeChange).add(incomeChange);
 		} else {
 			returnRef = Decimal.ZERO;
 		}
@@ -625,18 +621,18 @@ module.exports = (() => {
 		let returnRef;
 
 		if (currentSummary) {
-			if (direction === PositionDirection.LONG) {
-				let startValue;
+			let startValue;
 
-				if (previousSummary) {
-					startValue = previousSummary.end.value;
-				} else {
-					startValue = Decimal.ZERO;
-				}
+			if (previousSummary) {
+				startValue = previousSummary.end.value;
+			} else {
+				startValue = Decimal.ZERO;
+			}
 
-				returnRef = startValue.add(currentSummary.period.buys.opposite());
+			if (direction === PositionDirection.SHORT) {
+				returnRef = startValue.opposite().add(currentSummary.period.sells);
 			} else {
-				returnRef = Decimal.ZERO;
+				returnRef = startValue.add(currentSummary.period.buys.opposite());
 			}
 		} else {
 			returnRef = Decimal.ZERO;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.2.136",
+  "version": "1.2.140",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -4077,11 +4077,11 @@ module.exports = (() => {
 		const direction = summaries.reduce((accumulator, summary) => {
 			let returnRef = accumulator;
 
-			if (summary === null && summary.start.direction !== PositionDirection.EVEN) {
+			if (summary !== null && summary.start.direction !== PositionDirection.EVEN) {
 				returnRef = summary.start.direction;
 			}
 
-			if (summary === null && summary.start.direction !== PositionDirection.EVEN) {
+			if (summary !== null && summary.end.direction !== PositionDirection.EVEN) {
 				returnRef = summary.end.direction;
 			}
 
@@ -4095,31 +4095,27 @@ module.exports = (() => {
 		let returnRef;
 
 		if (currentSummary) {
-			if (direction === PositionDirection.LONG) {
-				let startValue;
+			let startValue;
 
-				if (previousSummary) {
-					startValue = previousSummary.end.value;
-				} else {
-					startValue = Decimal.ZERO;
-				}
-
-				let endValue;
-
-				if (overridePrice) {
-					endValue = currentSummary.end.open.multiply(overridePrice);
-				} else {
-					endValue = currentSummary.end.value;
-				}
+			if (previousSummary) {
+				startValue = previousSummary.end.value;
+			} else {
+				startValue = Decimal.ZERO;
+			}
 
-				const valueChange = endValue.subtract(startValue);
-				const tradeChange = currentSummary.period.sells.subtract(currentSummary.period.buys.opposite());
-				const incomeChange = currentSummary.period.income;
+			let endValue;
 
-				returnRef = valueChange.add(tradeChange).add(incomeChange);
+			if (overridePrice) {
+				endValue = currentSummary.end.open.multiply(overridePrice);
 			} else {
-				returnRef = Decimal.ZERO;
+				endValue = currentSummary.end.value;
 			}
+
+			const valueChange = endValue.subtract(startValue);
+			const tradeChange = currentSummary.period.sells.subtract(currentSummary.period.buys.opposite());
+			const incomeChange = currentSummary.period.income;
+
+			returnRef = valueChange.add(tradeChange).add(incomeChange);
 		} else {
 			returnRef = Decimal.ZERO;
 		}
@@ -4131,18 +4127,18 @@ module.exports = (() => {
 		let returnRef;
 
 		if (currentSummary) {
-			if (direction === PositionDirection.LONG) {
-				let startValue;
+			let startValue;
 
-				if (previousSummary) {
-					startValue = previousSummary.end.value;
-				} else {
-					startValue = Decimal.ZERO;
-				}
+			if (previousSummary) {
+				startValue = previousSummary.end.value;
+			} else {
+				startValue = Decimal.ZERO;
+			}
 
-				returnRef = startValue.add(currentSummary.period.buys.opposite());
+			if (direction === PositionDirection.SHORT) {
+				returnRef = startValue.opposite().add(currentSummary.period.sells);
 			} else {
-				returnRef = Decimal.ZERO;
+				returnRef = startValue.add(currentSummary.period.buys.opposite());
 			}
 		} else {
 			returnRef = Decimal.ZERO;