@barchart/portfolio-api-common 1.2.118 → 1.2.119

package/lib/data/TransactionValidator.js

@@ -218,23 +218,6 @@ module.exports = (() => {
 		static validateDirectionSwitch(instrumentType, currentDirection, proposedDirection) {
 			return currentDirection === null || instrumentType.canSwitchDirection || (currentDirection.closed || proposedDirection.closed || currentDirection.positive === proposedDirection.positive);
 		}
-		
-		/**
-		 * Assuming the transaction list is ordered by sequence, validates that
-		 * no opening transactions exist after delisting date.
-		 *
-		 * @static
-		 * @public
-		 * @param {Array.<Object>} transactions
-		 * @returns {Boolean}
-		 */
-		static validateDelisting(transactions) {
-			assert.argumentIsArray(transactions, 'transactions');
-
-			const delistIndex = transactions.findIndex(t =>  t.type === TransactionType.DELIST);
-
-			return delistIndex < 0 || !transactions.some((t, i) => delistIndex < i && t.type.opening);
-		}
 
 		toString() {
 			return '[TransactionValidator]';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.2.118",
+  "version": "1.2.119",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -1386,23 +1386,6 @@ module.exports = (() => {
 		static validateDirectionSwitch(instrumentType, currentDirection, proposedDirection) {
 			return currentDirection === null || instrumentType.canSwitchDirection || (currentDirection.closed || proposedDirection.closed || currentDirection.positive === proposedDirection.positive);
 		}
-		
-		/**
-		 * Assuming the transaction list is ordered by sequence, validates that
-		 * no opening transactions exist after delisting date.
-		 *
-		 * @static
-		 * @public
-		 * @param {Array.<Object>} transactions
-		 * @returns {Boolean}
-		 */
-		static validateDelisting(transactions) {
-			assert.argumentIsArray(transactions, 'transactions');
-
-			const delistIndex = transactions.findIndex(t =>  t.type === TransactionType.DELIST);
-
-			return delistIndex < 0 || !transactions.some((t, i) => delistIndex < i && t.type.opening);
-		}
 
 		toString() {
 			return '[TransactionValidator]';
@@ -18239,28 +18222,6 @@ describe('When validating transaction references', () => {
 	});
 });
 
-describe('When validating transactions which could include instrument delisting', () => {
-	const build = (type) => {
-		return { type: type };
-	};
-
-	it('An array without a DELSIT transaction should be valid', () => {
-		expect(TransactionValidator.validateDelisting([ build(TransactionType.BUY), build(TransactionType.SELL) ])).toEqual(true);
-	});
-
-	it('An array with a final DELSIT transaction should be valid', () => {
-		expect(TransactionValidator.validateDelisting([ build(TransactionType.BUY), build(TransactionType.SELL), build(TransactionType.DELIST) ])).toEqual(true);
-	});
-
-	it('An array with a closing transaction after a DELIST transaction should be valid', () => {
-		expect(TransactionValidator.validateDelisting([ build(TransactionType.BUY), build(TransactionType.SELL), build(TransactionType.DELIST), build(TransactionType.SELL) ])).toEqual(true);
-	});
-
-	it('An array with an opening transaction after a DELIST transaction should not be valid', () => {
-		expect(TransactionValidator.validateDelisting([ build(TransactionType.BUY), build(TransactionType.SELL), build(TransactionType.DELIST), build(TransactionType.BUY) ])).toEqual(false);
-	});
-});
-
 describe('When requesting all the user-initiated transaction types', () => {
 	'use strict';
 

package/test/specs/data/TransactionValidatorSpec.js

@@ -79,28 +79,6 @@ describe('When validating transaction references', () => {
 	});
 });
 
-describe('When validating transactions which could include instrument delisting', () => {
-	const build = (type) => {
-		return { type: type };
-	};
-
-	it('An array without a DELSIT transaction should be valid', () => {
-		expect(TransactionValidator.validateDelisting([ build(TransactionType.BUY), build(TransactionType.SELL) ])).toEqual(true);
-	});
-
-	it('An array with a final DELSIT transaction should be valid', () => {
-		expect(TransactionValidator.validateDelisting([ build(TransactionType.BUY), build(TransactionType.SELL), build(TransactionType.DELIST) ])).toEqual(true);
-	});
-
-	it('An array with a closing transaction after a DELIST transaction should be valid', () => {
-		expect(TransactionValidator.validateDelisting([ build(TransactionType.BUY), build(TransactionType.SELL), build(TransactionType.DELIST), build(TransactionType.SELL) ])).toEqual(true);
-	});
-
-	it('An array with an opening transaction after a DELIST transaction should not be valid', () => {
-		expect(TransactionValidator.validateDelisting([ build(TransactionType.BUY), build(TransactionType.SELL), build(TransactionType.DELIST), build(TransactionType.BUY) ])).toEqual(false);
-	});
-});
-
 describe('When requesting all the user-initiated transaction types', () => {
 	'use strict';