@barchart/portfolio-api-common 1.2.115 → 1.2.116

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (4) hide show
  1. package/lib/processing/PositionGroup.js +6 -6
  2. package/lib/processing/PositionItem.js +0 -2
  3. package/package.json +1 -1
  4. package/test/SpecRunner.js +6 -8
package/lib/processing/PositionGroup.js CHANGED
@@ -786,9 +786,9 @@ module.exports = (() => {
786
786
  actual.periodUnrealizedBasisPrevious = item.data.periodUnrealizedBasisPrevious;
787
787
  actual.periodUnrealizedBasisPrevious2 = item.data.periodUnrealizedBasisPrevious2;
788
788
 
789
- actual.periodPercent = calculatePeriodPercent(actual.periodRealized, actual.periodRealizedBasis, actual.periodUnrealized, actual.periodUnrealizedBasis);
790
- actual.periodPercentPrevious = calculatePeriodPercent(actual.periodRealizedPrevious, actual.periodRealizedBasisPrevious, actual.periodUnrealizedPrevious, actual.periodUnrealizedBasisPrevious);
791
- actual.periodPercentPrevious2 = calculatePeriodPercent(actual.periodRealizedPrevious2, actual.periodRealizedBasisPrevious2, actual.periodUnrealizedPrevious2, actual.periodUnrealizedBasisPrevious2);
789
+ actual.periodPercent = calculatePeriodPercent(actual.summaryTotalCurrent, actual.periodRealizedBasis, actual.periodUnrealizedBasis);
790
+ actual.periodPercentPrevious = calculatePeriodPercent(actual.summaryTotalPrevious, actual.periodRealizedBasisPrevious, actual.periodUnrealizedBasisPrevious);
791
+ actual.periodPercentPrevious2 = calculatePeriodPercent(actual.summaryTotalPrevious2, actual.periodRealizedBasisPrevious2, actual.periodUnrealizedBasisPrevious2);
792
792
 
793
793
  format.periodPercent = formatPercent(actual.periodPercent, 2);
794
794
  format.periodPercentPrevious = formatPercent(actual.periodPercentPrevious, 2);
@@ -921,7 +921,7 @@ module.exports = (() => {
921
921
  if (group.single && item) {
922
922
  actual.periodUnrealized = item.data.periodUnrealized;
923
923
 
924
- actual.periodPercent = calculatePeriodPercent(actual.periodRealized, actual.periodRealizedBasis, actual.periodUnrealized, actual.periodUnrealizedBasis);
924
+ actual.periodPercent = calculatePeriodPercent(actual.summaryTotalCurrent, actual.periodRealizedBasis, actual.periodUnrealizedBasis);
925
925
  format.periodPercent = formatPercent(actual.periodPercent, 2);
926
926
  }
927
927
  }
@@ -982,8 +982,8 @@ module.exports = (() => {
982
982
  }
983
983
  }
984
984
 
985
- function calculatePeriodPercent(realized, realizedBasis, unrealized, unrealizedBasis) {
986
- const numerator = realized.add(unrealized);
985
+ function calculatePeriodPercent(periodSummaryTotal, realizedBasis, unrealizedBasis) {
986
+ const numerator = periodSummaryTotal;
987
987
  const denominator = realizedBasis.add(unrealizedBasis);
988
988
 
989
989
  return denominator.getIsZero() ? Decimal.ZERO : numerator.divide(denominator);
package/lib/processing/PositionItem.js CHANGED
@@ -648,8 +648,6 @@ module.exports = (() => {
648
648
  let returnRef;
649
649
 
650
650
  if (currentSummary) {
651
- const period = currentSummary.period;
652
-
653
651
  returnRef = currentSummary.end.basis.absolute();
654
652
  } else {
655
653
  returnRef = Decimal.ZERO;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@barchart/portfolio-api-common",
3
- "version": "1.2.115",
3
+ "version": "1.2.116",
4
4
  "description": "Common classes used by the Portfolio system",
5
5
  "author": {
6
6
  "name": "Bryan Ingle",
package/test/SpecRunner.js CHANGED
@@ -3289,9 +3289,9 @@ module.exports = (() => {
3289
3289
  actual.periodUnrealizedBasisPrevious = item.data.periodUnrealizedBasisPrevious;
3290
3290
  actual.periodUnrealizedBasisPrevious2 = item.data.periodUnrealizedBasisPrevious2;
3291
3291
 
3292
- actual.periodPercent = calculatePeriodPercent(actual.periodRealized, actual.periodRealizedBasis, actual.periodUnrealized, actual.periodUnrealizedBasis);
3293
- actual.periodPercentPrevious = calculatePeriodPercent(actual.periodRealizedPrevious, actual.periodRealizedBasisPrevious, actual.periodUnrealizedPrevious, actual.periodUnrealizedBasisPrevious);
3294
- actual.periodPercentPrevious2 = calculatePeriodPercent(actual.periodRealizedPrevious2, actual.periodRealizedBasisPrevious2, actual.periodUnrealizedPrevious2, actual.periodUnrealizedBasisPrevious2);
3292
+ actual.periodPercent = calculatePeriodPercent(actual.summaryTotalCurrent, actual.periodRealizedBasis, actual.periodUnrealizedBasis);
3293
+ actual.periodPercentPrevious = calculatePeriodPercent(actual.summaryTotalPrevious, actual.periodRealizedBasisPrevious, actual.periodUnrealizedBasisPrevious);
3294
+ actual.periodPercentPrevious2 = calculatePeriodPercent(actual.summaryTotalPrevious2, actual.periodRealizedBasisPrevious2, actual.periodUnrealizedBasisPrevious2);
3295
3295
 
3296
3296
  format.periodPercent = formatPercent(actual.periodPercent, 2);
3297
3297
  format.periodPercentPrevious = formatPercent(actual.periodPercentPrevious, 2);
@@ -3424,7 +3424,7 @@ module.exports = (() => {
3424
3424
  if (group.single && item) {
3425
3425
  actual.periodUnrealized = item.data.periodUnrealized;
3426
3426
 
3427
- actual.periodPercent = calculatePeriodPercent(actual.periodRealized, actual.periodRealizedBasis, actual.periodUnrealized, actual.periodUnrealizedBasis);
3427
+ actual.periodPercent = calculatePeriodPercent(actual.summaryTotalCurrent, actual.periodRealizedBasis, actual.periodUnrealizedBasis);
3428
3428
  format.periodPercent = formatPercent(actual.periodPercent, 2);
3429
3429
  }
3430
3430
  }
@@ -3485,8 +3485,8 @@ module.exports = (() => {
3485
3485
  }
3486
3486
  }
3487
3487
 
3488
- function calculatePeriodPercent(realized, realizedBasis, unrealized, unrealizedBasis) {
3489
- const numerator = realized.add(unrealized);
3488
+ function calculatePeriodPercent(periodSummaryTotal, realizedBasis, unrealizedBasis) {
3489
+ const numerator = periodSummaryTotal;
3490
3490
  const denominator = realizedBasis.add(unrealizedBasis);
3491
3491
 
3492
3492
  return denominator.getIsZero() ? Decimal.ZERO : numerator.divide(denominator);
@@ -4148,8 +4148,6 @@ module.exports = (() => {
4148
4148
  let returnRef;
4149
4149
 
4150
4150
  if (currentSummary) {
4151
- const period = currentSummary.period;
4152
-
4153
4151
  returnRef = currentSummary.end.basis.absolute();
4154
4152
  } else {
4155
4153
  returnRef = Decimal.ZERO;