@barchart/portfolio-api-common 1.2.113 → 1.2.117

package/lib/data/PositionSummaryFrame.js

@@ -241,7 +241,32 @@ module.exports = (() => {
 	}
 
 	function getMonthlyRanges(transactions) {
-		return [ ];
+    const ranges = [ ];
+    
+    if (!transactions.length) {
+    	return ranges;
+		}
+
+		const first = array.first(transactions);
+		const last = array.last(transactions);
+
+		const firstDate = first.date;
+		let lastDate;
+
+		lastDate = last.snapshot.open.getIsZero()
+			? new Day(last.date.year, last.date.month, last.date.day).addMonths(1)
+			: Day.getToday();
+		lastDate = lastDate.getEndOfMonth();
+
+		for (
+			let end = firstDate.getEndOfMonth();
+			end.format() <= lastDate.format();
+			end = end.addMonths(1).getEndOfMonth()
+		) {
+			ranges.push(getRange(end.subtractMonths(1).getEndOfMonth(), end));
+		}
+    
+    return ranges;
 	}
 
 	function getYearToDateRanges(transactions) {
@@ -278,7 +303,11 @@ module.exports = (() => {
 	}
 
 	function getMonthlyStartDate(periods, date) {
-		return null;
+    const today = date || Day.getToday();
+    
+		return today
+			.subtractMonths(periods)
+			.subtractDays(today.day);
 	}
 
 	function getYearToDateStartDate(periods, date) {

package/lib/data/TransactionType.js

@@ -352,6 +352,17 @@ module.exports = (() => {
 		static get DEBIT() {
 			return debit;
 		}
+    
+		/**
+		 * A system-generated transaction, indicating the security has stopped active trading.
+		 *
+		 * @public
+		 * @static
+		 * @returns {TransactionType}
+		 */
+		static get DELIST() {
+			return delist;
+		}
 
 		/**
 		 * A system-generated deposit, arising from another transaction.
@@ -401,6 +412,7 @@ module.exports = (() => {
 	const split = new TransactionType('SP', 'Split', 'Split', 1, false, false, false, true, false, false, true, false, false);
 	const fee = new TransactionType('F', 'Fee', 'Fee', 0, false, false, false, false, false, true, false, false, false);
 	const feeUnits = new TransactionType('FU', 'Fee Units', 'Fee', 0, false, false, false, false, true, false, false, false, false);
+	const delist = new TransactionType('DL', 'Delist', 'Delist', 0, false, false, false, false, false, false, false, false, false);
 
 	const distributionCash = new TransactionType('DC', 'Distribution (Cash)', 'Cash Distribution', 1, false, false, true, false, false, false, true, false, false);
 	const distributionReinvest = new TransactionType('DY', 'Distribution (Reinvested)', 'Distribution Reinvest', 1, false, false, false, true, false, false, true, false, false);

package/lib/data/TransactionValidator.js

@@ -244,6 +244,7 @@ module.exports = (() => {
 	associateTypes(InstrumentType.EQUITY, TransactionType.DIVIDEND_REINVEST, false);
 	associateTypes(InstrumentType.EQUITY, TransactionType.DIVIDEND_STOCK, false);
 	associateTypes(InstrumentType.EQUITY, TransactionType.SPLIT, false);
+	associateTypes(InstrumentType.EQUITY, TransactionType.DELIST, false);
 
 	associateTypes(InstrumentType.FUND, TransactionType.BUY, true, [ PositionDirection.LONG, PositionDirection.EVEN ]);
 	associateTypes(InstrumentType.FUND, TransactionType.SELL, true, [ PositionDirection.LONG ]);
@@ -252,6 +253,7 @@ module.exports = (() => {
 	associateTypes(InstrumentType.FUND, TransactionType.DISTRIBUTION_CASH, false);
 	associateTypes(InstrumentType.FUND, TransactionType.DISTRIBUTION_REINVEST, false);
 	associateTypes(InstrumentType.FUND, TransactionType.DISTRIBUTION_FUND, false);
+	associateTypes(InstrumentType.FUND, TransactionType.DELIST, false);
 
 	associateTypes(InstrumentType.OTHER, TransactionType.BUY, true, [ PositionDirection.LONG, PositionDirection.EVEN ]);
 	associateTypes(InstrumentType.OTHER, TransactionType.SELL, true, [ PositionDirection.LONG ]);

package/lib/formatters/TransactionFormatter.js

@@ -216,7 +216,7 @@ module.exports = (() => {
 	formatters.set(TransactionType.INCOME, (t) => {
 		return {
 			total: t.income.amount
-		};	
+		};
 	});
 
 	formatters.set(TransactionType.FEE, (t) => {
@@ -254,6 +254,10 @@ module.exports = (() => {
 			price: rate
 		};
 	});
+	
+	formatters.set(TransactionType.DELIST, () => {
+		return { };
+	});
 
 	const cashFormatter = (t) => {
 		return {
@@ -298,4 +302,4 @@ module.exports = (() => {
 		.toComparator();
 
 	return TransactionFormatter;
-})();
+})();

package/lib/processing/PositionGroup.js

@@ -786,9 +786,9 @@ module.exports = (() => {
 			actual.periodUnrealizedBasisPrevious = item.data.periodUnrealizedBasisPrevious;
 			actual.periodUnrealizedBasisPrevious2 = item.data.periodUnrealizedBasisPrevious2;
 
-			actual.periodPercent = calculatePeriodPercent(actual.periodRealized, actual.periodRealizedBasis, actual.periodUnrealized, actual.periodUnrealizedBasis);
-			actual.periodPercentPrevious = calculatePeriodPercent(actual.periodRealizedPrevious, actual.periodRealizedBasisPrevious, actual.periodUnrealizedPrevious, actual.periodUnrealizedBasisPrevious);
-			actual.periodPercentPrevious2 = calculatePeriodPercent(actual.periodRealizedPrevious2, actual.periodRealizedBasisPrevious2, actual.periodUnrealizedPrevious2, actual.periodUnrealizedBasisPrevious2);
+			actual.periodPercent = calculatePeriodPercent(actual.summaryTotalCurrent, actual.periodRealizedBasis, actual.periodUnrealizedBasis);
+			actual.periodPercentPrevious = calculatePeriodPercent(actual.summaryTotalPrevious, actual.periodRealizedBasisPrevious, actual.periodUnrealizedBasisPrevious);
+			actual.periodPercentPrevious2 = calculatePeriodPercent(actual.summaryTotalPrevious2, actual.periodRealizedBasisPrevious2, actual.periodUnrealizedBasisPrevious2);
 
 			format.periodPercent = formatPercent(actual.periodPercent, 2);
 			format.periodPercentPrevious = formatPercent(actual.periodPercentPrevious, 2);
@@ -921,7 +921,7 @@ module.exports = (() => {
 		if (group.single && item) {
 			actual.periodUnrealized = item.data.periodUnrealized;
 
-			actual.periodPercent = calculatePeriodPercent(actual.periodRealized, actual.periodRealizedBasis, actual.periodUnrealized, actual.periodUnrealizedBasis);
+			actual.periodPercent = calculatePeriodPercent(actual.summaryTotalCurrent, actual.periodRealizedBasis, actual.periodUnrealizedBasis);
 			format.periodPercent = formatPercent(actual.periodPercent, 2);
 		}
 	}
@@ -982,8 +982,8 @@ module.exports = (() => {
 		}
 	}
 
-	function calculatePeriodPercent(realized, realizedBasis, unrealized, unrealizedBasis) {
-		const numerator = realized.add(unrealized);
+	function calculatePeriodPercent(periodSummaryTotal, realizedBasis, unrealizedBasis) {
+		const numerator = periodSummaryTotal;
 		const denominator = realizedBasis.add(unrealizedBasis);
 
 		return denominator.getIsZero() ? Decimal.ZERO : numerator.divide(denominator);

package/lib/processing/PositionItem.js

@@ -648,8 +648,6 @@ module.exports = (() => {
 		let returnRef;
 
 		if (currentSummary) {
-			const period = currentSummary.period;
-
 			returnRef = currentSummary.end.basis.absolute();
 		} else {
 			returnRef = Decimal.ZERO;

package/lib/serialization/TransactionSchema.js

@@ -113,6 +113,10 @@ module.exports = (() => {
 		static get VALUATION() {
 			return valuation;
 		}
+		
+		static get DELIST() {
+			return delist;
+		}
 
 		static get INCOME() {
 			return income;
@@ -322,8 +326,18 @@ module.exports = (() => {
 		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
-
-	const income = new TransactionSchema(SchemaBuilder.withName(TransactionType.INCOME.code)
+	
+	const delist = new TransactionSchema(SchemaBuilder.withName(TransactionType.DELIST.code)
+		.withField('portfolio', DataType.STRING)
+		.withField('position', DataType.STRING)
+		.withField('sequence', DataType.NUMBER, true)
+		.withField('type', DataType.forEnum(TransactionType, 'TransactionType'))
+		.withField('date', DataType.DAY)
+		.withField('force', DataType.BOOLEAN, true)
+		.schema
+	);
+  
+  const income = new TransactionSchema(SchemaBuilder.withName(TransactionType.INCOME.code)
 		.withField('portfolio', DataType.STRING)
 		.withField('position', DataType.STRING)
 		.withField('sequence', DataType.NUMBER, true)
@@ -349,6 +363,7 @@ module.exports = (() => {
 	addSchemaToMap(TransactionType.DEPOSIT, deposit);
 	addSchemaToMap(TransactionType.WITHDRAWAL, withdrawal);
 	addSchemaToMap(TransactionType.VALUATION, valuation);
+	addSchemaToMap(TransactionType.DELIST, delist);
 	addSchemaToMap(TransactionType.INCOME, income);
 
 	return TransactionSchema;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.2.113",
+  "version": "1.2.117",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -632,7 +632,32 @@ module.exports = (() => {
 	}
 
 	function getMonthlyRanges(transactions) {
-		return [ ];
+    const ranges = [ ];
+    
+    if (!transactions.length) {
+    	return ranges;
+		}
+
+		const first = array.first(transactions);
+		const last = array.last(transactions);
+
+		const firstDate = first.date;
+		let lastDate;
+
+		lastDate = last.snapshot.open.getIsZero()
+			? new Day(last.date.year, last.date.month, last.date.day).addMonths(1)
+			: Day.getToday();
+		lastDate = lastDate.getEndOfMonth();
+
+		for (
+			let end = firstDate.getEndOfMonth();
+			end.format() <= lastDate.format();
+			end = end.addMonths(1).getEndOfMonth()
+		) {
+			ranges.push(getRange(end.subtractMonths(1).getEndOfMonth(), end));
+		}
+    
+    return ranges;
 	}
 
 	function getYearToDateRanges(transactions) {
@@ -669,7 +694,11 @@ module.exports = (() => {
 	}
 
 	function getMonthlyStartDate(periods, date) {
-		return null;
+    const today = date || Day.getToday();
+    
+		return today
+			.subtractMonths(periods)
+			.subtractDays(today.day);
 	}
 
 	function getYearToDateStartDate(periods, date) {
@@ -1060,6 +1089,17 @@ module.exports = (() => {
 		static get DEBIT() {
 			return debit;
 		}
+    
+		/**
+		 * A system-generated transaction, indicating the security has stopped active trading.
+		 *
+		 * @public
+		 * @static
+		 * @returns {TransactionType}
+		 */
+		static get DELIST() {
+			return delist;
+		}
 
 		/**
 		 * A system-generated deposit, arising from another transaction.
@@ -1109,6 +1149,7 @@ module.exports = (() => {
 	const split = new TransactionType('SP', 'Split', 'Split', 1, false, false, false, true, false, false, true, false, false);
 	const fee = new TransactionType('F', 'Fee', 'Fee', 0, false, false, false, false, false, true, false, false, false);
 	const feeUnits = new TransactionType('FU', 'Fee Units', 'Fee', 0, false, false, false, false, true, false, false, false, false);
+	const delist = new TransactionType('DL', 'Delist', 'Delist', 0, false, false, false, false, false, false, false, false, false);
 
 	const distributionCash = new TransactionType('DC', 'Distribution (Cash)', 'Cash Distribution', 1, false, false, true, false, false, false, true, false, false);
 	const distributionReinvest = new TransactionType('DY', 'Distribution (Reinvested)', 'Distribution Reinvest', 1, false, false, false, true, false, false, true, false, false);
@@ -1372,6 +1413,7 @@ module.exports = (() => {
 	associateTypes(InstrumentType.EQUITY, TransactionType.DIVIDEND_REINVEST, false);
 	associateTypes(InstrumentType.EQUITY, TransactionType.DIVIDEND_STOCK, false);
 	associateTypes(InstrumentType.EQUITY, TransactionType.SPLIT, false);
+	associateTypes(InstrumentType.EQUITY, TransactionType.DELIST, false);
 
 	associateTypes(InstrumentType.FUND, TransactionType.BUY, true, [ PositionDirection.LONG, PositionDirection.EVEN ]);
 	associateTypes(InstrumentType.FUND, TransactionType.SELL, true, [ PositionDirection.LONG ]);
@@ -1380,6 +1422,7 @@ module.exports = (() => {
 	associateTypes(InstrumentType.FUND, TransactionType.DISTRIBUTION_CASH, false);
 	associateTypes(InstrumentType.FUND, TransactionType.DISTRIBUTION_REINVEST, false);
 	associateTypes(InstrumentType.FUND, TransactionType.DISTRIBUTION_FUND, false);
+	associateTypes(InstrumentType.FUND, TransactionType.DELIST, false);
 
 	associateTypes(InstrumentType.OTHER, TransactionType.BUY, true, [ PositionDirection.LONG, PositionDirection.EVEN ]);
 	associateTypes(InstrumentType.OTHER, TransactionType.SELL, true, [ PositionDirection.LONG ]);
@@ -3246,9 +3289,9 @@ module.exports = (() => {
 			actual.periodUnrealizedBasisPrevious = item.data.periodUnrealizedBasisPrevious;
 			actual.periodUnrealizedBasisPrevious2 = item.data.periodUnrealizedBasisPrevious2;
 
-			actual.periodPercent = calculatePeriodPercent(actual.periodRealized, actual.periodRealizedBasis, actual.periodUnrealized, actual.periodUnrealizedBasis);
-			actual.periodPercentPrevious = calculatePeriodPercent(actual.periodRealizedPrevious, actual.periodRealizedBasisPrevious, actual.periodUnrealizedPrevious, actual.periodUnrealizedBasisPrevious);
-			actual.periodPercentPrevious2 = calculatePeriodPercent(actual.periodRealizedPrevious2, actual.periodRealizedBasisPrevious2, actual.periodUnrealizedPrevious2, actual.periodUnrealizedBasisPrevious2);
+			actual.periodPercent = calculatePeriodPercent(actual.summaryTotalCurrent, actual.periodRealizedBasis, actual.periodUnrealizedBasis);
+			actual.periodPercentPrevious = calculatePeriodPercent(actual.summaryTotalPrevious, actual.periodRealizedBasisPrevious, actual.periodUnrealizedBasisPrevious);
+			actual.periodPercentPrevious2 = calculatePeriodPercent(actual.summaryTotalPrevious2, actual.periodRealizedBasisPrevious2, actual.periodUnrealizedBasisPrevious2);
 
 			format.periodPercent = formatPercent(actual.periodPercent, 2);
 			format.periodPercentPrevious = formatPercent(actual.periodPercentPrevious, 2);
@@ -3381,7 +3424,7 @@ module.exports = (() => {
 		if (group.single && item) {
 			actual.periodUnrealized = item.data.periodUnrealized;
 
-			actual.periodPercent = calculatePeriodPercent(actual.periodRealized, actual.periodRealizedBasis, actual.periodUnrealized, actual.periodUnrealizedBasis);
+			actual.periodPercent = calculatePeriodPercent(actual.summaryTotalCurrent, actual.periodRealizedBasis, actual.periodUnrealizedBasis);
 			format.periodPercent = formatPercent(actual.periodPercent, 2);
 		}
 	}
@@ -3442,8 +3485,8 @@ module.exports = (() => {
 		}
 	}
 
-	function calculatePeriodPercent(realized, realizedBasis, unrealized, unrealizedBasis) {
-		const numerator = realized.add(unrealized);
+	function calculatePeriodPercent(periodSummaryTotal, realizedBasis, unrealizedBasis) {
+		const numerator = periodSummaryTotal;
 		const denominator = realizedBasis.add(unrealizedBasis);
 
 		return denominator.getIsZero() ? Decimal.ZERO : numerator.divide(denominator);
@@ -4105,8 +4148,6 @@ module.exports = (() => {
 		let returnRef;
 
 		if (currentSummary) {
-			const period = currentSummary.period;
-
 			returnRef = currentSummary.end.basis.absolute();
 		} else {
 			returnRef = Decimal.ZERO;
@@ -4672,6 +4713,10 @@ module.exports = (() => {
 		static get VALUATION() {
 			return valuation;
 		}
+		
+		static get DELIST() {
+			return delist;
+		}
 
 		static get INCOME() {
 			return income;
@@ -4881,8 +4926,18 @@ module.exports = (() => {
 		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
-
-	const income = new TransactionSchema(SchemaBuilder.withName(TransactionType.INCOME.code)
+	
+	const delist = new TransactionSchema(SchemaBuilder.withName(TransactionType.DELIST.code)
+		.withField('portfolio', DataType.STRING)
+		.withField('position', DataType.STRING)
+		.withField('sequence', DataType.NUMBER, true)
+		.withField('type', DataType.forEnum(TransactionType, 'TransactionType'))
+		.withField('date', DataType.DAY)
+		.withField('force', DataType.BOOLEAN, true)
+		.schema
+	);
+  
+  const income = new TransactionSchema(SchemaBuilder.withName(TransactionType.INCOME.code)
 		.withField('portfolio', DataType.STRING)
 		.withField('position', DataType.STRING)
 		.withField('sequence', DataType.NUMBER, true)
@@ -4908,6 +4963,7 @@ module.exports = (() => {
 	addSchemaToMap(TransactionType.DEPOSIT, deposit);
 	addSchemaToMap(TransactionType.WITHDRAWAL, withdrawal);
 	addSchemaToMap(TransactionType.VALUATION, valuation);
+	addSchemaToMap(TransactionType.DELIST, delist);
 	addSchemaToMap(TransactionType.INCOME, income);
 
 	return TransactionSchema;
@@ -6311,6 +6367,19 @@ module.exports = function () {
 				return this.addYears(years, true);
 			}
 
+			/**
+    * Returns a new Day instance for the end of the month of the current instance.
+    *
+    * @public
+    * @returns {Day}
+    */
+
+		}, {
+			key: 'getEndOfMonth',
+			value: function getEndOfMonth() {
+				return new Day(this.year, this.month, Day.getDaysInMonth(this.year, this.month));
+			}
+
 			/**
     * Indicates if another {@link Day} occurs before the current instance.
     *
@@ -10103,7 +10172,7 @@ module.exports = function () {
    * the schema.
    *
    * @public
-   * @param {data} data
+   * @param {Object} data
    * @returns {Object}
    */
 
@@ -10185,7 +10254,13 @@ module.exports = function () {
 				};
 
 				return function (key, value) {
-					return advance(key).reviver(value);
+					var item = advance(key);
+
+					if (key === '') {
+						return value;
+					} else {
+						return item.reviver(value);
+					}
 				};
 			}
 
@@ -17827,6 +17902,50 @@ describe('After the PositionSummaryFrame enumeration is initialized', () => {
 		});
 	});
 
+	describe('and month position summary ranges are processed for a transaction set that does not close', () => {
+		let ranges;
+
+		beforeEach(() => {
+			const transactions = [
+				{
+					date: new Day(2018, 10, 20),
+					snapshot: {
+						open: new Decimal(1)
+					},
+					type: TransactionType.BUY
+				},
+				{
+					date: new Day(2018, 11, 21),
+					snapshot: {
+						open: new Decimal(1)
+					},
+					type: TransactionType.BUY
+				}
+			];
+
+			ranges = PositionSummaryFrame.MONTHLY.getRanges(transactions);
+		});
+
+		it('should have three ranges (assuming the current year is 2018 and the current month is December)', () => {
+			expect(ranges.length).toEqual(3);
+		});
+
+		it('the first range should be from 2018-09-30 to 2018-10-31', () => {
+			expect(ranges[0].start.format()).toEqual('2018-09-30');
+			expect(ranges[0].end.format()).toEqual('2018-10-31');
+		});
+
+		it('the second range should be from 2018-10-31 to 2018-11-30', () => {
+		  expect(ranges[1].start.format()).toEqual('2018-10-31');
+		  expect(ranges[1].end.format()).toEqual('2018-11-30');
+		});
+
+		it('the third range should be from 2018-10-31 to 2018-11-30', () => {
+			expect(ranges[2].start.format()).toEqual('2018-11-30');
+			expect(ranges[2].end.format()).toEqual('2018-12-31');
+		});
+	});
+
 	describe('and getting the start date for yearly frames', () => {
 		describe('for one year ago', function() {
 			let start;
@@ -17869,6 +17988,55 @@ describe('After the PositionSummaryFrame enumeration is initialized', () => {
 		});
 	});
 
+
+
+
+	////
+
+	describe('and getting the start date for monthly frames', () => {
+		describe('for one month ago', function () {
+			let start;
+
+			beforeEach(() => {
+				start = PositionSummaryFrame.MONTHLY.getStartDate(1);
+			});
+
+			it('should be on the last day of month', () => {
+				const today = Day.getToday();
+				
+				expect(start.day).toEqual(Day.getDaysInMonth(today.year, today.month - 2));
+			});
+
+			it('should be month ago', () => {
+				expect(start.month).toEqual(Day.getToday().month - 2);
+			});
+		});
+    
+    describe('for three months ago', function () {
+      let start;
+      
+      beforeEach(() => {
+        start = PositionSummaryFrame.MONTHLY.getStartDate(3);
+      });
+      
+      it('should be on the last day of month', () => {
+        const today = Day.getToday();
+        
+        expect(start.day).toEqual(Day.getDaysInMonth(today.year, today.month - 4));
+      });
+      
+      it('should be 3 month ago', () => {
+        expect(start.month).toEqual(Day.getToday().month - 4);
+      });
+    });
+	});
+
+	////
+
+
+
+
+
 	describe('and recent ranges are calculated', () => {
 		let todayYear;
 		let todayMonth;

package/test/specs/data/PositionSummaryFrameSpec.js

@@ -311,6 +311,50 @@ describe('After the PositionSummaryFrame enumeration is initialized', () => {
 		});
 	});
 
+	describe('and month position summary ranges are processed for a transaction set that does not close', () => {
+		let ranges;
+
+		beforeEach(() => {
+			const transactions = [
+				{
+					date: new Day(2018, 10, 20),
+					snapshot: {
+						open: new Decimal(1)
+					},
+					type: TransactionType.BUY
+				},
+				{
+					date: new Day(2018, 11, 21),
+					snapshot: {
+						open: new Decimal(1)
+					},
+					type: TransactionType.BUY
+				}
+			];
+
+			ranges = PositionSummaryFrame.MONTHLY.getRanges(transactions);
+		});
+
+		it('should have three ranges (assuming the current year is 2018 and the current month is December)', () => {
+			expect(ranges.length).toEqual(3);
+		});
+
+		it('the first range should be from 2018-09-30 to 2018-10-31', () => {
+			expect(ranges[0].start.format()).toEqual('2018-09-30');
+			expect(ranges[0].end.format()).toEqual('2018-10-31');
+		});
+
+		it('the second range should be from 2018-10-31 to 2018-11-30', () => {
+		  expect(ranges[1].start.format()).toEqual('2018-10-31');
+		  expect(ranges[1].end.format()).toEqual('2018-11-30');
+		});
+
+		it('the third range should be from 2018-10-31 to 2018-11-30', () => {
+			expect(ranges[2].start.format()).toEqual('2018-11-30');
+			expect(ranges[2].end.format()).toEqual('2018-12-31');
+		});
+	});
+
 	describe('and getting the start date for yearly frames', () => {
 		describe('for one year ago', function() {
 			let start;
@@ -353,6 +397,55 @@ describe('After the PositionSummaryFrame enumeration is initialized', () => {
 		});
 	});
 
+
+
+
+	////
+
+	describe('and getting the start date for monthly frames', () => {
+		describe('for one month ago', function () {
+			let start;
+
+			beforeEach(() => {
+				start = PositionSummaryFrame.MONTHLY.getStartDate(1);
+			});
+
+			it('should be on the last day of month', () => {
+				const today = Day.getToday();
+				
+				expect(start.day).toEqual(Day.getDaysInMonth(today.year, today.month - 2));
+			});
+
+			it('should be month ago', () => {
+				expect(start.month).toEqual(Day.getToday().month - 2);
+			});
+		});
+    
+    describe('for three months ago', function () {
+      let start;
+      
+      beforeEach(() => {
+        start = PositionSummaryFrame.MONTHLY.getStartDate(3);
+      });
+      
+      it('should be on the last day of month', () => {
+        const today = Day.getToday();
+        
+        expect(start.day).toEqual(Day.getDaysInMonth(today.year, today.month - 4));
+      });
+      
+      it('should be 3 month ago', () => {
+        expect(start.month).toEqual(Day.getToday().month - 4);
+      });
+    });
+	});
+
+	////
+
+
+
+
+
 	describe('and recent ranges are calculated', () => {
 		let todayYear;
 		let todayMonth;