@barchart/portfolio-api-common 1.2.106 → 1.2.110

package/lib/api/failures/PortfolioFailureType.js

@@ -56,6 +56,17 @@ module.exports = (() => {
 			return positionUpdateFailedNoPosition;
 		}
 
+		/**
+		 * Unable to delete, a related position is locked.
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get POSITION_DELETE_FAILED_POSITION_LOCKED() {
+			return positionDeleteFailedPositionLocked;
+		}
+
 		/**
 		 * The position does not exist.
 		 *
@@ -97,8 +108,8 @@ module.exports = (() => {
 		}
 
 		/**
-		 * The transaction would cause the position to change (from long to
-		 * short, or vice versa).
+		 * The transaction would cause the position direction to change
+		 * from long to short, or vice versa.
 		 *
 		 * @public
 		 * @static
@@ -144,7 +155,7 @@ module.exports = (() => {
 		}
 
 		/**
-		 * The transaction failed because the position has been locked.
+		 * The transaction failed because a related position is locked.
 		 *
 		 * @public
 		 * @static
@@ -188,6 +199,17 @@ module.exports = (() => {
 			return transactionDeleteFailedDirectionSwitchOnRewrite;
 		}
 
+		/**
+		 * Unable to delete, a related position is locked.
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get TRANSACTION_DELETE_FAILED_POSITION_LOCKED() {
+			return transactionDeleteFailedPositionLocked;
+		}
+
 		/**
 		 * Unable to edit, the transaction doesn't exist.
 		 *
@@ -221,6 +243,7 @@ module.exports = (() => {
 
 	const positionCreateFailedNoPortfolio = new FailureType('POSITION_CREATE_FAILED_NO_PORTFOLIO', 'Unable to create transaction. The portfolio does not exist, has it been deleted?');
 	const positionUpdateFailedNoPosition = new FailureType('POSITION_UPDATE_FAILED_NO_POSITION', 'Unable to update preferences for position. The position does not exist, has it been deleted?');
+	const positionDeleteFailedPositionLocked = new FailureType('POSITION_DELETE_FAILED_POSITION_LOCKED', 'Unable to delete position, your {L|description} history is being recalculated. Please wait a minute or two and retry.');
 
 	const transactionCreateFailedNoPosition = new FailureType('TRANSACTION_CREATE_FAILED_NO_POSITION', 'Unable to create transaction. The referenced position does not exist. Has it been deleted?');
 	const transactionCreateFailedOutOfSequence = new FailureType('TRANSACTION_CREATE_FAILED_OUT_OF_SEQUENCE', 'Unable to process transaction, because the transaction date is out-of-sequence. In other words, it would occur before an existing transaction. Please confirm your intent to re-write transaction history (which could take some time and alter the historical results for this position).');
@@ -235,6 +258,7 @@ module.exports = (() => {
 	const transactionDeleteFailedOutOfSequence = new FailureType('TRANSACTION_DELETE_FAILED_OUT_OF_SEQUENCE', 'Deleting any transaction, except for the most recent, will cause transaction history to be re-written. Please confirm your intent to re-write transaction history (which could take some time and alter the historical results for this position).');
 	const transactionDeleteFailedNoTransaction = new FailureType('TRANSACTION_DELETE_FAILED_NO_TRANSACTION', 'Unable to delete transaction. The referenced transaction does not exist.');
 	const transactionDeleteFailedDirectionSwitchOnRewrite = new FailureType('TRANSACTION_DELETE_FAILED_DIRECTION_SWITCH_ON_REWRITE', 'Deleting this transaction would cause your history to be re-written and the position to switch from long to short (i.e. positive to negative) or vice versa.');
+	const transactionDeleteFailedPositionLocked = new FailureType('TRANSACTION_DELETE_FAILED_POSITION_LOCKED', 'Unable to delete transaction, your {L|description} history is being recalculated. Please wait a minute or two and retry.');
 
 	const transactionEditFailedNoTransaction = new FailureType('TRANSACTION_EDIT_FAILED_NO_TRANSACTION', 'Unable to edit transaction. The referenced transaction does not exist.');
 	const transactionEditFailedTypeReserved = new FailureType('TRANSACTION_EDIT_FAILED_TYPE_RESERVED', 'Unable to edit {U|type.description} transaction, this type of transaction is managed by the system.');

package/lib/formatters/TransactionFormatter.js

@@ -205,6 +205,7 @@ module.exports = (() => {
 
 	formatters.set(TransactionType.DISTRIBUTION_REINVEST, (t) => {
 		return {
+			boughtSold: t.quantity,
 			shares: t.snapshot.open.subtract(t.quantity),
 			price: t.dividend.price,
 			fee: t.fee,

package/lib/processing/PositionContainer.js

@@ -104,7 +104,7 @@ module.exports = (() => {
 			}, { });
 
 			this._items = positions.reduce((items, position) => {
-				const item = createPositionItem.call(this, position);
+				const item = createPositionItem.call(this, position, reportFrame ? true : false);
 
 				if (item) {
 					items.push(item);
@@ -313,7 +313,7 @@ module.exports = (() => {
 				addSummaryPrevious(this._summariesPrevious, summary, this._previousSummaryFrame, this._previousSummaryRanges);
 			});
 
-			const item = createPositionItem.call(this, position);
+			const item = createPositionItem.call(this, position, false);
 
 			addBarchartSymbol(this._symbols, item);
 			addDisplaySymbol(this._symbolsDisplay, item);
@@ -959,7 +959,7 @@ module.exports = (() => {
 		}
 	}
 
-	function createPositionItem(position, currentQuote, previousQuote) {
+	function createPositionItem(position, requireCurrentSummary) {
 		const portfolio = this._portfolios[position.portfolio];
 
 		let returnRef;
@@ -968,7 +968,11 @@ module.exports = (() => {
 			const currentSummary = this._summariesCurrent[ position.position ] || null;
 			const previousSummaries = this._summariesPrevious[ position.position ] || getSummaryArray(this._previousSummaryRanges);
 
-			returnRef = new PositionItem(portfolio, position, currentSummary, previousSummaries, this._reporting);
+			if (!requireCurrentSummary || currentSummary !== null) {
+				returnRef = new PositionItem(portfolio, position, currentSummary, previousSummaries, this._reporting);
+			} else {
+				returnRef = null;
+			}
 		} else {
 			returnRef = null;
 		}

package/lib/processing/PositionGroup.js

@@ -734,7 +734,7 @@ module.exports = (() => {
 		if (group.single && group._items.length === 1) {
 			const item = group._items[0];
 
-			actual.quantity = item.position.snapshot.open;
+			actual.quantity = item.data.quantity;
 			actual.quantityPrevious = item.data.quantityPrevious;
 			
 			actual.basisPrice = item.data.basisPrice;

package/lib/processing/PositionItem.js

@@ -71,8 +71,8 @@ module.exports = (() => {
 			this._data.marketPrevious = null;
 			this._data.marketPrevious2 = null;
 
+			this._data.quantity = null;
 			this._data.quantityPrevious = null;
-			this._data.quantityPrevious2 = null;
 			
 			this._data.realized = null;
 			this._data.income = null;
@@ -385,6 +385,7 @@ module.exports = (() => {
 
 		const data = item._data;
 
+		data.quantity = snapshot.open;
 		data.previousPrice = position.previous || null;
 
 		let basis;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.2.106",
+  "version": "1.2.110",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -1528,7 +1528,7 @@ module.exports = (() => {
 			}, { });
 
 			this._items = positions.reduce((items, position) => {
-				const item = createPositionItem.call(this, position);
+				const item = createPositionItem.call(this, position, reportFrame ? true : false);
 
 				if (item) {
 					items.push(item);
@@ -1737,7 +1737,7 @@ module.exports = (() => {
 				addSummaryPrevious(this._summariesPrevious, summary, this._previousSummaryFrame, this._previousSummaryRanges);
 			});
 
-			const item = createPositionItem.call(this, position);
+			const item = createPositionItem.call(this, position, false);
 
 			addBarchartSymbol(this._symbols, item);
 			addDisplaySymbol(this._symbolsDisplay, item);
@@ -2383,7 +2383,7 @@ module.exports = (() => {
 		}
 	}
 
-	function createPositionItem(position, currentQuote, previousQuote) {
+	function createPositionItem(position, requireCurrentSummary) {
 		const portfolio = this._portfolios[position.portfolio];
 
 		let returnRef;
@@ -2392,7 +2392,11 @@ module.exports = (() => {
 			const currentSummary = this._summariesCurrent[ position.position ] || null;
 			const previousSummaries = this._summariesPrevious[ position.position ] || getSummaryArray(this._previousSummaryRanges);
 
-			returnRef = new PositionItem(portfolio, position, currentSummary, previousSummaries, this._reporting);
+			if (!requireCurrentSummary || currentSummary !== null) {
+				returnRef = new PositionItem(portfolio, position, currentSummary, previousSummaries, this._reporting);
+			} else {
+				returnRef = null;
+			}
 		} else {
 			returnRef = null;
 		}
@@ -3190,7 +3194,7 @@ module.exports = (() => {
 		if (group.single && group._items.length === 1) {
 			const item = group._items[0];
 
-			actual.quantity = item.position.snapshot.open;
+			actual.quantity = item.data.quantity;
 			actual.quantityPrevious = item.data.quantityPrevious;
 			
 			actual.basisPrice = item.data.basisPrice;
@@ -3468,8 +3472,8 @@ module.exports = (() => {
 			this._data.marketPrevious = null;
 			this._data.marketPrevious2 = null;
 
+			this._data.quantity = null;
 			this._data.quantityPrevious = null;
-			this._data.quantityPrevious2 = null;
 			
 			this._data.realized = null;
 			this._data.income = null;
@@ -3782,6 +3786,7 @@ module.exports = (() => {
 
 		const data = item._data;
 
+		data.quantity = snapshot.open;
 		data.previousPrice = position.previous || null;
 
 		let basis;
@@ -6295,12 +6300,11 @@ module.exports = function () {
 			}
 
 			/**
-    * Converts a string (which matches the output of {@link Day#format} into
-    * a {@link Day} instance.
+    * Clones a {@link Day} instance.
     *
     * @public
     * @static
-    * @param {String} value
+    * @param {Day} value
     * @returns {Day}
     */
 
@@ -6341,6 +6345,24 @@ module.exports = function () {
 				return this._day;
 			}
 		}], [{
+			key: 'clone',
+			value: function clone(value) {
+				assert.argumentIsRequired(value, 'value', Day, 'Day');
+
+				return new Day(value.year, value.month, value.day);
+			}
+
+			/**
+    * Converts a string (which matches the output of {@link Day#format} into
+    * a {@link Day} instance.
+    *
+    * @public
+    * @static
+    * @param {String} value
+    * @returns {Day}
+    */
+
+		}, {
 			key: 'parse',
 			value: function parse(value) {
 				assert.argumentIsRequired(value, 'value', String);
@@ -6657,15 +6679,17 @@ module.exports = function () {
     *
     * @public
     * @param {Boolean=} approximate
+    * @param {Number=} places
     * @returns {Boolean}
     */
 
 		}, {
 			key: 'getIsZero',
-			value: function getIsZero(approximate) {
+			value: function getIsZero(approximate, places) {
 				assert.argumentIsOptional(approximate, 'approximate', Boolean);
+				assert.argumentIsOptional(places, 'places', Number);
 
-				return this._big.eq(zero) || is.boolean(approximate) && approximate && this.round(20, RoundingMode.NORMAL).getIsZero();
+				return this._big.eq(zero) || is.boolean(approximate) && approximate && this.round(places || Big.DP, RoundingMode.NORMAL).getIsZero();
 			}
 
 			/**
@@ -6764,6 +6788,43 @@ module.exports = function () {
 				return this._big.eq(getBig(other));
 			}
 
+			/**
+    * Returns true if the current instance is an integer (i.e. has no decimal
+    * component).
+    *
+    * @public
+    * @return {Boolean}
+    */
+
+		}, {
+			key: 'getIsInteger',
+			value: function getIsInteger() {
+				return this.getIsEqual(this.round(0));
+			}
+
+			/**
+    * Returns the number of decimal places used.
+    *
+    * @public
+    * @returns {Number}
+    */
+
+		}, {
+			key: 'getDecimalPlaces',
+			value: function getDecimalPlaces() {
+				var matches = this.toFixed().match(/-?\d*\.(\d*)/);
+
+				var returnVal = void 0;
+
+				if (matches === null) {
+					returnVal = 0;
+				} else {
+					returnVal = matches[1].length;
+				}
+
+				return returnVal;
+			}
+
 			/**
     * Emits a floating point value that approximates the value of the current
     * instance.
@@ -6812,10 +6873,11 @@ module.exports = function () {
 			}
 
 			/**
-    * Parses the value emitted by {@link Decimal#toJSON}.
+    * Clones a {@link Decimal} instance.
     *
     * @public
-    * @param {String} value
+    * @static
+    * @param {Decimal} value
     * @returns {Decimal}
     */
 
@@ -6825,6 +6887,22 @@ module.exports = function () {
 				return '[Decimal]';
 			}
 		}], [{
+			key: 'clone',
+			value: function clone(value) {
+				assert.argumentIsRequired(value, 'value', Decimal, 'Decimal');
+
+				return new Decimal(value._big);
+			}
+
+			/**
+    * Parses the value emitted by {@link Decimal#toJSON}.
+    *
+    * @public
+    * @param {String} value
+    * @returns {Decimal}
+    */
+
+		}, {
 			key: 'parse',
 			value: function parse(value) {
 				return new Decimal(value);
@@ -7846,10 +7924,11 @@ module.exports = function () {
 			}
 
 			/**
-    * Parses the value emitted by {@link Timestamp#toJSON}.
+    * Clones a {@link Timestamp} instance.
     *
     * @public
-    * @param {Number} value
+    * @static
+    * @param {Timestamp} value
     * @returns {Timestamp}
     */
 
@@ -7885,6 +7964,22 @@ module.exports = function () {
 				return this._moment;
 			}
 		}], [{
+			key: 'clone',
+			value: function clone(value) {
+				assert.argumentIsRequired(value, 'value', Timestamp, 'Timestamp');
+
+				return new Timestamp(value._timestamp, value._timezone);
+			}
+
+			/**
+    * Parses the value emitted by {@link Timestamp#toJSON}.
+    *
+    * @public
+    * @param {Number} value
+    * @returns {Timestamp}
+    */
+
+		}, {
 			key: 'parse',
 			value: function parse(value) {
 				return new Timestamp(value);