@barchart/portfolio-api-common 1.0.41 → 1.0.46

package/lib/data/InstrumentType.js

@@ -10,20 +10,20 @@ module.exports = (() => {
 	 * @public
 	 * @extends {Enum}
 	 * @param {String} description
-	 * @param {String} groupDescription
+	 * @param {String} alternateDescription
 	 * @param {String} code
 	 * @param {Boolean} canReinvest
 	 */
 	class InstrumentType extends Enum {
-		constructor(code, description, groupDescription, canReinvest) {
+		constructor(code, description, alternateDescription, canReinvest) {
 			super(code, description);
 
-			this._groupDescription = groupDescription;
+			this._alternateDescription = alternateDescription;
 			this._canReinvest = canReinvest;
 		}
 
-		get groupDescription() {
-			return this._groupDescription;
+		get alternateDescription() {
+			return this._alternateDescription;
 		}
 
 		/**

package/lib/processing/PositionItem.js

@@ -19,6 +19,8 @@ module.exports = (() => {
 			this._data.current = null;
 			this._data.previous = position.previous || null;
 
+			const snapshot = this._position.snapshot;
+
 			this._priceChangeEvent = new Event(this);
 		}
 

package/lib/serialization/PositionSchema.js

@@ -6,7 +6,8 @@ const assert = require('@barchart/common-js/lang/assert'),
 	Schema = require('@barchart/common-js/serialization/json/Schema'),
 	SchemaBuilder = require('@barchart/common-js/serialization/json/builders/SchemaBuilder');
 
-const ValuationType = require('./../data/ValuationType');
+const InstrumentType = require('./../data/InstrumentType'),
+	ValuationType = require('./../data/ValuationType');
 
 module.exports = (() => {
 	'use strict';
@@ -67,7 +68,7 @@ module.exports = (() => {
 		.withField('sequence', DataType.NUMBER)
 		.withField('instrument.id', DataType.STRING)
 		.withField('instrument.name', DataType.STRING)
-		.withField('instrument.type', DataType.STRING)
+		.withField('instrument.type', DataType.forEnum(InstrumentType, 'InstrumentType'))
 		.withField('instrument.currency', DataType.forEnum(Currency, 'Currency'))
 		.withField('instrument.delist', DataType.DAY, true)
 		.withField('instrument.symbol.barchart', DataType.STRING, true)
@@ -99,7 +100,7 @@ module.exports = (() => {
 		.withField('sequence', DataType.NUMBER)
 		.withField('instrument.id', DataType.STRING)
 		.withField('instrument.name', DataType.STRING)
-		.withField('instrument.type', DataType.STRING)
+		.withField('instrument.type', DataType.forEnum(InstrumentType, 'InstrumentType'))
 		.withField('instrument.currency', DataType.forEnum(Currency, 'Currency'))
 		.withField('instrument.delist', DataType.DAY, true)
 		.withField('instrument.symbol.barchart', DataType.STRING, true)
@@ -117,6 +118,7 @@ module.exports = (() => {
 		.withField('snapshot.basis', DataType.DECIMAL)
 		.withField('snapshot.income', DataType.DECIMAL)
 		.withField('snapshot.value', DataType.DECIMAL)
+		.withField('previous', DataType.NUMBER, true)
 		.schema
 	);
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.41",
+  "version": "1.0.46",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -815,6 +815,8 @@ module.exports = (() => {
 			this._data.current = null;
 			this._data.previous = position.previous || null;
 
+			const snapshot = this._position.snapshot;
+
 			this._priceChangeEvent = new Event(this);
 		}