@barchart/portfolio-api-common 1.0.269 → 1.0.270

package/lib/api/failures/PortfolioFailureType.js

@@ -23,6 +23,17 @@ module.exports = (() => {
 			return portfolioUpdateFailedNoPortfolio;
 		}
 
+		/**
+		 * The portfolio does not exist.
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get PORTFOLIO_DELETE_FAILED_NO_PORTFOLIO() {
+			return portfolioDeleteFailedNoPortfolio;
+		}
+
 		/**
 		 * The portfolio does not exist.
 		 *
@@ -136,7 +147,8 @@ module.exports = (() => {
 		}
 	}
 
-	const portfolioUpdateFailedNoPortfolio = new FailureType('PORTFOLIO_UPDATED_FAILED_NO_PORTFOLIO', 'Unable to update portfolio. The portfolio does not exist, has it been deleted?');
+	const portfolioUpdateFailedNoPortfolio = new FailureType('PORTFOLIO_UPDATE_FAILED_NO_PORTFOLIO', 'Unable to update portfolio. The portfolio does not exist, has it been deleted?');
+	const portfolioDeleteFailedNoPortfolio = new FailureType('PORTFOLIO_DELETE_FAILED_NO_PORTFOLIO', 'Unable to delete portfolio. The portfolio does not exist, has it already been deleted?');
 
 	const positionCreateFailedNoPortfolio = new FailureType('POSITION_CREATE_FAILED_NO_PORTFOLIO', 'Unable to create transaction. The portfolio does not exist, has it been deleted?');
 	const positionUpdateFailedNoPosition = new FailureType('POSITION_UPDATE_FAILED_NO_POSITION', 'Unable to update preferences for position. The position does not exist, has it been deleted?');

package/lib/data/TransactionValidator.js

@@ -25,22 +25,12 @@ module.exports = (() => {
 		 * @public
 		 * @static
 		 * @param {Array.<Object>} transactions
-		 * @param {Boolean=} partial - If true, sequence validation starts with the array's first transaction.
 		 * @return {boolean}
 		 */
-		static validateOrder(transactions, partial) {
+		static validateOrder(transactions) {
 			assert.argumentIsArray(transactions, 'transactions');
-			assert.argumentIsOptional(partial, 'partial', Boolean);
 
-			let startSequence;
-
-			if (partial && transactions.length !== 0) {
-				startSequence = array.first(transactions).sequence;
-			} else {
-				startSequence = 1;
-			}
-
-			return transactions.every((t, i) => t.sequence === (i + startSequence) && (i === 0 || !t.date.getIsBefore(transactions[i - 1].date)));
+			return transactions.every((t, i) => t.sequence === (i + 1) && (i === 0 || !t.date.getIsBefore(transactions[i - 1].date)));
 		}
 
 		/**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.269",
+  "version": "1.0.270",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -983,22 +983,12 @@ module.exports = (() => {
 		 * @public
 		 * @static
 		 * @param {Array.<Object>} transactions
-		 * @param {Boolean=} partial - If true, sequence validation starts with the array's first transaction.
 		 * @return {boolean}
 		 */
-		static validateOrder(transactions, partial) {
+		static validateOrder(transactions) {
 			assert.argumentIsArray(transactions, 'transactions');
-			assert.argumentIsOptional(partial, 'partial', Boolean);
 
-			let startSequence;
-
-			if (partial && transactions.length !== 0) {
-				startSequence = array.first(transactions).sequence;
-			} else {
-				startSequence = 1;
-			}
-
-			return transactions.every((t, i) => t.sequence === (i + startSequence) && (i === 0 || !t.date.getIsBefore(transactions[i - 1].date)));
+			return transactions.every((t, i) => t.sequence === (i + 1) && (i === 0 || !t.date.getIsBefore(transactions[i - 1].date)));
 		}
 
 		/**
@@ -9103,14 +9093,6 @@ describe('When validating transaction order', () => {
 	it('An array of transactions with ordered sequences, on the reversed days should not be valid', () => {
 		expect(TransactionValidator.validateOrder([ build(1, '2018-05-02'), build(2, '2018-05-01'), build(3, '2018-04-30') ])).toEqual(false);
 	});
-
-	it('A partial array of transactions with ordered sequences (starting after one), on the same day should be valid', () => {
-		expect(TransactionValidator.validateOrder([ build(3, '2018-04-30'), build(4, '2018-04-30'), build(5, '2018-04-30') ], true)).toEqual(true);
-	});
-
-	it('A partial array of transactions with gap in sequences (starting after one), on the same day should be not valid', () => {
-		expect(TransactionValidator.validateOrder([ build(3, '2018-04-30'), build(5, '2018-04-30'), build(6, '2018-04-30') ], true)).toEqual(false);
-	});
 });
 
 },{"./../../../lib/data/TransactionValidator":5,"@barchart/common-js/lang/Day":18}],37:[function(require,module,exports){

package/test/specs/data/TransactionValidatorSpec.js

@@ -40,12 +40,4 @@ describe('When validating transaction order', () => {
 	it('An array of transactions with ordered sequences, on the reversed days should not be valid', () => {
 		expect(TransactionValidator.validateOrder([ build(1, '2018-05-02'), build(2, '2018-05-01'), build(3, '2018-04-30') ])).toEqual(false);
 	});
-
-	it('A partial array of transactions with ordered sequences (starting after one), on the same day should be valid', () => {
-		expect(TransactionValidator.validateOrder([ build(3, '2018-04-30'), build(4, '2018-04-30'), build(5, '2018-04-30') ], true)).toEqual(true);
-	});
-
-	it('A partial array of transactions with gap in sequences (starting after one), on the same day should be not valid', () => {
-		expect(TransactionValidator.validateOrder([ build(3, '2018-04-30'), build(5, '2018-04-30'), build(6, '2018-04-30') ], true)).toEqual(false);
-	});
 });