@barchart/portfolio-api-common 1.0.267 → 1.0.271

package/lib/api/failures/PortfolioFailureType.js

@@ -23,6 +23,17 @@ module.exports = (() => {
 			return portfolioUpdateFailedNoPortfolio;
 		}
 
+		/**
+		 * The portfolio does not exist.
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get PORTFOLIO_DELETE_FAILED_NO_PORTFOLIO() {
+			return portfolioDeleteFailedNoPortfolio;
+		}
+
 		/**
 		 * The portfolio does not exist.
 		 *
@@ -136,7 +147,8 @@ module.exports = (() => {
 		}
 	}
 
-	const portfolioUpdateFailedNoPortfolio = new FailureType('PORTFOLIO_UPDATED_FAILED_NO_PORTFOLIO', 'Unable to update portfolio. The portfolio does not exist, has it been deleted?');
+	const portfolioUpdateFailedNoPortfolio = new FailureType('PORTFOLIO_UPDATE_FAILED_NO_PORTFOLIO', 'Unable to update portfolio. The portfolio does not exist, has it been deleted?');
+	const portfolioDeleteFailedNoPortfolio = new FailureType('PORTFOLIO_DELETE_FAILED_NO_PORTFOLIO', 'Unable to delete portfolio. The portfolio does not exist, has it already been deleted?');
 
 	const positionCreateFailedNoPortfolio = new FailureType('POSITION_CREATE_FAILED_NO_PORTFOLIO', 'Unable to create transaction. The portfolio does not exist, has it been deleted?');
 	const positionUpdateFailedNoPosition = new FailureType('POSITION_UPDATE_FAILED_NO_POSITION', 'Unable to update preferences for position. The position does not exist, has it been deleted?');

package/lib/data/TransactionValidator.js

@@ -1,5 +1,5 @@
 const assert = require('@barchart/common-js/lang/assert'),
-	array = require('@barchart/common-js/lang/array')
+	array = require('@barchart/common-js/lang/array');
 
 const InstrumentType = require('./InstrumentType'),
 	PositionDirection = require('./PositionDirection'),
@@ -25,22 +25,12 @@ module.exports = (() => {
 		 * @public
 		 * @static
 		 * @param {Array.<Object>} transactions
-		 * @param {Boolean=} partial - If true, sequence validation starts with the array's first transaction.
 		 * @return {boolean}
 		 */
-		static validateOrder(transactions, partial) {
+		static validateOrder(transactions) {
 			assert.argumentIsArray(transactions, 'transactions');
-			assert.argumentIsOptional(partial, 'partial', Boolean);
 
-			let startSequence;
-
-			if (partial && transactions.length !== 0) {
-				startSequence = array.first(transactions).sequence;
-			} else {
-				startSequence = 1;
-			}
-
-			return transactions.every((t, i) => t.sequence === (i + startSequence) && (i === 0 || !t.date.getIsBefore(transactions[i - 1].date)));
+			return transactions.every((t, i) => t.sequence === (i + 1) && (i === 0 || !t.date.getIsBefore(transactions[i - 1].date)));
 		}
 
 		/**

package/lib/processing/PositionContainer.js

@@ -224,11 +224,9 @@ module.exports = (() => {
 			assert.argumentIsRequired(portfolio, 'portfolio', Object);
 			assert.argumentIsRequired(portfolio.portfolio, 'portfolio.portfolio', String);
 
-			this.startTransaction(() => {
-				getPositionItemsForPortfolio(this._items, portfolio.portfolio).forEach(item => item.updatePortfolio(portfolio));
+			getPositionItemsForPortfolio(this._items, portfolio.portfolio).forEach(item => item.updatePortfolio(portfolio));
 
-				updateEmptyPortfolioGroups.call(this, portfolio);
-			});
+			updateEmptyPortfolioGroups.call(this, portfolio);
 		}
 
 		/**
@@ -243,19 +241,19 @@ module.exports = (() => {
 			assert.argumentIsRequired(portfolio, 'portfolio', Object);
 			assert.argumentIsRequired(portfolio.portfolio, 'portfolio.portfolio', String);
 
-			this.startTransaction(() => {
-				getPositionItemsForPortfolio(this._items, portfolio.portfolio).forEach(item => removePositionItem.call(this, item));
+			getPositionItemsForPortfolio(this._items, portfolio.portfolio).forEach(item => removePositionItem.call(this, item));
 
-				delete this._portfolios[portfolio.portfolio];
+			delete this._portfolios[portfolio.portfolio];
 
-				Object.keys(this._trees).forEach((key) => {
-					this._trees[key].walk((group, groupNode) => {
-						if (group.definition.type === PositionLevelType.PORTFOLIO && group.key === PositionLevelDefinition.getKeyForPortfolioGroup(portfolio)) {
-							severGroupNode.call(this, groupNode);
-						}
-					}, true, false);
-				});
+			Object.keys(this._trees).forEach((key) => {
+				this._trees[key].walk((group, groupNode) => {
+					if (group.definition.type === PositionLevelType.PORTFOLIO && group.key === PositionLevelDefinition.getKeyForPortfolioGroup(portfolio)) {
+						severGroupNode.call(this, groupNode);
+					}
+				}, true, false);
 			});
+
+			recalculatePercentages.call(this);
 		}
 
 		/**
@@ -276,56 +274,54 @@ module.exports = (() => {
 				return;
 			}
 
-			this.startTransaction(() => {
-				const existingBarchartSymbols = this.getPositionSymbols(false);
+			const existingBarchartSymbols = this.getPositionSymbols(false);
 
-				removePositionItem.call(this, this._items.find((item) => item.position.position === position.position));
+			removePositionItem.call(this, this._items.find((item) => item.position.position === position.position));
 
-				summaries.forEach((summary) => {
-					addSummaryCurrent(this._summariesCurrent, summary, this._currentSummaryFrame, this._currentSummaryRange);
-					addSummaryPrevious(this._summariesPrevious, summary, this._previousSummaryFrame, this._previousSummaryRanges);
-				});
+			summaries.forEach((summary) => {
+				addSummaryCurrent(this._summariesCurrent, summary, this._currentSummaryFrame, this._currentSummaryRange);
+				addSummaryPrevious(this._summariesPrevious, summary, this._previousSummaryFrame, this._previousSummaryRanges);
+			});
 
-				const item = createPositionItem.call(this, position);
+			const item = createPositionItem.call(this, position);
 
-				addBarchartSymbol(this._symbols, item);
-				addDisplaySymbol(this._symbolsDisplay, item);
+			addBarchartSymbol(this._symbols, item);
+			addDisplaySymbol(this._symbolsDisplay, item);
 
-				this._items.push(item);
+			this._items.push(item);
 
-				const createGroupOrInjectItem = (parentTree, treeDefinition, levelDefinitions) => {
-					if (levelDefinitions.length === 0) {
-						return;
-					}
+			const createGroupOrInjectItem = (parentTree, treeDefinition, levelDefinitions) => {
+				if (levelDefinitions.length === 0) {
+					return;
+				}
 
-					const levelDefinition = levelDefinitions[0];
-					const levelKey = levelDefinition.keySelector(item);
+				const levelDefinition = levelDefinitions[0];
+				const levelKey = levelDefinition.keySelector(item);
 
-					let groupTree;
+				let groupTree;
 
-					if (parentTree.getChildren().length > 0) {
-						groupTree = parentTree.findChild(childGroup => childGroup.key === levelKey) || null;
-					} else {
-						groupTree = null;
-					}
+				if (parentTree.getChildren().length > 0) {
+					groupTree = parentTree.findChild(childGroup => childGroup.key === levelKey) || null;
+				} else {
+					groupTree = null;
+				}
 
-					if (groupTree !== null) {
-						groupTree.getValue().addItem(item);
+				if (groupTree !== null) {
+					groupTree.getValue().addItem(item);
 
-						createGroupOrInjectItem(groupTree, treeDefinition, array.dropLeft(levelDefinitions));
-					} else {
-						createGroups.call(this, parentTree, [ item ], treeDefinition, levelDefinitions, [ ]);
-					}
-				};
+					createGroupOrInjectItem(groupTree, treeDefinition, array.dropLeft(levelDefinitions));
+				} else {
+					createGroups.call(this, parentTree, [ item ], treeDefinition, levelDefinitions, [ ]);
+				}
+			};
 
-				this._definitions.forEach(definition => createGroupOrInjectItem(this._trees[definition.name], definition, definition.definitions));
+			this._definitions.forEach(definition => createGroupOrInjectItem(this._trees[definition.name], definition, definition.definitions));
 
-				const addedBarchartSymbol = extractSymbolForBarchart(item.position);
+			const addedBarchartSymbol = extractSymbolForBarchart(item.position);
 
-				if (addedBarchartSymbol !== null && !existingBarchartSymbols.some(existingBarchartSymbol => existingBarchartSymbol === addedBarchartSymbol)) {
-					this._positionSymbolAddedEvent.fire(addedBarchartSymbol);
-				}
-			});
+			if (addedBarchartSymbol !== null && !existingBarchartSymbols.some(existingBarchartSymbol => existingBarchartSymbol === addedBarchartSymbol)) {
+				this._positionSymbolAddedEvent.fire(addedBarchartSymbol);
+			}
 
 			recalculatePercentages.call(this);
 		}
@@ -376,22 +372,55 @@ module.exports = (() => {
 		}
 
 		/**
-		 * Updates the quote for a single symbol; causing updates to any grouping
-		 * level that contains the position(s) for the symbol.
+		 * Performs a batch update of both position quotes and forex quotes,
+		 * triggering updates to position(s) and data aggregation(s).
 		 *
 		 * @public
-		 * @param {String} symbol
-		 * @param {Object} quote
+		 * @param {Array.<Object>} positionQuotes
+		 * @param {Array.<Object>} forexQuotes
 		 */
-		setPositionQuote(symbol, quote) {
-			assert.argumentIsRequired(symbol, 'symbol', String);
-			assert.argumentIsRequired(quote, 'quote', Object);
+		setQuotes(positionQuotes, forexQuotes) {
+			assert.argumentIsArray(positionQuotes, 'positionQuotes');
+			assert.argumentIsArray(forexQuotes, 'forexQuotes');
+
+			if (positionQuotes.length !== 0) {
+				positionQuotes.forEach((quote) => {
+					const symbol = quote.symbol;
 
-			if (this._symbols.hasOwnProperty(symbol)) {
-				this._symbols[symbol].forEach(item => item.setQuote(quote));
+					if (symbol) {
+						if (this._symbols.hasOwnProperty(symbol)) {
+							this._symbols[ symbol ].forEach(item => item.setQuote(quote));
+						}
+					}
+				});
 			}
 
-			recalculatePercentages.call(this);
+			if (forexQuotes.length !== 0) {
+				forexQuotes.forEach((quote) => {
+					const symbol = quote.symbol;
+
+					if (symbol) {
+						const rate = Rate.fromPair(quote.lastPrice, symbol);
+						const index = this._forexQuotes.findIndex(existing => existing.formatPair() === rate.formatPair());
+
+						if (index < 0) {
+							this._forexQuotes.push(rate);
+						} else {
+							this._forexQuotes[index] = rate;
+						}
+
+						Object.keys(this._trees).forEach((key) => {
+							this._trees[key].walk(group => group.setForexRates(this._forexQuotes), true, false);
+						});
+
+						recalculatePercentages.call(this);
+					}
+				});
+			}
+
+			if (positionQuotes.length !== 0 || forexQuotes.length !== 0) {
+				recalculatePercentages.call(this);
+			}
 		}
 
 		/**
@@ -414,32 +443,6 @@ module.exports = (() => {
 			return this._forexQuotes;
 		}
 
-		/**
-		 * Updates the forex quote for a single currency pair; causing updates to
-		 * any grouping level that contains that requires translation.
-		 *
-		 * @public
-		 * @param {String} symbol
-		 * @param {Object} quote
-		 */
-		setForexQuote(symbol, quote) {
-			assert.argumentIsRequired(symbol, 'symbol', String);
-			assert.argumentIsRequired(quote, 'quote', Object);
-
-			const rate = Rate.fromPair(quote.lastPrice, symbol);
-			const index = this._forexQuotes.findIndex(existing => existing.formatPair() === rate.formatPair());
-
-			if (index < 0) {
-				this._forexQuotes.push(rate);
-			} else {
-				this._forexQuotes[index] = rate;
-			}
-
-			Object.keys(this._trees).forEach(key => this._trees[key].walk(group => group.setForexRates(this._forexQuotes), true, false));
-
-			recalculatePercentages.call(this);
-		}
-
 		/**
 		 * Updates fundamental data for a single symbol.
 		 *
@@ -588,39 +591,6 @@ module.exports = (() => {
 			return this.getPositions(portfolio).find(p => p.position === position) || null;
 		}
 
-		/**
-		 * Pauses aggregation calculations during the processing of an action.
-		 *
-		 * @public
-		 * @param {Function} executor
-		 * @param {String=|Array.<String>=} names
-		 */
-		startTransaction(executor, names) {
-			let namesToUse;
-
-			if (is.array(names)) {
-				assert.argumentIsArray(names, 'names', String);
-
-				namesToUse = names;
-			} else {
-				assert.argumentIsOptional(names, 'names', String);
-
-				if (names) {
-					namesToUse = [ names ];
-				} else {
-					namesToUse = Object.keys(this._trees);
-				}
-			}
-
-			assert.argumentIsRequired(executor, 'executor', Function);
-
-			namesToUse.forEach((name) => this._trees[name].walk(group => group.setSuspended(true), false, false));
-
-			executor(this);
-
-			namesToUse.forEach((name) => this._trees[name].walk(group => group.setSuspended(false), false, false));
-		}
-
 		/**
 		 * Registers an observer for symbol addition (this occurs when a new position is added
 		 * for a symbol that does not already exist in the container). This event only fires

package/lib/processing/PositionGroup.js

@@ -54,7 +54,6 @@ module.exports = (() => {
 			this._aggregateCash = is.boolean(aggregateCash) && aggregateCash;
 
 			this._excluded = false;
-			this._suspended = false;
 			this._showClosedPositions = false;
 
 			this._groupExcludedChangeEvent = new Event(this);
@@ -255,10 +254,6 @@ module.exports = (() => {
 			return this._single;
 		}
 
-		get suspended() {
-			return this._suspended;
-		}
-
 		/**
 		 * Indicates if the group should be excluded from higher-level aggregations.
 		 *
@@ -381,24 +376,6 @@ module.exports = (() => {
 			}
 		}
 
-		/**
-		 * Stops (or starts) group-level aggregation calculations.
-		 *
-		 * @public
-		 * @param {Boolean} value
-		 */
-		setSuspended(value) {
-			assert.argumentIsRequired(value, 'value', Boolean);
-
-			if (this._suspended !== value) {
-				this._suspended = value;
-
-				if (!this._suspended) {
-					this.refresh();
-				}
-			}
-		}
-
 		/**
 		 * Updates the portfolio data. For example, a portfolio's name might change. This
 		 * function only affects {@link PositionLevelType.PORTFOLIO} groups.
@@ -430,16 +407,11 @@ module.exports = (() => {
 		}
 
 		/**
-		 * Causes all aggregated data to be recalculated (assuming the group has not
-		 * been suspended).
+		 * Causes all aggregated data to be recalculated.
 		 *
 		 * @public
 		 */
 		refresh() {
-			if (this._suspended) {
-				return;
-			}
-
 			calculateStaticData(this, this._rates);
 			calculatePriceData(this, this._rates, null, true);
 		}
@@ -643,10 +615,6 @@ module.exports = (() => {
 	}
 
 	function calculateStaticData(group, rates) {
-		if (group.suspended) {
-			return;
-		}
-
 		const actual = group._dataActual;
 		const format = group._dataFormat;
 
@@ -743,10 +711,6 @@ module.exports = (() => {
 	}
 
 	function calculatePriceData(group, rates, item, forceRefresh) {
-		if (group.suspended) {
-			return;
-		}
-
 		const currency = group.currency;
 
 		const actual = group._dataActual;
@@ -832,10 +796,6 @@ module.exports = (() => {
 	}
 
 	function calculateMarketPercent(group, rates, parentGroup, portfolioGroup) {
-		if (group.suspended) {
-			return;
-		}
-
 		const actual = group._dataActual;
 		const format = group._dataFormat;
 		const excluded = group._excluded;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.267",
+  "version": "1.0.271",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -957,7 +957,7 @@ module.exports = (() => {
 
 },{"@barchart/common-js/lang/Enum":21,"@barchart/common-js/lang/assert":24}],5:[function(require,module,exports){
 const assert = require('@barchart/common-js/lang/assert'),
-	array = require('@barchart/common-js/lang/array')
+	array = require('@barchart/common-js/lang/array');
 
 const InstrumentType = require('./InstrumentType'),
 	PositionDirection = require('./PositionDirection'),
@@ -983,22 +983,12 @@ module.exports = (() => {
 		 * @public
 		 * @static
 		 * @param {Array.<Object>} transactions
-		 * @param {Boolean=} partial - If true, sequence validation starts with the array's first transaction.
 		 * @return {boolean}
 		 */
-		static validateOrder(transactions, partial) {
+		static validateOrder(transactions) {
 			assert.argumentIsArray(transactions, 'transactions');
-			assert.argumentIsOptional(partial, 'partial', Boolean);
 
-			let startSequence;
-
-			if (partial && transactions.length !== 0) {
-				startSequence = array.first(transactions).sequence;
-			} else {
-				startSequence = 1;
-			}
-
-			return transactions.every((t, i) => t.sequence === (i + startSequence) && (i === 0 || !t.date.getIsBefore(transactions[i - 1].date)));
+			return transactions.every((t, i) => t.sequence === (i + 1) && (i === 0 || !t.date.getIsBefore(transactions[i - 1].date)));
 		}
 
 		/**
@@ -1380,11 +1370,9 @@ module.exports = (() => {
 			assert.argumentIsRequired(portfolio, 'portfolio', Object);
 			assert.argumentIsRequired(portfolio.portfolio, 'portfolio.portfolio', String);
 
-			this.startTransaction(() => {
-				getPositionItemsForPortfolio(this._items, portfolio.portfolio).forEach(item => item.updatePortfolio(portfolio));
+			getPositionItemsForPortfolio(this._items, portfolio.portfolio).forEach(item => item.updatePortfolio(portfolio));
 
-				updateEmptyPortfolioGroups.call(this, portfolio);
-			});
+			updateEmptyPortfolioGroups.call(this, portfolio);
 		}
 
 		/**
@@ -1399,19 +1387,19 @@ module.exports = (() => {
 			assert.argumentIsRequired(portfolio, 'portfolio', Object);
 			assert.argumentIsRequired(portfolio.portfolio, 'portfolio.portfolio', String);
 
-			this.startTransaction(() => {
-				getPositionItemsForPortfolio(this._items, portfolio.portfolio).forEach(item => removePositionItem.call(this, item));
+			getPositionItemsForPortfolio(this._items, portfolio.portfolio).forEach(item => removePositionItem.call(this, item));
 
-				delete this._portfolios[portfolio.portfolio];
+			delete this._portfolios[portfolio.portfolio];
 
-				Object.keys(this._trees).forEach((key) => {
-					this._trees[key].walk((group, groupNode) => {
-						if (group.definition.type === PositionLevelType.PORTFOLIO && group.key === PositionLevelDefinition.getKeyForPortfolioGroup(portfolio)) {
-							severGroupNode.call(this, groupNode);
-						}
-					}, true, false);
-				});
+			Object.keys(this._trees).forEach((key) => {
+				this._trees[key].walk((group, groupNode) => {
+					if (group.definition.type === PositionLevelType.PORTFOLIO && group.key === PositionLevelDefinition.getKeyForPortfolioGroup(portfolio)) {
+						severGroupNode.call(this, groupNode);
+					}
+				}, true, false);
 			});
+
+			recalculatePercentages.call(this);
 		}
 
 		/**
@@ -1432,56 +1420,54 @@ module.exports = (() => {
 				return;
 			}
 
-			this.startTransaction(() => {
-				const existingBarchartSymbols = this.getPositionSymbols(false);
+			const existingBarchartSymbols = this.getPositionSymbols(false);
 
-				removePositionItem.call(this, this._items.find((item) => item.position.position === position.position));
+			removePositionItem.call(this, this._items.find((item) => item.position.position === position.position));
 
-				summaries.forEach((summary) => {
-					addSummaryCurrent(this._summariesCurrent, summary, this._currentSummaryFrame, this._currentSummaryRange);
-					addSummaryPrevious(this._summariesPrevious, summary, this._previousSummaryFrame, this._previousSummaryRanges);
-				});
+			summaries.forEach((summary) => {
+				addSummaryCurrent(this._summariesCurrent, summary, this._currentSummaryFrame, this._currentSummaryRange);
+				addSummaryPrevious(this._summariesPrevious, summary, this._previousSummaryFrame, this._previousSummaryRanges);
+			});
 
-				const item = createPositionItem.call(this, position);
+			const item = createPositionItem.call(this, position);
 
-				addBarchartSymbol(this._symbols, item);
-				addDisplaySymbol(this._symbolsDisplay, item);
+			addBarchartSymbol(this._symbols, item);
+			addDisplaySymbol(this._symbolsDisplay, item);
 
-				this._items.push(item);
+			this._items.push(item);
 
-				const createGroupOrInjectItem = (parentTree, treeDefinition, levelDefinitions) => {
-					if (levelDefinitions.length === 0) {
-						return;
-					}
+			const createGroupOrInjectItem = (parentTree, treeDefinition, levelDefinitions) => {
+				if (levelDefinitions.length === 0) {
+					return;
+				}
 
-					const levelDefinition = levelDefinitions[0];
-					const levelKey = levelDefinition.keySelector(item);
+				const levelDefinition = levelDefinitions[0];
+				const levelKey = levelDefinition.keySelector(item);
 
-					let groupTree;
+				let groupTree;
 
-					if (parentTree.getChildren().length > 0) {
-						groupTree = parentTree.findChild(childGroup => childGroup.key === levelKey) || null;
-					} else {
-						groupTree = null;
-					}
+				if (parentTree.getChildren().length > 0) {
+					groupTree = parentTree.findChild(childGroup => childGroup.key === levelKey) || null;
+				} else {
+					groupTree = null;
+				}
 
-					if (groupTree !== null) {
-						groupTree.getValue().addItem(item);
+				if (groupTree !== null) {
+					groupTree.getValue().addItem(item);
 
-						createGroupOrInjectItem(groupTree, treeDefinition, array.dropLeft(levelDefinitions));
-					} else {
-						createGroups.call(this, parentTree, [ item ], treeDefinition, levelDefinitions, [ ]);
-					}
-				};
+					createGroupOrInjectItem(groupTree, treeDefinition, array.dropLeft(levelDefinitions));
+				} else {
+					createGroups.call(this, parentTree, [ item ], treeDefinition, levelDefinitions, [ ]);
+				}
+			};
 
-				this._definitions.forEach(definition => createGroupOrInjectItem(this._trees[definition.name], definition, definition.definitions));
+			this._definitions.forEach(definition => createGroupOrInjectItem(this._trees[definition.name], definition, definition.definitions));
 
-				const addedBarchartSymbol = extractSymbolForBarchart(item.position);
+			const addedBarchartSymbol = extractSymbolForBarchart(item.position);
 
-				if (addedBarchartSymbol !== null && !existingBarchartSymbols.some(existingBarchartSymbol => existingBarchartSymbol === addedBarchartSymbol)) {
-					this._positionSymbolAddedEvent.fire(addedBarchartSymbol);
-				}
-			});
+			if (addedBarchartSymbol !== null && !existingBarchartSymbols.some(existingBarchartSymbol => existingBarchartSymbol === addedBarchartSymbol)) {
+				this._positionSymbolAddedEvent.fire(addedBarchartSymbol);
+			}
 
 			recalculatePercentages.call(this);
 		}
@@ -1532,22 +1518,55 @@ module.exports = (() => {
 		}
 
 		/**
-		 * Updates the quote for a single symbol; causing updates to any grouping
-		 * level that contains the position(s) for the symbol.
+		 * Performs a batch update of both position quotes and forex quotes,
+		 * triggering updates to position(s) and data aggregation(s).
 		 *
 		 * @public
-		 * @param {String} symbol
-		 * @param {Object} quote
+		 * @param {Array.<Object>} positionQuotes
+		 * @param {Array.<Object>} forexQuotes
 		 */
-		setPositionQuote(symbol, quote) {
-			assert.argumentIsRequired(symbol, 'symbol', String);
-			assert.argumentIsRequired(quote, 'quote', Object);
+		setQuotes(positionQuotes, forexQuotes) {
+			assert.argumentIsArray(positionQuotes, 'positionQuotes');
+			assert.argumentIsArray(forexQuotes, 'forexQuotes');
+
+			if (positionQuotes.length !== 0) {
+				positionQuotes.forEach((quote) => {
+					const symbol = quote.symbol;
 
-			if (this._symbols.hasOwnProperty(symbol)) {
-				this._symbols[symbol].forEach(item => item.setQuote(quote));
+					if (symbol) {
+						if (this._symbols.hasOwnProperty(symbol)) {
+							this._symbols[ symbol ].forEach(item => item.setQuote(quote));
+						}
+					}
+				});
 			}
 
-			recalculatePercentages.call(this);
+			if (forexQuotes.length !== 0) {
+				forexQuotes.forEach((quote) => {
+					const symbol = quote.symbol;
+
+					if (symbol) {
+						const rate = Rate.fromPair(quote.lastPrice, symbol);
+						const index = this._forexQuotes.findIndex(existing => existing.formatPair() === rate.formatPair());
+
+						if (index < 0) {
+							this._forexQuotes.push(rate);
+						} else {
+							this._forexQuotes[index] = rate;
+						}
+
+						Object.keys(this._trees).forEach((key) => {
+							this._trees[key].walk(group => group.setForexRates(this._forexQuotes), true, false);
+						});
+
+						recalculatePercentages.call(this);
+					}
+				});
+			}
+
+			if (positionQuotes.length !== 0 || forexQuotes.length !== 0) {
+				recalculatePercentages.call(this);
+			}
 		}
 
 		/**
@@ -1570,32 +1589,6 @@ module.exports = (() => {
 			return this._forexQuotes;
 		}
 
-		/**
-		 * Updates the forex quote for a single currency pair; causing updates to
-		 * any grouping level that contains that requires translation.
-		 *
-		 * @public
-		 * @param {String} symbol
-		 * @param {Object} quote
-		 */
-		setForexQuote(symbol, quote) {
-			assert.argumentIsRequired(symbol, 'symbol', String);
-			assert.argumentIsRequired(quote, 'quote', Object);
-
-			const rate = Rate.fromPair(quote.lastPrice, symbol);
-			const index = this._forexQuotes.findIndex(existing => existing.formatPair() === rate.formatPair());
-
-			if (index < 0) {
-				this._forexQuotes.push(rate);
-			} else {
-				this._forexQuotes[index] = rate;
-			}
-
-			Object.keys(this._trees).forEach(key => this._trees[key].walk(group => group.setForexRates(this._forexQuotes), true, false));
-
-			recalculatePercentages.call(this);
-		}
-
 		/**
 		 * Updates fundamental data for a single symbol.
 		 *
@@ -1744,39 +1737,6 @@ module.exports = (() => {
 			return this.getPositions(portfolio).find(p => p.position === position) || null;
 		}
 
-		/**
-		 * Pauses aggregation calculations during the processing of an action.
-		 *
-		 * @public
-		 * @param {Function} executor
-		 * @param {String=|Array.<String>=} names
-		 */
-		startTransaction(executor, names) {
-			let namesToUse;
-
-			if (is.array(names)) {
-				assert.argumentIsArray(names, 'names', String);
-
-				namesToUse = names;
-			} else {
-				assert.argumentIsOptional(names, 'names', String);
-
-				if (names) {
-					namesToUse = [ names ];
-				} else {
-					namesToUse = Object.keys(this._trees);
-				}
-			}
-
-			assert.argumentIsRequired(executor, 'executor', Function);
-
-			namesToUse.forEach((name) => this._trees[name].walk(group => group.setSuspended(true), false, false));
-
-			executor(this);
-
-			namesToUse.forEach((name) => this._trees[name].walk(group => group.setSuspended(false), false, false));
-		}
-
 		/**
 		 * Registers an observer for symbol addition (this occurs when a new position is added
 		 * for a symbol that does not already exist in the container). This event only fires
@@ -2183,7 +2143,6 @@ module.exports = (() => {
 			this._aggregateCash = is.boolean(aggregateCash) && aggregateCash;
 
 			this._excluded = false;
-			this._suspended = false;
 			this._showClosedPositions = false;
 
 			this._groupExcludedChangeEvent = new Event(this);
@@ -2384,10 +2343,6 @@ module.exports = (() => {
 			return this._single;
 		}
 
-		get suspended() {
-			return this._suspended;
-		}
-
 		/**
 		 * Indicates if the group should be excluded from higher-level aggregations.
 		 *
@@ -2510,24 +2465,6 @@ module.exports = (() => {
 			}
 		}
 
-		/**
-		 * Stops (or starts) group-level aggregation calculations.
-		 *
-		 * @public
-		 * @param {Boolean} value
-		 */
-		setSuspended(value) {
-			assert.argumentIsRequired(value, 'value', Boolean);
-
-			if (this._suspended !== value) {
-				this._suspended = value;
-
-				if (!this._suspended) {
-					this.refresh();
-				}
-			}
-		}
-
 		/**
 		 * Updates the portfolio data. For example, a portfolio's name might change. This
 		 * function only affects {@link PositionLevelType.PORTFOLIO} groups.
@@ -2559,16 +2496,11 @@ module.exports = (() => {
 		}
 
 		/**
-		 * Causes all aggregated data to be recalculated (assuming the group has not
-		 * been suspended).
+		 * Causes all aggregated data to be recalculated.
 		 *
 		 * @public
 		 */
 		refresh() {
-			if (this._suspended) {
-				return;
-			}
-
 			calculateStaticData(this, this._rates);
 			calculatePriceData(this, this._rates, null, true);
 		}
@@ -2772,10 +2704,6 @@ module.exports = (() => {
 	}
 
 	function calculateStaticData(group, rates) {
-		if (group.suspended) {
-			return;
-		}
-
 		const actual = group._dataActual;
 		const format = group._dataFormat;
 
@@ -2872,10 +2800,6 @@ module.exports = (() => {
 	}
 
 	function calculatePriceData(group, rates, item, forceRefresh) {
-		if (group.suspended) {
-			return;
-		}
-
 		const currency = group.currency;
 
 		const actual = group._dataActual;
@@ -2961,10 +2885,6 @@ module.exports = (() => {
 	}
 
 	function calculateMarketPercent(group, rates, parentGroup, portfolioGroup) {
-		if (group.suspended) {
-			return;
-		}
-
 		const actual = group._dataActual;
 		const format = group._dataFormat;
 		const excluded = group._excluded;
@@ -9173,14 +9093,6 @@ describe('When validating transaction order', () => {
 	it('An array of transactions with ordered sequences, on the reversed days should not be valid', () => {
 		expect(TransactionValidator.validateOrder([ build(1, '2018-05-02'), build(2, '2018-05-01'), build(3, '2018-04-30') ])).toEqual(false);
 	});
-
-	it('A partial array of transactions with ordered sequences (starting after one), on the same day should be valid', () => {
-		expect(TransactionValidator.validateOrder([ build(3, '2018-04-30'), build(4, '2018-04-30'), build(5, '2018-04-30') ], true)).toEqual(true);
-	});
-
-	it('A partial array of transactions with gap in sequences (starting after one), on the same day should be not valid', () => {
-		expect(TransactionValidator.validateOrder([ build(3, '2018-04-30'), build(5, '2018-04-30'), build(6, '2018-04-30') ], true)).toEqual(false);
-	});
 });
 
 },{"./../../../lib/data/TransactionValidator":5,"@barchart/common-js/lang/Day":18}],37:[function(require,module,exports){

package/test/specs/data/TransactionValidatorSpec.js

@@ -40,12 +40,4 @@ describe('When validating transaction order', () => {
 	it('An array of transactions with ordered sequences, on the reversed days should not be valid', () => {
 		expect(TransactionValidator.validateOrder([ build(1, '2018-05-02'), build(2, '2018-05-01'), build(3, '2018-04-30') ])).toEqual(false);
 	});
-
-	it('A partial array of transactions with ordered sequences (starting after one), on the same day should be valid', () => {
-		expect(TransactionValidator.validateOrder([ build(3, '2018-04-30'), build(4, '2018-04-30'), build(5, '2018-04-30') ], true)).toEqual(true);
-	});
-
-	it('A partial array of transactions with gap in sequences (starting after one), on the same day should be not valid', () => {
-		expect(TransactionValidator.validateOrder([ build(3, '2018-04-30'), build(5, '2018-04-30'), build(6, '2018-04-30') ], true)).toEqual(false);
-	});
 });