@barchart/portfolio-api-common 1.0.256 → 1.0.260

package/lib/processing/PositionGroup.js

@@ -495,18 +495,61 @@ module.exports = (() => {
 			calculatePriceData(this, this._container.getForexQuotes(), sender, false);
 		});
 
+		let fundamentalBinding = item.registerFundamentalDataChangeHandler((data, sender) => {
+			if (this._single) {
+				this._dataFormat.fundamental = data;
+			} else {
+				const fundamentalFields = [ 'percentChange1m', 'percentChange1y', 'percentChange3m', 'percentChangeYtd' ];
+
+				const fundamentalData = this.items.reduce((sums, item, i) => {
+					if (item.data && item.data.fundamental && item.data.fundamental.raw) {
+						const fundamental = item.data.fundamental.raw;
+
+						fundamentalFields.forEach((fieldName) => {
+							const summary = sums[fieldName];
+							const value = fundamental[fieldName];
+
+							if (is.number(value)) {
+								summary.total = sums[fieldName].total + value;
+								summary.count = sums[fieldName].count + 1;
+							}
+
+							if ((i + 1) == this.items.length) {
+								let averageFormat;
+
+								if (summary.count > 0) {
+									averageFormat = formatPercent(new Decimal(summary.total / summary.count), 2, true);
+								} else {
+									averageFormat = '--';
+								}
+
+								summary.averageFormat = averageFormat;
+							}
+						});
+					}
+
+					return sums;
+				}, fundamentalFields.reduce((sums, fieldName) => {
+					sums[fieldName] = { total: 0, count: 0, averageFormat: '--' };
+
+					return sums;
+				}, { }));
+
+				this._dataFormat.fundamental = fundamentalFields.reduce((sums, fieldName) => {
+					sums[fieldName] = fundamentalData[fieldName].averageFormat;
+
+					return sums;
+				}, { });
+			}
+		});
+
 		let newsBinding = Disposable.getEmpty();
-		let fundamentalBinding = Disposable.getEmpty();
 
 		if (this._single) {
 			newsBinding = item.registerNewsExistsChangeHandler((exists, sender) => {
 				this._dataActual.newsExists = exists;
 				this._dataFormat.newsExists = exists;
 			});
-
-			fundamentalBinding = item.registerFundamentalDataChangeHandler((data, sender) => {
-				this._dataFormat.fundamental = data;
-			});
 		}
 
 		this._disposeStack.push(item.registerPortfolioChangeHandler((portfolio, sender) => {
@@ -553,9 +596,17 @@ module.exports = (() => {
 		}
 	}
 
-	function formatPercent(decimal, precision) {
+	function formatPercent(decimal, precision, plus) {
 		if (decimal !== null) {
-			return formatDecimal(decimal.multiply(100), precision) + '%';
+			let prefix;
+
+			if (is.boolean(plus) && plus && !Decimal.getIsNegative(decimal)) {
+				prefix = '+';
+			} else {
+				prefix = '';
+			}
+
+			return `${prefix}${formatDecimal(decimal.multiply(100), precision)}%`;
 		} else {
 			return '—';
 		}
@@ -626,7 +677,7 @@ module.exports = (() => {
 		actual.cashTotal = updates.cashTotal;
 
 		format.basis = formatCurrency(actual.basis, currency);
-		format.realized = formatCurrency(actual.basis, currency);
+		format.realized = formatCurrency(actual.realized, currency);
 		format.unrealized = formatCurrency(actual.unrealized, currency);
 		format.income = formatCurrency(actual.income, currency);
 		format.summaryTotalCurrent = formatCurrency(updates.summaryTotalCurrent, currency);

package/lib/serialization/TransactionSchema.js

@@ -233,7 +233,6 @@ module.exports = (() => {
 		.withField('dividend.effective', DataType.DAY, true)
 		.withField('dividend.price', DataType.DECIMAL, true)
 		.withField('dividend.amount', DataType.DECIMAL, true)
-		.withField('dividend.reference', DataType.STRING, true)
 		.withField('split.numerator', DataType.DECIMAL, true)
 		.withField('split.denominator', DataType.DECIMAL, true)
 		.withField('split.effective', DataType.DAY, true)
@@ -283,6 +282,7 @@ module.exports = (() => {
 		.withField('quantity', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
 		.withField('force', DataType.BOOLEAN, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.256",
+  "version": "1.0.260",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -2252,18 +2252,61 @@ module.exports = (() => {
 			calculatePriceData(this, this._container.getForexQuotes(), sender, false);
 		});
 
+		let fundamentalBinding = item.registerFundamentalDataChangeHandler((data, sender) => {
+			if (this._single) {
+				this._dataFormat.fundamental = data;
+			} else {
+				const fundamentalFields = [ 'percentChange1m', 'percentChange1y', 'percentChange3m', 'percentChangeYtd' ];
+
+				const fundamentalData = this.items.reduce((sums, item, i) => {
+					if (item.data && item.data.fundamental && item.data.fundamental.raw) {
+						const fundamental = item.data.fundamental.raw;
+
+						fundamentalFields.forEach((fieldName) => {
+							const summary = sums[fieldName];
+							const value = fundamental[fieldName];
+
+							if (is.number(value)) {
+								summary.total = sums[fieldName].total + value;
+								summary.count = sums[fieldName].count + 1;
+							}
+
+							if ((i + 1) == this.items.length) {
+								let averageFormat;
+
+								if (summary.count > 0) {
+									averageFormat = formatPercent(new Decimal(summary.total / summary.count), 2, true);
+								} else {
+									averageFormat = '--';
+								}
+
+								summary.averageFormat = averageFormat;
+							}
+						});
+					}
+
+					return sums;
+				}, fundamentalFields.reduce((sums, fieldName) => {
+					sums[fieldName] = { total: 0, count: 0, averageFormat: '--' };
+
+					return sums;
+				}, { }));
+
+				this._dataFormat.fundamental = fundamentalFields.reduce((sums, fieldName) => {
+					sums[fieldName] = fundamentalData[fieldName].averageFormat;
+
+					return sums;
+				}, { });
+			}
+		});
+
 		let newsBinding = Disposable.getEmpty();
-		let fundamentalBinding = Disposable.getEmpty();
 
 		if (this._single) {
 			newsBinding = item.registerNewsExistsChangeHandler((exists, sender) => {
 				this._dataActual.newsExists = exists;
 				this._dataFormat.newsExists = exists;
 			});
-
-			fundamentalBinding = item.registerFundamentalDataChangeHandler((data, sender) => {
-				this._dataFormat.fundamental = data;
-			});
 		}
 
 		this._disposeStack.push(item.registerPortfolioChangeHandler((portfolio, sender) => {
@@ -2310,9 +2353,17 @@ module.exports = (() => {
 		}
 	}
 
-	function formatPercent(decimal, precision) {
+	function formatPercent(decimal, precision, plus) {
 		if (decimal !== null) {
-			return formatDecimal(decimal.multiply(100), precision) + '%';
+			let prefix;
+
+			if (is.boolean(plus) && plus && !Decimal.getIsNegative(decimal)) {
+				prefix = '+';
+			} else {
+				prefix = '';
+			}
+
+			return `${prefix}${formatDecimal(decimal.multiply(100), precision)}%`;
 		} else {
 			return '—';
 		}
@@ -2383,7 +2434,7 @@ module.exports = (() => {
 		actual.cashTotal = updates.cashTotal;
 
 		format.basis = formatCurrency(actual.basis, currency);
-		format.realized = formatCurrency(actual.basis, currency);
+		format.realized = formatCurrency(actual.realized, currency);
 		format.unrealized = formatCurrency(actual.unrealized, currency);
 		format.income = formatCurrency(actual.income, currency);
 		format.summaryTotalCurrent = formatCurrency(updates.summaryTotalCurrent, currency);