@barchart/portfolio-api-common 1.0.252 → 1.0.256

package/lib/api/failures/PortfolioFailureType.js

@@ -120,6 +120,17 @@ module.exports = (() => {
 			return transactionDeleteFailedNoTransaction;
 		}
 
+		/**
+		 * Unable to delete, the position's direction would switch.
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get TRANSACTION_DELETE_FAILED_DIRECTION_SWITCH_ON_REWRITE() {
+			return transactionDeleteFailedDirectionSwitchOnRewrite;
+		}
+
 		toString() {
 			return '[PortfolioFailureType]';
 		}
@@ -138,6 +149,7 @@ module.exports = (() => {
 
 	const transactionDeleteFailedOutOfSequence = new FailureType('TRANSACTION_DELETE_FAILED_OUT_OF_SEQUENCE', 'Deleting any transaction, except for the most recent, will cause transaction history to be re-written. Please confirm your intent to re-write transaction history (which could take some time and alter the historical results for this position).');
 	const transactionDeleteFailedNoTransaction = new FailureType('TRANSACTION_DELETE_FAILED_NO_TRANSACTION', 'Unable to delete transaction. The referenced transaction does not exist.');
+	const transactionDeleteFailedDirectionSwitchOnRewrite = new FailureType('TRANSACTION_DELETE_FAILED_DIRECTION_SWITCH_ON_REWRITE', 'Deleting this transaction would cause your history to be re-written and the position to switch from long to short (i.e. positive to negative) or vice versa.');
 
 	return PortfolioFailureType;
 })();

package/lib/processing/PositionGroup.js

@@ -730,7 +730,7 @@ module.exports = (() => {
 		actual.unrealized = updates.unrealized;
 		actual.unrealizedToday = updates.unrealizedToday;
 		actual.summaryTotalCurrent = updates.summaryTotalCurrent;
-		actual.total = updates.unrealizedToday.add(actual.realized).add(actual.income);
+		actual.total = updates.unrealized.add(actual.realized).add(actual.income);
 		
 		format.market = formatCurrency(actual.market, currency);
 		

package/lib/serialization/TransactionSchema.js

@@ -258,6 +258,7 @@ module.exports = (() => {
 		.withField('quantity', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
 		.withField('force', DataType.BOOLEAN, true)
+		.withField('reinvest', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -299,6 +300,7 @@ module.exports = (() => {
 		.withField('quantity', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
 		.withField('force', DataType.BOOLEAN, true)
+		.withField('reinvest', DataType.BOOLEAN, true)
 		.schema
 	);
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.252",
+  "version": "1.0.256",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -2487,7 +2487,7 @@ module.exports = (() => {
 		actual.unrealized = updates.unrealized;
 		actual.unrealizedToday = updates.unrealizedToday;
 		actual.summaryTotalCurrent = updates.summaryTotalCurrent;
-		actual.total = updates.unrealizedToday.add(actual.realized).add(actual.income);
+		actual.total = updates.unrealized.add(actual.realized).add(actual.income);
 		
 		format.market = formatCurrency(actual.market, currency);