@barchart/portfolio-api-common 1.0.246 → 1.0.250

package/lib/api/failures/PortfolioFailureType.js

@@ -13,7 +13,18 @@ module.exports = (() => {
 		}
 
 		/**
-		 * The portfolio referenced does not exist.
+		 * The portfolio does not exist.
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get PORTFOLIO_UPDATE_FAILED_NO_PORTFOLIO() {
+			return portfolioUpdateFailedNoPortfolio;
+		}
+
+		/**
+		 * The portfolio does not exist.
 		 *
 		 * @public
 		 * @static
@@ -24,7 +35,18 @@ module.exports = (() => {
 		}
 
 		/**
-		 * The referenced position does not exist.
+		 * The portfolio does not exist.
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get POSITION_UPDATE_FAILED_NO_POSITION() {
+			return positionUpdateFailedNoPosition;
+		}
+
+		/**
+		 * The position does not exist.
 		 *
 		 * @public
 		 * @static
@@ -103,7 +125,10 @@ module.exports = (() => {
 		}
 	}
 
-	const positionCreateFailedNoPortfolio = new FailureType('POSITION_CREATE_FAILED_NO_PORTFOLIO', 'Unable to create transaction. The referenced portfolio does not exist. Has it been deleted?');
+	const portfolioUpdateFailedNoPortfolio = new FailureType('PORTFOLIO_UPDATED_FAILED_NO_PORTFOLIO', 'Unable to update portfolio. The portfolio does not exist, has it been deleted?');
+
+	const positionCreateFailedNoPortfolio = new FailureType('POSITION_CREATE_FAILED_NO_PORTFOLIO', 'Unable to create transaction. The portfolio does not exist, has it been deleted?');
+	const positionUpdateFailedNoPosition = new FailureType('POSITION_UPDATE_FAILED_NO_POSITION', 'Unable to update preferences for position. The position does not exist, has it been deleted?');
 
 	const transactionCreateFailedNoPosition = new FailureType('TRANSACTION_CREATE_FAILED_NO_POSITION', 'Unable to create transaction. The referenced position does not exist. Has it been deleted?');
 	const transactionCreateFailedOutOfSequence = new FailureType('TRANSACTION_CREATE_FAILED_OUT_OF_SEQUENCE', 'Unable to process transaction, because the transaction date is out-of-sequence. In other words, it would occur before an existing transaction. Please confirm your intent to re-write transaction history (which could take some time and alter the historical results for this position).');

package/lib/serialization/PositionSchema.js

@@ -88,7 +88,7 @@ module.exports = (() => {
 		.withField('open', DataType.BOOLEAN, true)
 		.withField('transaction', DataType.NUMBER)
 		.withField('valuation', DataType.forEnum(ValuationType, 'ValuationType'))
-		.withField('reinvest', DataType.BOOLEAN)
+		.withField('reinvest', DataType.BOOLEAN, true)
 		.withField('snapshot.date', DataType.DAY)
 		.withField('snapshot.open', DataType.DECIMAL)
 		.withField('snapshot.direction', DataType.forEnum(PositionDirection, 'PositionDirection'))
@@ -120,7 +120,7 @@ module.exports = (() => {
 		.withField('open', DataType.BOOLEAN, true)
 		.withField('transaction', DataType.NUMBER)
 		.withField('valuation', DataType.forEnum(ValuationType, 'ValuationType'))
-		.withField('reinvest', DataType.BOOLEAN)
+		.withField('reinvest', DataType.BOOLEAN, true)
 		.withField('snapshot.date', DataType.DAY)
 		.withField('snapshot.open', DataType.DECIMAL)
 		.withField('snapshot.direction', DataType.forEnum(PositionDirection, 'PositionDirection'))
@@ -129,13 +129,14 @@ module.exports = (() => {
 		.withField('snapshot.gain', DataType.DECIMAL)
 		.withField('snapshot.basis', DataType.DECIMAL)
 		.withField('snapshot.income', DataType.DECIMAL)
-		.withField('snapshot.value', DataType.DECIMAL)
+		.withField('snapshot.value', DataType.DECIMAL)rm pa
 		.withField('previous', DataType.NUMBER, true)
 		.schema
 	);
 
 	const update = new PositionSchema(SchemaBuilder.withName('update')
 		.withField('portfolio', DataType.STRING)
+		.withField('position', DataType.STRING)
 		.withField('reinvest', DataType.BOOLEAN, true)
 		.schema
 	);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.246",
+  "version": "1.0.250",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -3830,6 +3830,33 @@ module.exports = function () {
 				}
 			}
 
+			/**
+    * Climbs the tree, evaluating each parent until a predicate is matched. Once matched,
+    * the {@link Tree} node is returned. Otherwise, if the predicate cannot be matched,
+    * a null value is returned.
+    *
+    * @public
+    * @param {Tree~nodePredicate} predicate - A predicate that tests each child node. The predicate takes two arguments -- the node's value, and the node itself.
+    * @param {boolean=} includeCurrentNode - If true, the predicate will be applied to the current node.
+    * @returns {Tree|null}
+    */
+
+		}, {
+			key: 'findParent',
+			value: function findParent(predicate, includeCurrentNode) {
+				var returnRef = void 0;
+
+				if (is.boolean(includeCurrentNode) && includeCurrentNode && predicate(this.getValue(), this)) {
+					returnRef = this;
+				} else if (this._parent !== null) {
+					returnRef = this._parent.findParent(predicate, true);
+				} else {
+					returnRef = null;
+				}
+
+				return returnRef;
+			}
+
 			/**
     * Creates a representation of the tree using JavaScript objects and arrays.
     *