@barchart/portfolio-api-common 1.0.196 → 1.0.200

package/lib/api/failures/PortfolioFailureType.js

@@ -15,6 +15,7 @@ module.exports = (() => {
 		/**
 		 * The transaction would occur before an existing transaction.
 		 *
+		 * @public
 		 * @static
 		 * @returns {FailureType}
 		 */
@@ -22,12 +23,49 @@ module.exports = (() => {
 			return transactionCreateFailedOutOfSequence;
 		}
 
+		/**
+		 * The transaction would cause the position to change (from long to
+		 * short, or vice versa).
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get TRANSACTION_CREATE_FAILED_DIRECTION_SWITCH() {
+			return transactionCreateFailedDirectionSwitch;
+		}
+
+		static get TRANSACTION_CREATE_REWRITE_UNSUPPORTED() {
+			return transactionCreateRewriteUnsupported;
+		}
+
+		/**
+		 * Deleting any transaction except for the most recent requires
+		 * re-writing transaction history.
+		 *
+		 * @public
+		 * @static
+		 * @returns {FailureType}
+		 */
+		static get TRANSACTION_DELETE_FAILED_OUT_OF_SEQUENCE() {
+			return transactionDeleteFailedOutOfSequence;
+		}
+
+		static get TRANSACTION_DELETE_UNSUPPORTED() {
+			return transactionDeleteUnsupported;
+		}
+
 		toString() {
 			return '[PortfolioFailureType]';
 		}
 	}
 
-	const transactionCreateFailedOutOfSequence = new FailureType('TRANSACTION_CREATE_FAILED_OUT_OF_SEQUENCE', 'Unable to create transaction, the transaction date is out-of-sequence (i.e. it would occur before an existing transaction). Please confirm your intent to re-write transaction history.');
+	const transactionCreateFailedOutOfSequence = new FailureType('TRANSACTION_CREATE_FAILED_OUT_OF_SEQUENCE', 'Unable to create transaction, because the transaction date is out-of-sequence. In other words, it would occur before an existing transaction. Please confirm your intent to re-write transaction history (which could take some time and alter the historical results for this position).');
+	const transactionCreateFailedDirectionSwitch = new FailureType('TRANSACTION_CREATE_FAILED_DIRECTION_SWITCH', 'Unable to create transaction, because the position direction would be switched (from long to short or vice versa). Please close the position (to a zero balance) first, then enter a second transaction.');
+	const transactionCreateRewriteUnsupported = new FailureType('TRANSACTION_CREATE_REWRITE_UNSUPPORTED', 'Unable to re-write transaction history. This operation is not currently supported (but will be implemented soon).');
+
+	const transactionDeleteFailedOutOfSequence = new FailureType('TRANSACTION_DELETE_FAILED_OUT_OF_SEQUENCE', 'Deleting any transaction, except for the most recent, will cause transaction history to be re-written. Please confirm your intent to re-write transaction history (which could take some time and alter the historical results for this position).');
+	const transactionDeleteUnsupported = new FailureType('TRANSACTION_DELETE_UNSUPPORTED', 'Unable to delete transaction. This operation is not currently supported (but will be implemented soon).');
 
 	return PortfolioFailureType;
 })();

package/lib/processing/PositionContainer.js

@@ -24,6 +24,11 @@ module.exports = (() => {
 
 	const DEFAULT_CURRENCY = Currency.CAD;
 
+	const REQUIRED_CURRENCIES = [
+		Currency.CAD,
+		Currency.USD
+	];
+
 	/**
 	 * A container for positions which groups the positions into one or more
 	 * trees for aggregation and display purposes. For example, positions could be
@@ -114,7 +119,9 @@ module.exports = (() => {
 				return map;
 			}, { });
 
-			this._forexSymbols = Object.keys(this._currencies).reduce((symbols, code) => {
+			const forexCurrencyCodes = array.unique(Object.keys(this._currencies).concat(REQUIRED_CURRENCIES.map(c => c.code)));
+
+			this._forexSymbols = forexCurrencyCodes.reduce((symbols, code) => {
 				if (code !== DEFAULT_CURRENCY.code) {
 					symbols.push(`^${DEFAULT_CURRENCY.code}${code}`);
 				}

package/lib/serialization/TransactionSchema.js

@@ -254,6 +254,7 @@ module.exports = (() => {
 		.withField('price', DataType.DECIMAL)
 		.withField('quantity', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -265,6 +266,7 @@ module.exports = (() => {
 		.withField('price', DataType.DECIMAL)
 		.withField('quantity', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -276,6 +278,7 @@ module.exports = (() => {
 		.withField('price', DataType.DECIMAL)
 		.withField('quantity', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -292,6 +295,7 @@ module.exports = (() => {
 		.withField('price', DataType.DECIMAL)
 		.withField('quantity', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -303,6 +307,7 @@ module.exports = (() => {
 		.withField('rate', DataType.DECIMAL)
 		.withField('effective', DataType.DAY)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -315,6 +320,7 @@ module.exports = (() => {
 		.withField('effective', DataType.DAY)
 		.withField('price', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -327,6 +333,7 @@ module.exports = (() => {
 		.withField('effective', DataType.DAY)
 		.withField('price', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -338,6 +345,7 @@ module.exports = (() => {
 		.withField('rate', DataType.DECIMAL)
 		.withField('effective', DataType.DAY)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -350,6 +358,7 @@ module.exports = (() => {
 		.withField('effective', DataType.DAY)
 		.withField('price', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -362,6 +371,7 @@ module.exports = (() => {
 		.withField('denominator', DataType.DECIMAL)
 		.withField('effective', DataType.DAY)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -371,6 +381,7 @@ module.exports = (() => {
 		.withField('type', DataType.forEnum(TransactionType, 'TransactionType'))
 		.withField('date', DataType.DAY)
 		.withField('fee', DataType.DECIMAL)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -381,6 +392,7 @@ module.exports = (() => {
 		.withField('date', DataType.DAY)
 		.withField('fee', DataType.DECIMAL)
 		.withField('price', DataType.DECIMAL)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -393,6 +405,7 @@ module.exports = (() => {
 		.withField('date', DataType.DAY)
 		.withField('amount', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -403,6 +416,7 @@ module.exports = (() => {
 		.withField('date', DataType.DAY)
 		.withField('amount', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -413,6 +427,7 @@ module.exports = (() => {
 		.withField('date', DataType.DAY)
 		.withField('amount', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -423,6 +438,7 @@ module.exports = (() => {
 		.withField('date', DataType.DAY)
 		.withField('amount', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -433,6 +449,7 @@ module.exports = (() => {
 		.withField('date', DataType.DAY)
 		.withField('value', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 
@@ -443,6 +460,7 @@ module.exports = (() => {
 		.withField('date', DataType.DAY)
 		.withField('income', DataType.DECIMAL)
 		.withField('fee', DataType.DECIMAL, true)
+		.withField('force', DataType.BOOLEAN, true)
 		.schema
 	);
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.196",
+  "version": "1.0.200",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -740,6 +740,11 @@ module.exports = (() => {
 
 	const DEFAULT_CURRENCY = Currency.CAD;
 
+	const REQUIRED_CURRENCIES = [
+		Currency.CAD,
+		Currency.USD
+	];
+
 	/**
 	 * A container for positions which groups the positions into one or more
 	 * trees for aggregation and display purposes. For example, positions could be
@@ -830,7 +835,9 @@ module.exports = (() => {
 				return map;
 			}, { });
 
-			this._forexSymbols = Object.keys(this._currencies).reduce((symbols, code) => {
+			const forexCurrencyCodes = array.unique(Object.keys(this._currencies).concat(REQUIRED_CURRENCIES.map(c => c.code)));
+
+			this._forexSymbols = forexCurrencyCodes.reduce((symbols, code) => {
 				if (code !== DEFAULT_CURRENCY.code) {
 					symbols.push(`^${DEFAULT_CURRENCY.code}${code}`);
 				}