@barchart/portfolio-api-common 1.0.152 → 1.0.156

package/lib/processing/PositionContainer.js

@@ -181,7 +181,7 @@ module.exports = (() => {
 						const items = populatedObjects[key];
 						const first = items[0];
 
-						list.push(new PositionGroup(this, parent, items, levelDefinition.currencySelector(first), key, levelDefinition.descriptionSelector(first), levelDefinition.single && items.length === 1));
+						list.push(new PositionGroup(this, parent, items, levelDefinition.currencySelector(first), key, levelDefinition.descriptionSelector(first), levelDefinition.single && items.length === 1, levelDefinition.aggregateCash));
 
 						return list;
 					}, [ ]);
@@ -523,6 +523,5 @@ module.exports = (() => {
 		}
 	}
 
-
 	return PositionContainer;
 })();

package/lib/processing/PositionGroup.js

@@ -8,6 +8,8 @@ const array = require('@barchart/common-js/lang/array'),
 	is = require('@barchart/common-js/lang/is'),
 	Rate = require('@barchart/common-js/lang/Rate');
 
+const InstrumentType = require('./../data/InstrumentType');
+
 module.exports = (() => {
 	'use strict';
 
@@ -25,9 +27,10 @@ module.exports = (() => {
 	 * @param {String} key
 	 * @param {String} description
 	 * @param {Boolean=} single
+	 * @param {Boolean=} aggregateCash
 	 */
 	class PositionGroup {
-		constructor(container, parent, items, currency, key, description, single) {
+		constructor(container, parent, items, currency, key, description, single, aggregateCash) {
 			this._id = counter++;
 			this._container = container;
 			this._parent = parent || null;
@@ -40,6 +43,7 @@ module.exports = (() => {
 			this._description = description;
 
 			this._single = is.boolean(single) && single;
+			this._aggregateCash = is.boolean(aggregateCash) && aggregateCash;
 
 			this._excluded = false;
 			this._suspended = false;
@@ -117,6 +121,7 @@ module.exports = (() => {
 			this._dataActual.total = null;
 			this._dataActual.summaryTotalCurrent = null;
 			this._dataActual.summaryTotalPrevious = null;
+			this._dataActual.cashTotal = null;
 
 			this._dataFormat.currentPrice = null;
 			this._dataFormat.previousPrice = null;
@@ -137,6 +142,7 @@ module.exports = (() => {
 			this._dataActual.summaryTotalCurrentNegative = false;
 			this._dataFormat.summaryTotalPrevious = null;
 			this._dataFormat.summaryTotalPreviousNegative = false;
+			this._dataFormat.cashTotal = null;
 
 			this._items.forEach((item) => {
 				this._disposeStack.push(item.registerQuoteChangeHandler((quote, sender) => {
@@ -164,8 +170,11 @@ module.exports = (() => {
 						this._dataFormat.quoteTime = this._dataActual.quoteTime;
 						this._dataFormat.quoteVolume = formatNumber(this._dataActual.quoteVolume, 0);
 
-						setTimeout(() => this._dataFormat.quoteChangeDirection = { up: this._dataActual.quoteChange.getIsPositive(), down: this._dataActual.quoteChange.getIsNegative() });
-						this._dataFormat.quoteChangeNegative = this._dataActual.quoteChange.getIsNegative();
+						const quoteChangePositive = is.number(this._dataActual.quoteChange) && this._dataActual.quoteChange > 0;
+						const quoteChangeNegative = is.number(this._dataActual.quoteChange) && this._dataActual.quoteChange < 0;
+
+						setTimeout(() => this._dataFormat.quoteChangeDirection = { up: quoteChangePositive, down: quoteChangeNegative }, 0);
+						this._dataFormat.quoteChangeNegative = quoteChangeNegative;
 					} else {
 						this._dataActual.currentPrice = null;
 						this._dataFormat.currentPrice = null;
@@ -317,6 +326,13 @@ module.exports = (() => {
 			}
 		}
 
+		/**
+		 * Set a flag to indicate if parent groups should exclude this group's
+		 * items from their calculations.
+		 *
+		 * @public
+		 * @param {Boolean} value
+		 */
 		setExcluded(value) {
 			assert.argumentIsRequired(value, 'value', Boolean);
 
@@ -455,6 +471,10 @@ module.exports = (() => {
 			updates.summaryTotalCurrent = updates.summaryTotalCurrent.add(translate(item, item.data.summaryTotalCurrent));
 			updates.summaryTotalPrevious = updates.summaryTotalPrevious.add(translate(item, item.data.summaryTotalPrevious));
 
+			if (item.position.type === InstrumentType.CASH) {
+				updates.cashTotal = updates.cashTotal.add(translate(item, item.data.market));
+			}
+
 			return updates;
 		}, {
 			basis: Decimal.ZERO,
@@ -462,7 +482,8 @@ module.exports = (() => {
 			unrealized: Decimal.ZERO,
 			income: Decimal.ZERO,
 			summaryTotalCurrent: Decimal.ZERO,
-			summaryTotalPrevious: Decimal.ZERO
+			summaryTotalPrevious: Decimal.ZERO,
+			cashTotal: Decimal.ZERO
 		});
 
 		actual.basis = updates.basis;
@@ -471,6 +492,7 @@ module.exports = (() => {
 		actual.income = updates.income;
 		actual.summaryTotalCurrent = updates.summaryTotalCurrent;
 		actual.summaryTotalPrevious = updates.summaryTotalPrevious;
+		actual.cashTotal = updates.cashTotal;
 
 		format.basis = formatCurrency(actual.basis, currency);
 		format.realized = formatCurrency(actual.basis, currency);
@@ -479,6 +501,7 @@ module.exports = (() => {
 		format.summaryTotalCurrent = formatCurrency(updates.summaryTotalCurrent, currency);
 		format.summaryTotalPrevious = formatCurrency(updates.summaryTotalPrevious, currency);
 		format.summaryTotalPreviousNegative = updates.summaryTotalPrevious.getIsNegative();
+		format.cashTotal = formatCurrency(updates.cashTotal, currency);
 
 		calculateUnrealizedPercent(group);
 

package/lib/processing/PositionItem.js

@@ -35,9 +35,7 @@ module.exports = (() => {
 			this._data.basis = null;
 
 			this._currentQuote = null;
-
 			this._currentPrice = null;
-			this._previousPrice = null;
 
 			this._data.currentPrice = null;
 			this._data.currentPricePrevious = null;

package/lib/processing/definitions/PositionLevelDefinition.js

@@ -15,10 +15,12 @@ module.exports = (() => {
 	 * @param {PositionLevelDefinition~descriptionSelector} descriptionSelector
 	 * @param {PositionLevelDefinition~currencySelector} currencySelector
 	 * @param {Array.<PositionLevelDefinition~RequiredGroup>=} requiredGroups
+	 * @param {Array.<PositionLevelDefinition~RequiredGroup>=} requiredGroups
 	 * @param {Boolean=} single
+	 * @param {Boolean=} aggregateCash
 	 */
 	class PositionLevelDefinition {
-		constructor(name, keySelector, descriptionSelector, currencySelector, requiredGroups, single) {
+		constructor(name, keySelector, descriptionSelector, currencySelector, requiredGroups, single, aggregateCash) {
 			assert.argumentIsRequired(name, 'name', String);
 			assert.argumentIsRequired(keySelector, 'keySelector', Function);
 			assert.argumentIsRequired(descriptionSelector, 'descriptionSelector', Function);
@@ -29,6 +31,7 @@ module.exports = (() => {
 			}
 
 			assert.argumentIsOptional(single, 'single', Boolean);
+			assert.argumentIsOptional(aggregateCash, 'aggregateCash', Boolean);
 
 			this._name = name;
 
@@ -38,6 +41,7 @@ module.exports = (() => {
 
 			this._requiredGroups = requiredGroups || [ ];
 			this._single = is.boolean(single) && single;
+			this._aggregateCash = is.boolean(aggregateCash) && aggregateCash;
 		}
 
 		/**
@@ -104,6 +108,16 @@ module.exports = (() => {
 			return this._single;
 		}
 
+		/**
+		 * Indicates if the grouping level should aggregate cash positions.
+		 *
+		 * @public
+		 * @returns {Boolean}
+		 */
+		get aggregateCash() {
+			return this._aggregateCash;
+		}
+
 		toString() {
 			return '[PositionLevelDefinition]';
 		}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.152",
+  "version": "1.0.156",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -897,7 +897,7 @@ module.exports = (() => {
 						const items = populatedObjects[key];
 						const first = items[0];
 
-						list.push(new PositionGroup(this, parent, items, levelDefinition.currencySelector(first), key, levelDefinition.descriptionSelector(first), levelDefinition.single && items.length === 1));
+						list.push(new PositionGroup(this, parent, items, levelDefinition.currencySelector(first), key, levelDefinition.descriptionSelector(first), levelDefinition.single && items.length === 1, levelDefinition.aggregateCash));
 
 						return list;
 					}, [ ]);
@@ -1239,7 +1239,6 @@ module.exports = (() => {
 		}
 	}
 
-
 	return PositionContainer;
 })();
 
@@ -1254,6 +1253,8 @@ const array = require('@barchart/common-js/lang/array'),
 	is = require('@barchart/common-js/lang/is'),
 	Rate = require('@barchart/common-js/lang/Rate');
 
+const InstrumentType = require('./../data/InstrumentType');
+
 module.exports = (() => {
 	'use strict';
 
@@ -1271,9 +1272,10 @@ module.exports = (() => {
 	 * @param {String} key
 	 * @param {String} description
 	 * @param {Boolean=} single
+	 * @param {Boolean=} aggregateCash
 	 */
 	class PositionGroup {
-		constructor(container, parent, items, currency, key, description, single) {
+		constructor(container, parent, items, currency, key, description, single, aggregateCash) {
 			this._id = counter++;
 			this._container = container;
 			this._parent = parent || null;
@@ -1286,6 +1288,7 @@ module.exports = (() => {
 			this._description = description;
 
 			this._single = is.boolean(single) && single;
+			this._aggregateCash = is.boolean(aggregateCash) && aggregateCash;
 
 			this._excluded = false;
 			this._suspended = false;
@@ -1363,6 +1366,7 @@ module.exports = (() => {
 			this._dataActual.total = null;
 			this._dataActual.summaryTotalCurrent = null;
 			this._dataActual.summaryTotalPrevious = null;
+			this._dataActual.cashTotal = null;
 
 			this._dataFormat.currentPrice = null;
 			this._dataFormat.previousPrice = null;
@@ -1383,6 +1387,7 @@ module.exports = (() => {
 			this._dataActual.summaryTotalCurrentNegative = false;
 			this._dataFormat.summaryTotalPrevious = null;
 			this._dataFormat.summaryTotalPreviousNegative = false;
+			this._dataFormat.cashTotal = null;
 
 			this._items.forEach((item) => {
 				this._disposeStack.push(item.registerQuoteChangeHandler((quote, sender) => {
@@ -1410,8 +1415,11 @@ module.exports = (() => {
 						this._dataFormat.quoteTime = this._dataActual.quoteTime;
 						this._dataFormat.quoteVolume = formatNumber(this._dataActual.quoteVolume, 0);
 
-						setTimeout(() => this._dataFormat.quoteChangeDirection = { up: this._dataActual.quoteChange.getIsPositive(), down: this._dataActual.quoteChange.getIsNegative() });
-						this._dataFormat.quoteChangeNegative = this._dataActual.quoteChange.getIsNegative();
+						const quoteChangePositive = is.number(this._dataActual.quoteChange) && this._dataActual.quoteChange > 0;
+						const quoteChangeNegative = is.number(this._dataActual.quoteChange) && this._dataActual.quoteChange < 0;
+
+						setTimeout(() => this._dataFormat.quoteChangeDirection = { up: quoteChangePositive, down: quoteChangeNegative }, 0);
+						this._dataFormat.quoteChangeNegative = quoteChangeNegative;
 					} else {
 						this._dataActual.currentPrice = null;
 						this._dataFormat.currentPrice = null;
@@ -1563,6 +1571,13 @@ module.exports = (() => {
 			}
 		}
 
+		/**
+		 * Set a flag to indicate if parent groups should exclude this group's
+		 * items from their calculations.
+		 *
+		 * @public
+		 * @param {Boolean} value
+		 */
 		setExcluded(value) {
 			assert.argumentIsRequired(value, 'value', Boolean);
 
@@ -1701,6 +1716,10 @@ module.exports = (() => {
 			updates.summaryTotalCurrent = updates.summaryTotalCurrent.add(translate(item, item.data.summaryTotalCurrent));
 			updates.summaryTotalPrevious = updates.summaryTotalPrevious.add(translate(item, item.data.summaryTotalPrevious));
 
+			if (item.position.type === InstrumentType.CASH) {
+				updates.cashTotal = updates.cashTotal.add(translate(item, item.data.market));
+			}
+
 			return updates;
 		}, {
 			basis: Decimal.ZERO,
@@ -1708,7 +1727,8 @@ module.exports = (() => {
 			unrealized: Decimal.ZERO,
 			income: Decimal.ZERO,
 			summaryTotalCurrent: Decimal.ZERO,
-			summaryTotalPrevious: Decimal.ZERO
+			summaryTotalPrevious: Decimal.ZERO,
+			cashTotal: Decimal.ZERO
 		});
 
 		actual.basis = updates.basis;
@@ -1717,6 +1737,7 @@ module.exports = (() => {
 		actual.income = updates.income;
 		actual.summaryTotalCurrent = updates.summaryTotalCurrent;
 		actual.summaryTotalPrevious = updates.summaryTotalPrevious;
+		actual.cashTotal = updates.cashTotal;
 
 		format.basis = formatCurrency(actual.basis, currency);
 		format.realized = formatCurrency(actual.basis, currency);
@@ -1725,6 +1746,7 @@ module.exports = (() => {
 		format.summaryTotalCurrent = formatCurrency(updates.summaryTotalCurrent, currency);
 		format.summaryTotalPrevious = formatCurrency(updates.summaryTotalPrevious, currency);
 		format.summaryTotalPreviousNegative = updates.summaryTotalPrevious.getIsNegative();
+		format.cashTotal = formatCurrency(updates.cashTotal, currency);
 
 		calculateUnrealizedPercent(group);
 
@@ -1886,7 +1908,7 @@ module.exports = (() => {
 	return PositionGroup;
 })();
 
-},{"@barchart/common-js/collections/specialized/DisposableStack":13,"@barchart/common-js/lang/Currency":14,"@barchart/common-js/lang/Decimal":16,"@barchart/common-js/lang/Rate":19,"@barchart/common-js/lang/array":20,"@barchart/common-js/lang/assert":21,"@barchart/common-js/lang/formatter":22,"@barchart/common-js/lang/is":23,"@barchart/common-js/messaging/Event":25}],6:[function(require,module,exports){
+},{"./../data/InstrumentType":1,"@barchart/common-js/collections/specialized/DisposableStack":13,"@barchart/common-js/lang/Currency":14,"@barchart/common-js/lang/Decimal":16,"@barchart/common-js/lang/Rate":19,"@barchart/common-js/lang/array":20,"@barchart/common-js/lang/assert":21,"@barchart/common-js/lang/formatter":22,"@barchart/common-js/lang/is":23,"@barchart/common-js/messaging/Event":25}],6:[function(require,module,exports){
 const array = require('@barchart/common-js/lang/array'),
 	assert = require('@barchart/common-js/lang/assert'),
 	Currency = require('@barchart/common-js/lang/Currency'),
@@ -1924,9 +1946,7 @@ module.exports = (() => {
 			this._data.basis = null;
 
 			this._currentQuote = null;
-
 			this._currentPrice = null;
-			this._previousPrice = null;
 
 			this._data.currentPrice = null;
 			this._data.currentPricePrevious = null;
@@ -2273,10 +2293,12 @@ module.exports = (() => {
 	 * @param {PositionLevelDefinition~descriptionSelector} descriptionSelector
 	 * @param {PositionLevelDefinition~currencySelector} currencySelector
 	 * @param {Array.<PositionLevelDefinition~RequiredGroup>=} requiredGroups
+	 * @param {Array.<PositionLevelDefinition~RequiredGroup>=} requiredGroups
 	 * @param {Boolean=} single
+	 * @param {Boolean=} aggregateCash
 	 */
 	class PositionLevelDefinition {
-		constructor(name, keySelector, descriptionSelector, currencySelector, requiredGroups, single) {
+		constructor(name, keySelector, descriptionSelector, currencySelector, requiredGroups, single, aggregateCash) {
 			assert.argumentIsRequired(name, 'name', String);
 			assert.argumentIsRequired(keySelector, 'keySelector', Function);
 			assert.argumentIsRequired(descriptionSelector, 'descriptionSelector', Function);
@@ -2287,6 +2309,7 @@ module.exports = (() => {
 			}
 
 			assert.argumentIsOptional(single, 'single', Boolean);
+			assert.argumentIsOptional(aggregateCash, 'aggregateCash', Boolean);
 
 			this._name = name;
 
@@ -2296,6 +2319,7 @@ module.exports = (() => {
 
 			this._requiredGroups = requiredGroups || [ ];
 			this._single = is.boolean(single) && single;
+			this._aggregateCash = is.boolean(aggregateCash) && aggregateCash;
 		}
 
 		/**
@@ -2362,6 +2386,16 @@ module.exports = (() => {
 			return this._single;
 		}
 
+		/**
+		 * Indicates if the grouping level should aggregate cash positions.
+		 *
+		 * @public
+		 * @returns {Boolean}
+		 */
+		get aggregateCash() {
+			return this._aggregateCash;
+		}
+
 		toString() {
 			return '[PositionLevelDefinition]';
 		}