@barchart/portfolio-api-common 1.0.136 → 1.0.140

package/lib/processing/PositionContainer.js

@@ -396,6 +396,16 @@ module.exports = (() => {
 			return findNode(this._trees[name], keys).getChildren().map(node => node.getValue());
 		}
 
+		getPositions(portfolio) {
+			return this._items.reduce((positions, item) => {
+				if (item.position.portfolio === portfolio) {
+					positions.push(item);
+				}
+
+				return positions;
+			}, []);
+		}
+
 		startTransaction(name, executor) {
 			assert.argumentIsRequired(name, 'name', String);
 			assert.argumentIsRequired(executor, 'executor', Function);

package/lib/processing/PositionGroup.js

@@ -146,7 +146,7 @@ module.exports = (() => {
 						this._dataFormat.newsExists = exists;
 					});
 
-					item._fundamentalDataChangeEvent((data, sender) => {
+					item.registerFundamentalDataChangeHandler((data, sender) => {
 						this._dataFormat.fundamental = data;
 					});
 				}
@@ -264,7 +264,7 @@ module.exports = (() => {
 			assert.argumentIsRequired(value, 'value', Boolean);
 
 			if (this._showClosedPositions !== value) {
-				this._showClosedPositionsChangeEvent(this._showClosedPositions = value);
+				this._showClosedPositionsChangeEvent.fire(this._showClosedPositions = value);
 			}
 		}
 

package/lib/processing/PositionItem.js

@@ -172,7 +172,7 @@ module.exports = (() => {
 		setPositionFundamentalData(data) {
 			assert.argumentIsRequired(data, 'data', Object);
 
-			this._fundamentalDataChangeEvent(this._data.fundamental = data);
+			this._fundamentalDataChangeEvent.fire(this._data.fundamental = data);
 		}
 
 		/**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.136",
+  "version": "1.0.140",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -1112,6 +1112,16 @@ module.exports = (() => {
 			return findNode(this._trees[name], keys).getChildren().map(node => node.getValue());
 		}
 
+		getPositions(portfolio) {
+			return this._items.reduce((positions, item) => {
+				if (item.position.portfolio === portfolio) {
+					positions.push(item);
+				}
+
+				return positions;
+			}, []);
+		}
+
 		startTransaction(name, executor) {
 			assert.argumentIsRequired(name, 'name', String);
 			assert.argumentIsRequired(executor, 'executor', Function);
@@ -1305,7 +1315,7 @@ module.exports = (() => {
 						this._dataFormat.newsExists = exists;
 					});
 
-					item._fundamentalDataChangeEvent((data, sender) => {
+					item.registerFundamentalDataChangeHandler((data, sender) => {
 						this._dataFormat.fundamental = data;
 					});
 				}
@@ -1423,7 +1433,7 @@ module.exports = (() => {
 			assert.argumentIsRequired(value, 'value', Boolean);
 
 			if (this._showClosedPositions !== value) {
-				this._showClosedPositionsChangeEvent(this._showClosedPositions = value);
+				this._showClosedPositionsChangeEvent.fire(this._showClosedPositions = value);
 			}
 		}
 
@@ -1899,7 +1909,7 @@ module.exports = (() => {
 		setPositionFundamentalData(data) {
 			assert.argumentIsRequired(data, 'data', Object);
 
-			this._fundamentalDataChangeEvent(this._data.fundamental = data);
+			this._fundamentalDataChangeEvent.fire(this._data.fundamental = data);
 		}
 
 		/**
@@ -2859,7 +2869,7 @@ module.exports = function () {
 	var Currency = function (_Enum) {
 		_inherits(Currency, _Enum);
 
-		function Currency(code, description, precision, alternateDescription) {
+		function Currency(code, description, precision) {
 			_classCallCheck(this, Currency);
 
 			var _this = _possibleConstructorReturn(this, (Currency.__proto__ || Object.getPrototypeOf(Currency)).call(this, code, description));
@@ -2867,11 +2877,7 @@ module.exports = function () {
 			assert.argumentIsRequired(precision, 'precision', Number);
 			assert.argumentIsValid(precision, 'precision', is.integer, 'is an integer');
 
-			assert.argumentIsOptional(alternateDescription, 'alternateDescription', String);
-
 			_this._precision = precision;
-
-			_this._alternateDescription = alternateDescription || description;
 			return _this;
 		}
 
@@ -2894,19 +2900,6 @@ module.exports = function () {
 				return this._precision;
 			}
 
-			/**
-    * An alternate human-readable description.
-    *
-    * @public
-    * @returns {String}
-    */
-
-		}, {
-			key: 'alternateDescription',
-			get: function get() {
-				return this._alternateDescription;
-			}
-
 			/**
     * Given a code, returns the enumeration item.
     *
@@ -2964,9 +2957,9 @@ module.exports = function () {
 		return Currency;
 	}(Enum);
 
-	var cad = new Currency('CAD', 'Canadian Dollar', 2, 'CAD$');
-	var eur = new Currency('EUR', 'Euro', 2, 'EUR');
-	var usd = new Currency('USD', 'US Dollar', 2, 'US$');
+	var cad = new Currency('CAD', 'Canadian Dollar', 2);
+	var eur = new Currency('EUR', 'Euro', 2);
+	var usd = new Currency('USD', 'US Dollar', 2);
 
 	return Currency;
 }();
@@ -3940,9 +3933,9 @@ module.exports = function () {
 				assert.argumentIsRequired(a, 'a', Decimal, 'Decimal');
 				assert.argumentIsRequired(b, 'b', Decimal, 'Decimal');
 
-				if (a._big.gt(b._big)) {
+				if (a._big.gt(b)) {
 					return 1;
-				} else if (a._big.lt(b._big)) {
+				} else if (a._big.lt(b)) {
 					return -1;
 				} else {
 					return 0;
@@ -4403,10 +4396,12 @@ var _createClass = function () { function defineProperties(target, props) { for
 function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
 
 var assert = require('./assert'),
+    is = require('./is'),
     memoize = require('./memoize');
 
 var Currency = require('./Currency'),
-    Decimal = require('./Decimal');
+    Decimal = require('./Decimal'),
+    Enum = require('./Enum');
 
 module.exports = function () {
 	'use strict';
@@ -4586,7 +4581,12 @@ module.exports = function () {
 				assert.argumentIsRequired(amount, 'amount', Decimal, 'Decimal');
 				assert.argumentIsRequired(currency, 'currency', Currency, 'Currency');
 				assert.argumentIsRequired(desiredCurrency, 'desiredCurrency', Currency, 'Currency');
-				//assert.argumentIsArray(rates, 'rates', Rate, 'Rate');
+
+				for (var _len = arguments.length, rates = Array(_len > 3 ? _len - 3 : 0), _key = 3; _key < _len; _key++) {
+					rates[_key - 3] = arguments[_key];
+				}
+
+				assert.argumentIsArray(rates, 'rates', Rate, 'Rate');
 
 				var converted = void 0;
 
@@ -4596,10 +4596,6 @@ module.exports = function () {
 					var numerator = desiredCurrency;
 					var denominator = currency;
 
-					for (var _len = arguments.length, rates = Array(_len > 3 ? _len - 3 : 0), _key = 3; _key < _len; _key++) {
-						rates[_key - 3] = arguments[_key];
-					}
-
 					var rate = rates.find(function (r) {
 						return r.numerator === numerator && r.denominator === denominator || r.numerator === denominator && r.denominator === numerator;
 					});
@@ -4650,7 +4646,7 @@ module.exports = function () {
 	return Rate;
 }();
 
-},{"./Currency":12,"./Decimal":14,"./assert":19,"./memoize":22}],18:[function(require,module,exports){
+},{"./Currency":12,"./Decimal":14,"./Enum":16,"./assert":19,"./is":21,"./memoize":22}],18:[function(require,module,exports){
 'use strict';
 
 var assert = require('./assert'),