@barchart/portfolio-api-common 1.0.132 → 1.0.136

package/lib/processing/PositionContainer.js

@@ -333,7 +333,12 @@ module.exports = (() => {
 		 * @param {Object} data
 		 */
 		setPositionFundamentalData(symbol, data) {
-			return;
+			assert.argumentIsRequired(symbol, 'symbol', String);
+			assert.argumentIsRequired(data, 'data', Object);
+
+			if (this._symbols.hasOwnProperty(symbol)) {
+				this._symbols[symbol].forEach(item => item.setPositionFundamentalData(data));
+			}
 		}
 
 		/**
@@ -352,9 +357,9 @@ module.exports = (() => {
 			let map;
 
 			if (display) {
-				map = this._symbols;
-			} else {
 				map = this._symbolsDisplay;
+			} else {
+				map = this._symbols;
 			}
 
 			if (map.hasOwnProperty(symbol)) {

package/lib/processing/PositionGroup.js

@@ -38,15 +38,18 @@ module.exports = (() => {
 
 			this._excluded = false;
 			this._suspended = false;
+			this._showClosedPositions = false;
 
 			this._marketPercentChangeEvent = new Event(this);
 			this._excludedChangeEvent = new Event(this);
+			this._showClosedPositionsChangeEvent = new Event(this);
 
 			this._dataFormat = { };
 			this._dataActual = { };
 
 			this._dataFormat.key = this._key;
 			this._dataFormat.description = this._description;
+			this._dataFormat.hide = false;
 			this._dataFormat.newsExists = false;
 			this._dataFormat.quantity = null;
 			this._dataFormat.basisPrice = null;
@@ -63,10 +66,12 @@ module.exports = (() => {
 				this._dataFormat.portfolio = item.portfolio.portfolio;
 				this._dataFormat.position = item.position.position;
 				this._dataFormat.instrument = item.position.instrument;
+				this._dataFormat.fundamental = item.fundamental || { };
 			} else {
 				this._dataFormat.portfolio = null;
 				this._dataFormat.position = null;
 				this._dataFormat.instrument = null;
+				this._dataFormat.fundamental = { };
 			}
 
 			this._dataFormat.quoteLast = null;
@@ -137,8 +142,12 @@ module.exports = (() => {
 
 				if (this._single) {
 					item.registerNewsExistsChangeHandler((exists, sender) => {
+						this._dataActual.newsExists = exists;
 						this._dataFormat.newsExists = exists;
-						this._dataFormat.newsExists = exists;
+					});
+
+					item._fundamentalDataChangeEvent((data, sender) => {
+						this._dataFormat.fundamental = data;
 					});
 				}
 			});
@@ -251,6 +260,14 @@ module.exports = (() => {
 			}
 		}
 
+		setShowClosedPositions(value) {
+			assert.argumentIsRequired(value, 'value', Boolean);
+
+			if (this._showClosedPositions !== value) {
+				this._showClosedPositionsChangeEvent(this._showClosedPositions = value);
+			}
+		}
+
 		setSuspended(value) {
 			assert.argumentIsRequired(value, 'value', Boolean);
 

package/lib/processing/PositionItem.js

@@ -50,7 +50,7 @@ module.exports = (() => {
 
 			this._data.unrealized = null;
 			this._data.unrealizedChange = null;
-			
+
 			this._data.summaryTotalCurrent = null;
 			this._data.summaryTotalCurrentChange = null;
 
@@ -61,12 +61,14 @@ module.exports = (() => {
 			this._data.basisPrice = null;
 
 			this._data.newsExists = false;
+			this._data.fundamental = { };
 
 			calculateStaticData(this);
 			calculatePriceData(this, null);
 
 			this._quoteChangedEvent = new Event(this);
 			this._newsExistsChangedEvent = new Event(this);
+			this._fundamentalDataChangeEvent = new Event(this);
 		}
 
 		/**
@@ -161,6 +163,18 @@ module.exports = (() => {
 			}
 		}
 
+		/**
+		 * Sets fundamental data for the position.
+		 *
+		 * @public
+		 * @param {Object} data
+		 */
+		setPositionFundamentalData(data) {
+			assert.argumentIsRequired(data, 'data', Object);
+
+			this._fundamentalDataChangeEvent(this._data.fundamental = data);
+		}
+
 		/**
 		 * Sets a flag which indicates if news article(s) exist for the encapsulated position's
 		 * symbol.
@@ -187,6 +201,16 @@ module.exports = (() => {
 			this._quoteChangedEvent.register(handler);
 		}
 
+		/**
+		 * Registers an observer for fundamental data changes.
+		 *
+		 * @public
+		 * @param {Function} handler
+		 */
+		registerFundamentalDataChangeHandler(handler) {
+			this._fundamentalDataChangeEvent.register(handler);
+		}
+
 		/**
 		 * Registers an observer changes to the status of news existence.
 		 *
@@ -321,10 +345,10 @@ module.exports = (() => {
 			data.unrealizedChange = Decimal.ZERO;
 		}
 	}
-	
+
 	function calculateSummaryTotal(summary) {
 		let returnRef;
-		
+
 		if (summary) {
 			const period = summary.period;
 
@@ -332,7 +356,7 @@ module.exports = (() => {
 		} else {
 			returnRef = Decimal.ZERO;
 		}
-		
+
 		return returnRef;
 	}
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.132",
+  "version": "1.0.136",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -1049,7 +1049,12 @@ module.exports = (() => {
 		 * @param {Object} data
 		 */
 		setPositionFundamentalData(symbol, data) {
-			return;
+			assert.argumentIsRequired(symbol, 'symbol', String);
+			assert.argumentIsRequired(data, 'data', Object);
+
+			if (this._symbols.hasOwnProperty(symbol)) {
+				this._symbols[symbol].forEach(item => item.setPositionFundamentalData(data));
+			}
 		}
 
 		/**
@@ -1068,9 +1073,9 @@ module.exports = (() => {
 			let map;
 
 			if (display) {
-				map = this._symbols;
-			} else {
 				map = this._symbolsDisplay;
+			} else {
+				map = this._symbols;
 			}
 
 			if (map.hasOwnProperty(symbol)) {
@@ -1192,15 +1197,18 @@ module.exports = (() => {
 
 			this._excluded = false;
 			this._suspended = false;
+			this._showClosedPositions = false;
 
 			this._marketPercentChangeEvent = new Event(this);
 			this._excludedChangeEvent = new Event(this);
+			this._showClosedPositionsChangeEvent = new Event(this);
 
 			this._dataFormat = { };
 			this._dataActual = { };
 
 			this._dataFormat.key = this._key;
 			this._dataFormat.description = this._description;
+			this._dataFormat.hide = false;
 			this._dataFormat.newsExists = false;
 			this._dataFormat.quantity = null;
 			this._dataFormat.basisPrice = null;
@@ -1217,10 +1225,12 @@ module.exports = (() => {
 				this._dataFormat.portfolio = item.portfolio.portfolio;
 				this._dataFormat.position = item.position.position;
 				this._dataFormat.instrument = item.position.instrument;
+				this._dataFormat.fundamental = item.fundamental || { };
 			} else {
 				this._dataFormat.portfolio = null;
 				this._dataFormat.position = null;
 				this._dataFormat.instrument = null;
+				this._dataFormat.fundamental = { };
 			}
 
 			this._dataFormat.quoteLast = null;
@@ -1291,9 +1301,13 @@ module.exports = (() => {
 
 				if (this._single) {
 					item.registerNewsExistsChangeHandler((exists, sender) => {
-						this._dataFormat.newsExists = exists;
+						this._dataActual.newsExists = exists;
 						this._dataFormat.newsExists = exists;
 					});
+
+					item._fundamentalDataChangeEvent((data, sender) => {
+						this._dataFormat.fundamental = data;
+					});
 				}
 			});
 
@@ -1405,6 +1419,14 @@ module.exports = (() => {
 			}
 		}
 
+		setShowClosedPositions(value) {
+			assert.argumentIsRequired(value, 'value', Boolean);
+
+			if (this._showClosedPositions !== value) {
+				this._showClosedPositionsChangeEvent(this._showClosedPositions = value);
+			}
+		}
+
 		setSuspended(value) {
 			assert.argumentIsRequired(value, 'value', Boolean);
 
@@ -1755,7 +1777,7 @@ module.exports = (() => {
 
 			this._data.unrealized = null;
 			this._data.unrealizedChange = null;
-			
+
 			this._data.summaryTotalCurrent = null;
 			this._data.summaryTotalCurrentChange = null;
 
@@ -1766,12 +1788,14 @@ module.exports = (() => {
 			this._data.basisPrice = null;
 
 			this._data.newsExists = false;
+			this._data.fundamental = { };
 
 			calculateStaticData(this);
 			calculatePriceData(this, null);
 
 			this._quoteChangedEvent = new Event(this);
 			this._newsExistsChangedEvent = new Event(this);
+			this._fundamentalDataChangeEvent = new Event(this);
 		}
 
 		/**
@@ -1866,6 +1890,18 @@ module.exports = (() => {
 			}
 		}
 
+		/**
+		 * Sets fundamental data for the position.
+		 *
+		 * @public
+		 * @param {Object} data
+		 */
+		setPositionFundamentalData(data) {
+			assert.argumentIsRequired(data, 'data', Object);
+
+			this._fundamentalDataChangeEvent(this._data.fundamental = data);
+		}
+
 		/**
 		 * Sets a flag which indicates if news article(s) exist for the encapsulated position's
 		 * symbol.
@@ -1892,6 +1928,16 @@ module.exports = (() => {
 			this._quoteChangedEvent.register(handler);
 		}
 
+		/**
+		 * Registers an observer for fundamental data changes.
+		 *
+		 * @public
+		 * @param {Function} handler
+		 */
+		registerFundamentalDataChangeHandler(handler) {
+			this._fundamentalDataChangeEvent.register(handler);
+		}
+
 		/**
 		 * Registers an observer changes to the status of news existence.
 		 *
@@ -2026,10 +2072,10 @@ module.exports = (() => {
 			data.unrealizedChange = Decimal.ZERO;
 		}
 	}
-	
+
 	function calculateSummaryTotal(summary) {
 		let returnRef;
-		
+
 		if (summary) {
 			const period = summary.period;
 
@@ -2037,7 +2083,7 @@ module.exports = (() => {
 		} else {
 			returnRef = Decimal.ZERO;
 		}
-		
+
 		return returnRef;
 	}