@barchart/portfolio-api-common 1.0.131 → 1.0.135

package/lib/processing/PositionContainer.js

@@ -108,6 +108,20 @@ module.exports = (() => {
 				return map;
 			}, { });
 
+			this._symbolsDisplay = this._items.reduce((map, item) => {
+				const symbol = extractSymbolForDisplay(item.position);
+
+				if (symbol) {
+					if (!map.hasOwnProperty(symbol)) {
+						map[symbol] = [ ];
+					}
+
+					map[symbol].push(item);
+				}
+
+				return map;
+			}, { });
+
 			this._currencies = this._items.reduce((map, item) => {
 				const position = item.position;
 
@@ -319,7 +333,12 @@ module.exports = (() => {
 		 * @param {Object} data
 		 */
 		setPositionFundamentalData(symbol, data) {
-			return;
+			assert.argumentIsRequired(symbol, 'symbol', String);
+			assert.argumentIsRequired(data, 'data', Object);
+
+			if (this._symbols.hasOwnProperty(symbol)) {
+				this._symbols[symbol].forEach(item => item.setPositionFundamentalData(data));
+			}
 		}
 
 		/**
@@ -327,14 +346,24 @@ module.exports = (() => {
 		 *
 		 * @public
 		 * @param {String} symbol
+		 * @param {Boolean} display
 		 * @param {Boolean} exists
 		 */
-		setNewsArticleExists(symbol, exists) {
+		setNewsArticleExists(symbol, display, exists) {
 			assert.argumentIsRequired(symbol, 'symbol', String);
+			assert.argumentIsRequired(display, 'display', Boolean);
 			assert.argumentIsRequired(exists, 'exists', Boolean);
 
-			if (this._symbols.hasOwnProperty(symbol)) {
-				this._symbols[symbol].forEach(item => item.setNewsArticleExists(exists));
+			let map;
+
+			if (display) {
+				map = this._symbolsDisplay;
+			} else {
+				map = this._symbols;
+			}
+
+			if (map.hasOwnProperty(symbol)) {
+				map[symbol].forEach(item => item.setNewsArticleExists(exists));
 			}
 		}
 

package/lib/processing/PositionGroup.js

@@ -38,8 +38,11 @@ module.exports = (() => {
 
 			this._excluded = false;
 			this._suspended = false;
+			this._showClosedPositions = false;
 
 			this._marketPercentChangeEvent = new Event(this);
+			this._excludedChangeEvent = new Event(this);
+			this._showClosedPositionsChangeEvent = new Event(this);
 
 			this._dataFormat = { };
 			this._dataActual = { };
@@ -62,10 +65,12 @@ module.exports = (() => {
 				this._dataFormat.portfolio = item.portfolio.portfolio;
 				this._dataFormat.position = item.position.position;
 				this._dataFormat.instrument = item.position.instrument;
+				this._dataFormat.fundamental = item.fundamental || { };
 			} else {
 				this._dataFormat.portfolio = null;
 				this._dataFormat.position = null;
 				this._dataFormat.instrument = null;
+				this._dataFormat.fundamental = { };
 			}
 
 			this._dataFormat.quoteLast = null;
@@ -136,8 +141,12 @@ module.exports = (() => {
 
 				if (this._single) {
 					item.registerNewsExistsChangeHandler((exists, sender) => {
+						this._dataActual.newsExists = exists;
 						this._dataFormat.newsExists = exists;
-						this._dataFormat.newsExists = exists;
+					});
+
+					item._fundamentalDataChangeEvent((data, sender) => {
+						this._dataFormat.fundamental = data;
 					});
 				}
 			});
@@ -246,11 +255,15 @@ module.exports = (() => {
 			assert.argumentIsRequired(value, 'value', Boolean);
 
 			if (this._excluded !== value) {
-				this._container.startTransaction(() => {
-					this._items.forEach((item) => {
-						item.setExcluded(value);
-					});
-				});
+				this._excludedChangeEvent(this._excluded = value);
+			}
+		}
+
+		setShowClosedPositions(value) {
+			assert.argumentIsRequired(value, 'value', Boolean);
+
+			if (this._showClosedPositions !== value) {
+				this._showClosedPositionsChangeEvent(this._showClosedPositions = value);
 			}
 		}
 

package/lib/processing/PositionItem.js

@@ -50,7 +50,7 @@ module.exports = (() => {
 
 			this._data.unrealized = null;
 			this._data.unrealizedChange = null;
-			
+
 			this._data.summaryTotalCurrent = null;
 			this._data.summaryTotalCurrentChange = null;
 
@@ -61,15 +61,14 @@ module.exports = (() => {
 			this._data.basisPrice = null;
 
 			this._data.newsExists = false;
-
-			this._excluded = false;
+			this._data.fundamental = { };
 
 			calculateStaticData(this);
 			calculatePriceData(this, null);
 
 			this._quoteChangedEvent = new Event(this);
-			this._excludedChangeEvent = new Event(this);
 			this._newsExistsChangedEvent = new Event(this);
+			this._fundamentalDataChangeEvent = new Event(this);
 		}
 
 		/**
@@ -142,10 +141,6 @@ module.exports = (() => {
 			return this._currentQuote;
 		}
 
-		get excluded() {
-			return this._excluded;
-		}
-
 		/**
 		 * Sets the current quote -- causing position-level data (e.g. market value) to
 		 * be recalculated.
@@ -168,12 +163,16 @@ module.exports = (() => {
 			}
 		}
 
-		setExcluded(value) {
-			assert.argumentIsRequired(value, 'value', Boolean);
+		/**
+		 * Sets fundamental data for the position.
+		 *
+		 * @public
+		 * @param {Object} data
+		 */
+		setPositionFundamentalData(data) {
+			assert.argumentIsRequired(data, 'data', Object);
 
-			if (this._excluded !== value) {
-				this._excludedChangeEvent.fire(this._excluded = value);
-			}
+			this._fundamentalDataChangeEvent(this._data.fundamental = data);
 		}
 
 		/**
@@ -202,8 +201,14 @@ module.exports = (() => {
 			this._quoteChangedEvent.register(handler);
 		}
 
-		registerExcludedChangeHandler(handler) {
-			this._excludedChangeEvent.register(handler);
+		/**
+		 * Registers an observer for fundamental data changes.
+		 *
+		 * @public
+		 * @param {Function} handler
+		 */
+		registerFundamentalDataChangeHandler(handler) {
+			this._fundamentalDataChangeEvent.register(handler);
 		}
 
 		/**
@@ -340,10 +345,10 @@ module.exports = (() => {
 			data.unrealizedChange = Decimal.ZERO;
 		}
 	}
-	
+
 	function calculateSummaryTotal(summary) {
 		let returnRef;
-		
+
 		if (summary) {
 			const period = summary.period;
 
@@ -351,7 +356,7 @@ module.exports = (() => {
 		} else {
 			returnRef = Decimal.ZERO;
 		}
-		
+
 		return returnRef;
 	}
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.131",
+  "version": "1.0.135",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -824,6 +824,20 @@ module.exports = (() => {
 				return map;
 			}, { });
 
+			this._symbolsDisplay = this._items.reduce((map, item) => {
+				const symbol = extractSymbolForDisplay(item.position);
+
+				if (symbol) {
+					if (!map.hasOwnProperty(symbol)) {
+						map[symbol] = [ ];
+					}
+
+					map[symbol].push(item);
+				}
+
+				return map;
+			}, { });
+
 			this._currencies = this._items.reduce((map, item) => {
 				const position = item.position;
 
@@ -1035,7 +1049,12 @@ module.exports = (() => {
 		 * @param {Object} data
 		 */
 		setPositionFundamentalData(symbol, data) {
-			return;
+			assert.argumentIsRequired(symbol, 'symbol', String);
+			assert.argumentIsRequired(data, 'data', Object);
+
+			if (this._symbols.hasOwnProperty(symbol)) {
+				this._symbols[symbol].forEach(item => item.setPositionFundamentalData(data));
+			}
 		}
 
 		/**
@@ -1043,14 +1062,24 @@ module.exports = (() => {
 		 *
 		 * @public
 		 * @param {String} symbol
+		 * @param {Boolean} display
 		 * @param {Boolean} exists
 		 */
-		setNewsArticleExists(symbol, exists) {
+		setNewsArticleExists(symbol, display, exists) {
 			assert.argumentIsRequired(symbol, 'symbol', String);
+			assert.argumentIsRequired(display, 'display', Boolean);
 			assert.argumentIsRequired(exists, 'exists', Boolean);
 
-			if (this._symbols.hasOwnProperty(symbol)) {
-				this._symbols[symbol].forEach(item => item.setNewsArticleExists(exists));
+			let map;
+
+			if (display) {
+				map = this._symbolsDisplay;
+			} else {
+				map = this._symbols;
+			}
+
+			if (map.hasOwnProperty(symbol)) {
+				map[symbol].forEach(item => item.setNewsArticleExists(exists));
 			}
 		}
 
@@ -1168,8 +1197,11 @@ module.exports = (() => {
 
 			this._excluded = false;
 			this._suspended = false;
+			this._showClosedPositions = false;
 
 			this._marketPercentChangeEvent = new Event(this);
+			this._excludedChangeEvent = new Event(this);
+			this._showClosedPositionsChangeEvent = new Event(this);
 
 			this._dataFormat = { };
 			this._dataActual = { };
@@ -1192,10 +1224,12 @@ module.exports = (() => {
 				this._dataFormat.portfolio = item.portfolio.portfolio;
 				this._dataFormat.position = item.position.position;
 				this._dataFormat.instrument = item.position.instrument;
+				this._dataFormat.fundamental = item.fundamental || { };
 			} else {
 				this._dataFormat.portfolio = null;
 				this._dataFormat.position = null;
 				this._dataFormat.instrument = null;
+				this._dataFormat.fundamental = { };
 			}
 
 			this._dataFormat.quoteLast = null;
@@ -1266,9 +1300,13 @@ module.exports = (() => {
 
 				if (this._single) {
 					item.registerNewsExistsChangeHandler((exists, sender) => {
-						this._dataFormat.newsExists = exists;
+						this._dataActual.newsExists = exists;
 						this._dataFormat.newsExists = exists;
 					});
+
+					item._fundamentalDataChangeEvent((data, sender) => {
+						this._dataFormat.fundamental = data;
+					});
 				}
 			});
 
@@ -1376,11 +1414,15 @@ module.exports = (() => {
 			assert.argumentIsRequired(value, 'value', Boolean);
 
 			if (this._excluded !== value) {
-				this._container.startTransaction(() => {
-					this._items.forEach((item) => {
-						item.setExcluded(value);
-					});
-				});
+				this._excludedChangeEvent(this._excluded = value);
+			}
+		}
+
+		setShowClosedPositions(value) {
+			assert.argumentIsRequired(value, 'value', Boolean);
+
+			if (this._showClosedPositions !== value) {
+				this._showClosedPositionsChangeEvent(this._showClosedPositions = value);
 			}
 		}
 
@@ -1734,7 +1776,7 @@ module.exports = (() => {
 
 			this._data.unrealized = null;
 			this._data.unrealizedChange = null;
-			
+
 			this._data.summaryTotalCurrent = null;
 			this._data.summaryTotalCurrentChange = null;
 
@@ -1745,15 +1787,14 @@ module.exports = (() => {
 			this._data.basisPrice = null;
 
 			this._data.newsExists = false;
-
-			this._excluded = false;
+			this._data.fundamental = { };
 
 			calculateStaticData(this);
 			calculatePriceData(this, null);
 
 			this._quoteChangedEvent = new Event(this);
-			this._excludedChangeEvent = new Event(this);
 			this._newsExistsChangedEvent = new Event(this);
+			this._fundamentalDataChangeEvent = new Event(this);
 		}
 
 		/**
@@ -1826,10 +1867,6 @@ module.exports = (() => {
 			return this._currentQuote;
 		}
 
-		get excluded() {
-			return this._excluded;
-		}
-
 		/**
 		 * Sets the current quote -- causing position-level data (e.g. market value) to
 		 * be recalculated.
@@ -1852,12 +1889,16 @@ module.exports = (() => {
 			}
 		}
 
-		setExcluded(value) {
-			assert.argumentIsRequired(value, 'value', Boolean);
+		/**
+		 * Sets fundamental data for the position.
+		 *
+		 * @public
+		 * @param {Object} data
+		 */
+		setPositionFundamentalData(data) {
+			assert.argumentIsRequired(data, 'data', Object);
 
-			if (this._excluded !== value) {
-				this._excludedChangeEvent.fire(this._excluded = value);
-			}
+			this._fundamentalDataChangeEvent(this._data.fundamental = data);
 		}
 
 		/**
@@ -1886,8 +1927,14 @@ module.exports = (() => {
 			this._quoteChangedEvent.register(handler);
 		}
 
-		registerExcludedChangeHandler(handler) {
-			this._excludedChangeEvent.register(handler);
+		/**
+		 * Registers an observer for fundamental data changes.
+		 *
+		 * @public
+		 * @param {Function} handler
+		 */
+		registerFundamentalDataChangeHandler(handler) {
+			this._fundamentalDataChangeEvent.register(handler);
 		}
 
 		/**
@@ -2024,10 +2071,10 @@ module.exports = (() => {
 			data.unrealizedChange = Decimal.ZERO;
 		}
 	}
-	
+
 	function calculateSummaryTotal(summary) {
 		let returnRef;
-		
+
 		if (summary) {
 			const period = summary.period;
 
@@ -2035,7 +2082,7 @@ module.exports = (() => {
 		} else {
 			returnRef = Decimal.ZERO;
 		}
-		
+
 		return returnRef;
 	}