@barchart/portfolio-api-common 1.0.126 → 1.0.130

package/lib/processing/PositionContainer.js

@@ -276,15 +276,22 @@ module.exports = (() => {
 				this._forexQuotes[index] = rate;
 			}
 
-			this._trees.forEach((tree) => {
-				tree.walk(group => group.setForexRate(rate), true, false);
-			});
+			Object.keys(this._trees).forEach(key => this._trees[key].walk(group => group.setForexRate(rate), true, false));
 		}
 
-		setPositionFundamentals(data) {
+		setPositionFundamentals(symbol, data) {
 			return;
 		}
 
+		setNewsArticleExists(symbol, exists) {
+			assert.argumentIsRequired(symbol, 'symbol', String);
+			assert.argumentIsRequired(exists, 'exists', Boolean);
+
+			if (this._symbols.hasOwnProperty(symbol)) {
+				this._symbols[symbol].forEach(item => item.setNewsArticleExists(exists));
+			}
+		}
+
 		getGroup(name, keys) {
 			assert.argumentIsRequired(name, 'name', String);
 			assert.argumentIsArray(keys, 'keys', Number);

package/lib/processing/PositionGroup.js

@@ -36,8 +36,15 @@ module.exports = (() => {
 
 			this._dataFormat.key = this._key;
 			this._dataFormat.description = this._description;
-
+			this._dataFormat.newsExists = false;
 			this._dataFormat.quantity = null;
+			this._dataFormat.basisPrice = null;
+
+			this._dataActual.key = this._key;
+			this._dataActual.description = this._description;
+			this._dataActual.newsExists = false;
+			this._dataActual.quantity = null;
+			this._dataActual.basisPrice = null;
 
 			if (this._single) {
 				const item = items[0];
@@ -116,6 +123,13 @@ module.exports = (() => {
 
 					calculatePriceData(this, this._container.getForexQuotes(), sender, false);
 				});
+
+				if (this._single) {
+					item.registerNewsExistsChangeHandler((exists, sender) => {
+						this._dataFormat.newsExists = exists;
+						this._dataFormat.newsExists = exists;
+					});
+				}
 			});
 
 			this.refresh();
@@ -245,7 +259,7 @@ module.exports = (() => {
 		
 		const items = group._items;
 
-		group._bypassCurrencyTranslation = items.some(item => item.currency !== currency);
+		group._bypassCurrencyTranslation = items.every(item => item.currency === currency);
 
 		const translate = (item, value) => {
 			let translated;
@@ -297,8 +311,11 @@ module.exports = (() => {
 		if (group.single) {
 			const item = group._items[0];
 
-			format.quantity = formatDecimal(item.position.snapshot.open, 2);
-			format.basisPrice = formatCurrency(item.data.basisPrice, currency);
+			actual.quantity = item.position.snapshot.open;
+			actual.basisPrice = item.data.basisPrice;
+
+			format.quantity = formatDecimal(actual.quantity, 2);
+			format.basisPrice = formatCurrency(actual.basisPrice, currency);
 		}
 	}
 

package/lib/processing/PositionItem.js

@@ -50,6 +50,8 @@ module.exports = (() => {
 			this._data.income = null;
 			this._data.basisPrice = null;
 
+			this._data.newsExists = false;
+
 			this._excluded = false;
 
 			calculateStaticData(this);
@@ -57,6 +59,7 @@ module.exports = (() => {
 
 			this._quoteChangedEvent = new Event(this);
 			this._excludedChangeEvent = new Event(this);
+			this._newsExistsChangedEvent = new Event(this);
 		}
 
 		get portfolio() {
@@ -112,6 +115,14 @@ module.exports = (() => {
 			}
 		}
 
+		setNewsArticleExists(value) {
+			assert.argumentIsRequired(value, 'value', Boolean);
+
+			if (this._data.newsExists !== value) {
+				this._newsExistsChangedEvent.fire(this._data.newsExists = value);
+			}
+		}
+
 		registerQuoteChangeHandler(handler) {
 			this._quoteChangedEvent.register(handler);
 		}
@@ -120,6 +131,10 @@ module.exports = (() => {
 			this._excludedChangeEvent.register(handler);
 		}
 
+		registerNewsExistsChangeHandler(handler) {
+			this._newsExistsChangedEvent.register(handler);
+		}
+
 		toString() {
 			return '[PositionItem]';
 		}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barchart/portfolio-api-common",
-  "version": "1.0.126",
+  "version": "1.0.130",
   "description": "Common classes used by the Portfolio system",
   "author": {
     "name": "Bryan Ingle",

package/test/SpecRunner.js

@@ -992,15 +992,22 @@ module.exports = (() => {
 				this._forexQuotes[index] = rate;
 			}
 
-			this._trees.forEach((tree) => {
-				tree.walk(group => group.setForexRate(rate), true, false);
-			});
+			Object.keys(this._trees).forEach(key => this._trees[key].walk(group => group.setForexRate(rate), true, false));
 		}
 
-		setPositionFundamentals(data) {
+		setPositionFundamentals(symbol, data) {
 			return;
 		}
 
+		setNewsArticleExists(symbol, exists) {
+			assert.argumentIsRequired(symbol, 'symbol', String);
+			assert.argumentIsRequired(exists, 'exists', Boolean);
+
+			if (this._symbols.hasOwnProperty(symbol)) {
+				this._symbols[symbol].forEach(item => item.setNewsArticleExists(exists));
+			}
+		}
+
 		getGroup(name, keys) {
 			assert.argumentIsRequired(name, 'name', String);
 			assert.argumentIsArray(keys, 'keys', Number);
@@ -1100,8 +1107,15 @@ module.exports = (() => {
 
 			this._dataFormat.key = this._key;
 			this._dataFormat.description = this._description;
-
+			this._dataFormat.newsExists = false;
 			this._dataFormat.quantity = null;
+			this._dataFormat.basisPrice = null;
+
+			this._dataActual.key = this._key;
+			this._dataActual.description = this._description;
+			this._dataActual.newsExists = false;
+			this._dataActual.quantity = null;
+			this._dataActual.basisPrice = null;
 
 			if (this._single) {
 				const item = items[0];
@@ -1180,6 +1194,13 @@ module.exports = (() => {
 
 					calculatePriceData(this, this._container.getForexQuotes(), sender, false);
 				});
+
+				if (this._single) {
+					item.registerNewsExistsChangeHandler((exists, sender) => {
+						this._dataFormat.newsExists = exists;
+						this._dataFormat.newsExists = exists;
+					});
+				}
 			});
 
 			this.refresh();
@@ -1309,7 +1330,7 @@ module.exports = (() => {
 		
 		const items = group._items;
 
-		group._bypassCurrencyTranslation = items.some(item => item.currency !== currency);
+		group._bypassCurrencyTranslation = items.every(item => item.currency === currency);
 
 		const translate = (item, value) => {
 			let translated;
@@ -1361,8 +1382,11 @@ module.exports = (() => {
 		if (group.single) {
 			const item = group._items[0];
 
-			format.quantity = formatDecimal(item.position.snapshot.open, 2);
-			format.basisPrice = formatCurrency(item.data.basisPrice, currency);
+			actual.quantity = item.position.snapshot.open;
+			actual.basisPrice = item.data.basisPrice;
+
+			format.quantity = formatDecimal(actual.quantity, 2);
+			format.basisPrice = formatCurrency(actual.basisPrice, currency);
 		}
 	}
 
@@ -1575,6 +1599,8 @@ module.exports = (() => {
 			this._data.income = null;
 			this._data.basisPrice = null;
 
+			this._data.newsExists = false;
+
 			this._excluded = false;
 
 			calculateStaticData(this);
@@ -1582,6 +1608,7 @@ module.exports = (() => {
 
 			this._quoteChangedEvent = new Event(this);
 			this._excludedChangeEvent = new Event(this);
+			this._newsExistsChangedEvent = new Event(this);
 		}
 
 		get portfolio() {
@@ -1637,6 +1664,14 @@ module.exports = (() => {
 			}
 		}
 
+		setNewsArticleExists(value) {
+			assert.argumentIsRequired(value, 'value', Boolean);
+
+			if (this._data.newsExists !== value) {
+				this._newsExistsChangedEvent.fire(this._data.newsExists = value);
+			}
+		}
+
 		registerQuoteChangeHandler(handler) {
 			this._quoteChangedEvent.register(handler);
 		}
@@ -1645,6 +1680,10 @@ module.exports = (() => {
 			this._excludedChangeEvent.register(handler);
 		}
 
+		registerNewsExistsChangeHandler(handler) {
+			this._newsExistsChangedEvent.register(handler);
+		}
+
 		toString() {
 			return '[PositionItem]';
 		}