@bannynet/core-v6 0.0.43 → 0.0.45

package/README.md

@@ -1,6 +1,6 @@
 # Banny Retail
 
-Banny Retail is an onchain avatar system for Juicebox 721 collections. A body NFT can wear outfit NFTs, use a background NFT, and resolve to a base64 JSON token URI whose image is an onchain SVG.
+`@bannynet/core-v6` is the onchain avatar layer for Juicebox 721 collections. It defines how a body NFT wears outfit NFTs, uses a background NFT, and resolves to a base64 JSON token URI whose image is an onchain SVG.
 
 
 ## Documentation
@@ -13,7 +13,7 @@ Banny Retail is an onchain avatar system for Juicebox 721 collections. A body NF
 - [AUDIT_INSTRUCTIONS.md](./AUDIT_INSTRUCTIONS.md) — guidance for security reviewers
 - [SKILLS.md](./SKILLS.md) — repo-specific gotchas and integration notes
 - [STYLE_GUIDE.md](./STYLE_GUIDE.md) — coding and naming conventions
-- [CHANGELOG.md](./CHANGELOG.md) — notable changes
+- [CHANGELOG.md](./CHANGELOG.md) - V5 to V6 migration changelog
 
 ## Overview
 
@@ -28,13 +28,13 @@ The main user flows are:
 
 Use this repo when you need collection-specific, fully onchain metadata composition on top of Juicebox NFTs. Do not use it as a generic 721 hook. It is an app-layer resolver, not a protocol NFT primitive.
 
-## Key Contract
+## Key contract
 
 | Contract | Role |
 | --- | --- |
 | `Banny721TokenUriResolver` | Resolves metadata, stores equipped accessories, enforces outfit locks, and renders layered SVG output for Banny collections. |
 
-## Mental Model
+## Mental model
 
 This repo owns three things:
 
@@ -44,14 +44,14 @@ This repo owns three things:
 
 It does not own mint pricing, tier issuance, or treasury accounting.
 
-## Read These Files First
+## Read these files first
 
 1. `src/Banny721TokenUriResolver.sol`
 2. `test/DecorateFlow.t.sol`
 3. `test/OutfitTransferLifecycle.t.sol`
 4. `nana-721-hook-v6/src/JB721TiersHook.sol` for upstream mint and tier behavior
 
-## High-Signal Tests
+## High-signal tests
 
 1. `test/DecorateFlow.t.sol`
 2. `test/OutfitTransferLifecycle.t.sol`
@@ -59,7 +59,7 @@ It does not own mint pricing, tier issuance, or treasury accounting.
 4. `test/regression/TryTransferFromStrandsAssets.t.sol`
 5. `test/TestQALastMile.t.sol`
 
-## Integration Traps
+## Integration traps
 
 - the resolver holds equipped assets, so transfer edge cases matter as much as rendering output
 - transferred bodies carry their equipped assets, so a new body holder can inherit control of them
@@ -67,7 +67,7 @@ It does not own mint pricing, tier issuance, or treasury accounting.
 - outfit locks survive body transfers until expiry
 - metadata quality depends on lazily uploaded asset payloads, not only token state
 
-## Where State Lives
+## Where state lives
 
 - equipped outfit and background state live in `Banny721TokenUriResolver`
 - layer rendering and token URI generation live in the same resolver
@@ -96,11 +96,11 @@ Useful scripts:
 - `npm run deploy:mainnets:drop:1`
 - `npm run deploy:testnets:drop:1`
 
-## Deployment Notes
+## Deployment notes
 
 Deployments are handled through Sphinx using the environments configured in `script/Deploy.s.sol`. The resolver is meant to be plugged into a Juicebox 721 hook as that hook's token URI resolver.
 
-## Repository Layout
+## Repository layout
 
 ```text
 src/
@@ -115,7 +115,7 @@ script/
   helpers/
 ```
 
-## Risks And Notes
+## Risks and notes
 
 - attached outfits and backgrounds are held by the resolver while equipped
 - outfit locks are fixed-duration and cannot be shortened once set
@@ -123,7 +123,7 @@ script/
 - plain `transferFrom` can still create asset-tracking surprises around resolver custody
 - rendering quality depends on the integrity of uploaded SVG assets
 
-## For AI Agents
+## For AI agents
 
 - Treat this repo as an app-layer resolver, not as the NFT issuance primitive.
 - Start with `Banny721TokenUriResolver` and the lifecycle tests before summarizing attachment behavior.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bannynet/core-v6",
-  "version": "0.0.43",
+  "version": "0.0.45",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -19,7 +19,6 @@
   "scripts": {
     "test": "forge test",
     "coverage": "forge coverage --match-path \"./src/*.sol\" --report lcov --report summary",
-    "generate:migration": "node ./script/outfit_drop/generate-migration.js",
     "deploy:mainnets": "source ./.env && export START_TIME=$(date +%s) && npx sphinx propose ./script/Deploy.s.sol --networks mainnets",
     "deploy:testnets": "source ./.env && export START_TIME=$(date +%s) && npx sphinx propose ./script/Deploy.s.sol --networks testnets",
     "deploy:testnets:drop:1": "source ./.env && npx sphinx propose ./script/Drop1.s.sol --networks testnets",
@@ -27,18 +26,15 @@
     "artifacts": "source ./.env && npx sphinx artifacts --org-id 'ea165b21-7cdc-4d7b-be59-ecdd4c26bee4' --project-name 'banny-core-v6'"
   },
   "dependencies": {
-    "@bananapus/721-hook-v6": "^0.0.65",
-    "@bananapus/buyback-hook-v6": "^0.0.66",
-    "@bananapus/core-v6": "^0.0.78",
-    "@bananapus/router-terminal-v6": "^0.0.60",
-    "@bananapus/suckers-v6": "^0.0.67",
-    "@croptop/core-v6": "^0.0.64",
+    "@bananapus/721-hook-v6": "^0.0.69",
+    "@bananapus/buyback-hook-v6": "^0.0.69",
+    "@bananapus/core-v6": "^0.0.82",
+    "@bananapus/suckers-v6": "^0.0.72",
     "@openzeppelin/contracts": "5.6.1",
-    "@rev-net/core-v6": "^0.0.84",
-    "keccak": "3.0.4"
+    "@rev-net/core-v6": "^0.0.89"
   },
   "devDependencies": {
-    "@bananapus/address-registry-v6": "^0.0.32",
+    "@bananapus/address-registry-v6": "^0.0.34",
     "@sphinx-labs/plugins": "0.33.3"
   }
 }

package/references/operations.md

@@ -1,25 +1,25 @@
 # Banny Operations
 
-## Content and Deployment Surface
+## Content and deployment surface
 
 - [`script/Deploy.s.sol`](../script/Deploy.s.sol) is the main deployment entry point.
 - [`script/Drop1.s.sol`](../script/Drop1.s.sol) and [`script/Add.Denver.s.sol`](../script/Add.Denver.s.sol) are the first places to check when a problem is drop-specific rather than core resolver logic.
 - The resolver's metadata and SVG-content management functions live in [`src/Banny721TokenUriResolver.sol`](../src/Banny721TokenUriResolver.sol), not in separate admin helpers.
 
-## Change Checklist
+## Change checklist
 
 - If you edit decoration behavior, verify both attachment and return-to-owner paths.
 - If you edit SVG rendering, re-check default layer injection and non-body preview rendering.
 - If you edit content upload assumptions, verify hash registration and one-time content storage still match.
 - If you edit metadata fields, check whether the issue belongs in resolver config or in the upstream hook that points to the resolver.
 
-## Common Failure Modes
+## Common failure modes
 
 - Visible rendering issue is really stale or missing SVG content rather than code logic.
 - Resolver is blamed for minting or tier problems that actually live upstream in the 721 hook repo.
 - Attachment state looks inconsistent because a prior transfer or return failed and the resolver intentionally preserved safety over convenience.
 
-## Useful Proof Points
+## Useful proof points
 
 - [`test/BannyAttacks.t.sol`](../test/BannyAttacks.t.sol) and [`test/TestRegressionGaps.sol`](../test/TestRegressionGaps.sol) for security-sensitive assumptions.
 - [`script/Drop1.s.sol`](../script/Drop1.s.sol) and [`script/Add.Denver.s.sol`](../script/Add.Denver.s.sol) when a deployment issue is really a script/config problem.

package/references/runtime.md

@@ -1,10 +1,10 @@
 # Banny Runtime
 
-## Contract Role
+## Contract role
 
 - [`src/Banny721TokenUriResolver.sol`](../src/Banny721TokenUriResolver.sol) resolves token metadata, stores equipped outfits and backgrounds, enforces outfit locks, and composes layered SVG output for Banny collections.
 
-## Runtime Path
+## Runtime path
 
 1. The hook calls the resolver for `tokenURI`-style metadata.
 2. The resolver reads tier and ownership context from the upstream 721 hook.
@@ -12,14 +12,14 @@
 4. If the token is an outfit or background, it renders a preview-style representation instead.
 5. During decoration flows, the resolver takes custody of attached items and updates wearer/background mappings.
 
-## High-Risk Areas
+## High-risk areas
 
 - Attachment custody: equipped items are held by the resolver, so transfer and return behavior matters.
 - Outfit lock windows: lock duration is part of user-facing state and should not drift unexpectedly.
 - Rendering composition: layer ordering and default-item behavior affect visible output and must stay deterministic.
 - Stale attachment cleanup: views intentionally guard against inconsistent attachment state.
 
-## Tests To Trust First
+## Tests to trust first
 
 - [`test/DecorateFlow.t.sol`](../test/DecorateFlow.t.sol) for the main equip/unequip lifecycle.
 - [`test/OutfitTransferLifecycle.t.sol`](../test/OutfitTransferLifecycle.t.sol) for custody and return behavior.

package/src/Banny721TokenUriResolver.sol

@@ -35,30 +35,67 @@ contract Banny721TokenUriResolver is
     // --------------------------- custom errors ------------------------- //
     //*********************************************************************//
 
+    /// @notice Thrown when two array arguments that must correspond have differing lengths.
     error Banny721TokenUriResolver_ArrayLengthMismatch(uint256 firstLength, uint256 secondLength);
+
+    /// @notice Thrown when the token being decorated is not a banny body tier.
     error Banny721TokenUriResolver_BannyBodyNotBodyCategory(address hook, uint256 bannyBodyId, uint256 category);
+
+    /// @notice Thrown when re-locking a banny body would shorten its existing outfit-change lock.
     error Banny721TokenUriResolver_CantAccelerateTheLock(
         address hook, uint256 bannyBodyId, uint256 currentLockedUntil, uint256 newLockUntil
     );
+
+    /// @notice Thrown when SVG contents have already been stored for the product code.
     error Banny721TokenUriResolver_ContentsAlreadyStored(uint256 upc);
+
+    /// @notice Thrown when the provided SVG contents do not match the product code's precommitted hash.
     error Banny721TokenUriResolver_ContentsMismatch(uint256 upc, bytes32 expectedHash, bytes32 actualHash);
+
+    /// @notice Thrown when two outfits in the merged set share the same category.
     error Banny721TokenUriResolver_DuplicateCategory(uint256 category);
+
+    /// @notice Thrown when an SVG hash has already been stored for the product code.
     error Banny721TokenUriResolver_HashAlreadyStored(uint256 upc, bytes32 existingHash);
+
+    /// @notice Thrown when no SVG hash has been stored for the product code.
     error Banny721TokenUriResolver_HashNotFound(uint256 upc);
+
+    /// @notice Thrown when a full head and individual head pieces are equipped together.
     error Banny721TokenUriResolver_HeadAlreadyAdded(uint256 category);
+
+    /// @notice Thrown when outfit changes are attempted on a banny body whose lock has not yet expired.
     error Banny721TokenUriResolver_OutfitChangesLocked(address hook, uint256 bannyBodyId, uint256 lockedUntil);
+
+    /// @notice Thrown when a full suit and individual suit pieces are equipped together.
     error Banny721TokenUriResolver_SuitAlreadyAdded(uint256 category);
+
+    /// @notice Thrown when the caller is not authorized to use the background for decoration.
     error Banny721TokenUriResolver_UnauthorizedBackground(
         address hook, uint256 backgroundId, address sender, address owner
     );
+
+    /// @notice Thrown when the caller does not own the banny body.
     error Banny721TokenUriResolver_UnauthorizedBannyBody(
         address hook, uint256 bannyBodyId, address sender, address owner
     );
+
+    /// @notice Thrown when the caller is not authorized to use the outfit for decoration.
     error Banny721TokenUriResolver_UnauthorizedOutfit(address hook, uint256 outfitId, address sender, address owner);
+
+    /// @notice Thrown when an ERC-721 token is received through an operator other than this contract.
     error Banny721TokenUriResolver_UnauthorizedTransfer(address operator, address expectedOperator);
+
+    /// @notice Thrown when outfit categories are not supplied in strictly ascending order.
     error Banny721TokenUriResolver_UnorderedCategories(uint256 previousCategory, uint256 nextCategory);
+
+    /// @notice Thrown when the supplied background does not exist or is not a background-category tier.
     error Banny721TokenUriResolver_UnrecognizedBackground(address hook, uint256 backgroundId, uint256 category);
+
+    /// @notice Thrown when an outfit's category falls outside the recognized category range.
     error Banny721TokenUriResolver_UnrecognizedCategory(uint256 category);
+
+    /// @notice Thrown when no fills are defined for the product code.
     error Banny721TokenUriResolver_UnrecognizedProduct(uint256 upc);
 
     //*********************************************************************//
@@ -72,28 +109,50 @@ contract Banny721TokenUriResolver is
     /// @notice The duration that banny bodies can be locked for.
     uint256 private constant _LOCK_DURATION = 7 days;
 
+    /// @notice The tier category for banny bodies, the carrier NFT that wears the other layers.
     uint8 private constant _BODY_CATEGORY = 0;
+    /// @notice The tier category for backgrounds rendered behind the banny body.
     uint8 private constant _BACKGROUND_CATEGORY = 1;
+    /// @notice The tier category for backside accessories rendered behind the body.
     uint8 private constant _BACKSIDE_CATEGORY = 2;
+    /// @notice The tier category for necklace accessories.
     uint8 private constant _NECKLACE_CATEGORY = 3;
+    /// @notice The tier category for full-head accessories that cover the face.
     uint8 private constant _HEAD_CATEGORY = 4;
+    /// @notice The tier category for eye accessories.
     uint8 private constant _EYES_CATEGORY = 5;
+    /// @notice The tier category for glasses accessories.
     uint8 private constant _GLASSES_CATEGORY = 6;
+    /// @notice The tier category for mouth accessories.
     uint8 private constant _MOUTH_CATEGORY = 7;
+    /// @notice The tier category for legs accessories.
     uint8 private constant _LEGS_CATEGORY = 8;
+    /// @notice The tier category for full-suit accessories that cover the body.
     uint8 private constant _SUIT_CATEGORY = 9;
+    /// @notice The tier category for suit-bottom accessories.
     uint8 private constant _SUIT_BOTTOM_CATEGORY = 10;
+    /// @notice The tier category for suit-top accessories.
     uint8 private constant _SUIT_TOP_CATEGORY = 11;
+    /// @notice The tier category for headtop accessories worn above the head.
     uint8 private constant _HEADTOP_CATEGORY = 12;
+    /// @notice The tier category for hand accessories.
     uint8 private constant _HAND_CATEGORY = 13;
+    /// @notice The tier category for special suit accessories.
     uint8 private constant _SPECIAL_SUIT_CATEGORY = 14;
+    /// @notice The tier category for special legs accessories.
     uint8 private constant _SPECIAL_LEGS_CATEGORY = 15;
+    /// @notice The tier category for special head accessories.
     uint8 private constant _SPECIAL_HEAD_CATEGORY = 16;
+    /// @notice The tier category for special banny bodies.
     uint8 private constant _SPECIAL_BODY_CATEGORY = 17;
 
+    /// @notice The universal product code of the alien banny body.
     uint8 private constant ALIEN_UPC = 1;
+    /// @notice The universal product code of the pink banny body.
     uint8 private constant PINK_UPC = 2;
+    /// @notice The universal product code of the orange banny body.
     uint8 private constant ORANGE_UPC = 3;
+    /// @notice The universal product code of the original banny body.
     uint8 private constant ORIGINAL_UPC = 4;
 
     //*********************************************************************//
@@ -141,12 +200,11 @@ contract Banny721TokenUriResolver is
     /// @dev Naked Banny bodies are shown only with outfits currently owned by the body owner.
     /// @dev NOTE: Equipped outfits travel with the banny body NFT on transfer. When a body is transferred,
     /// the new owner inherits all equipped outfits and can unequip them to receive the outfit NFTs.
-    // The _attachedOutfitIdsOf array grows with each attachment. Gas cost for operations
-    // iterating this array increases linearly. In practice, Bannys have a small, bounded number of outfit slots
-    // (< 20), making gas cost manageable. No explicit cap is needed given the natural slot limit.
-    // This array may contain stale entries (e.g. outfits transferred away externally). Stale entries are
-    // filtered at read time via `outfitsOf` and `wearerOf`, which check current ownership/attachment status.
-    // This lazy reconciliation avoids extra storage writes on every transfer.
+    /// @dev The array grows with each attachment, so operations iterating it cost gas linearly. Bannys have a small,
+    /// bounded number of outfit slots (< 20), so no explicit cap is needed given the natural slot limit.
+    /// @dev The array may contain stale entries (e.g. outfits transferred away externally). Stale entries are
+    /// filtered at read time via `outfitsOf` and `wearerOf`, which check current ownership/attachment status. This
+    /// lazy reconciliation avoids extra storage writes on every transfer.
     /// @custom:param hook The hook address of the collection.
     /// @custom:param bannyBodyId The ID of the banny body of the outfits.
     mapping(address hook => mapping(uint256 bannyBodyId => uint256[])) internal _attachedOutfitIdsOf;
@@ -450,9 +508,7 @@ contract Banny721TokenUriResolver is
         );
     }
 
-    /// @notice Returns the SVG showing either a banny body with/without outfits and a background, or the stand alone
-    /// outfit
-    /// or background.
+    /// @notice Returns the SVG for a banny body, a standalone outfit, or a standalone background.
     /// @param hook The hook storing the assets.
     /// @param tokenId The ID of the token to show. If the ID belongs to a banny body, it will be shown with its
     /// current outfits in its current background if specified.
@@ -657,9 +713,9 @@ contract Banny721TokenUriResolver is
     }
 
     /// @notice Encode the token URI JSON with base64.
-    // Metadata strings (name, description, external_url) are set by the contract owner, not by users.
-    // No JSON escaping is applied — the owner is trusted to provide valid values. On-chain JSON is consumed
-    // by off-chain indexers and UIs, not rendered in a browser context where XSS would apply.
+    /// @dev Metadata strings (name, description, external_url) are set by the contract owner, not by users, and no
+    /// JSON escaping is applied because the owner is trusted to provide valid values. On-chain JSON is consumed by
+    /// off-chain indexers and UIs, not rendered in a browser context where XSS would apply.
     /// @param tokenId The ID of the token.
     /// @param product The tier product for the token.
     /// @param extraMetadata Additional JSON metadata fields to include.
@@ -1115,9 +1171,8 @@ contract Banny721TokenUriResolver is
     ///
     /// @dev WARNING: Equipped outfits and backgrounds are held by this contract on behalf of the banny body. When the
     /// banny body NFT is transferred to a new owner, all equipped assets remain associated with that body. The new
-    /// owner of the body effectively gains control of all equipped items — they can unequip them (receiving the
-    /// outfit
-    /// NFTs) or re-equip different items. Sellers should unequip valuable outfits before transferring a banny body.
+    /// owner of the body effectively gains control of all equipped items. They can unequip them, receiving the outfit
+    /// NFTs, or re-equip different items. Sellers should unequip valuable outfits before transferring a banny body.
     ///
     /// @param hook The hook storing the assets.
     /// @param bannyBodyId The ID of the banny body to dress.
@@ -1198,9 +1253,9 @@ contract Banny721TokenUriResolver is
 
     /// @notice Handles the receipt of an ERC-721 token, only accepting transfers initiated by this contract.
     /// @dev Make sure tokens can be received if the transaction was initiated by this contract.
-    // NFTs sent via transferFrom (not safeTransferFrom) bypass onERC721Received and cannot be
-    // tracked or recovered. This is an inherent ERC-721 limitation — the contract cannot prevent non-safe
-    // transfers. Users and UIs should always use safeTransferFrom.
+    /// @dev NFTs sent via transferFrom (not safeTransferFrom) bypass onERC721Received and cannot be tracked or
+    /// recovered. This is an inherent ERC-721 limitation — the contract cannot prevent non-safe transfers. Users and
+    /// UIs should always use safeTransferFrom.
     /// @param operator The address that initiated the transaction.
     /// @param from The address that initiated the transfer.
     /// @param tokenId The ID of the token to transfer.