@band-app/server 0.53.0 → 0.54.0

package/dist/start-server.mjs

@@ -54081,7 +54081,7 @@ import { lstatSync as lstatSync3, realpathSync as realpathSync4 } from "node:fs"
 import { platform } from "node:os";
 import { delimiter as delimiter3, join as join19, resolve as resolve4 } from "node:path";
 function findCliBinaryAt(opts) {
-  const { cwd, dirname: dirname17 } = opts;
+  const { cwd, dirname: dirname18 } = opts;
   const exe = platform() === "win32" ? "band.exe" : "band";
   const explicit = process.env.BAND_CLI_PATH;
   if (explicit) {
@@ -54097,7 +54097,7 @@ function findCliBinaryAt(opts) {
     // cwd = repo root (fallback)
     resolve4(cwd, "apps"),
     // From this source file in dev (packages/host-local/src/process/ → apps/)
-    resolve4(dirname17, "..", "..", "..", "..", "apps"),
+    resolve4(dirname18, "..", "..", "..", "..", "apps"),
     // From bundled `dist/` file (<Resources>/web/dist/ → <Resources>/) only
     // — in dev mode this resolves to `packages/`, which has no
     // `cli/target/<profile>/band` and is harmless; the walk above is the
@@ -54105,7 +54105,7 @@ function findCliBinaryAt(opts) {
     // layout under <Resources>/cli/ would still resolve. Today's Electron
     // bundle ships the binary under `binaries/` (handled by Strategy B),
     // so this strategy never hits in production either.
-    resolve4(dirname17, "..", "..", "..")
+    resolve4(dirname18, "..", "..", "..")
   ];
   for (const appsDir of appsStrategies) {
     for (const profile of ["release", "debug"]) {
@@ -54122,7 +54122,7 @@ function findCliBinaryAt(opts) {
     resolve4(cwd, "..", "binaries", exe),
     // From the bundled dist file (<Resources>/web/dist/start-server.mjs)
     // → <Resources>/binaries/band
-    resolve4(dirname17, "..", "..", "binaries", exe)
+    resolve4(dirname18, "..", "..", "binaries", exe)
   ];
   for (const p2 of electronCandidates) {
     try {
@@ -63153,10 +63153,10 @@ var init_agent_command = __esm({
 import { readdirSync as readdirSync8 } from "node:fs";
 import { mkdir as mkdir5 } from "node:fs/promises";
 import { join as join38 } from "node:path";
-async function openSharedDir(worktreeId4) {
+async function openSharedDir(worktreeId4, chatId) {
   const host = hostRegistry.hostFor(worktreeId4);
   if (host.id === hostRegistry.local.id) {
-    const path3 = join38(bandHome(), "shared", worktreeId4);
+    const path3 = join38(bandHome(), "shared", worktreeId4, chatId);
     await mkdir5(path3, { recursive: true });
     return {
       path: path3,
@@ -63171,7 +63171,7 @@ async function openSharedDir(worktreeId4) {
   }
   const dirs = (await host.info()).dirs;
   if (!dirs) throw new Error(`Worker ${host.id} has no directory for shared files`);
-  const path2 = join38(dirs.shared, worktreeId4);
+  const path2 = join38(dirs.shared, worktreeId4, chatId);
   await host.fs.mkdir(path2, { recursive: true });
   return {
     path: path2,
@@ -63192,6 +63192,25 @@ async function agentExtraDirs(worktreeId4) {
   const dirs = (await host.info()).dirs;
   return dirs ? [dirs.uploads, dirs.shared] : [];
 }
+function sharedFileUrl(worktreeId4, chatId, filename) {
+  return `/api/shared/${encodeURIComponent(worktreeId4)}/${encodeURIComponent(chatId)}/${encodeURIComponent(filename)}`;
+}
+function parseSharedPath(rest) {
+  const raw = rest.split("?")[0].split("/");
+  if (raw.length !== 2 && raw.length !== 3) return null;
+  const parts = [];
+  for (const segment of raw) {
+    let decoded;
+    try {
+      decoded = decodeURIComponent(segment);
+    } catch {
+      return null;
+    }
+    if (!decoded || decoded === "." || decoded === ".." || /[/\\\0]/.test(decoded)) return null;
+    parts.push(decoded);
+  }
+  return parts.length === 3 ? { worktreeId: parts[0], chatId: parts[1], name: parts[2] } : { worktreeId: parts[0], name: parts[1] };
+}
 var init_shared_dir = __esm({
   "src/server/services/_utils/shared-dir.ts"() {
     "use strict";
@@ -68229,7 +68248,7 @@ function turnUsage(res, ctx) {
   return { ...usage, model, costUsd: (previousCost ?? 0) + cost };
 }
 function sharedDirNote(sharedDir) {
-  return `[File sharing: to send a file to the user, write or copy it to ${sharedDir}/ and it will appear as a downloadable file card in the chat.]`;
+  return `[File sharing: to send a file to the user, write or copy it to ${sharedDir}/ and it will appear as a file card in this chat.]`;
 }
 function fileUri(path2) {
   return `file://${path2.split("/").map(encodeURIComponent).join("/")}`;
@@ -68729,6 +68748,8 @@ var init_session3 = __esm({
         this.misses = opts.heartbeatMisses ?? HEARTBEAT_MISSES;
         this.nextChan = opts.role === "client" ? 1 : 2;
       }
+      /** Close code and reason of the last socket that ended. Code 1006 means no close frame arrived. */
+      lastClose = null;
       get attached() {
         return this.ws !== null && this.ws.readyState === 1;
       }
@@ -68823,8 +68844,10 @@ var init_session3 = __esm({
         ws.on("message", (data, isBinary) => {
           if (this.ws === ws) this.onMessage(data, isBinary);
         });
-        ws.on("close", () => {
-          if (this.ws === ws) this.detach();
+        ws.on("close", (code, reason) => {
+          if (this.ws !== ws) return;
+          this.lastClose = { code, reason: reason.toString().slice(0, 200) };
+          this.detach();
         });
         ws.on("error", () => {
         });
@@ -68913,34 +68936,40 @@ var init_session3 = __esm({
           let frame;
           try {
             frame = decodeFrame(Buffer.isBuffer(data) ? data : Buffer.from(data));
-          } catch {
-            this.ws?.terminate();
+          } catch (err) {
+            this.cut("undecodable frame", err);
             return;
           }
           try {
             this.channels.get(frame.chan)?.handleFrame(frame);
-          } catch {
-            this.ws?.terminate();
+          } catch (err) {
+            this.cut(`channel ${frame.chan} failed to handle a frame`, err);
           }
           return;
         }
         let msg;
         try {
           msg = JSON.parse(data.toString());
-        } catch {
-          this.ws?.terminate();
+        } catch (err) {
+          this.cut("unparsable message", err);
           return;
         }
         if (msg === null || typeof msg !== "object") {
-          this.ws?.terminate();
+          this.cut("message is not an object");
           return;
         }
         try {
           this.dispatchText(msg);
-        } catch {
-          this.ws?.terminate();
+        } catch (err) {
+          this.cut("invalid message", err);
         }
       }
+      /** Drops the socket after a protocol violation, and says why, so the drop is not silent. */
+      cut(reason, err) {
+        const detail = err instanceof Error ? `: ${err.message}` : "";
+        this.emit("fault", `${reason}${detail}`);
+        this.ws?.terminate();
+      }
       dispatchText(msg) {
         if (typeof msg.method === "string") {
           if ("id" in msg && msg.id !== void 0 && msg.id !== null)
@@ -68965,14 +68994,32 @@ var init_session3 = __esm({
               throw new Error("malformed link.open");
             }
             if (this.channels.has(p2.chan) || this.tombstones.has(p2.chan)) return;
-            if (this.channels.size >= MAX_CHANNELS) throw new Error("too many channels");
+            if (this.channels.size >= MAX_CHANNELS) {
+              this.emit("fault", `refused channel ${p2.chan}: too many channels`);
+              this.writeBinary(
+                encodeFrame({
+                  chan: p2.chan,
+                  seq: 0,
+                  kind: "reset",
+                  payload: Buffer.from("too many channels")
+                })
+              );
+              return;
+            }
             const ch = new Channel(this, p2.chan, p2.name, p2.meta, this.window);
             this.channels.set(p2.chan, ch);
             this.emit("channel", ch);
             return;
           }
         }
-        this.notifyHandlers.get(msg.method)?.(msg.params);
+        try {
+          this.notifyHandlers.get(msg.method)?.(msg.params);
+        } catch (err) {
+          this.emit(
+            "fault",
+            `notification ${msg.method} handler threw: ${err instanceof Error ? err.message : String(err)}`
+          );
+        }
       }
       async onRequest(msg) {
         const handler = this.handlers.get(msg.method);
@@ -69324,7 +69371,8 @@ var init_server3 = __esm({
             resumed,
             wsPing: true
           });
-        } catch {
+        } catch (err) {
+          this.emit("fault", session, `attach failed: ${err instanceof Error ? err.message : err}`);
           ws.terminate();
           return;
         }
@@ -69341,6 +69389,7 @@ var init_server3 = __esm({
           this.expiry.set(session.workerId, t2);
         });
         session.on("lost", () => this.emit("lost", session));
+        session.on("fault", (reason) => this.emit("fault", session, reason));
       }
       dropSession(session, reason) {
         clearTimeout(this.expiry.get(session.workerId));
@@ -70413,7 +70462,7 @@ async function runTask(task) {
   }
   if (task.model) await applyTurnChoice(chatId, "model", task.model);
   if (task.mode) await applyTurnChoice(chatId, "mode", task.mode);
-  const shared2 = await openSharedDir(task.worktreeId);
+  const shared2 = await openSharedDir(task.worktreeId, chatId);
   const seenShared = new Set(await shared2.list());
   const announce = (names) => {
     for (const filename of names) {
@@ -70422,7 +70471,7 @@ async function runTask(task) {
       agentSessionService.record(chatId, {
         type: "file",
         mediaType: mimeTypeFromFilename(filename),
-        url: `/api/shared/${encodeURIComponent(task.worktreeId)}/${encodeURIComponent(filename)}`,
+        url: sharedFileUrl(task.worktreeId, chatId, filename),
         filename
       });
     }
@@ -75665,10 +75714,8 @@ var init_client_state_keys = __esm({
       perWorktree("band:dockview-layout-v9:", [jsonPart("device")]),
       // The `at` of the continuation the user has seen, which hides the sidebar clock icon.
       perWorktree("band:continued-seen:", [rawPart("device")]),
-      // The repo names the mobile app's worktree list has collapsed.
+      // The repo and group names the mobile app's worktree list has collapsed.
       exact("band.mobile.collapsed-repos", [jsonPart("device")]),
-      // How the mobile worktree list is grouped: repo, origin or host.
-      exact("band.mobile.group-by", [rawPart("device")]),
       // The group the mobile worktree list is filtered to (a group id; unset means All).
       exact("band.mobile.group-filter", [rawPart("device")])
     ];
@@ -75803,7 +75850,7 @@ var init_client_state_service = __esm({
         }
         const updatedAt = Date.now();
         const version3 = input2.baseVersion + 1;
-        const written = input2.baseVersion === 0 ? this.queries.insertIfAbsent({
+        let written = input2.baseVersion === 0 ? this.queries.insertIfAbsent({
           key: input2.key,
           scope: input2.scope,
           worktreeId: worktreeId4,
@@ -75815,6 +75862,16 @@ var init_client_state_service = __esm({
           version: version3,
           updatedAt
         });
+        if (!written && input2.baseVersion === 0) {
+          const current3 = this.queries.find(input2.key, input2.scope);
+          if (current3 && current3.value === null) {
+            written = this.queries.updateIfVersion(input2.key, input2.scope, current3.version, {
+              value,
+              version: current3.version + 1,
+              updatedAt
+            });
+          }
+        }
         const entry = this.queries.find(input2.key, input2.scope) ?? {
           key: input2.key,
           scope: input2.scope,
@@ -83233,7 +83290,7 @@ var init_agent_session_service = __esm({
         ownerGrants.delete(chatId);
         const grant = await worktree.host.relay?.issue({ worktreeId: chat.worktreeId, chatId });
         if (grant) ownerGrants.set(chatId, grant);
-        const shared2 = await openSharedDir(chat.worktreeId).catch(() => null);
+        const shared2 = await openSharedDir(chat.worktreeId, chatId).catch(() => null);
         const login = await agentLoginService.resolve({
           agentType: def.type,
           repo: worktree.repo.name,
@@ -90632,6 +90689,7 @@ import {
   existsSync as existsSync18,
   mkdirSync as mkdirSync11,
   readFileSync as readFileSync12,
+  realpathSync as realpathSync7,
   statSync as statSync16
 } from "node:fs";
 import { createServer as createServer3 } from "node:http";
@@ -111646,7 +111704,7 @@ init_registry();
 // package.json
 var package_default = {
   name: "@band-app/server",
-  version: "0.53.0",
+  version: "0.54.0",
   type: "module",
   types: "src/index.ts",
   exports: {
@@ -113002,9 +113060,18 @@ var WorkerLinkService = class {
     this.server = new LinkServer({ authenticate: (hello) => this.authenticate(hello) });
     this.server.on("session", (session) => this.onSession(session));
     this.server.on("connected", (session) => void this.onConnected(session));
+    this.server.on("disconnected", (session) => {
+      const close = session.lastClose;
+      if (close) {
+        log67.info(
+          `link of ${session.workerId} closed (code ${close.code}${close.reason ? `, ${close.reason}` : ""})`
+        );
+      }
+      this.setStatus(session.workerId, "offline", this.now());
+    });
     this.server.on(
-      "disconnected",
-      (session) => this.setStatus(session.workerId, "offline", this.now())
+      "fault",
+      (session, reason) => log67.warn(`link of ${session.workerId}: ${reason}`)
     );
     this.server.on(
       "lost",
@@ -124601,8 +124668,8 @@ init_webhook();
 
 // src/server/services/_utils/hosted-file.ts
 init_registry();
-import { basename as basename6, join as join58 } from "node:path";
-async function openHostedFile(kind, worktreeId4, rawName) {
+import { basename as basename6, dirname as dirname17, join as join58 } from "node:path";
+async function openHostedFile(kind, worktreeId4, rawName, chatId) {
   const host = hostRegistry.hostFor(worktreeId4);
   if (host.id === hostRegistry.local.id) return null;
   let name5;
@@ -124615,7 +124682,9 @@ async function openHostedFile(kind, worktreeId4, rawName) {
   try {
     const dirs = (await host.info()).dirs;
     if (!dirs) return null;
-    const path2 = join58(dirs[kind], worktreeId4, name5);
+    const path2 = chatId ? join58(dirs[kind], worktreeId4, chatId, name5) : join58(dirs[kind], worktreeId4, name5);
+    const dir = await host.fs.realpath(dirname17(path2));
+    if (!(await host.fs.realpath(path2)).startsWith(`${dir}/`)) return null;
     const stat7 = await host.fs.stat(path2, { followSymlinks: true });
     if (stat7.kind !== "file") return null;
     return { size: stat7.size, stream: host.fs.readStream(path2) };
@@ -132736,6 +132805,7 @@ async function listenWithFallback(server, startPort, attempts = 20) {
 }
 
 // start-server.ts
+init_shared_dir();
 init_agent_session_registry_service();
 init_branch_status_poller();
 init_browser_service();
@@ -133098,6 +133168,13 @@ function getCachedScalarHtml() {
   _scalarHtml = getScalarHtml("/api/openapi.json");
   return _scalarHtml;
 }
+function hostedFileHeaders(contentType) {
+  const headers = { "X-Content-Type-Options": "nosniff" };
+  if (/^(text\/html|image\/svg\+xml)\b/.test(contentType)) {
+    headers["Content-Security-Policy"] = "sandbox allow-scripts";
+  }
+  return headers;
+}
 function serveStaticFile(res, root, subdir, rawFilename) {
   const filename = basename7(decodeURIComponent(rawFilename));
   if (!filename || filename.includes("..")) {
@@ -133107,12 +133184,19 @@ function serveStaticFile(res, root, subdir, rawFilename) {
   }
   const filePath = join59(root, subdir, filename);
   try {
+    const dir = realpathSync7(join59(root, subdir));
+    if (!realpathSync7(filePath).startsWith(dir + sep10)) {
+      res.writeHead(404);
+      res.end("Not found");
+      return;
+    }
     const fileStat = statSync16(filePath);
     const contentType = mimeTypeFromFilename(filename);
     res.writeHead(200, {
       "Content-Type": contentType,
       "Content-Length": fileStat.size.toString(),
-      "Cache-Control": "private, max-age=86400"
+      "Cache-Control": "private, max-age=86400",
+      ...hostedFileHeaders(contentType)
     });
     createReadStream6(filePath).pipe(res);
   } catch {
@@ -133120,18 +133204,20 @@ function serveStaticFile(res, root, subdir, rawFilename) {
     res.end("Not found");
   }
 }
-async function serveHostedFile(res, kind, worktreeId4, rawName) {
+async function serveHostedFile(res, kind, worktreeId4, rawName, chatId) {
   if (hostRegistry.hostFor(worktreeId4).id === hostRegistry.local.id) return false;
-  const file3 = await openHostedFile(kind, worktreeId4, rawName);
+  const file3 = await openHostedFile(kind, worktreeId4, rawName, chatId);
   if (!file3) {
     res.writeHead(404);
     res.end("Not found");
     return true;
   }
+  const contentType = mimeTypeFromFilename(basename7(decodeURIComponent(rawName)));
   res.writeHead(200, {
-    "Content-Type": mimeTypeFromFilename(basename7(decodeURIComponent(rawName))),
+    "Content-Type": contentType,
     "Content-Length": file3.size.toString(),
-    "Cache-Control": "private, max-age=86400"
+    "Cache-Control": "private, max-age=86400",
+    ...hostedFileHeaders(contentType)
   });
   pipeline2(
     Readable2.from(file3.stream, { objectMode: false, highWaterMark: 64 * 1024 }),
@@ -133559,21 +133645,17 @@ async function main() {
       return;
     }
     if (req.url?.startsWith("/api/shared/")) {
-      const rest = req.url.slice("/api/shared/".length).split("?")[0];
-      const slashIdx = rest.indexOf("/");
-      if (slashIdx === -1) {
+      const parsed = parseSharedPath(req.url.slice("/api/shared/".length));
+      if (!parsed) {
         res.writeHead(400);
         res.end("Bad request");
         return;
       }
-      const partition = basename7(decodeURIComponent(rest.slice(0, slashIdx)));
-      if (!partition || partition === ".." || partition === ".") {
-        res.writeHead(400);
-        res.end("Bad request");
+      const encodedName = encodeURIComponent(parsed.name);
+      if (await serveHostedFile(res, "shared", parsed.worktreeId, encodedName, parsed.chatId))
         return;
-      }
-      if (await serveHostedFile(res, "shared", partition, rest.slice(slashIdx + 1))) return;
-      serveStaticFile(res, bandHome(), join59("shared", partition), rest.slice(slashIdx + 1));
+      const subdir = parsed.chatId ? join59("shared", parsed.worktreeId, parsed.chatId) : join59("shared", parsed.worktreeId);
+      serveStaticFile(res, bandHome(), subdir, encodedName);
       return;
     }
     if (req.url?.startsWith("/api/worktree-file/")) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@band-app/server",
-  "version": "0.53.0",
+  "version": "0.54.0",
   "type": "module",
   "types": "src/index.ts",
   "exports": {
@@ -57,18 +57,18 @@
     "vitest": "^4.0.18",
     "ws": "^8.18.0",
     "zod": "^3.25.67",
-    "@band-app/coding-agent": "^0.53.0",
+    "@band-app/coding-agent": "^0.54.0",
+    "@band-app/host-api": "^0.1.0",
+    "@band-app/chat-runtime": "^0.1.0",
     "@band-app/environment": "^0.1.0",
     "@band-app/host-local": "^0.1.0",
     "@band-app/host-remote": "^0.1.0",
-    "@band-app/chat-runtime": "^0.1.0",
-    "@band-app/host-api": "^0.1.0",
-    "@band-app/logger": "^0.53.0",
-    "@band-app/plugin-api": "^0.1.0",
+    "@band-app/link": "^0.1.0",
     "@band-app/plugin-github": "^0.1.0",
+    "@band-app/plugin-api": "^0.1.0",
     "@band-app/shared": "^0.1.0",
     "@band-app/worktree-ops": "^0.1.0",
-    "@band-app/link": "^0.1.0"
+    "@band-app/logger": "^0.54.0"
   },
   "scripts": {
     "dev": "NODE_ENV=development tsx watch --exclude '../web/**' start-server.ts",

package/dist/client/assets/channel-DO7Rw5s3.js

@@ -1 +0,0 @@
-import{Y as a,Z as n}from"./main-Bgor0kVJ.js";const t=(r,o)=>a.lang.round(n.parse(r)[o]);export{t as c};

package/dist/client/assets/classDiagram-2ON5EDUG-Dydmjn5K.js

@@ -1 +0,0 @@
-import{s as a,c as s,a as e,C as t}from"./chunk-B4BG7PRW-CRx24wmo.js";import{_ as i}from"./main-Bgor0kVJ.js";import"./chunk-FMBD7UC4-CFQ4Ns-B.js";import"./chunk-55IACEB6-CZirdcYj.js";import"./chunk-QN33PNHL-O1rjaqXm.js";var p={parser:e,get db(){return new t},renderer:s,styles:a,init:i(r=>{r.class||(r.class={}),r.class.arrowMarkerAbsolute=r.arrowMarkerAbsolute},"init")};export{p as diagram};

package/dist/client/assets/classDiagram-v2-WZHVMYZB-Dydmjn5K.js

@@ -1 +0,0 @@
-import{s as a,c as s,a as e,C as t}from"./chunk-B4BG7PRW-CRx24wmo.js";import{_ as i}from"./main-Bgor0kVJ.js";import"./chunk-FMBD7UC4-CFQ4Ns-B.js";import"./chunk-55IACEB6-CZirdcYj.js";import"./chunk-QN33PNHL-O1rjaqXm.js";var p={parser:e,get db(){return new t},renderer:s,styles:a,init:i(r=>{r.class||(r.class={}),r.class.arrowMarkerAbsolute=r.arrowMarkerAbsolute},"init")};export{p as diagram};

package/dist/client/assets/clone-BBqOdmdW.js

@@ -1 +0,0 @@
-import{b as r}from"./_baseUniq-BH8BhmRB.js";var e=4;function a(o){return r(o,e)}export{a as c};