@bananapus/univ4-lp-split-hook-v6 0.0.4 → 0.0.5

package/SKILLS.md

@@ -8,7 +8,7 @@ Juicebox reserved-token split hook that accumulates project tokens, deploys a Un
 
 | Contract | Role |
 |----------|------|
-| `UniV4DeploymentSplitHook` | Core split hook. Implements `IJBSplitHook.processSplitWith` to accumulate or burn tokens. Manages V4 pool creation, LP position minting, fee collection, and liquidity rebalancing. Inherits `JBPermissioned`, `Ownable`. Deployed as clones via factory. |
+| `UniV4DeploymentSplitHook` | Core split hook. Implements `IJBSplitHook.processSplitWith` to accumulate or burn tokens. Manages V4 pool creation, LP position minting, fee collection, and liquidity rebalancing. Inherits `JBPermissioned`. Deployed as clones via factory. |
 | `UniV4DeploymentSplitHookDeployer` | Factory that deploys hook clones via `LibClone` (Solady). Supports CREATE2 deterministic deployment. Initializes clones with `feeProjectId` and `feePercent`. Registers each deployed clone in `JBAddressRegistry` so frontends can verify the deployer. |
 
 ## Key Functions
@@ -71,7 +71,7 @@ Juicebox reserved-token split hook that accumulates project tokens, deploys a Un
 | `@bananapus/permission-ids-v6` | `JBPermissionIds` | `SET_BUYBACK_POOL` permission ID |
 | `@uniswap/v4-core` | `IPoolManager`, `PoolKey`, `PoolId`, `Currency`, `TickMath`, `IHooks` | V4 pool creation, price math, currency handling |
 | `@uniswap/v4-periphery` | `IPositionManager`, `Actions`, `LiquidityAmounts` | V4 position management: mint, modify, burn, collect |
-| `@openzeppelin/contracts` | `IERC20`, `IERC20Metadata`, `SafeERC20`, `Ownable` | Token operations, ownership |
+| `@openzeppelin/contracts` | `IERC20`, `IERC20Metadata`, `SafeERC20` | Token operations |
 | `@prb/math` | `mulDiv`, `sqrt` | Overflow-safe arithmetic for sqrtPriceX96 calculations |
 | `@bananapus/address-registry-v6` | `IJBAddressRegistry` | On-chain registry mapping deployed hooks to their deployer contract |
 | `solady` | `LibClone` | Clone factory for deploying hook instances |
@@ -107,7 +107,7 @@ Juicebox reserved-token split hook that accumulates project tokens, deploys a Un
 | `UniV4DeploymentSplitHook_InvalidFeePercent` | `feePercent > BPS` (> 100%) |
 | `UniV4DeploymentSplitHook_InvalidTerminalToken` | No primary terminal found for project/token pair |
 | `UniV4DeploymentSplitHook_PoolAlreadyDeployed` | `deployPool` called for a pair that already has a position |
-| `UniV4DeploymentSplitHook_AlreadyInitialized` | `initialize` called on a clone that was already initialized (uses explicit `initialized` flag, safe against `renounceOwnership` re-init) |
+| `UniV4DeploymentSplitHook_AlreadyInitialized` | `initialize` called on a clone that was already initialized |
 | `UniV4DeploymentSplitHook_FeePercentWithoutFeeProject` | `initialize` called with `feePercent > 0` but `feeProjectId == 0` (fees would get stuck since `primaryTerminalOf(0, token)` returns `address(0)`) |
 
 ## Constants
@@ -127,7 +127,7 @@ Juicebox reserved-token split hook that accumulates project tokens, deploys a Un
 | `accumulatedProjectTokens` | `projectId => uint256` | Pre-deployment token accumulation |
 | `projectDeployed` | `projectId => bool` | Switches accumulate (Stage 1) to burn (Stage 2) |
 | `claimableFeeTokens` | `projectId => uint256` | Fee-project tokens claimable via `claimFeeTokensFor` |
-| `initialized` | `bool` | Prevents re-initialization after `renounceOwnership()` (explicit flag instead of relying on `owner() == address(0)`) |
+| `initialized` | `bool` | Prevents re-initialization of clone instances |
 
 ## Gotchas
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bananapus/univ4-lp-split-hook-v6",
-  "version": "0.0.4",
+  "version": "0.0.5",
   "license": "MIT",
   "repository": {
     "type": "git",

package/src/UniV4DeploymentSplitHook.sol

@@ -19,7 +19,6 @@ import {JBConstants} from "@bananapus/core/libraries/JBConstants.sol";
 import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import {IERC20Metadata} from "@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol";
 import {SafeERC20} from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
-import {Ownable} from "@openzeppelin/contracts/access/Ownable.sol";
 import {mulDiv, sqrt} from "@prb/math/src/Common.sol";
 import {PoolKey} from "@uniswap/v4-core/src/types/PoolKey.sol";
 import {PoolId, PoolIdLibrary} from "@uniswap/v4-core/src/types/PoolId.sol";
@@ -52,7 +51,7 @@ import {IUniV4DeploymentSplitHook} from "./interfaces/IUniV4DeploymentSplitHook.
  * @dev For any given Uniswap V4 pool, the contract will control a single LP position.
  * @dev Pool deployment requires SET_BUYBACK_POOL permission from the project owner.
  */
-contract UniV4DeploymentSplitHook is IUniV4DeploymentSplitHook, IJBSplitHook, JBPermissioned, Ownable {
+contract UniV4DeploymentSplitHook is IUniV4DeploymentSplitHook, IJBSplitHook, JBPermissioned {
     using JBRulesetMetadataResolver for JBRuleset;
     using SafeERC20 for IERC20;
     using PoolIdLibrary for PoolKey;
@@ -129,7 +128,7 @@ contract UniV4DeploymentSplitHook is IUniV4DeploymentSplitHook, IJBSplitHook, JB
     /// @notice ProjectID => Fee tokens claimable by that project
     mapping(uint256 projectId => uint256 claimableFeeTokens) public claimableFeeTokens;
 
-    /// @notice Whether this clone instance has been initialized (prevents re-initialization after renounceOwnership).
+    /// @notice Whether this clone instance has been initialized.
     bool public initialized;
 
     //*********************************************************************//
@@ -149,7 +148,6 @@ contract UniV4DeploymentSplitHook is IUniV4DeploymentSplitHook, IJBSplitHook, JB
         IPositionManager positionManager
     )
         JBPermissioned(permissions)
-        Ownable(msg.sender)
     {
         if (directory == address(0)) revert UniV4DeploymentSplitHook_ZeroAddressNotAllowed();
         if (tokens == address(0)) revert UniV4DeploymentSplitHook_ZeroAddressNotAllowed();
@@ -163,12 +161,9 @@ contract UniV4DeploymentSplitHook is IUniV4DeploymentSplitHook, IJBSplitHook, JB
     }
 
     /// @notice Initialize per-instance config on a clone. Can only be called once.
-    /// @dev Uses an explicit `initialized` flag rather than relying on owner() == address(0),
-    ///      which would allow re-initialization after renounceOwnership().
-    /// @param initialOwner The owner of this clone instance.
     /// @param feeProjectId Project ID to receive LP fees.
     /// @param feePercent Percentage of LP fees to route to fee project (in basis points, e.g., 3800 = 38%).
-    function initialize(address initialOwner, uint256 feeProjectId, uint256 feePercent) external {
+    function initialize(uint256 feeProjectId, uint256 feePercent) external {
         if (initialized) revert UniV4DeploymentSplitHook_AlreadyInitialized();
 
         if (feePercent > BPS) revert UniV4DeploymentSplitHook_InvalidFeePercent();
@@ -185,8 +180,6 @@ contract UniV4DeploymentSplitHook is IUniV4DeploymentSplitHook, IJBSplitHook, JB
         initialized = true;
         FEE_PROJECT_ID = feeProjectId;
         FEE_PERCENT = feePercent;
-
-        _transferOwnership(initialOwner);
     }
 
     /// @notice Accept ETH transfers (needed for cashOut with native ETH and V4 TAKE operations).

package/src/UniV4DeploymentSplitHookDeployer.sol

@@ -66,7 +66,7 @@ contract UniV4DeploymentSplitHookDeployer is IUniV4DeploymentSplitHookDeployer {
                 })
         );
 
-        IUniV4DeploymentSplitHook(address(hook)).initialize(msg.sender, feeProjectId, feePercent);
+        IUniV4DeploymentSplitHook(address(hook)).initialize(feeProjectId, feePercent);
 
         emit HookDeployed(feeProjectId, feePercent, hook, msg.sender);
 

package/src/interfaces/IUniV4DeploymentSplitHook.sol

@@ -35,11 +35,10 @@ interface IUniV4DeploymentSplitHook {
 
     /**
      * @notice Initialize per-instance config on a clone.
-     * @param initialOwner The owner of this clone instance.
      * @param feeProjectId Project ID to receive LP fees.
      * @param feePercent Percentage of LP fees to route to fee project (in basis points).
      */
-    function initialize(address initialOwner, uint256 feeProjectId, uint256 feePercent) external;
+    function initialize(uint256 feeProjectId, uint256 feePercent) external;
 
     /**
      * @notice Check if a pool has been deployed for a project/terminal token pair

package/test/ConstructorTest.t.sol

@@ -25,11 +25,10 @@ contract ConstructorTest is LPSplitHookV4TestBase {
         assertEq(address(hook.POSITION_MANAGER()), address(positionManager), "POSITION_MANAGER mismatch");
     }
 
-    /// @notice Verify initialize() sets per-clone config (owner, feeProjectId, feePercent).
+    /// @notice Verify initialize() sets per-clone config (feeProjectId, feePercent).
     function test_Initialize_SetsCloneConfig() public view {
         assertEq(hook.FEE_PROJECT_ID(), FEE_PROJECT_ID, "FEE_PROJECT_ID mismatch");
         assertEq(hook.FEE_PERCENT(), FEE_PERCENT, "FEE_PERCENT mismatch");
-        assertEq(hook.owner(), owner, "owner mismatch");
     }
 
     /// @notice Constructor reverts when directory is address(0).
@@ -94,11 +93,9 @@ contract ConstructorTest is LPSplitHookV4TestBase {
             IPoolManager(address(1)),
             IPositionManager(address(positionManager))
         );
-        // Zero out slot 0 (owner) so initialize() can be called
-        vm.store(address(impl), bytes32(uint256(0)), bytes32(0));
 
         vm.expectRevert(UniV4DeploymentSplitHook.UniV4DeploymentSplitHook_InvalidFeePercent.selector);
-        impl.initialize(owner, FEE_PROJECT_ID, 10_001);
+        impl.initialize(FEE_PROJECT_ID, 10_001);
     }
 
     /// @notice initialize() reverts when feeProjectId is 0 but feePercent > 0 (L-25 fix).
@@ -111,11 +108,9 @@ contract ConstructorTest is LPSplitHookV4TestBase {
             IPoolManager(address(1)),
             IPositionManager(address(positionManager))
         );
-        // Zero out slot 0 (owner) so initialize() can be called
-        vm.store(address(impl), bytes32(uint256(0)), bytes32(0));
 
         vm.expectRevert(UniV4DeploymentSplitHook.UniV4DeploymentSplitHook_FeePercentWithoutFeeProject.selector);
-        impl.initialize(owner, 0, FEE_PERCENT);
+        impl.initialize(0, FEE_PERCENT);
     }
 
     /// @notice When both feeProjectId and feePercent are 0, initialize() succeeds (no fees configured).
@@ -128,14 +123,11 @@ contract ConstructorTest is LPSplitHookV4TestBase {
             IPoolManager(address(1)),
             IPositionManager(address(positionManager))
         );
-        // Zero out slot 0 (owner) so initialize() can be called
-        vm.store(address(impl), bytes32(uint256(0)), bytes32(0));
 
-        impl.initialize(owner, 0, 0);
+        impl.initialize(0, 0);
 
         assertEq(impl.FEE_PROJECT_ID(), 0, "FEE_PROJECT_ID should be 0");
         assertEq(impl.FEE_PERCENT(), 0, "FEE_PERCENT should be 0");
-        assertEq(impl.owner(), owner, "owner mismatch");
     }
 
     /// @notice Calling initialize() a second time reverts with AlreadyInitialized.
@@ -148,14 +140,12 @@ contract ConstructorTest is LPSplitHookV4TestBase {
             IPoolManager(address(1)),
             IPositionManager(address(positionManager))
         );
-        // Zero out slot 0 (owner) so initialize() can be called
-        vm.store(address(impl), bytes32(uint256(0)), bytes32(0));
 
         // First init succeeds
-        impl.initialize(owner, FEE_PROJECT_ID, FEE_PERCENT);
+        impl.initialize(FEE_PROJECT_ID, FEE_PERCENT);
 
         // Second init reverts
         vm.expectRevert(UniV4DeploymentSplitHook.UniV4DeploymentSplitHook_AlreadyInitialized.selector);
-        impl.initialize(owner, FEE_PROJECT_ID, FEE_PERCENT);
+        impl.initialize(FEE_PROJECT_ID, FEE_PERCENT);
     }
 }

package/test/DeployerTest.t.sol

@@ -99,7 +99,6 @@ contract DeployerTest is Test {
         IUniV4DeploymentSplitHook hook = deployer.deployHookFor(FEE_PROJECT_ID, FEE_PERCENT, bytes32(0));
 
         UniV4DeploymentSplitHook concreteHook = UniV4DeploymentSplitHook(payable(address(hook)));
-        assertEq(concreteHook.owner(), caller, "owner not set");
         assertEq(concreteHook.FEE_PROJECT_ID(), FEE_PROJECT_ID, "feeProjectId not set");
         assertEq(concreteHook.FEE_PERCENT(), FEE_PERCENT, "feePercent not set");
     }

package/test/NativeETHTest.t.sol

@@ -43,8 +43,7 @@ contract NativeETHTest is LPSplitHookV4TestBase {
             IPoolManager(address(1)),
             IPositionManager(address(positionManager))
         );
-        vm.store(address(testableHook), bytes32(uint256(0)), bytes32(0));
-        testableHook.initialize(owner, FEE_PROJECT_ID, FEE_PERCENT);
+        testableHook.initialize(FEE_PROJECT_ID, FEE_PERCENT);
     }
 
     // -----------------------------------------------------------------------

package/test/PriceMathTest.t.sol

@@ -137,8 +137,7 @@ contract PriceMathTest is LPSplitHookV4TestBase {
             IPoolManager(address(1)),
             IPositionManager(address(positionManager))
         );
-        vm.store(address(testableHook), bytes32(uint256(0)), bytes32(0));
-        testableHook.initialize(owner, FEE_PROJECT_ID, FEE_PERCENT);
+        testableHook.initialize(FEE_PROJECT_ID, FEE_PERCENT);
     }
 
     // ─────────────────────────────────────────────────────────────────────

package/test/TestBaseV4.sol

@@ -142,7 +142,7 @@ contract LPSplitHookV4TestBase is Test {
             IPositionManager(address(positionManager))
         );
         hook = UniV4DeploymentSplitHook(payable(LibClone.clone(address(hookImpl))));
-        hook.initialize(owner, FEE_PROJECT_ID, FEE_PERCENT);
+        hook.initialize(FEE_PROJECT_ID, FEE_PERCENT);
     }
 
     // ─── Directory Helpers (write to fallback-based mock) ───────────────

package/test/regression/L25_FeeProjectIdValidation.t.sol

@@ -53,18 +53,17 @@ contract L25_FeeProjectIdValidationTest is Test {
         UniV4DeploymentSplitHook clone = UniV4DeploymentSplitHook(payable(LibClone.clone(address(hookImpl))));
 
         vm.expectRevert(UniV4DeploymentSplitHook.UniV4DeploymentSplitHook_FeePercentWithoutFeeProject.selector);
-        clone.initialize(address(this), 0, 3800); // feeProjectId=0, feePercent=38%
+        clone.initialize(0, 3800); // feeProjectId=0, feePercent=38%
     }
 
     /// @notice initialize succeeds when feePercent == 0 and feeProjectId == 0 (no fees configured).
     function test_initialize_succeeds_zero_feePercent_zero_feeProjectId() public {
         UniV4DeploymentSplitHook clone = UniV4DeploymentSplitHook(payable(LibClone.clone(address(hookImpl))));
 
-        clone.initialize(address(this), 0, 0); // both zero is fine
+        clone.initialize(0, 0); // both zero is fine
 
         assertEq(clone.FEE_PERCENT(), 0);
         assertEq(clone.FEE_PROJECT_ID(), 0);
-        assertEq(clone.owner(), address(this));
     }
 
     /// @notice initialize succeeds when feePercent > 0 and feeProjectId != 0 (valid fee config).
@@ -75,10 +74,9 @@ contract L25_FeeProjectIdValidationTest is Test {
 
         UniV4DeploymentSplitHook clone = UniV4DeploymentSplitHook(payable(LibClone.clone(address(hookImpl))));
 
-        clone.initialize(address(this), 2, 3800); // feeProjectId=2, feePercent=38%
+        clone.initialize(2, 3800); // feeProjectId=2, feePercent=38%
 
         assertEq(clone.FEE_PERCENT(), 3800);
         assertEq(clone.FEE_PROJECT_ID(), 2);
-        assertEq(clone.owner(), address(this));
     }
 }

package/test/regression/M32_ReinitAfterRenounce.t.sol

@@ -21,10 +21,8 @@ import {
     MockJBPermissions
 } from "../mock/MockJBContracts.sol";
 
-/// @notice Regression test for M-32: Re-initialization after renounceOwnership.
-/// @dev After renounceOwnership() sets owner to address(0), the old owner() != address(0) check
-///      in initialize() would pass again, allowing an attacker to re-initialize with malicious
-///      fee parameters. The fix uses an explicit `initialized` boolean.
+/// @notice Regression test for M-32: Re-initialization protection.
+/// @dev The `initialized` boolean prevents calling initialize() more than once.
 contract M32_ReinitAfterRenounceTest is Test {
     UniV4DeploymentSplitHook public hookImpl;
     UniV4DeploymentSplitHook public hook;
@@ -34,11 +32,9 @@ contract M32_ReinitAfterRenounceTest is Test {
     MockJBPermissions public permissions;
     MockPositionManager public positionManager;
 
-    address public owner;
     address public attacker;
 
     function setUp() public {
-        owner = makeAddr("owner");
         attacker = makeAddr("attacker");
 
         directory = new MockJBDirectory();
@@ -61,38 +57,29 @@ contract M32_ReinitAfterRenounceTest is Test {
 
         // Clone and initialize
         hook = UniV4DeploymentSplitHook(payable(LibClone.clone(address(hookImpl))));
-        hook.initialize(owner, 2, 3800); // feeProjectId=2, feePercent=38%
+        hook.initialize(2, 3800); // feeProjectId=2, feePercent=38%
     }
 
-    /// @notice After renounceOwnership, re-initialization should still revert.
-    function test_reinitialize_after_renounce_reverts() public {
-        // Verify initial state
-        assertEq(hook.owner(), owner);
+    /// @notice Re-initialization should revert.
+    function test_reinitialize_reverts() public {
         assertEq(hook.FEE_PROJECT_ID(), 2);
         assertEq(hook.FEE_PERCENT(), 3800);
         assertTrue(hook.initialized());
 
-        // Owner renounces ownership
-        vm.prank(owner);
-        hook.renounceOwnership();
-
-        // owner() is now address(0)
-        assertEq(hook.owner(), address(0));
-
         // Attacker tries to re-initialize with malicious parameters
         vm.prank(attacker);
         vm.expectRevert(UniV4DeploymentSplitHook.UniV4DeploymentSplitHook_AlreadyInitialized.selector);
-        hook.initialize(attacker, 2, 10_000); // trying to set 100% fee
+        hook.initialize(2, 10_000); // trying to set 100% fee
     }
 
     /// @notice The `initialized` flag is set to true after first initialization.
-    function test_initialized_flag_set() public {
+    function test_initialized_flag_set() public view {
         assertTrue(hook.initialized(), "initialized should be true after initialize()");
     }
 
-    /// @notice Double initialization (without renounce) also still reverts.
+    /// @notice Double initialization also still reverts.
     function test_double_init_reverts() public {
         vm.expectRevert(UniV4DeploymentSplitHook.UniV4DeploymentSplitHook_AlreadyInitialized.selector);
-        hook.initialize(attacker, 2, 5000);
+        hook.initialize(2, 5000);
     }
 }