@bananapus/suckers-v6 0.0.41 → 0.0.42

package/foundry.toml

@@ -1,5 +1,6 @@
 [profile.default]
 solc = '0.8.28'
+bytecode_hash = "none"
 evm_version = 'cancun'
 optimizer_runs = 200
 libs = ["node_modules", "lib"]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bananapus/suckers-v6",
-  "version": "0.0.41",
+  "version": "0.0.42",
   "license": "MIT",
   "repository": {
     "type": "git",

package/src/JBSwapCCIPSucker.sol

@@ -309,6 +309,14 @@ contract JBSwapCCIPSucker is JBCCIPSucker, IUnlockCallback, IUniswapV3SwapCallba
                             delivered: deliveredToken, expected: address(BRIDGE_TOKEN)
                         });
                     }
+                    // Zero delivery alongside a positive root is structurally indistinguishable from
+                    // "no delivery + positive root" — both leave the local sucker with nothing to back
+                    // the leaves the root advertises. Reject so a peer cannot mint a claimable rate
+                    // that records `leafTotal=N, localTotal=0` and lets later claims withdraw against
+                    // unrelated balance.
+                    if (leafTotal > 0 && deliveredAmount == 0) {
+                        revert JBSwapCCIPSucker_PositiveRootWithoutDelivery(leafTotal);
+                    }
                 }
             }
 

package/src/libraries/JBSwapPoolLib.sol

@@ -51,6 +51,7 @@ library JBSwapPoolLib {
     error JBSwapPoolLib_InsufficientTwapHistory(address pool, uint256 availableWindow, uint256 requiredWindow);
     error JBSwapPoolLib_NoLiquidity(address pool, PoolId poolId);
     error JBSwapPoolLib_NoPool(address tokenIn, address tokenOut);
+    error JBSwapPoolLib_PartialFill(uint256 consumed, uint256 requested);
     error JBSwapPoolLib_SlippageExceeded(uint256 amountOut, uint256 minAmountOut);
 
     //*********************************************************************//
@@ -989,6 +990,18 @@ library JBSwapPoolLib {
             data: abi.encode(originalTokenIn, normalizedTokenIn, normalizedTokenOut)
         });
 
+        // Reject partial fills: when the V3 pool's price limit is hit before the full input is
+        // consumed, the pool returns only the consumed portion of `amount` and the caller is left
+        // holding the unconsumed remainder. The sucker's accounting assumes the full bridge amount
+        // was either swapped or made retryable, so a silent partial fill strands input tokens and
+        // breaks cross-chain solvency. Revert so the caller can either retry with a smaller size
+        // or wait for liquidity to return.
+        // forge-lint: disable-next-line(unsafe-typecast)
+        uint256 consumedAmount = uint256(zeroForOne ? amount0 : amount1);
+        if (consumedAmount < amount) {
+            revert JBSwapPoolLib_PartialFill({consumed: consumedAmount, requested: amount});
+        }
+
         // Extract the output amount from the signed delta (negative = tokens received).
         amountOut = uint256(-(zeroForOne ? amount1 : amount0));