@bananapus/omnichain-deployers-v6 0.0.19 → 0.0.21

package/test/OmnichainDeployerEdgeCases.t.sol

@@ -614,11 +614,20 @@ contract OmnichainDeployerEdgeCases is Test {
             abi.encode(uint256(50)) // A past ruleset ID — no hook stored at this ID
         );
 
+        // Mock currentOf to return a ruleset with id=50 (no hook stored for this id via the deployer).
+        JBRuleset memory currentRuleset;
+        currentRuleset.id = uint48(50);
+        vm.mockCall(
+            address(rulesets),
+            abi.encodeWithSelector(IJBRulesets.currentOf.selector, projectId),
+            abi.encode(currentRuleset)
+        );
+
         JBRulesetConfig[] memory configs = new JBRulesetConfig[](1);
         configs[0] = _makeRulesetConfig(address(0), true, false);
 
         // Empty 721 config — no tiers, so it tries to carry forward an existing hook.
-        // But no hook was stored for rulesetId=1 via this deployer.
+        // But no hook was stored for rulesetId=50 via this deployer.
         JBOmnichain721Config memory empty721Config;
         vm.prank(projectOwner);
         vm.expectRevert(JBOmnichainDeployer.JBOmnichainDeployer_InvalidHook.selector);

package/test/TestAuditGaps.sol

@@ -539,6 +539,7 @@ contract TestAuditGaps is Test {
         // latestRulesetIdOf still = BASE_TIME (from launch).
         // Guard: BASE_TIME >= BASE_TIME + 1 -> false -> passes.
         _mockLatestRulesetId(BASE_TIME);
+        _mockCurrentRulesetId(BASE_TIME);
 
         uint256 expectedQueuedId = BASE_TIME + 1;
         vm.mockCall(
@@ -565,6 +566,7 @@ contract TestAuditGaps is Test {
         // Warp forward 1 second for first queue.
         vm.warp(BASE_TIME + 1);
         _mockLatestRulesetId(BASE_TIME);
+        _mockCurrentRulesetId(BASE_TIME);
 
         uint256 firstQueueTime = BASE_TIME + 1;
         vm.mockCall(
@@ -672,6 +674,7 @@ contract TestAuditGaps is Test {
         // Warp past the latestRulesetId: block.timestamp = BASE_TIME + 3.
         vm.warp(BASE_TIME + 3);
         _mockLatestRulesetId(latestRulesetId);
+        _mockCurrentRulesetId(BASE_TIME);
 
         uint256 expectedQueuedId = BASE_TIME + 3;
         vm.mockCall(
@@ -699,6 +702,7 @@ contract TestAuditGaps is Test {
         // Warp forward.
         vm.warp(BASE_TIME + 100);
         _mockLatestRulesetId(BASE_TIME);
+        _mockCurrentRulesetId(BASE_TIME);
 
         uint256 expectedQueuedId = BASE_TIME + 100;
         vm.mockCall(
@@ -739,6 +743,16 @@ contract TestAuditGaps is Test {
         vm.warp(BASE_TIME + 50);
         _mockLatestRulesetId(BASE_TIME);
 
+        // Mock currentOf to return a ruleset whose id matches the launch ruleset so carry-forward can look up the
+        // stored 721 hook.
+        JBRuleset memory currentRuleset;
+        currentRuleset.id = uint48(BASE_TIME);
+        vm.mockCall(
+            address(rulesetsContract),
+            abi.encodeWithSelector(IJBRulesets.currentOf.selector, projectId),
+            abi.encode(currentRuleset)
+        );
+
         uint256 expectedQueuedId = BASE_TIME + 50;
         vm.mockCall(
             address(controller),
@@ -820,6 +834,7 @@ contract TestAuditGaps is Test {
 
         vm.warp(BASE_TIME + 10);
         _mockLatestRulesetId(BASE_TIME);
+        _mockCurrentRulesetId(BASE_TIME);
 
         uint256 expectedQueuedId = BASE_TIME + 10;
         vm.mockCall(
@@ -866,6 +881,14 @@ contract TestAuditGaps is Test {
         );
     }
 
+    function _mockCurrentRulesetId(uint256 currentRulesetId) internal {
+        JBRuleset memory r;
+        r.id = uint48(currentRulesetId);
+        vm.mockCall(
+            address(rulesetsContract), abi.encodeWithSelector(IJBRulesets.currentOf.selector, projectId), abi.encode(r)
+        );
+    }
+
     function _makePayContext(uint256 pid, uint256 rid) internal returns (JBBeforePayRecordedContext memory) {
         return JBBeforePayRecordedContext({
             terminal: makeAddr("terminal"),

package/test/audit/CarryForwardRejectedHook.t.sol

@@ -0,0 +1,305 @@
+// SPDX-License-Identifier: MIT
+pragma solidity 0.8.28;
+
+import {TestBaseWorkflow} from "@bananapus/core-v6/test/helpers/TestBaseWorkflow.sol";
+import {JBApprovalStatus} from "@bananapus/core-v6/src/enums/JBApprovalStatus.sol";
+import {IJBController} from "@bananapus/core-v6/src/interfaces/IJBController.sol";
+import {IJBDirectory} from "@bananapus/core-v6/src/interfaces/IJBDirectory.sol";
+import {IJBPermissions} from "@bananapus/core-v6/src/interfaces/IJBPermissions.sol";
+import {IJBProjects} from "@bananapus/core-v6/src/interfaces/IJBProjects.sol";
+import {IJBRulesetApprovalHook} from "@bananapus/core-v6/src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBFundAccessLimitGroup} from "@bananapus/core-v6/src/structs/JBFundAccessLimitGroup.sol";
+import {JBPermissionsData} from "@bananapus/core-v6/src/structs/JBPermissionsData.sol";
+import {JBRuleset} from "@bananapus/core-v6/src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "@bananapus/core-v6/src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "@bananapus/core-v6/src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "@bananapus/core-v6/src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "@bananapus/core-v6/src/structs/JBTerminalConfig.sol";
+import {IJB721TiersHook} from "@bananapus/721-hook-v6/src/interfaces/IJB721TiersHook.sol";
+import {IJB721TiersHookDeployer} from "@bananapus/721-hook-v6/src/interfaces/IJB721TiersHookDeployer.sol";
+import {JBDeploy721TiersHookConfig} from "@bananapus/721-hook-v6/src/structs/JBDeploy721TiersHookConfig.sol";
+import {JB721TierConfig} from "@bananapus/721-hook-v6/src/structs/JB721TierConfig.sol";
+import {IJBSuckerRegistry} from "@bananapus/suckers-v6/src/interfaces/IJBSuckerRegistry.sol";
+import {JBSuckerDeployerConfig} from "@bananapus/suckers-v6/src/structs/JBSuckerDeployerConfig.sol";
+import {JBSuckersPair} from "@bananapus/suckers-v6/src/structs/JBSuckersPair.sol";
+import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
+import {ERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
+import {IERC165} from "@openzeppelin/contracts/utils/introspection/IERC165.sol";
+import {JBOmnichainDeployer} from "../../src/JBOmnichainDeployer.sol";
+import {JBOmnichain721Config} from "../../src/structs/JBOmnichain721Config.sol";
+import {JBSuckerDeploymentConfig} from "../../src/structs/JBSuckerDeploymentConfig.sol";
+
+contract RejectingApprovalHook is ERC165, IJBRulesetApprovalHook {
+    function DURATION() external pure override returns (uint256) {
+        return 0;
+    }
+
+    function approvalStatusOf(uint256, JBRuleset calldata) external pure override returns (JBApprovalStatus) {
+        return JBApprovalStatus.Failed;
+    }
+
+    function supportsInterface(bytes4 interfaceId) public view override(ERC165, IERC165) returns (bool) {
+        return interfaceId == type(IJBRulesetApprovalHook).interfaceId || super.supportsInterface(interfaceId);
+    }
+}
+
+contract HookStub {
+    uint256 public lastProjectId;
+
+    function transferOwnershipToProject(uint256 projectId) external {
+        lastProjectId = projectId;
+    }
+}
+
+contract SequentialHookDeployer is IJB721TiersHookDeployer {
+    HookStub[] internal _hooks;
+    uint256 internal _index;
+
+    constructor(HookStub[] memory hooks) {
+        _hooks = hooks;
+    }
+
+    function deployHookFor(
+        uint256,
+        JBDeploy721TiersHookConfig calldata,
+        bytes32
+    )
+        external
+        override
+        returns (IJB721TiersHook)
+    {
+        return IJB721TiersHook(address(_hooks[_index++]));
+    }
+}
+
+contract MockSuckerRegistryCarryForward is IJBSuckerRegistry {
+    function DIRECTORY() external pure override returns (IJBDirectory) {
+        return IJBDirectory(address(0));
+    }
+
+    function PROJECTS() external pure override returns (IJBProjects) {
+        return IJBProjects(address(0));
+    }
+
+    function isSuckerOf(uint256, address) external pure override returns (bool) {
+        return false;
+    }
+
+    function suckerDeployerIsAllowed(address) external pure override returns (bool) {
+        return false;
+    }
+
+    function suckerPairsOf(uint256) external pure override returns (JBSuckersPair[] memory) {
+        return new JBSuckersPair[](0);
+    }
+
+    function suckersOf(uint256) external pure override returns (address[] memory) {
+        return new address[](0);
+    }
+
+    function MAX_TO_REMOTE_FEE() external pure override returns (uint256) {
+        return 0;
+    }
+
+    function toRemoteFee() external pure override returns (uint256) {
+        return 0;
+    }
+
+    function setToRemoteFee(uint256) external override {}
+    function allowSuckerDeployer(address) external override {}
+    function allowSuckerDeployers(address[] calldata) external override {}
+
+    function deploySuckersFor(
+        uint256,
+        bytes32,
+        JBSuckerDeployerConfig[] memory
+    )
+        external
+        pure
+        override
+        returns (address[] memory)
+    {
+        return new address[](0);
+    }
+
+    function removeDeprecatedSucker(uint256, address) external override {}
+    function removeSuckerDeployer(address) external override {}
+}
+
+contract CarryForwardRejectedHookTest is TestBaseWorkflow {
+    JBOmnichainDeployer internal deployer;
+    RejectingApprovalHook internal rejectHook;
+    SequentialHookDeployer internal hookDeployer;
+    HookStub internal initialHook;
+    HookStub internal rejectedHook;
+    MockSuckerRegistryCarryForward internal suckerRegistry;
+
+    address internal owner;
+
+    function setUp() public override {
+        super.setUp();
+
+        owner = multisig();
+        rejectHook = new RejectingApprovalHook();
+        initialHook = new HookStub();
+        rejectedHook = new HookStub();
+        HookStub[] memory hooks = new HookStub[](2);
+        hooks[0] = initialHook;
+        hooks[1] = rejectedHook;
+        hookDeployer = new SequentialHookDeployer(hooks);
+        suckerRegistry = new MockSuckerRegistryCarryForward();
+
+        deployer = new JBOmnichainDeployer(
+            IJBSuckerRegistry(address(suckerRegistry)),
+            IJB721TiersHookDeployer(address(hookDeployer)),
+            IJBPermissions(address(jbPermissions())),
+            IJBProjects(address(jbProjects())),
+            trustedForwarder()
+        );
+
+        vm.prank(multisig());
+        jbDirectory().setIsAllowedToSetFirstController(address(deployer), true);
+    }
+
+    function test_queueCarryForward_usesRejectedRulesetHook_notCurrentRulesetHook() public {
+        JBRulesetConfig[] memory initialRulesets = _makeRulesets(rejectHook);
+        JBTerminalConfig[] memory terminals = new JBTerminalConfig[](0);
+        JBOmnichain721Config memory configWithTiers = _configWithTiers(false);
+
+        (uint256 projectId, IJB721TiersHook launchedHook,) = deployer.launchProjectFor(
+            owner,
+            "ipfs://project",
+            configWithTiers,
+            initialRulesets,
+            terminals,
+            "launch",
+            _emptySuckerConfig(),
+            IJBController(address(jbController()))
+        );
+        uint256 initialRulesetId = jbRulesets().latestRulesetIdOf(projectId);
+
+        assertEq(address(launchedHook), address(initialHook), "launch should use the first hook");
+
+        _grantQueuePermissions(projectId);
+
+        vm.warp(block.timestamp + 1);
+
+        JBOmnichain721Config memory rejectedConfig = _configWithTiers(true);
+        (uint256 rejectedRulesetId,) = deployer.queueRulesetsOf(
+            projectId,
+            rejectedConfig,
+            _makeRulesets(IJBRulesetApprovalHook(address(0))),
+            "rejected",
+            IJBController(address(jbController()))
+        );
+
+        JBRuleset memory currentRuleset = jbRulesets().currentOf(projectId);
+        assertEq(currentRuleset.id, initialRulesetId, "core should still use the last approved ruleset");
+
+        vm.warp(block.timestamp + 2);
+
+        (uint256 carriedRulesetId,) = deployer.queueRulesetsOf(
+            projectId,
+            _default721Config(),
+            _makeRulesets(IJBRulesetApprovalHook(address(0))),
+            "carry",
+            IJBController(address(jbController()))
+        );
+
+        (IJB721TiersHook carriedHook, bool carriedCashOutFlag) = deployer.tiered721HookOf(projectId, carriedRulesetId);
+        (IJB721TiersHook currentHook, bool currentCashOutFlag) = deployer.tiered721HookOf(projectId, initialRulesetId);
+        (IJB721TiersHook rejectedStoredHook, bool rejectedCashOutFlag) =
+            deployer.tiered721HookOf(projectId, rejectedRulesetId);
+
+        assertEq(address(currentHook), address(initialHook), "approved ruleset should point to the initial hook");
+        assertFalse(currentCashOutFlag, "approved ruleset should preserve its original cash-out flag");
+
+        assertEq(address(rejectedStoredHook), address(rejectedHook), "rejected ruleset should store the second hook");
+        assertTrue(rejectedCashOutFlag, "rejected ruleset should store the second cash-out flag");
+
+        // The carry-forward uses currentOf (the approved ruleset), not the rejected queued one.
+        assertEq(
+            address(carriedHook),
+            address(initialHook),
+            "carry-forward should inherit the current (approved) hook, not the rejected one"
+        );
+        assertFalse(carriedCashOutFlag, "carry-forward should inherit the current (approved) cash-out flag");
+    }
+
+    function _configWithTiers(bool useDataHookForCashOut) internal pure returns (JBOmnichain721Config memory config) {
+        config = _default721Config();
+        config.useDataHookForCashOut = useDataHookForCashOut;
+        config.deployTiersHookConfig.tiersConfig.tiers = new JB721TierConfig[](1);
+        config.deployTiersHookConfig.tiersConfig.tiers[0].price = 1 ether;
+        config.deployTiersHookConfig.tiersConfig.tiers[0].initialSupply = 10;
+    }
+
+    function _default721Config() internal pure returns (JBOmnichain721Config memory config) {
+        config.deployTiersHookConfig.tiersConfig.currency =
+            uint32(uint160(address(0x000000000000000000000000000000000000EEEe)));
+        config.deployTiersHookConfig.tiersConfig.decimals = 18;
+    }
+
+    function _makeRulesets(IJBRulesetApprovalHook approvalHook)
+        internal
+        pure
+        returns (JBRulesetConfig[] memory configs)
+    {
+        configs = new JBRulesetConfig[](1);
+        configs[0] = JBRulesetConfig({
+            mustStartAtOrAfter: uint48(0),
+            duration: uint32(0),
+            weight: uint112(1e18),
+            weightCutPercent: uint32(0),
+            approvalHook: approvalHook,
+            metadata: JBRulesetMetadata({
+                reservedPercent: 0,
+                cashOutTaxRate: 0,
+                baseCurrency: uint32(uint160(address(0x000000000000000000000000000000000000EEEe))),
+                pausePay: false,
+                pauseCreditTransfers: false,
+                allowOwnerMinting: false,
+                allowSetCustomToken: false,
+                allowTerminalMigration: false,
+                allowSetController: false,
+                allowSetTerminals: false,
+                allowAddAccountingContext: false,
+                allowAddPriceFeed: false,
+                ownerMustSendPayouts: false,
+                holdFees: false,
+                useTotalSurplusForCashOuts: false,
+                useDataHookForPay: false,
+                useDataHookForCashOut: false,
+                dataHook: address(0),
+                metadata: 0
+            }),
+            splitGroups: new JBSplitGroup[](0),
+            fundAccessLimitGroups: new JBFundAccessLimitGroup[](0)
+        });
+    }
+
+    function _emptySuckerConfig() internal pure returns (JBSuckerDeploymentConfig memory) {
+        return JBSuckerDeploymentConfig({deployerConfigurations: new JBSuckerDeployerConfig[](0), salt: bytes32(0)});
+    }
+
+    function _grantQueuePermissions(uint256 projectId) internal {
+        uint8[] memory permissionIds = new uint8[](1);
+        permissionIds[0] = JBPermissionIds.QUEUE_RULESETS;
+
+        vm.prank(owner);
+        jbPermissions()
+            .setPermissionsFor(
+                owner,
+                JBPermissionsData({operator: address(this), projectId: uint64(projectId), permissionIds: permissionIds})
+            );
+
+        vm.prank(owner);
+        jbPermissions()
+            .setPermissionsFor(
+                owner,
+                JBPermissionsData({
+                    operator: address(deployer), projectId: uint64(projectId), permissionIds: permissionIds
+                })
+            );
+    }
+}

package/test/audit/JBOmnichainDeployer.t.sol

@@ -11,6 +11,7 @@ import {IJBProjects} from "@bananapus/core-v6/src/interfaces/IJBProjects.sol";
 import {IJBRulesetDataHook} from "@bananapus/core-v6/src/interfaces/IJBRulesetDataHook.sol";
 import {IJBRulesets} from "@bananapus/core-v6/src/interfaces/IJBRulesets.sol";
 import {JBConstants} from "@bananapus/core-v6/src/libraries/JBConstants.sol";
+import {JBRuleset} from "@bananapus/core-v6/src/structs/JBRuleset.sol";
 import {JBBeforeCashOutRecordedContext} from "@bananapus/core-v6/src/structs/JBBeforeCashOutRecordedContext.sol";
 import {JBCashOutHookSpecification} from "@bananapus/core-v6/src/structs/JBCashOutHookSpecification.sol";
 import {JBFundAccessLimitGroup} from "@bananapus/core-v6/src/structs/JBFundAccessLimitGroup.sol";
@@ -196,6 +197,15 @@ contract JBOmnichainDeployerTest is Test {
             abi.encode(initialRulesetId)
         );
 
+        // Mock currentOf to return a JBRuleset with id = initialRulesetId so the carry-forward lookup succeeds.
+        JBRuleset memory currentRuleset;
+        currentRuleset.id = uint48(initialRulesetId);
+        vm.mockCall(
+            address(rulesets),
+            abi.encodeWithSelector(IJBRulesets.currentOf.selector, PROJECT_ID),
+            abi.encode(currentRuleset)
+        );
+
         vm.warp(block.timestamp + 1);
         uint256 queuedRulesetId = block.timestamp;
         vm.mockCall(

package/test/fork/OmnichainForkTestBase.sol

@@ -34,6 +34,7 @@ import {IJB721TokenUriResolver} from "@bananapus/721-hook-v6/src/interfaces/IJB7
 import {JBDeploy721TiersHookConfig} from "@bananapus/721-hook-v6/src/structs/JBDeploy721TiersHookConfig.sol";
 import {JB721TierConfig} from "@bananapus/721-hook-v6/src/structs/JB721TierConfig.sol";
 import {JB721InitTiersConfig} from "@bananapus/721-hook-v6/src/structs/JB721InitTiersConfig.sol";
+import {JB721TierConfigFlags} from "@bananapus/721-hook-v6/src/structs/JB721TierConfigFlags.sol";
 import {JB721TiersHookFlags} from "@bananapus/721-hook-v6/src/structs/JB721TiersHookFlags.sol";
 import {JBAddressRegistry} from "@bananapus/address-registry-v6/src/JBAddressRegistry.sol";
 import {IJBAddressRegistry} from "@bananapus/address-registry-v6/src/interfaces/IJBAddressRegistry.sol";
@@ -231,13 +232,15 @@ abstract contract OmnichainForkTestBase is TestBaseWorkflow {
             encodedIPFSUri: bytes32("tier1"),
             category: 1,
             discountPercent: 0,
-            allowOwnerMint: false,
-            useReserveBeneficiaryAsDefault: false,
-            transfersPausable: false,
-            useVotingUnits: false,
-            cantBeRemoved: false,
-            cantIncreaseDiscountPercent: false,
-            cantBuyWithCredits: false,
+            flags: JB721TierConfigFlags({
+                allowOwnerMint: false,
+                useReserveBeneficiaryAsDefault: false,
+                transfersPausable: false,
+                useVotingUnits: false,
+                cantBeRemoved: false,
+                cantIncreaseDiscountPercent: false,
+                cantBuyWithCredits: false
+            }),
             splitPercent: SPLIT_PERCENT,
             splits: tierSplits
         });

package/test/fork/TestOmnichain721QueueAndAdjust.t.sol

@@ -9,6 +9,7 @@ import {JBRulesetConfig} from "@bananapus/core-v6/src/structs/JBRulesetConfig.so
 import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
 import {IJB721TiersHook} from "@bananapus/721-hook-v6/src/interfaces/IJB721TiersHook.sol";
 import {JB721TierConfig} from "@bananapus/721-hook-v6/src/structs/JB721TierConfig.sol";
+import {JB721TierConfigFlags} from "@bananapus/721-hook-v6/src/structs/JB721TierConfigFlags.sol";
 import {IJBOwnable} from "@bananapus/ownable-v6/src/interfaces/IJBOwnable.sol";
 import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
 import {JBOmnichain721Config} from "../../src/structs/JBOmnichain721Config.sol";
@@ -69,13 +70,15 @@ contract TestOmnichain721QueueAndAdjust is OmnichainForkTestBase {
             encodedIPFSUri: bytes32("tier2"),
             category: 2,
             discountPercent: 0,
-            allowOwnerMint: false,
-            useReserveBeneficiaryAsDefault: false,
-            transfersPausable: false,
-            useVotingUnits: false,
-            cantBeRemoved: false,
-            cantIncreaseDiscountPercent: false,
-            cantBuyWithCredits: false,
+            flags: JB721TierConfigFlags({
+                allowOwnerMint: false,
+                useReserveBeneficiaryAsDefault: false,
+                transfersPausable: false,
+                useVotingUnits: false,
+                cantBeRemoved: false,
+                cantIncreaseDiscountPercent: false,
+                cantBuyWithCredits: false
+            }),
             splitPercent: 0,
             splits: new JBSplit[](0)
         });
@@ -146,13 +149,15 @@ contract TestOmnichain721QueueAndAdjust is OmnichainForkTestBase {
             encodedIPFSUri: bytes32("tier3"),
             category: 3,
             discountPercent: 0,
-            allowOwnerMint: false,
-            useReserveBeneficiaryAsDefault: false,
-            transfersPausable: false,
-            useVotingUnits: false,
-            cantBeRemoved: false,
-            cantIncreaseDiscountPercent: false,
-            cantBuyWithCredits: false,
+            flags: JB721TierConfigFlags({
+                allowOwnerMint: false,
+                useReserveBeneficiaryAsDefault: false,
+                transfersPausable: false,
+                useVotingUnits: false,
+                cantBeRemoved: false,
+                cantIncreaseDiscountPercent: false,
+                cantBuyWithCredits: false
+            }),
             splitPercent: 0,
             splits: new JBSplit[](0)
         });
@@ -195,13 +200,15 @@ contract TestOmnichain721QueueAndAdjust is OmnichainForkTestBase {
             encodedIPFSUri: bytes32("bad"),
             category: 4,
             discountPercent: 0,
-            allowOwnerMint: false,
-            useReserveBeneficiaryAsDefault: false,
-            transfersPausable: false,
-            useVotingUnits: false,
-            cantBeRemoved: false,
-            cantIncreaseDiscountPercent: false,
-            cantBuyWithCredits: false,
+            flags: JB721TierConfigFlags({
+                allowOwnerMint: false,
+                useReserveBeneficiaryAsDefault: false,
+                transfersPausable: false,
+                useVotingUnits: false,
+                cantBeRemoved: false,
+                cantIncreaseDiscountPercent: false,
+                cantBuyWithCredits: false
+            }),
             splitPercent: 0,
             splits: new JBSplit[](0)
         });