@bananapus/core-v6 0.0.8 → 0.0.10

package/foundry.toml

@@ -4,7 +4,6 @@ evm_version = 'paris'
 optimizer_runs = 200
 libs = ["node_modules", "lib"]
 fs_permissions = [{ access = "read-write", path = "./"}]
-match_contract = "_Local"
 
 [profile.ci_sizes]
 optimizer_runs = 200

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bananapus/core-v6",
-  "version": "0.0.8",
+  "version": "0.0.10",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -26,7 +26,7 @@
     "artifacts": "source ./.env && npx sphinx artifacts --org-id 'ea165b21-7cdc-4d7b-be59-ecdd4c26bee4' --project-name 'nana-core-v6'"
   },
   "dependencies": {
-    "@bananapus/permission-ids-v6": "^0.0.2",
+    "@bananapus/permission-ids-v6": "^0.0.5",
     "@chainlink/contracts": "^1.3.0",
     "@openzeppelin/contracts": "^5.2.0",
     "@prb/math": "^4.1.0",

package/script/DeployPeriphery.s.sol

@@ -44,6 +44,14 @@ contract DeployPeriphery is Script, Sphinx {
     /// @notice The nonce that gets used across all chains to sync deployment addresses and allow for new deployments of
     /// the same bytecode.
     uint256 private CORE_DEPLOYMENT_NONCE = 6;
+
+    /// @notice The address of the omnichain ruleset operator contract (e.g. JBOmnichainDeployer).
+    /// @dev TRUST ASSUMPTION: This address is granted implicit permission to launch rulesets, set terminals, and queue
+    /// rulesets on any project via the JBController (bypassing normal JBPermissions checks). A compromised or
+    /// incorrect operator address could manipulate any project's rulesets across chains.
+    /// @dev This address should correspond to the deterministic CREATE2 deployment of the omnichain deployer contract
+    /// from the nana-omnichain-deployers-v6 repository. Verify it matches the deployed address on all target chains
+    /// before running this script.
     address private OMNICHAIN_RULESET_OPERATOR = address(0x8f5DED85c40b50d223269C1F922A056E72101590);
 
     function configureSphinx() public override {
@@ -66,6 +74,9 @@ contract DeployPeriphery is Script, Sphinx {
     }
 
     function deploy() public sphinx {
+        // Validate the omnichain ruleset operator is set. See TRUST ASSUMPTION above.
+        require(OMNICHAIN_RULESET_OPERATOR != address(0), "Omnichain ruleset operator not set");
+
         // Deploy the ETH/USD price feed.
         IJBPriceFeed feed;
 

package/src/JBChainlinkV3PriceFeed.sol

@@ -20,16 +20,12 @@ contract JBChainlinkV3PriceFeed is IJBPriceFeed {
     error JBChainlinkV3PriceFeed_StalePrice(uint256 timestamp, uint256 threshold, uint256 updatedAt);
 
     //*********************************************************************//
-    // ---------------- public stored immutable properties --------------- //
+    // --------------- public immutable stored properties ---------------- //
     //*********************************************************************//
 
     /// @notice The Chainlink feed that prices are reported from.
     AggregatorV3Interface public immutable FEED;
 
-    //*********************************************************************//
-    // ---------------- public immutable stored properties --------------- //
-    //*********************************************************************//
-
     /// @notice How many seconds old a Chainlink price update is allowed to be before considered "stale".
     uint256 public immutable THRESHOLD;
 

package/src/JBChainlinkV3SequencerPriceFeed.sol

@@ -19,7 +19,7 @@ contract JBChainlinkV3SequencerPriceFeed is JBChainlinkV3PriceFeed {
     );
 
     //*********************************************************************//
-    // ---------------- public stored immutable properties --------------- //
+    // --------------- public immutable stored properties ---------------- //
     //*********************************************************************//
 
     /// @notice How long the sequencer must be re-active in order to return a price.