@bananapus/core-v6 0.0.42 → 0.0.43

package/src/JBTerminalStore.sol

@@ -40,8 +40,10 @@ contract JBTerminalStore is IJBTerminalStore {
     //*********************************************************************//
 
     error JBTerminalStore_AccountingContextAlreadySet(address token);
-    error JBTerminalStore_AccountingContextDecimalsMismatch();
-    error JBTerminalStore_AddingAccountingContextNotAllowed();
+    error JBTerminalStore_AccountingContextDecimalsMismatch(
+        address token, uint256 providedDecimals, uint256 expectedDecimals
+    );
+    error JBTerminalStore_AddingAccountingContextNotAllowed(uint256 projectId, uint256 rulesetId, address terminal);
     error JBTerminalStore_InadequateControllerAllowance(uint256 amount, uint256 allowance);
     error JBTerminalStore_InadequateControllerPayoutLimit(uint256 amount, uint256 limit);
     error JBTerminalStore_InadequateTerminalStoreBalance(uint256 amount, uint256 balance);
@@ -49,10 +51,10 @@ contract JBTerminalStore is IJBTerminalStore {
     error JBTerminalStore_InvalidAmountToForwardHook(uint256 amount, uint256 paidAmount);
     error JBTerminalStore_NoopHookSpecHasAmount(uint256 amount);
     error JBTerminalStore_RulesetNotFound(uint256 projectId);
-    error JBTerminalStore_RulesetPaymentPaused();
-    error JBTerminalStore_TerminalMigrationNotAllowed();
+    error JBTerminalStore_RulesetPaymentPaused(uint256 projectId, uint256 rulesetId);
+    error JBTerminalStore_TerminalMigrationNotAllowed(uint256 projectId, uint256 rulesetId);
     error JBTerminalStore_Uint224Overflow(uint256 value);
-    error JBTerminalStore_ZeroAccountingContextCurrency();
+    error JBTerminalStore_ZeroAccountingContextCurrency(address token);
 
     //*********************************************************************//
     // -------------------------- internal constants --------------------- //
@@ -176,7 +178,9 @@ contract JBTerminalStore is IJBTerminalStore {
 
         // Make sure that if there's a ruleset, it allows adding accounting contexts.
         if (ruleset.id != 0 && !ruleset.allowAddAccountingContext()) {
-            revert JBTerminalStore_AddingAccountingContextNotAllowed();
+            revert JBTerminalStore_AddingAccountingContextNotAllowed({
+                projectId: projectId, rulesetId: ruleset.id, terminal: msg.sender
+            });
         }
 
         // Record each accounting context.
@@ -185,20 +189,22 @@ contract JBTerminalStore is IJBTerminalStore {
 
             // Make sure the token accounting context isn't already set.
             if (_accountingContextForTokenOf[msg.sender][projectId][context.token].token != address(0)) {
-                revert JBTerminalStore_AccountingContextAlreadySet(context.token);
+                revert JBTerminalStore_AccountingContextAlreadySet({token: context.token});
             }
 
             // Keep track of a flag indicating if we know the provided decimals are incorrect.
             bool knownInvalidDecimals;
+            uint256 expectedDecimals;
 
             // Check if the token is the native token and has the correct decimals.
             if (context.token == JBConstants.NATIVE_TOKEN && context.decimals != 18) {
                 knownInvalidDecimals = true;
+                expectedDecimals = 18;
             } else if (context.token != JBConstants.NATIVE_TOKEN && context.token.code.length > 0) {
-                // slither-disable-next-line calls-loop
                 try IERC20Metadata(context.token).decimals() returns (uint8 decimals) {
                     if (context.decimals != decimals) {
                         knownInvalidDecimals = true;
+                        expectedDecimals = decimals;
                     }
                 } catch {
                     // The token didn't support `decimals`.
@@ -210,11 +216,13 @@ contract JBTerminalStore is IJBTerminalStore {
 
             // Make sure the decimals are correct.
             if (knownInvalidDecimals) {
-                revert JBTerminalStore_AccountingContextDecimalsMismatch();
+                revert JBTerminalStore_AccountingContextDecimalsMismatch({
+                    token: context.token, providedDecimals: context.decimals, expectedDecimals: expectedDecimals
+                });
             }
 
             // Make sure the currency is non-zero.
-            if (context.currency == 0) revert JBTerminalStore_ZeroAccountingContextCurrency();
+            if (context.currency == 0) revert JBTerminalStore_ZeroAccountingContextCurrency({token: context.token});
 
             // Store the accounting context.
             _accountingContextForTokenOf[msg.sender][projectId][context.token] = context;
@@ -303,7 +311,7 @@ contract JBTerminalStore is IJBTerminalStore {
 
         // The amount being reclaimed must be within the project's balance.
         if (balanceDiff > currentBalance) {
-            revert JBTerminalStore_InadequateTerminalStoreBalance(balanceDiff, currentBalance);
+            revert JBTerminalStore_InadequateTerminalStoreBalance({amount: balanceDiff, balance: currentBalance});
         }
 
         // Remove the reclaimed funds from the project's balance.
@@ -404,7 +412,7 @@ contract JBTerminalStore is IJBTerminalStore {
 
         // The amount being paid out must be available.
         if (amountPaidOut > currentBalance) {
-            revert JBTerminalStore_InadequateTerminalStoreBalance(amountPaidOut, currentBalance);
+            revert JBTerminalStore_InadequateTerminalStoreBalance({amount: amountPaidOut, balance: currentBalance});
         }
 
         // The new total amount which has been paid out during this ruleset.
@@ -420,7 +428,7 @@ contract JBTerminalStore is IJBTerminalStore {
 
         // Make sure the new used amount is within the payout limit.
         if (newUsedPayoutLimitOf > payoutLimit || payoutLimit == 0) {
-            revert JBTerminalStore_InadequateControllerPayoutLimit(newUsedPayoutLimitOf, payoutLimit);
+            revert JBTerminalStore_InadequateControllerPayoutLimit({amount: newUsedPayoutLimitOf, limit: payoutLimit});
         }
 
         // Removed the paid out funds from the project's token balance.
@@ -444,7 +452,7 @@ contract JBTerminalStore is IJBTerminalStore {
 
         // Terminal migration must be allowed.
         if (!ruleset.allowTerminalMigration()) {
-            revert JBTerminalStore_TerminalMigrationNotAllowed();
+            revert JBTerminalStore_TerminalMigrationNotAllowed({projectId: projectId, rulesetId: ruleset.id});
         }
 
         // Return the current balance, which is the amount being migrated.
@@ -525,7 +533,9 @@ contract JBTerminalStore is IJBTerminalStore {
 
         // Make sure the new used amount is within the allowance.
         if (newUsedSurplusAllowanceOf > surplusAllowance || surplusAllowance == 0) {
-            revert JBTerminalStore_InadequateControllerAllowance(newUsedSurplusAllowanceOf, surplusAllowance);
+            revert JBTerminalStore_InadequateControllerAllowance({
+                amount: newUsedSurplusAllowanceOf, allowance: surplusAllowance
+            });
         }
 
         // Cache the balance slot to avoid redundant storage reads.
@@ -915,7 +925,7 @@ contract JBTerminalStore is IJBTerminalStore {
         // Noop specifications are informational only, so they can't also request forwarded funds.
         for (uint256 i; i < hookSpecifications.length;) {
             if (hookSpecifications[i].noop && hookSpecifications[i].amount != 0) {
-                revert JBTerminalStore_NoopHookSpecHasAmount(hookSpecifications[i].amount);
+                revert JBTerminalStore_NoopHookSpecHasAmount({amount: hookSpecifications[i].amount});
             }
             unchecked {
                 ++i;
@@ -983,7 +993,7 @@ contract JBTerminalStore is IJBTerminalStore {
 
         // Can't cash out more tokens than are in the supply.
         if (cashOutCount > effectiveTotalSupply) {
-            revert JBTerminalStore_InsufficientTokens(cashOutCount, effectiveTotalSupply);
+            revert JBTerminalStore_InsufficientTokens({count: cashOutCount, totalSupply: effectiveTotalSupply});
         }
 
         // SECURITY NOTE: The data hook has absolute control over cash-out pricing.
@@ -991,7 +1001,7 @@ contract JBTerminalStore is IJBTerminalStore {
         // completely overriding the terminal's bonding curve math. For example, setting
         // effectiveTotalSupply = surplus makes reclaimAmount = effectiveCashOutCount, bypassing the curve.
         // The terminal still burns the caller-supplied cashOutCount after pricing completes.
-        // Project owners MUST audit their data hooks with the same rigor as the terminal.
+        // Project owners must review their data hooks with the same rigor as the terminal.
 
         // If the ruleset has a data hook which is enabled for cash outs, use it to derive a claim amount and memo.
         if (ruleset.useDataHookForCashOut() && ruleset.dataHook() != address(0)) {
@@ -1067,7 +1077,9 @@ contract JBTerminalStore is IJBTerminalStore {
         if (ruleset.cycleNumber == 0) revert JBTerminalStore_RulesetNotFound(projectId);
 
         // The ruleset must not have payments paused.
-        if (ruleset.pausePay()) revert JBTerminalStore_RulesetPaymentPaused();
+        if (ruleset.pausePay()) {
+            revert JBTerminalStore_RulesetPaymentPaused({projectId: projectId, rulesetId: ruleset.id});
+        }
 
         // The weight according to which new tokens are to be minted, as a fixed point number with 18 decimals.
         uint256 weight;
@@ -1075,7 +1087,7 @@ contract JBTerminalStore is IJBTerminalStore {
         // SECURITY NOTE: The data hook has absolute control over payment token minting.
         // It can return an arbitrary weight (overriding the ruleset's weight) and hook specifications
         // that divert payment funds to external hooks before they reach the project's balance.
-        // Project owners MUST audit their data hooks with the same rigor as the terminal.
+        // Project owners must review their data hooks with the same rigor as the terminal.
 
         // If the ruleset has a data hook enabled for payments, use it to derive a weight and memo.
         if (ruleset.useDataHookForPay() && ruleset.dataHook() != address(0)) {
@@ -1105,7 +1117,7 @@ contract JBTerminalStore is IJBTerminalStore {
         // Ensure that the specifications have valid amounts.
         for (uint256 i; i < hookSpecifications.length;) {
             if (hookSpecifications[i].noop && hookSpecifications[i].amount != 0) {
-                revert JBTerminalStore_NoopHookSpecHasAmount(hookSpecifications[i].amount);
+                revert JBTerminalStore_NoopHookSpecHasAmount({amount: hookSpecifications[i].amount});
             }
 
             uint256 specifiedAmount = hookSpecifications[i].amount;
@@ -1113,7 +1125,9 @@ contract JBTerminalStore is IJBTerminalStore {
             // Can't send more to hook than was paid.
             if (specifiedAmount != 0) {
                 if (specifiedAmount > balanceDiff) {
-                    revert JBTerminalStore_InvalidAmountToForwardHook(specifiedAmount, balanceDiff);
+                    revert JBTerminalStore_InvalidAmountToForwardHook({
+                        amount: specifiedAmount, paidAmount: balanceDiff
+                    });
                 }
 
                 // Decrement the total amount being added to the local balance.
@@ -1319,7 +1333,6 @@ contract JBTerminalStore is IJBTerminalStore {
             });
 
         // Add up all the balances.
-        // slither-disable-next-line calls-loop
         surplus = (surplus == 0 || accountingContext.currency == targetCurrency)
             ? surplus
             : mulDiv({
@@ -1335,7 +1348,6 @@ contract JBTerminalStore is IJBTerminalStore {
             });
 
         // Get a reference to the payout limit during the ruleset for the token.
-        // slither-disable-next-line calls-loop
         JBCurrencyAmount[] memory payoutLimits = IJBController(address(DIRECTORY.controllerOf(projectId)))
             .FUND_ACCESS_LIMITS()
             .payoutLimitsOf({
@@ -1375,7 +1387,6 @@ contract JBTerminalStore is IJBTerminalStore {
 
             // Convert the `payoutLimit`'s amount to be in terms of the provided currency.
             if (payoutLimit.amount != 0 && payoutLimit.currency != targetCurrency) {
-                // slither-disable-next-line calls-loop
                 uint256 converted = mulDiv({
                     x: payoutLimit.amount,
                     y: 10 ** _MAX_FIXED_POINT_FIDELITY, // Use `_MAX_FIXED_POINT_FIDELITY` to keep as much of the

package/src/JBTokens.sol

@@ -19,8 +19,8 @@ contract JBTokens is JBControlled, IJBTokens {
     // --------------------------- custom errors ------------------------- //
     //*********************************************************************//
 
-    error JBTokens_EmptyName();
-    error JBTokens_EmptySymbol();
+    error JBTokens_EmptyName(uint256 projectId);
+    error JBTokens_EmptySymbol(uint256 projectId);
     error JBTokens_EmptyToken(uint256 projectId);
     error JBTokens_InsufficientCredits(uint256 count, uint256 creditBalance);
     error JBTokens_InsufficientTokensToBurn(uint256 count, uint256 tokenBalance);
@@ -28,7 +28,7 @@ contract JBTokens is JBControlled, IJBTokens {
     error JBTokens_ProjectAlreadyHasToken(IJBToken token);
     error JBTokens_TokenAlreadyBeingUsed(uint256 projectId);
     error JBTokens_TokenCantBeAdded(uint256 projectId);
-    error JBTokens_TokenNotFound();
+    error JBTokens_TokenNotFound(uint256 projectId);
     error JBTokens_TokensMustHave18Decimals(uint256 decimals);
 
     //*********************************************************************//
@@ -49,7 +49,6 @@ contract JBTokens is JBControlled, IJBTokens {
 
     /// @notice The project ID that a given ERC-20 token is associated with.
     /// @custom:param token The address of the token associated with the project.
-    // slither-disable-next-line unused-return
     mapping(IJBToken token => uint256) public override projectIdOf;
 
     /// @notice Each project's attached token contract.
@@ -92,7 +91,7 @@ contract JBTokens is JBControlled, IJBTokens {
 
         // There must be enough tokens to burn across the holder's combined token and credit balance.
         if (count > tokenBalance + creditBalance) {
-            revert JBTokens_InsufficientTokensToBurn(count, tokenBalance + creditBalance);
+            revert JBTokens_InsufficientTokensToBurn({count: count, tokenBalance: tokenBalance + creditBalance});
         }
 
         // The amount of tokens to burn.
@@ -153,7 +152,7 @@ contract JBTokens is JBControlled, IJBTokens {
         IJBToken token = tokenOf[projectId];
 
         // The project must have a token contract attached.
-        if (token == IJBToken(address(0))) revert JBTokens_TokenNotFound();
+        if (token == IJBToken(address(0))) revert JBTokens_TokenNotFound({projectId: projectId});
 
         // Get a reference to the amount of credits the holder has.
         uint256 creditBalance = creditBalanceOf[holder][projectId];
@@ -204,10 +203,10 @@ contract JBTokens is JBControlled, IJBTokens {
         returns (IJBToken token)
     {
         // There must be a name.
-        if (bytes(name).length == 0) revert JBTokens_EmptyName();
+        if (bytes(name).length == 0) revert JBTokens_EmptyName({projectId: projectId});
 
         // There must be a symbol.
-        if (bytes(symbol).length == 0) revert JBTokens_EmptySymbol();
+        if (bytes(symbol).length == 0) revert JBTokens_EmptySymbol({projectId: projectId});
 
         // The project shouldn't already have a token.
         if (tokenOf[projectId] != IJBToken(address(0))) revert JBTokens_ProjectAlreadyHasToken(tokenOf[projectId]);
@@ -263,12 +262,11 @@ contract JBTokens is JBControlled, IJBTokens {
 
         // The total supply after minting can't exceed the maximum value storable in a uint208.
         if (supply + count > type(uint208).max) {
-            revert JBTokens_OverflowAlert(supply + count, type(uint208).max);
+            revert JBTokens_OverflowAlert({value: supply + count, limit: type(uint208).max});
         }
 
         if (tokensWereClaimed) {
             // If tokens should be claimed, mint tokens into the holder's wallet.
-            // slither-disable-next-line reentrancy-events
             token.mint({account: holder, amount: count});
         } else {
             // Otherwise, add the tokens to their credits and the credit supply.
@@ -333,13 +331,13 @@ contract JBTokens is JBControlled, IJBTokens {
         IJBToken token = tokenOf[projectId];
 
         // The project must have a token contract attached.
-        if (token == IJBToken(address(0))) revert JBTokens_TokenNotFound();
+        if (token == IJBToken(address(0))) revert JBTokens_TokenNotFound({projectId: projectId});
 
         // There must be a name.
-        if (bytes(name).length == 0) revert JBTokens_EmptyName();
+        if (bytes(name).length == 0) revert JBTokens_EmptyName({projectId: projectId});
 
         // There must be a symbol.
-        if (bytes(symbol).length == 0) revert JBTokens_EmptySymbol();
+        if (bytes(symbol).length == 0) revert JBTokens_EmptySymbol({projectId: projectId});
 
         emit SetTokenMetadata({projectId: projectId, name: name, symbol: symbol, caller: msg.sender});
 

package/src/abstract/JBControlled.sol

@@ -48,10 +48,9 @@ abstract contract JBControlled is IJBControlled {
     /// @notice Only allows the controller of the specified project to proceed.
     function _onlyControllerOf(uint256 projectId) internal view {
         // Cache the controller address to avoid a redundant external call on revert.
-        // slither-disable-next-line calls-loop
         address controller = address(DIRECTORY.controllerOf(projectId));
         if (controller != msg.sender) {
-            revert JBControlled_ControllerUnauthorized(controller);
+            revert JBControlled_ControllerUnauthorized({controller: controller});
         }
     }
 }

package/src/interfaces/IJBController.sol

@@ -81,12 +81,6 @@ interface IJBController is IERC165, IJBProjectUriRegistry, IJBDirectoryAccessCon
         address caller
     );
 
-    /// @notice A project was prepared for migration from another controller.
-    /// @param projectId The ID of the project to prepare for migration.
-    /// @param from The controller to migrate from.
-    /// @param caller The address that called the prep migration function.
-    event PrepMigration(uint256 indexed projectId, address from, address caller);
-
     /// @notice Rulesets were queued for a project.
     /// @param rulesetId The ID of the first queued ruleset.
     /// @param projectId The ID of the project.

package/src/libraries/JBCashOuts.sol

@@ -13,7 +13,7 @@ import {JBConstants} from "./JBConstants.sol";
 /// reclaim amount.
 library JBCashOuts {
     /// @notice Thrown when the desired output cannot be achieved (e.g., cash out tax rate is 100%).
-    error JBCashOuts_DesiredOutputNotAchievable();
+    error JBCashOuts_DesiredOutputNotAchievable(uint256 desiredOutput, uint256 cashOutTaxRate, uint256 maxTaxRate);
 
     /// @notice Returns the amount of surplus terminal tokens which can be reclaimed based on the total surplus, the
     /// number of tokens to cash out, the total token supply, and the ruleset's cash out tax rate.
@@ -81,7 +81,11 @@ library JBCashOuts {
 
         // If the cash out tax rate is at maximum, no output is achievable.
         if (cashOutTaxRate == JBConstants.MAX_CASH_OUT_TAX_RATE) {
-            revert JBCashOuts_DesiredOutputNotAchievable();
+            revert JBCashOuts_DesiredOutputNotAchievable({
+                desiredOutput: desiredOutput,
+                cashOutTaxRate: cashOutTaxRate,
+                maxTaxRate: JBConstants.MAX_CASH_OUT_TAX_RATE
+            });
         }
 
         // If the desired output meets or exceeds the surplus, the entire supply must be cashed out.

package/src/libraries/JBCurrencyIds.sol

@@ -4,6 +4,9 @@ pragma solidity 0.8.28;
 /// @notice Well-known currency IDs used as the `baseCurrency` in ruleset metadata. These are distinct from accounting
 /// context currencies (which use `uint32(uint160(tokenAddress))`). Only used for price feed lookups in `JBPrices`.
 library JBCurrencyIds {
+    /// @notice The currency ID used for ETH-denominated price feeds.
     uint32 public constant ETH = 1;
+
+    /// @notice The currency ID used for USD-denominated price feeds.
     uint32 public constant USD = 2;
 }

package/src/libraries/JBMetadataResolver.sol

@@ -25,10 +25,10 @@ pragma solidity 0.8.28;
  *            +-----------------------+
  */
 library JBMetadataResolver {
-    error JBMetadataResolver_DataNotPadded();
-    error JBMetadataResolver_LengthMismatch();
-    error JBMetadataResolver_MetadataTooLong();
-    error JBMetadataResolver_MetadataTooShort();
+    error JBMetadataResolver_DataNotPadded(uint256 dataLength);
+    error JBMetadataResolver_LengthMismatch(uint256 idsLength, uint256 datasLength);
+    error JBMetadataResolver_MetadataTooLong(uint256 offset, uint256 maxOffset);
+    error JBMetadataResolver_MetadataTooShort(uint256 metadataLength, uint256 minMetadataLength);
 
     // The various sizes used in bytes.
     uint256 constant ID_SIZE = 4;
@@ -61,7 +61,7 @@ library JBMetadataResolver {
         returns (bytes memory newMetadata)
     {
         // Validate data padding upfront so that the fast path below cannot bypass the check.
-        if (dataToAdd.length < 32) revert JBMetadataResolver_DataNotPadded();
+        if (dataToAdd.length < 32) revert JBMetadataResolver_DataNotPadded({dataLength: dataToAdd.length});
 
         // Empty original metadata and maybe something in the first 32 bytes: create new metadata
         if (originalMetadata.length <= RESERVED_SIZE) {
@@ -70,7 +70,11 @@ library JBMetadataResolver {
         }
 
         // There is something in the table offset, but not a valid entry - avoid overwriting
-        if (originalMetadata.length < RESERVED_SIZE + ID_SIZE + 1) revert JBMetadataResolver_MetadataTooShort();
+        if (originalMetadata.length < RESERVED_SIZE + ID_SIZE + 1) {
+            revert JBMetadataResolver_MetadataTooShort({
+                metadataLength: originalMetadata.length, minMetadataLength: RESERVED_SIZE + ID_SIZE + 1
+            });
+        }
 
         // Get the first data offset - upcast to avoid overflow (same for other offset)...
         uint256 firstOffset = uint8(originalMetadata[RESERVED_SIZE + ID_SIZE]);
@@ -104,7 +108,9 @@ library JBMetadataResolver {
                     // Increment every offset by 1 (as the table now takes one more word)
                     for (uint256 j = RESERVED_SIZE + ID_SIZE; j < lastOffsetIndex + 1; j += TOTAL_ID_SIZE) {
                         uint256 incremented = uint256(uint8(originalMetadata[j])) + 1;
-                        if (incremented > 255) revert JBMetadataResolver_MetadataTooLong();
+                        if (incremented > 255) {
+                            revert JBMetadataResolver_MetadataTooLong({offset: incremented, maxOffset: 255});
+                        }
                         // forge-lint: disable-next-line(unsafe-typecast)
                         newMetadata[j] = bytes1(uint8(incremented));
                     }
@@ -121,7 +127,7 @@ library JBMetadataResolver {
         // taken by the last data
         // Compute in uint256 first — casting directly to uint8 silently wraps offsets > 255.
         uint256 newOffset = lastOffset + numberOfWordslastData;
-        if (newOffset > 255) revert JBMetadataResolver_MetadataTooLong();
+        if (newOffset > 255) revert JBMetadataResolver_MetadataTooLong({offset: newOffset, maxOffset: 255});
         // forge-lint: disable-next-line(unsafe-typecast)
         newMetadata = abi.encodePacked(newMetadata, idToAdd, bytes1(uint8(newOffset)));
 
@@ -167,7 +173,9 @@ library JBMetadataResolver {
     /// @param datas The list of corresponding datas
     /// @return metadata The resulting metadata
     function createMetadata(bytes4[] memory ids, bytes[] memory datas) internal pure returns (bytes memory metadata) {
-        if (ids.length != datas.length) revert JBMetadataResolver_LengthMismatch();
+        if (ids.length != datas.length) {
+            revert JBMetadataResolver_LengthMismatch({idsLength: ids.length, datasLength: datas.length});
+        }
 
         // Return empty bytes for empty input arrays to avoid underflow in offset calculation below.
         if (ids.length == 0) return bytes("");
@@ -191,7 +199,7 @@ library JBMetadataResolver {
             bytes memory data = datas[i];
 
             if (data.length < 32 || data.length % JBMetadataResolver.WORD_SIZE != 0) {
-                revert JBMetadataResolver_DataNotPadded();
+                revert JBMetadataResolver_DataNotPadded({dataLength: data.length});
             }
 
             // forge-lint: disable-next-line(unsafe-typecast)
@@ -199,7 +207,7 @@ library JBMetadataResolver {
             offset += data.length / JBMetadataResolver.WORD_SIZE;
 
             // Overflowing a bytes1?
-            if (offset > 255) revert JBMetadataResolver_MetadataTooLong();
+            if (offset > 255) revert JBMetadataResolver_MetadataTooLong({offset: offset, maxOffset: 255});
         }
 
         // Pad the table to a multiple of 32B
@@ -277,7 +285,7 @@ library JBMetadataResolver {
     /// @param purpose A string describing the purpose associated with the id
     /// @return id The resulting ID.
     function getId(string memory purpose) internal view returns (bytes4) {
-        return getId(purpose, address(this));
+        return getId({purpose: purpose, target: address(this)});
     }
 
     /// @notice Returns an unique id following a suggested format (`xor(address(this), purpose name)` where purpose name

package/src/libraries/JBPayoutSplitGroupLib.sol

@@ -12,6 +12,13 @@ import {JBConstants} from "./JBConstants.sol";
 /// @dev Kept local to this file because `executePayout(...)` is an implementation detail, not a shared public
 /// interface.
 interface IJBPayoutSplitGroupExecutor {
+    /// @notice Executes one payout split from the terminal that is using this library.
+    /// @param split The split to pay.
+    /// @param projectId The ID of the project paying the split.
+    /// @param token The token being paid out.
+    /// @param amount The amount assigned to the split.
+    /// @param originalMessageSender The account that started the payout flow.
+    /// @return netPayoutAmount The amount that was actually paid after fees or hook behavior.
     function executePayout(
         JBSplit calldata split,
         uint256 projectId,
@@ -30,6 +37,7 @@ interface IJBPayoutSplitGroupExecutor {
 /// are emitted from the terminal's address.
 library JBPayoutSplitGroupLib {
     event PayoutReverted(uint256 indexed projectId, JBSplit split, uint256 amount, bytes reason, address caller);
+
     event SendPayoutToSplit(
         uint256 indexed projectId,
         uint256 indexed rulesetId,
@@ -80,7 +88,6 @@ library JBPayoutSplitGroupLib {
             uint256 payoutAmount = mulDiv(leftoverAmount, split.percent, leftoverPercentage);
 
             // The final payout amount after taking out any fees.
-            // slither-disable-next-line calls-loop
             uint256 netPayoutAmount = _sendPayoutToSplit({
                 store: store, split: split, projectId: projectId, token: token, amount: payoutAmount, caller: caller
             });
@@ -140,7 +147,6 @@ library JBPayoutSplitGroupLib {
         // split from DoS-ing the entire payout. Failed splits' amounts are returned to the project balance via
         // `recordAddedBalanceFor`. Payout limit consumption is correct because the project authorized the
         // distribution.
-        // slither-disable-next-line reentrancy-events,calls-loop
         try IJBPayoutSplitGroupExecutor(address(this))
             .executePayout({
             split: split, projectId: projectId, token: token, amount: amount, originalMessageSender: caller
@@ -154,7 +160,6 @@ library JBPayoutSplitGroupLib {
             });
 
             // Add balance back to the project.
-            // slither-disable-next-line calls-loop
             store.recordAddedBalanceFor({projectId: projectId, token: token, amount: amount});
 
             // Since the payout failed the netPayoutAmount is zero.

package/src/libraries/JBSplitGroupIds.sol

@@ -4,5 +4,6 @@ pragma solidity 0.8.28;
 /// @notice Well-known split group IDs. The reserved tokens group (ID 1) defines how a project's reserved tokens are
 /// distributed. Payout split groups use the token address cast to `uint256(uint160(token))` as their group ID.
 library JBSplitGroupIds {
+    /// @notice The split group ID used for reserved token distributions.
     uint256 public constant RESERVED_TOKENS = 1;
 }

package/src/periphery/JBDeadline1Day.sol

@@ -3,6 +3,7 @@ pragma solidity 0.8.28;
 
 import {JBDeadline} from "../JBDeadline.sol";
 
+/// @notice A reusable deadline implementation with a fixed one-day duration.
 contract JBDeadline1Day is JBDeadline {
     constructor() JBDeadline(1 days) {}
 }

package/src/periphery/JBDeadline3Days.sol

@@ -3,6 +3,7 @@ pragma solidity 0.8.28;
 
 import {JBDeadline} from "../JBDeadline.sol";
 
+/// @notice A reusable deadline implementation with a fixed three-day duration.
 contract JBDeadline3Days is JBDeadline {
     constructor() JBDeadline(3 days) {}
 }

package/src/periphery/JBDeadline3Hours.sol

@@ -3,6 +3,7 @@ pragma solidity 0.8.28;
 
 import {JBDeadline} from "../JBDeadline.sol";
 
+/// @notice A reusable deadline implementation with a fixed three-hour duration.
 contract JBDeadline3Hours is JBDeadline {
     constructor() JBDeadline(3 hours) {}
 }

package/src/periphery/JBDeadline7Days.sol

@@ -3,6 +3,7 @@ pragma solidity 0.8.28;
 
 import {JBDeadline} from "../JBDeadline.sol";
 
+/// @notice A reusable deadline implementation with a fixed seven-day duration.
 contract JBDeadline7Days is JBDeadline {
     constructor() JBDeadline(7 days) {}
 }