@bananapus/core-v6 0.0.27 → 0.0.29

package/test/TestFeeFreeCashOutBypass.sol

@@ -802,7 +802,7 @@ contract TestFeeFreeCashOutBypass is TestBaseWorkflow {
             beneficiary: payable(user),
             metadata: new bytes(0)
         });
-        // Balance dropped significantly. _reduceFeeFreeSurplus should have capped fee-free at remaining balance.
+        // Balance dropped significantly. _capFeeFreeSurplus should have capped fee-free at remaining balance.
 
         // Step 4: Switch back to zero tax. Cash out remaining.
         _reconfigureWithTaxRate(_projectIdB, 0);
@@ -855,7 +855,7 @@ contract TestFeeFreeCashOutBypass is TestBaseWorkflow {
         vm.prank(multisig());
         jbFeelessAddresses().setFeelessAddress(_attacker, true);
 
-        // Step 3: Feeless cashout — no fees charged, but _reduceFeeFreeSurplus should still cap.
+        // Step 3: Feeless cashout — no fees charged, but _capFeeFreeSurplus should still cap.
         uint256 attackerTokens = _tokens.totalBalanceOf(_attacker, _projectIdB);
         vm.prank(_attacker);
         uint256 reclaim = _terminal.cashOutTokensOf({

package/test/TestFees.sol

@@ -216,8 +216,9 @@ contract TestFees_Local is TestBaseWorkflow {
         // Send: Migration to terminal2
         _terminal.migrateBalanceOf(_projectId, JBConstants.NATIVE_TOKEN, _terminal2);
 
-        // Check: Held Fee is processed and feeAmount remains in terminal
-        assertEq(address(_terminal).balance, _feeAmount);
+        // Check: Held fee remains in terminal, plus migration fee paid to fee project (on same terminal)
+        uint256 _migrationFee = _nativeDistLimit * _terminal.FEE() / JBConstants.MAX_FEE;
+        assertEq(address(_terminal).balance, _feeAmount + _migrationFee);
 
         vm.stopPrank();
     }
@@ -265,8 +266,9 @@ contract TestFees_Local is TestBaseWorkflow {
         // Send: Migration to terminal2
         _terminal.migrateBalanceOf(_projectId, JBConstants.NATIVE_TOKEN, _terminal2);
 
-        // Check: Held fee has been repaid, no balance remains.
-        assertEq(address(_terminal).balance, 0);
+        // Check: Held fee has been repaid. Migration fee paid to fee project remains on this terminal.
+        uint256 _migrationFee = _nativePayAmount * _terminal.FEE() / JBConstants.MAX_FEE;
+        assertEq(address(_terminal).balance, _migrationFee);
 
         vm.stopPrank();
     }

package/test/TestTerminalMigration.sol

@@ -6,6 +6,7 @@ import {JBMultiTerminal} from "../src/JBMultiTerminal.sol";
 import {IJBController} from "../src/interfaces/IJBController.sol";
 import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
 import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBFees} from "../src/libraries/JBFees.sol";
 import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
 import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
 import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
@@ -105,7 +106,7 @@ contract TestTerminalMigration_Local is TestBaseWorkflow {
         uint256 migratedBalance = _terminalA.migrateBalanceOf(_projectId, JBConstants.NATIVE_TOKEN, _terminalB);
         assertEq(migratedBalance, payAmount, "full balance should be migrated");
 
-        // Step 4: Verify balances after migration
+        // Step 4: Verify balances after migration (fee project is exempt from migration fee)
         uint256 balanceAAfter = jbTerminalStore().balanceOf(address(_terminalA), _projectId, JBConstants.NATIVE_TOKEN);
         assertEq(balanceAAfter, 0, "terminal A should have zero after migration");
 
@@ -152,7 +153,7 @@ contract TestTerminalMigration_Local is TestBaseWorkflow {
         vm.prank(_projectOwner);
         _terminalA.migrateBalanceOf(_projectId, JBConstants.NATIVE_TOKEN, _terminalB);
 
-        // Check surplus from terminal B
+        // Check surplus from terminal B (fee project exempt from migration fee)
         uint256 surplusAfter =
             _terminalB.currentSurplusOf(_projectId, new address[](0), 18, uint32(uint160(JBConstants.NATIVE_TOKEN)));
         assertEq(surplusAfter, surplusBefore, "surplus should be preserved after migration");
@@ -169,4 +170,105 @@ contract TestTerminalMigration_Local is TestBaseWorkflow {
         vm.expectRevert();
         _terminalA.migrateBalanceOf(_projectId, JBConstants.NATIVE_TOKEN, _terminalB);
     }
+
+    /// @notice Non-fee project migration charges the 2.5% fee; fee project balance increases.
+    function test_migration_nonFeeProject_chargesFee() public {
+        // Launch a second project (project 2) — this is NOT the fee project.
+        JBRulesetMetadata memory _metadata2 = JBRulesetMetadata({
+            reservedPercent: 0,
+            cashOutTaxRate: 0,
+            baseCurrency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
+            pausePay: false,
+            pauseCreditTransfers: false,
+            allowOwnerMinting: false,
+            allowSetCustomToken: false,
+            allowTerminalMigration: true,
+            allowSetTerminals: true,
+            allowSetController: false,
+            allowAddAccountingContext: false,
+            allowAddPriceFeed: false,
+            ownerMustSendPayouts: false,
+            holdFees: false,
+            useTotalSurplusForCashOuts: false,
+            useDataHookForPay: false,
+            useDataHookForCashOut: false,
+            dataHook: address(0),
+            metadata: 0
+        });
+
+        JBRulesetConfig[] memory _rulesetConfig2 = new JBRulesetConfig[](1);
+        _rulesetConfig2[0].mustStartAtOrAfter = 0;
+        _rulesetConfig2[0].duration = 0;
+        _rulesetConfig2[0].weight = 1000 * 10 ** 18;
+        _rulesetConfig2[0].weightCutPercent = 0;
+        _rulesetConfig2[0].approvalHook = IJBRulesetApprovalHook(address(0));
+        _rulesetConfig2[0].metadata = _metadata2;
+        _rulesetConfig2[0].splitGroups = new JBSplitGroup[](0);
+        _rulesetConfig2[0].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
+
+        JBAccountingContext[] memory _tokensToAccept = new JBAccountingContext[](1);
+        _tokensToAccept[0] = JBAccountingContext({
+            token: JBConstants.NATIVE_TOKEN, decimals: 18, currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
+        });
+
+        JBTerminalConfig[] memory _terminalConfigs2 = new JBTerminalConfig[](2);
+        _terminalConfigs2[0] = JBTerminalConfig({terminal: _terminalA, accountingContextsToAccept: _tokensToAccept});
+        _terminalConfigs2[1] = JBTerminalConfig({terminal: _terminalB, accountingContextsToAccept: _tokensToAccept});
+
+        uint256 project2 = _controller.launchProjectFor({
+            owner: _projectOwner,
+            projectUri: "non-fee-project",
+            rulesetConfigurations: _rulesetConfig2,
+            terminalConfigurations: _terminalConfigs2,
+            memo: ""
+        });
+
+        // Confirm project 2 is NOT the fee project.
+        assertGt(project2, 1, "project2 should not be the fee project");
+
+        uint256 payAmount = 10 ether;
+
+        // Pay into terminal A for project 2.
+        vm.deal(_beneficiary, payAmount);
+        vm.prank(_beneficiary);
+        _terminalA.pay{value: payAmount}(project2, JBConstants.NATIVE_TOKEN, payAmount, _beneficiary, 0, "", "");
+
+        // Snapshot fee project balance before migration.
+        uint256 feeBalanceBefore = jbTerminalStore().balanceOf(address(_terminalA), 1, JBConstants.NATIVE_TOKEN);
+
+        // Migrate project 2 from terminal A to terminal B.
+        vm.prank(_projectOwner);
+        _terminalA.migrateBalanceOf(project2, JBConstants.NATIVE_TOKEN, _terminalB);
+
+        // Fee project balance should have increased (fee was charged).
+        uint256 feeBalanceAfter = jbTerminalStore().balanceOf(address(_terminalA), 1, JBConstants.NATIVE_TOKEN);
+        assertGt(feeBalanceAfter, feeBalanceBefore, "fee project should receive migration fee");
+
+        // Terminal B should have received payAmount minus the 2.5% fee.
+        uint256 expectedFee = JBFees.feeAmountFrom({amountBeforeFee: payAmount, feePercent: 25});
+        uint256 balanceBAfter = jbTerminalStore().balanceOf(address(_terminalB), project2, JBConstants.NATIVE_TOKEN);
+        assertEq(balanceBAfter, payAmount - expectedFee, "terminal B balance should reflect fee deduction");
+    }
+
+    /// @notice Fee project (project 1) migration is exempt from fees.
+    function test_migration_feeProject_noFeeCharged() public {
+        // _projectId is project 1, which IS the fee project.
+        assertEq(_projectId, 1, "project under test should be the fee project");
+
+        uint256 payAmount = 10 ether;
+
+        // Pay into terminal A for the fee project.
+        vm.deal(_beneficiary, payAmount);
+        vm.prank(_beneficiary);
+        _terminalA.pay{value: payAmount}(_projectId, JBConstants.NATIVE_TOKEN, payAmount, _beneficiary, 0, "", "");
+
+        // Migrate fee project from terminal A to terminal B.
+        vm.prank(_projectOwner);
+        uint256 migratedBalance = _terminalA.migrateBalanceOf(_projectId, JBConstants.NATIVE_TOKEN, _terminalB);
+        assertEq(migratedBalance, payAmount, "full balance should be migrated without fee");
+
+        // Terminal B should have the full amount (no fee deducted).
+        uint256 balanceBAfter = jbTerminalStore().balanceOf(address(_terminalB), _projectId, JBConstants.NATIVE_TOKEN);
+        assertEq(balanceBAfter, payAmount, "fee project should not be charged migration fee");
+    }
 }

package/test/audit/FeeFreeSurplusLifecycle.t.sol

@@ -318,10 +318,13 @@ contract FeeFreeSurplusLifecycleTest is TestBaseWorkflow {
             jbTerminalStore().balanceOf(address(_terminal), _recipientProjectId, JBConstants.NATIVE_TOKEN);
         assertEq(balanceAfterOnOldTerminal, 0, "Old terminal balance should be zero after migration");
 
-        // Verify the new terminal received the balance.
+        // Verify the new terminal received the balance minus the 2.5% migration fee.
         uint256 balanceOnNewTerminal =
             jbTerminalStore().balanceOf(address(_terminal2), _recipientProjectId, JBConstants.NATIVE_TOKEN);
-        assertEq(balanceOnNewTerminal, balanceBefore, "New terminal should have the migrated balance");
+        uint256 migrationFee = balanceBefore * 25 / 1000;
+        assertEq(
+            balanceOnNewTerminal, balanceBefore - migrationFee, "New terminal should have balance minus migration fee"
+        );
     }
 
     // --- Helpers ---

package/test/units/static/JBMultiTerminal/TestCashOutTokensOf.sol

@@ -340,7 +340,7 @@ contract TestCashOutTokensOf_Local is JBMultiTerminalSetup {
         whenADataHookIsConfigured
         whenCallerHasPermission
     {
-        // it will safeIncreaseAllowance pass the full amount to the hook and emit HookAfterRecordCashOut
+        // it will forceApprove pass the full amount to the hook and emit HookAfterRecordCashOut
 
         // mint mocked erc20 tokens to hodler
         _mockToken2.mint(address(_terminal), _defaultAmount * 10);
@@ -350,9 +350,6 @@ contract TestCashOutTokensOf_Local is JBMultiTerminalSetup {
         vm.prank(_holder);
         _mockToken2.approve(address(_terminal), _defaultAmount);
 
-        vm.prank(address(_terminal));
-        _mockToken2.approve(address(_mockHook), _defaultAmount);
-
         uint256 reclaimAmount = 1e9;
         JBCashOutHookSpecification[] memory hookSpecifications = new JBCashOutHookSpecification[](1);
         hookSpecifications[0] =
@@ -431,8 +428,8 @@ contract TestCashOutTokensOf_Local is JBMultiTerminalSetup {
 
         mockExpect(address(_mockHook), abi.encodeCall(IJBCashOutHook.afterCashOutRecordedWith, (context)), "");
 
-        // ensure approval is increased
-        vm.expectCall(address(_mockToken2), abi.encodeCall(IERC20.approve, (address(_mockHook), _defaultAmount * 2)));
+        // ensure approval is set via forceApprove
+        vm.expectCall(address(_mockToken2), abi.encodeCall(IERC20.approve, (address(_mockHook), _defaultAmount)));
 
         _acceptToken(address(_mockToken2), 18, uint32(uint160(address(_mockToken2))));
 
@@ -456,7 +453,7 @@ contract TestCashOutTokensOf_Local is JBMultiTerminalSetup {
         whenADataHookIsConfigured
         whenCallerHasPermission
     {
-        // it will safeIncreaseAllowance pass the amount to the hook and emit HookAfterRecordCashOut
+        // it will forceApprove pass the amount to the hook and emit HookAfterRecordCashOut
 
         // mint mocked erc20 tokens to hodler
         _mockToken2.mint(address(_terminal), _defaultAmount * 10);
@@ -466,9 +463,6 @@ contract TestCashOutTokensOf_Local is JBMultiTerminalSetup {
         vm.prank(_holder);
         _mockToken2.approve(address(_terminal), _defaultAmount);
 
-        vm.prank(address(_terminal));
-        _mockToken2.approve(address(_mockHook), _defaultAmount);
-
         uint256 reclaimAmount = 1e9;
         JBCashOutHookSpecification[] memory hookSpecifications = new JBCashOutHookSpecification[](1);
         JBCashOutHookSpecification[] memory paySpecs = new JBCashOutHookSpecification[](0);

package/test/units/static/JBMultiTerminal/TestExecutePayout.sol

@@ -4,18 +4,14 @@ pragma solidity 0.8.28;
 import {JBMultiTerminal} from "../../../../src/JBMultiTerminal.sol";
 import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
 import {IJBFeelessAddresses} from "../../../../src/interfaces/IJBFeelessAddresses.sol";
-import {IJBRulesetApprovalHook} from "../../../../src/interfaces/IJBRulesetApprovalHook.sol";
 import {IJBSplitHook} from "../../../../src/interfaces/IJBSplitHook.sol";
 import {IJBTerminal} from "../../../../src/interfaces/IJBTerminal.sol";
 import {IJBTerminalStore} from "../../../../src/interfaces/IJBTerminalStore.sol";
 import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
 import {JBFees} from "../../../../src/libraries/JBFees.sol";
 import {JBAccountingContext} from "../../../../src/structs/JBAccountingContext.sol";
-import {JBPayHookSpecification} from "../../../../src/structs/JBPayHookSpecification.sol";
-import {JBRuleset} from "../../../../src/structs/JBRuleset.sol";
 import {JBSplit} from "../../../../src/structs/JBSplit.sol";
 import {JBSplitHookContext} from "../../../../src/structs/JBSplitHookContext.sol";
-import {JBTokenAmount} from "../../../../src/structs/JBTokenAmount.sol";
 import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import {IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 import {JBMultiTerminalSetup} from "./JBMultiTerminalSetup.sol";
@@ -336,12 +332,7 @@ contract TestExecutePayout_Local is JBMultiTerminalSetup {
         uint256 taxedAmount = JBFees.feeAmountFrom(_defaultAmount, _fee);
         uint256 amountAfterTax = _defaultAmount - taxedAmount;
 
-        // mock call for SafeERC20s allowance check
-        mockExpect(
-            _usdc, abi.encodeCall(IERC20.allowance, (address(_terminal), address(_mockSecondTerminal))), abi.encode(0)
-        );
-
-        // mock call for SafeERC20s safeIncreaseAllowance approval
+        // mock call for SafeERC20s forceApprove approval
         mockExpect(_usdc, abi.encodeCall(IERC20.approve, (_mockSecondTerminal, amountAfterTax)), "");
 
         // mock call to second terminals addToBalanceOf
@@ -366,9 +357,7 @@ contract TestExecutePayout_Local is JBMultiTerminalSetup {
     }
 
     function test_GivenPreferAddToBalanceDNEQTrueAndTerminalEQThisAddress() external {
-        // it will call internal _pay
-
-        _setAccountingContext(_projectId, _usdc, 0, _usdcCurrency);
+        // it will revert with MintNotAllowed because same-project same-terminal pay splits are blocked
 
         // mock call to directory primaryTerminalOf
         mockExpect(
@@ -386,41 +375,8 @@ contract TestExecutePayout_Local is JBMultiTerminalSetup {
             hook: IJBSplitHook(address(0))
         });
 
-        // needed for next mock call returns
-        JBTokenAmount memory tokenAmount =
-            JBTokenAmount({token: _usdc, decimals: 0, currency: _usdcCurrency, value: _defaultAmount});
-        JBPayHookSpecification[] memory hookSpecifications = new JBPayHookSpecification[](0);
-        JBRuleset memory returnedRuleset = JBRuleset({
-            cycleNumber: 1,
-            id: 1,
-            basedOnId: 0,
-            start: 0,
-            duration: 0,
-            weight: 0,
-            weightCutPercent: 0,
-            approvalHook: IJBRulesetApprovalHook(address(0)),
-            metadata: 0
-        });
-
-        // mock call to JBTerminalStore recordPaymentFrom
-        mockExpect(
-            address(store),
-            abi.encodeCall(
-                IJBTerminalStore.recordPaymentFrom,
-                (
-                    address(_terminal),
-                    tokenAmount,
-                    _projectId,
-                    address(this),
-                    bytes(abi.encodePacked(uint256(_projectId)))
-                )
-            ),
-            abi.encode(returnedRuleset, 0, hookSpecifications)
-        );
-
-        // for safe ERC20 check of code length at token address
         vm.prank(address(_terminal));
-
+        vm.expectRevert(JBMultiTerminal.JBMultiTerminal_MintNotAllowed.selector);
         JBMultiTerminal(address(_terminal))
             .executePayout({
                 split: _splitMemory,
@@ -460,12 +416,7 @@ contract TestExecutePayout_Local is JBMultiTerminalSetup {
         uint256 taxedAmount = JBFees.feeAmountFrom(_defaultAmount, _fee);
         uint256 amountAfterTax = _defaultAmount - taxedAmount;
 
-        // mock call for SafeERC20s allowance check
-        mockExpect(
-            _usdc, abi.encodeCall(IERC20.allowance, (address(_terminal), address(_mockSecondTerminal))), abi.encode(0)
-        );
-
-        // mock call for SafeERC20s safeIncreaseAllowance approval
+        // mock call for SafeERC20s forceApprove approval
         mockExpect(_usdc, abi.encodeCall(IERC20.approve, (_mockSecondTerminal, amountAfterTax)), "");
 
         // mock call to second terminals pay function

package/test/units/static/JBMultiTerminal/TestExecuteProcessFee.sol

@@ -68,12 +68,9 @@ contract TestExecuteProcessFee_Local is JBMultiTerminalSetup {
     }
 
     function test_WhenTokenIsErc20AndFeeTerminalIsExternal() external {
-        // it will safeIncreaseAllowance
+        // it will forceApprove
 
-        // mock token allowance call
-        mockExpect(_usdc, abi.encodeCall(IERC20.allowance, (address(_terminal), address(_feeTerminal))), abi.encode(0));
-
-        // mock approval call
+        // mock approval call for forceApprove
         mockExpect(_usdc, abi.encodeCall(IERC20.approve, (address(_feeTerminal), _defaultAmount)), "");
 
         // mock pay call to fee terminal

package/test/units/static/JBMultiTerminal/TestMigrateBalanceOf.sol

@@ -11,6 +11,7 @@ import {JBAccountingContext} from "../../../../src/structs/JBAccountingContext.s
 import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
 import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import {IERC721} from "@openzeppelin/contracts/token/ERC721/IERC721.sol";
+import {IJBFeelessAddresses} from "../../../../src/interfaces/IJBFeelessAddresses.sol";
 import {JBMultiTerminalSetup} from "./JBMultiTerminalSetup.sol";
 
 contract TestMigrateBalanceOf_Local is JBMultiTerminalSetup {
@@ -102,7 +103,14 @@ contract TestMigrateBalanceOf_Local is JBMultiTerminalSetup {
     } */
 
     function test_GivenTokenIsERC20() external whenPermissioned {
-        // it will safeIncreaseAllowance and addToBalanceOf
+        // it will forceApprove and addToBalanceOf
+
+        // mock _isFeeless to return true (skip migration fee for this unit test)
+        mockExpect(
+            address(feelessAddresses),
+            abi.encodeCall(IJBFeelessAddresses.isFeeless, (address(_newTerminal))),
+            abi.encode(true)
+        );
 
         // for next mock
         // forge-lint: disable-next-line(unsafe-typecast)
@@ -124,10 +132,7 @@ contract TestMigrateBalanceOf_Local is JBMultiTerminalSetup {
             abi.encode(_defaultAmount)
         );
 
-        // mock call for SafeERC20s allowance check
-        mockExpect(_usdc, abi.encodeCall(IERC20.allowance, (address(_terminal), address(_newTerminal))), abi.encode(0));
-
-        // mock call for SafeERC20s safeIncreaseAllowance approval
+        // mock call for SafeERC20s forceApprove approval
         mockExpect(_usdc, abi.encodeCall(IERC20.approve, (address(_newTerminal), _defaultAmount)), "");
 
         // mock call to new terminal addToBalance
@@ -143,6 +148,13 @@ contract TestMigrateBalanceOf_Local is JBMultiTerminalSetup {
     function test_GivenTokenIsNative() external whenPermissioned {
         // it will addToBalanceOf with value in msgvalue
 
+        // mock _isFeeless to return true (skip migration fee for this unit test)
+        mockExpect(
+            address(feelessAddresses),
+            abi.encodeCall(IJBFeelessAddresses.isFeeless, (address(_newTerminal))),
+            abi.encode(true)
+        );
+
         // for next mock
         // forge-lint: disable-next-line(unsafe-typecast)
         JBAccountingContext memory _context =

package/test/units/static/JBMultiTerminal/TestSelfPayRevert.sol

@@ -0,0 +1,55 @@
+// SPDX-License-Identifier: MIT
+pragma solidity 0.8.28;
+
+import {JBMultiTerminal} from "../../../../src/JBMultiTerminal.sol";
+import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
+import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
+import {JBSplit} from "../../../../src/structs/JBSplit.sol";
+import {IJBSplitHook} from "../../../../src/interfaces/IJBSplitHook.sol";
+import {JBMultiTerminalSetup} from "./JBMultiTerminalSetup.sol";
+
+/// @notice Tests that a pay-type split back into the same terminal reverts with MintNotAllowed.
+contract TestSelfPayRevert_Local is JBMultiTerminalSetup {
+    uint64 _projectId = 1;
+    uint256 _defaultAmount = 1e18;
+    address _sender = makeAddr("sender");
+    address _native = JBConstants.NATIVE_TOKEN;
+
+    function setUp() public {
+        super.multiTerminalSetup();
+    }
+
+    /// @notice When a split routes a pay back to the same project on the same terminal,
+    /// executePayout should revert with MintNotAllowed.
+    function test_RevertWhen_SplitPaysBackToSameTerminal() external {
+        // Build a split targeting the SAME project with preferAddToBalance = false (pay path).
+        JBSplit memory split = JBSplit({
+            preferAddToBalance: false,
+            percent: 1_000_000_000,
+            projectId: _projectId,
+            beneficiary: payable(_sender),
+            lockedUntil: 0,
+            hook: IJBSplitHook(address(0))
+        });
+
+        // Mock primaryTerminalOf to return this terminal (self-referencing).
+        mockExpect(
+            address(directory),
+            abi.encodeCall(IJBDirectory.primaryTerminalOf, (_projectId, _native)),
+            abi.encode(address(_terminal))
+        );
+
+        // executePayout requires msg.sender == address(this), so we call it via the terminal.
+        // The terminal's try-catch in the split group lib would normally catch this.
+        vm.prank(address(_terminal));
+        vm.expectRevert(JBMultiTerminal.JBMultiTerminal_MintNotAllowed.selector);
+        JBMultiTerminal(payable(address(_terminal)))
+            .executePayout({
+                split: split,
+                projectId: uint256(_projectId),
+                token: _native,
+                amount: _defaultAmount,
+                originalMessageSender: _sender
+            });
+    }
+}