@bananapus/core-v6 0.0.2 → 0.0.4

package/foundry.toml

@@ -9,20 +9,6 @@ match_contract = "_Local"
 [profile.ci_sizes]
 optimizer_runs = 200
 
-[profile.fork]
-match_contract = "_Fork"
-fs_permissions = [{ access = "read", path = "./deployments/mainnet" }]
-
-[rpc_endpoints]
-ethereum = "${RPC_ETHEREUM_MAINNET}"
-optimism = "${RPC_OPTIMISM_MAINNET}"
-arbitrum = "${RPC_ARBITRUM_MAINNET}"
-base = "${RPC_BASE_MAINNET}"
-ethereum_sepolia = "${RPC_ETHEREUM_SEPOLIA}"
-optimism_sepolia = "${RPC_OPTIMISM_SEPOLIA}"
-arbitrum_sepolia = "${RPC_ARBITRUM_SEPOLIA}"
-base_sepolia = "${RPC_BASE_SEPOLIA}"
-
 [fuzz]
 runs = 4096
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bananapus/core-v6",
-  "version": "0.0.2",
+  "version": "0.0.4",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -26,7 +26,7 @@
     "artifacts": "source ./.env && npx sphinx artifacts --org-id 'ea165b21-7cdc-4d7b-be59-ecdd4c26bee4' --project-name 'nana-core-v6'"
   },
   "dependencies": {
-    "@bananapus/permission-ids-v6": "^0.0.1",
+    "@bananapus/permission-ids-v6": "^0.0.2",
     "@chainlink/contracts": "^1.3.0",
     "@openzeppelin/contracts": "^5.2.0",
     "@prb/math": "^4.1.0",

package/test/TestRulesetQueueing.sol

@@ -20,6 +20,9 @@ contract TestRulesetQueuing_Local is TestBaseWorkflow {
     function setUp() public override {
         super.setUp();
 
+        // Foundry defaults block.timestamp to 1, which causes underflow in tests using past timestamps.
+        vm.warp(7 days);
+
         _terminal = jbMultiTerminal();
         _controller = jbController();
 

package/test/units/static/JBChainlinkV3PriceFeed/TestPriceFeed.sol

@@ -52,6 +52,9 @@ contract TestPriceFeed_Local is JBTest {
     uint256 constant THRESHOLD = 1 hours;
 
     function setUp() external {
+        // Foundry defaults block.timestamp to 1, which causes underflow in stale-price tests.
+        vm.warp(THRESHOLD + 1 days);
+
         mockFeed = new MockAggregator();
         mockFeed.setDecimals(8);
         mockFeed.setPrice(200_000_000_000); // $2000 with 8 decimals

package/test/units/static/JBDeadline/TestDeadlineFuzz.sol

@@ -13,6 +13,9 @@ contract TestDeadlineFuzz_Local is JBTest {
     uint256 constant DURATION = 3 days;
 
     function setUp() external {
+        // Foundry defaults block.timestamp to 1, which causes underflow in tests
+        // that subtract DURATION from timestamp-derived values.
+        vm.warp(DURATION + 1 days);
         deadline = new JBDeadline(DURATION);
     }
 
@@ -112,15 +115,14 @@ contract TestDeadlineFuzz_Local is JBTest {
     }
 
     /// @notice If gap >= DURATION and deadline passed, always Approved.
-    function testFuzz_sufficientGap_deadlinePassed_approved(uint256 gapExtra) external view {
+    function testFuzz_sufficientGap_deadlinePassed_approved(uint256 gapExtra) external {
         // gap = DURATION + gapExtra (always >= DURATION)
         gapExtra = bound(gapExtra, 0, 365 days);
         uint256 gap = DURATION + gapExtra;
 
-        // start = block.timestamp (deadline already passed since block.timestamp + DURATION >= start)
+        // Warp to a timestamp large enough so that start >= gap always holds.
+        vm.warp(gap + 1);
         uint48 start = uint48(block.timestamp);
-        // Ensure queuedAt doesn't underflow
-        vm.assume(start >= gap);
         uint48 queuedAt = start - uint48(gap);
 
         JBRuleset memory ruleset = _makeRuleset({queuedAt: queuedAt, start: start});
@@ -131,8 +133,8 @@ contract TestDeadlineFuzz_Local is JBTest {
     /// @notice Status monotonically transitions: ApprovalExpected -> Approved as time advances.
     function testFuzz_statusMonotonic(uint48 gap) external {
         gap = uint48(bound(uint256(gap), DURATION, type(uint32).max));
-        // Ensure arithmetic doesn't overflow uint48
-        uint48 start = uint48(bound(uint256(block.timestamp) + 2 * DURATION + 100, gap, type(uint48).max));
+        // Cap start to leave room for `start + 1000` without overflowing uint48.
+        uint48 start = uint48(bound(uint256(block.timestamp) + 2 * DURATION + 100, gap, type(uint48).max - 1000));
         uint48 queuedAt = start - gap;
 
         JBRuleset memory ruleset = _makeRuleset({queuedAt: queuedAt, start: start});

package/test/units/static/JBRulesets/TestRulesets.sol

@@ -55,6 +55,9 @@ contract TestJBRulesetsUnits_Local is JBTest {
     }
 
     function setUp() public {
+        // Foundry defaults block.timestamp to 1, which causes underflow in tests using past timestamps.
+        vm.warp(7 days);
+
         // Mock contracts and label them
         _directory = IJBDirectory(makeAddr("JBDirectory"));
         _permissions = IJBPermissions(makeAddr("JBPermissions"));