@bananapus/core-v6 0.0.11 → 0.0.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bananapus/core-v6",
-  "version": "0.0.11",
+  "version": "0.0.13",
   "license": "MIT",
   "repository": {
     "type": "git",

package/test/TestPermissions.sol

@@ -2,6 +2,7 @@
 pragma solidity ^0.8.6;
 
 import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {JBTest} from "./helpers/JBTest.sol";
 
 contract TestPermissions_Local is TestBaseWorkflow, JBTest {
     IJBController private _controller;

package/test/formal/BondingCurveProperties.t.sol

@@ -198,8 +198,8 @@ contract BondingCurveProperties is Test {
         if (firstResult + secondResult > singleResult) {
             // The excess should be tiny relative to the result
             uint256 excess = (firstResult + secondResult) - singleResult;
-            // Allow up to 1 basis point (0.01%) rounding tolerance
-            assert(excess * 10_000 <= singleResult);
+            // Allow up to 2 wei absolute (for small values) or 0.01% relative
+            assert(excess <= 2 || excess * 10_000 <= singleResult);
         }
     }
 
@@ -229,10 +229,13 @@ contract BondingCurveProperties is Test {
         uint256 secondResult = JBCashOuts.cashOutFrom(remainingSurplus, b, remainingSupply, cashOutTaxRate);
 
         // NOTE: Strict subadditivity violated due to mulDiv rounding.
-        // Verify the weaker property: excess bounded by rounding tolerance (< 0.01%).
+        // Verify the weaker property: excess bounded by rounding tolerance (<=2 wei or < 0.01%).
         if (firstResult + secondResult > singleResult) {
             uint256 excess = (firstResult + secondResult) - singleResult;
-            assertLe(excess * 10_000, singleResult, "No-arbitrage: rounding excess should be < 0.01%");
+            assertTrue(
+                excess <= 2 || excess * 10_000 <= singleResult,
+                "No-arbitrage: rounding excess should be <= 2 wei or < 0.01%"
+            );
         }
     }
 

package/test/helpers/TestBaseWorkflow.sol

@@ -93,7 +93,6 @@ import {JBSplitGroupIds} from "../../src/libraries/JBSplitGroupIds.sol";
 import {IPermit2, IAllowanceTransfer} from "@uniswap/permit2/src/interfaces/IPermit2.sol";
 import {DeployPermit2} from "@uniswap/permit2/test/utils/DeployPermit2.sol";
 
-import {JBTest} from "./JBTest.sol";
 import {MetadataResolverHelper} from "./MetadataResolverHelper.sol";
 
 import {MockERC20} from "./../mock/MockERC20.sol";

package/test/units/static/JBChainlinkV3PriceFeed/TestPriceFeed.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 import {JBChainlinkV3PriceFeed} from "../../../../src/JBChainlinkV3PriceFeed.sol";
 import {AggregatorV3Interface} from "@chainlink/contracts/src/v0.8/shared/interfaces/AggregatorV3Interface.sol";
 import {JBFixedPointNumber} from "../../../../src/libraries/JBFixedPointNumber.sol";

package/test/units/static/JBController/JBControllerSetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBDeadline/TestDeadlineFuzz.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 import {JBDeadline} from "../../../../src/JBDeadline.sol";
 import {JBApprovalStatus} from "../../../../src/enums/JBApprovalStatus.sol";
 import {JBRuleset} from "../../../../src/structs/JBRuleset.sol";

package/test/units/static/JBDirectory/JBDirectorySetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBERC20/JBERC20Setup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBFeelessAdresses/JBFeelessSetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBFees/TestFeesFuzz.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 import {JBFees} from "../../../../src/libraries/JBFees.sol";
 
 /// @notice Fuzz tests for the JBFees library.

package/test/units/static/JBFixedPointNumber/TestAdjustDecimals.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 import {JBFixedPointNumber} from "../../../../src/libraries/JBFixedPointNumber.sol";
 
 contract TestAdjustDecimals_Local is JBTest {

package/test/units/static/JBFixedPointNumber/TestAdjustDecimalsFuzz.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 import {JBFixedPointNumber} from "../../../../src/libraries/JBFixedPointNumber.sol";
 
 /// @notice Fuzz tests for JBFixedPointNumber.adjustDecimals.

package/test/units/static/JBFundAccessLimits/JBFundAccessSetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBFundAccessLimits/TestFundAccessLimitsEdge.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /// @notice Edge case tests for JBFundAccessLimits append behavior and packing.
 /// The key finding is that setFundAccessLimitsFor uses .push() (append), not replace.

package/test/units/static/JBMetadataResolver/TestGetDataFor.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 import {JBMetadataResolver} from "../../../../src/libraries/JBMetadataResolver.sol";
 
 contract TestGetDataFor_Local is JBTest {

package/test/units/static/JBMetadataResolver/TestMetadataResolverFuzz.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 import {JBMetadataResolver} from "../../../../src/libraries/JBMetadataResolver.sol";
 
 /// @notice Wrapper contract to expose JBMetadataResolver internal functions for testing.

package/test/units/static/JBMetadataResolver/TestMetadataResolverM20M21.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 import {JBMetadataResolver} from "../../../../src/libraries/JBMetadataResolver.sol";
 
 /// @notice Harness that exposes JBMetadataResolver internals and adds a combined operation

package/test/units/static/JBMultiTerminal/JBMultiTerminalSetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBPermissions/JBPermissionsSetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBPrices/JBPricesSetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBProjects/JBProjectsSetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBProjects/TestInitialProject.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 contract TestInitialProject_Local is JBTest {
     address _owner = makeAddr("owner");

package/test/units/static/JBRulesetMetadataResolver/TestSetCashOutTaxRateTo.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 contract TestSetCashOutTaxRateTo_Local is JBTest {
     using JBRulesetMetadataResolver for JBRulesetMetadata;

package/test/units/static/JBRulesets/JBRulesetsSetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBRulesets/TestRulesets.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 import {JBRulesetWeightCache} from "src/structs/JBRulesetWeightCache.sol";
 
 contract TestJBRulesetsUnits_Local is JBTest {

package/test/units/static/JBSplits/JBSplitsSetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBSurplus/TestSurplusFuzz.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 import {JBSurplus} from "../../../../src/libraries/JBSurplus.sol";
 
 /// @notice Mock terminal that returns a fixed surplus for testing JBSurplus.

package/test/units/static/JBTerminalStore/JBTerminalStoreSetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.

package/test/units/static/JBTokens/JBTokensSetup.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.26;
 
 import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*
 Contract that deploys a target contract with other mock contracts to satisfy the constructor.