@bananapus/721-hook-v6 0.0.34 → 0.0.35

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bananapus/721-hook-v6",
-  "version": "0.0.34",
+  "version": "0.0.35",
   "license": "MIT",
   "repository": {
     "type": "git",

package/src/JB721TiersHook.sol

@@ -110,7 +110,7 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
     uint256 internal _packedPricingContext;
 
     /// @notice The checkpoint module that manages IVotes-compatible checkpointed voting power for this hook's NFTs.
-    /// @dev Set once during `initialize()`. Pass this to JBTokenDistributor as the IVotes token.
+    /// @dev Lazily deployed on the first transfer. Pass this to JBTokenDistributor as the IVotes token.
     IJB721Checkpoints public override CHECKPOINTS;
 
     //*********************************************************************//
@@ -307,9 +307,6 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
                 || flags.preventOverspending || flags.issueTokensForSplits
         ) STORE.recordFlags(flags);
 
-        // Deploy the checkpoint module for IVotes-compatible voting power.
-        CHECKPOINTS = CHECKPOINTS_DEPLOYER.deploy({hook: address(this), store: STORE});
-
         // Transfer ownership to the initializer.
         _transferOwnership(_msgSender());
     }
@@ -794,6 +791,11 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
         // slither-disable-next-line reentrency-events,calls-loop
         STORE.recordTransferForTier({tierId: tierId, from: from, to: to});
 
+        // Deploy the checkpoint module lazily on the first transfer.
+        if (address(CHECKPOINTS) == address(0)) {
+            CHECKPOINTS = CHECKPOINTS_DEPLOYER.deploy({hook: address(this), store: STORE});
+        }
+
         // Notify the checkpoint module to update checkpointed voting power.
         CHECKPOINTS.onTransfer({from: from, to: to, tokenId: tokenId});
     }

package/test/TestCheckpoints.t.sol

@@ -48,17 +48,29 @@ contract TestCheckpoints is UnitTestSetup {
     }
 
     // -------------------------------------------------------------------
-    // Test 1: Checkpoint module is deployed eagerly during initialize
+    // Test 1: Checkpoint module is deployed lazily on first transfer
     // -------------------------------------------------------------------
-    function test_checkpointModule_isDeployed() public {
+    function test_checkpointModule_isDeployedLazily() public {
         defaultTierConfig.flags.allowOwnerMint = true;
         defaultTierConfig.reserveFrequency = 0;
 
         ForTest_JB721TiersHook tiersHook = _initializeHookWithCheckpoints(1);
 
-        // CHECKPOINTS should be deployed immediately after initialization.
+        // CHECKPOINTS should NOT be deployed after initialization (lazy deployment).
         assertTrue(
-            address(tiersHook.CHECKPOINTS()) != address(0), "Checkpoint module should be deployed after initialization"
+            address(tiersHook.CHECKPOINTS()) == address(0),
+            "Checkpoint module should not be deployed after initialization"
+        );
+
+        // Mint a token to trigger lazy deployment.
+        uint16[] memory tiersToMint = new uint16[](1);
+        tiersToMint[0] = 1;
+        vm.prank(owner);
+        tiersHook.mintFor(tiersToMint, owner);
+
+        // CHECKPOINTS should now be deployed after the first mint.
+        assertTrue(
+            address(tiersHook.CHECKPOINTS()) != address(0), "Checkpoint module should be deployed after first mint"
         );
     }