@bananapus/721-hook-v6 0.0.28 → 0.0.30

package/references/runtime.md

@@ -0,0 +1,32 @@
+# 721 Hook Runtime
+
+## Contract Roles
+
+- [`src/abstract/JB721Hook.sol`](../src/abstract/JB721Hook.sol) is the shared pay and cash-out hook surface. It validates the calling terminal, decodes metadata, and delegates runtime behavior to the concrete hook.
+- [`src/JB721TiersHook.sol`](../src/JB721TiersHook.sol) is the main project-facing contract. It handles tier-aware minting, split forwarding, discount updates, metadata changes, reserve minting, and cash-out weight calculations.
+- [`src/JB721TiersHookStore.sol`](../src/JB721TiersHookStore.sol) is the shared storage and accounting backend. It owns tier definitions, supply counters, burn counts, reserve availability, and voting-unit state.
+- [`src/libraries/JB721TiersHookLib.sol`](../src/libraries/JB721TiersHookLib.sol) holds size-sensitive helper logic such as tier adjustment, split calculation/distribution, pricing normalization, and token-URI resolution.
+
+## Runtime Path
+
+1. Terminal calls [`src/abstract/JB721Hook.sol`](../src/abstract/JB721Hook.sol) through the pay or cash-out hook interface.
+2. The abstract hook validates the terminal and decodes metadata.
+3. [`src/JB721TiersHook.sol`](../src/JB721TiersHook.sol) computes pricing, splits, credits, or burn-side cash-out weights.
+4. [`src/JB721TiersHookStore.sol`](../src/JB721TiersHookStore.sol) records the mint, reserve, burn, and tier-state effects.
+5. If the flow forwards split funds or resolves token metadata, the hook delegates into [`src/libraries/JB721TiersHookLib.sol`](../src/libraries/JB721TiersHookLib.sol).
+
+## High-Risk Areas
+
+- Reserve accounting: edits around `reserveFrequency`, pending reserves, or owner minting must preserve the store's supply protections.
+- Tier splits: split forwarding changes affect both payer economics and project treasury accounting. Check both `beforePayRecordedWith` and the distribution path.
+- Discount behavior: price discounts affect mint eligibility but cash-out weight still tracks the original tier price. Do not conflate the two.
+- Voting units: verify whether a tier uses explicit voting units or falls back to price-based voting power before changing governance-facing math.
+- Tier removal and cleanup: removing tiers is not the same as cleaning the sorted tier list. Storage cleanup behavior matters.
+
+## Tests To Trust First
+
+- [`test/invariants/`](../test/invariants/) for broad accounting invariants.
+- [`test/E2E/`](../test/E2E/) for launch and end-to-end payment flows.
+- [`test/regression/`](../test/regression/) for previously broken edge cases.
+- [`test/TestVotingUnitsLifecycle.t.sol`](../test/TestVotingUnitsLifecycle.t.sol) for voting-unit lifecycle behavior.
+- [`test/TestSafeTransferReentrancy.t.sol`](../test/TestSafeTransferReentrancy.t.sol) and [`test/721HookAttacks.t.sol`](../test/721HookAttacks.t.sol) for reentrancy and attack-surface checks.

package/script/Deploy.s.sol

@@ -1,10 +1,11 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.28;
 
-// forge-lint: disable-next-line(unaliased-plain-import)
-import "@bananapus/core-v6/script/helpers/CoreDeploymentLib.sol";
-// forge-lint: disable-next-line(unaliased-plain-import)
-import "@bananapus/address-registry-v6/script/helpers/AddressRegistryDeploymentLib.sol";
+import {CoreDeployment, CoreDeploymentLib} from "@bananapus/core-v6/script/helpers/CoreDeploymentLib.sol";
+import {
+    AddressRegistryDeployment,
+    AddressRegistryDeploymentLib
+} from "@bananapus/address-registry-v6/script/helpers/AddressRegistryDeploymentLib.sol";
 
 import {Sphinx} from "@sphinx-labs/contracts/contracts/foundry/SphinxPlugin.sol";
 import {Script} from "forge-std/Script.sol";

package/src/JB721TiersHook.sol

@@ -776,7 +776,7 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
         // Transfers must not be paused (when not minting or burning).
         if (from != address(0)) {
             // If transfers are pausable, check if they're paused.
-            if (tier.transfersPausable) {
+            if (tier.flags.transfersPausable) {
                 // Get a reference to the project's current ruleset.
                 JBRuleset memory ruleset = _currentRulesetOf(PROJECT_ID);
 

package/src/JB721TiersHookDeployer.sol

@@ -29,7 +29,7 @@ contract JB721TiersHookDeployer is ERC2771Context, IJB721TiersHookDeployer {
     IJB721TiersHookStore public immutable STORE;
 
     //*********************************************************************//
-    // ----------------------- internal properties ----------------------- //
+    // -------------------- internal stored properties ------------------- //
     //*********************************************************************//
 
     /// @notice This contract's current nonce, used for the Juicebox address registry.

package/src/JB721TiersHookProjectDeployer.sol

@@ -218,7 +218,7 @@ contract JB721TiersHookProjectDeployer is ERC2771Context, JBPermissioned, IJB721
     }
 
     //*********************************************************************//
-    // ------------------------ internal functions ----------------------- //
+    // ----------------------- internal helpers -------------------------- //
     //*********************************************************************//
 
     /// @notice Launches a project.

package/src/JB721TiersHookStore.sol

@@ -10,6 +10,7 @@ import {JB721Constants} from "./libraries/JB721Constants.sol";
 import {JBBitmap} from "./libraries/JBBitmap.sol";
 import {JB721Tier} from "./structs/JB721Tier.sol";
 import {JB721TierConfig} from "./structs/JB721TierConfig.sol";
+import {JB721TierFlags} from "./structs/JB721TierFlags.sol";
 import {JB721TiersHookFlags} from "./structs/JB721TiersHookFlags.sol";
 import {JBBitmapWord} from "./structs/JBBitmapWord.sol";
 import {JBStored721Tier} from "./structs/JBStored721Tier.sol";
@@ -549,11 +550,13 @@ contract JB721TiersHookStore is IJB721TiersHookStore {
             encodedIPFSUri: encodedIPFSUriOf[hook][tierId],
             category: storedTier.category,
             discountPercent: storedTier.discountPercent,
-            allowOwnerMint: (packed & 0x1 != 0),
-            transfersPausable: (packed & 0x2 != 0),
-            cantBeRemoved: (packed & 0x8 != 0),
-            cantIncreaseDiscountPercent: (packed & 0x10 != 0),
-            cantBuyWithCredits: (packed & 0x20 != 0),
+            flags: JB721TierFlags({
+                allowOwnerMint: (packed & 0x1 != 0),
+                transfersPausable: (packed & 0x2 != 0),
+                cantBeRemoved: (packed & 0x8 != 0),
+                cantIncreaseDiscountPercent: (packed & 0x10 != 0),
+                cantBuyWithCredits: (packed & 0x20 != 0)
+            }),
             splitPercent: storedTier.splitPercent,
             resolvedUri: !includeResolvedUri || tokenUriResolverOf[hook] == IJB721TokenUriResolver(address(0))
                 ? ""
@@ -744,9 +747,11 @@ contract JB721TiersHookStore is IJB721TiersHookStore {
         uint256 currentSortedTierId = _firstSortedTierIdOf({hook: hook, category: 0});
 
         // Keep track of the previous non-removed tier ID.
+        // slither-disable-next-line uninitialized-local
         uint256 previousSortedTierId;
 
         // Initialize a `JBBitmapWord` for tracking removed tiers.
+        // slither-disable-next-line uninitialized-local
         JBBitmapWord memory bitmapWord;
 
         // Make the sorted array.
@@ -820,6 +825,7 @@ contract JB721TiersHookStore is IJB721TiersHookStore {
         uint256 startSortedTierId = currentMaxTierIdOf == 0 ? 0 : _firstSortedTierIdOf({hook: msg.sender, category: 0});
 
         // Keep track of the previous tier's ID while iterating.
+        // slither-disable-next-line uninitialized-local
         uint256 previousTierId;
 
         // Keep a reference to the 721 contract's flags.
@@ -855,20 +861,20 @@ contract JB721TiersHookStore is IJB721TiersHookStore {
             // Make sure the new tier doesn't have voting units if the 721 contract's flags don't allow it to.
             if (
                 flags.noNewTiersWithVotes
-                    && ((tierToAdd.useVotingUnits && tierToAdd.votingUnits != 0)
-                        || (!tierToAdd.useVotingUnits && tierToAdd.price != 0))
+                    && ((tierToAdd.flags.useVotingUnits && tierToAdd.votingUnits != 0)
+                        || (!tierToAdd.flags.useVotingUnits && tierToAdd.price != 0))
             ) {
                 revert JB721TiersHookStore_VotingUnitsNotAllowed(tierId);
             }
 
             // Make sure the new tier doesn't have a reserve frequency if the 721 contract's flags don't allow it to,
             // OR if manual minting is allowed.
-            if ((flags.noNewTiersWithReserves || tierToAdd.allowOwnerMint) && tierToAdd.reserveFrequency != 0) {
+            if ((flags.noNewTiersWithReserves || tierToAdd.flags.allowOwnerMint) && tierToAdd.reserveFrequency != 0) {
                 revert JB721TiersHookStore_ReserveFrequencyNotAllowed(tierId);
             }
 
             // Make sure the new tier doesn't have owner minting enabled if the 721 contract's flags don't allow it to.
-            if (flags.noNewTiersWithOwnerMinting && tierToAdd.allowOwnerMint) {
+            if (flags.noNewTiersWithOwnerMinting && tierToAdd.flags.allowOwnerMint) {
                 revert JB721TiersHookStore_ManualMintingNotAllowed(tierId);
             }
 
@@ -905,17 +911,17 @@ contract JB721TiersHookStore is IJB721TiersHookStore {
                 category: uint24(tierToAdd.category),
                 discountPercent: uint8(tierToAdd.discountPercent),
                 packedBools: _packBools({
-                    allowOwnerMint: tierToAdd.allowOwnerMint,
-                    transfersPausable: tierToAdd.transfersPausable,
-                    useVotingUnits: tierToAdd.useVotingUnits,
-                    cantBeRemoved: tierToAdd.cantBeRemoved,
-                    cantIncreaseDiscountPercent: tierToAdd.cantIncreaseDiscountPercent,
-                    cantBuyWithCredits: tierToAdd.cantBuyWithCredits
+                    allowOwnerMint: tierToAdd.flags.allowOwnerMint,
+                    transfersPausable: tierToAdd.flags.transfersPausable,
+                    useVotingUnits: tierToAdd.flags.useVotingUnits,
+                    cantBeRemoved: tierToAdd.flags.cantBeRemoved,
+                    cantIncreaseDiscountPercent: tierToAdd.flags.cantIncreaseDiscountPercent,
+                    cantBuyWithCredits: tierToAdd.flags.cantBuyWithCredits
                 })
             });
 
             // Store voting units in a separate mapping if custom voting units are used.
-            if (tierToAdd.useVotingUnits && tierToAdd.votingUnits != 0) {
+            if (tierToAdd.flags.useVotingUnits && tierToAdd.votingUnits != 0) {
                 _tierVotingUnitsOf[msg.sender][tierId] = uint32(tierToAdd.votingUnits);
             }
 
@@ -928,7 +934,7 @@ contract JB721TiersHookStore is IJB721TiersHookStore {
 
             // Set the reserve beneficiary if needed.
             if (tierToAdd.reserveBeneficiary != address(0) && tierToAdd.reserveFrequency != 0) {
-                if (tierToAdd.useReserveBeneficiaryAsDefault) {
+                if (tierToAdd.flags.useReserveBeneficiaryAsDefault) {
                     // WARNING: This overwrites the global default for ALL tiers without a tier-specific beneficiary.
                     if (defaultReserveBeneficiaryOf[msg.sender] != tierToAdd.reserveBeneficiary) {
                         defaultReserveBeneficiaryOf[msg.sender] = tierToAdd.reserveBeneficiary;

package/src/libraries/JB721Constants.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.0;
+pragma solidity 0.8.28;
 
 /// @notice Global constants used across 721 hook contracts.
 library JB721Constants {

package/src/libraries/JB721TiersRulesetMetadataResolver.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.17;
+pragma solidity 0.8.28;
 
 import {JB721TiersRulesetMetadata} from "../structs/JB721TiersRulesetMetadata.sol";
 

package/src/libraries/JBBitmap.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.17;
+pragma solidity 0.8.28;
 
 import {JBBitmapWord} from "../structs/JBBitmapWord.sol";
 

package/src/libraries/JBIpfsDecoder.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.17;
+pragma solidity 0.8.28;
 
 /// @title JBIpfsDecoder
 /// @notice Utilities to decode an IPFS hash.

package/src/structs/JB721Tier.sol

@@ -1,6 +1,8 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 
+import {JB721TierFlags} from "./JB721TierFlags.sol";
+
 /// @custom:member id The tier's ID.
 /// @custom:member price The price to buy an NFT in this tier, in terms of the currency in its `JBInitTiersConfig`.
 /// @custom:member remainingSupply The remaining number of NFTs which can be minted from this tier.
@@ -13,12 +15,8 @@ pragma solidity ^0.8.0;
 /// @custom:member encodedIPFSUri The IPFS URI to use for each NFT in this tier.
 /// @custom:member category The category that NFTs in this tier belongs to. Used to group NFT tiers.
 /// @custom:member discountPercent The discount that should be applied to the tier.
-/// @custom:member allowOwnerMint A boolean indicating whether the contract's owner can mint NFTs from this tier
-/// on-demand.
-/// @custom:member cantBeRemoved A boolean indicating whether attempts to remove this tier will revert.
-/// @custom:member cantIncreaseDiscountPercent If the tier cannot have its discount increased.
-/// @custom:member cantBuyWithCredits If true, this tier cannot be purchased using accumulated pay credits.
-/// @custom:member transfersPausable A boolean indicating whether transfers for NFTs in tier can be paused.
+/// @custom:member flags Boolean flags for this tier (allowOwnerMint, transfersPausable, cantBeRemoved,
+/// cantIncreaseDiscountPercent, cantBuyWithCredits).
 /// @custom:member splitPercent The percentage of the tier's price that gets routed to the project's split group when
 /// an NFT from this tier is minted. Out of `JBConstants.SPLITS_TOTAL_PERCENT`.
 /// @custom:member resolvedUri A resolved token URI for NFTs in this tier. Only available if the NFT this tier belongs
@@ -36,11 +34,7 @@ struct JB721Tier {
     bytes32 encodedIPFSUri;
     uint24 category;
     uint8 discountPercent;
-    bool allowOwnerMint;
-    bool transfersPausable;
-    bool cantBeRemoved;
-    bool cantIncreaseDiscountPercent;
-    bool cantBuyWithCredits;
+    JB721TierFlags flags;
     uint32 splitPercent;
     string resolvedUri;
 }

package/src/structs/JB721TierConfig.sol

@@ -3,6 +3,8 @@ pragma solidity ^0.8.0;
 
 import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
 
+import {JB721TierConfigFlags} from "./JB721TierConfigFlags.sol";
+
 /// @notice Config for a single NFT tier within a `JB721TiersHook`.
 /// @custom:member price The price to buy an NFT in this tier, in terms of the currency in its `JBInitTiersConfig`.
 /// @custom:member initialSupply The total number of NFTs which can be minted from this tier.
@@ -15,19 +17,8 @@ import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
 /// @custom:member encodedIPFSUri The IPFS URI to use for each NFT in this tier.
 /// @custom:member category The category that NFTs in this tier belongs to. Used to group NFT tiers.
 /// @custom:member discountPercent The discount that should be applied to the tier.
-/// @custom:member allowOwnerMint A boolean indicating whether the contract's owner can mint NFTs from this tier
-/// on-demand.
-/// @custom:member useReserveBeneficiaryAsDefault A boolean indicating whether this tier's `reserveBeneficiary` should
-/// be stored as the default beneficiary for all tiers. WARNING: Setting this to `true` overwrites the global
-/// `defaultReserveBeneficiaryOf` for the hook, which affects ALL existing tiers that do not have a tier-specific
-/// reserve beneficiary. Use with caution when calling `adjustTiers` on hooks with existing tiers.
-/// @custom:member transfersPausable A boolean indicating whether transfers for NFTs in tier can be paused.
-/// @custom:member useVotingUnits A boolean indicating whether the `votingUnits` should be used to calculate voting
-/// power. If `useVotingUnits` is false, voting power is based on the tier's price.
-/// @custom:member cantBeRemoved If the tier cannot be removed once added.
-/// @custom:member cannotIncreaseDiscount If the tier cannot have its discount increased.
-/// @custom:member cantBuyWithCredits If true, this tier cannot be purchased using accumulated pay credits. Only fresh
-/// payment value counts toward this tier's price.
+/// @custom:member flags Boolean flags for this tier config (allowOwnerMint, useReserveBeneficiaryAsDefault,
+/// transfersPausable, useVotingUnits, cantBeRemoved, cantIncreaseDiscountPercent, cantBuyWithCredits).
 /// @custom:member splitPercent The percentage of the tier's price that gets routed to the tier's split group when
 /// an NFT from this tier is minted. Out of `JBConstants.SPLITS_TOTAL_PERCENT`.
 /// @custom:member splits The splits to use for this tier's split group. These define where the split portion of the
@@ -43,13 +34,7 @@ struct JB721TierConfig {
     bytes32 encodedIPFSUri;
     uint24 category;
     uint8 discountPercent;
-    bool allowOwnerMint;
-    bool useReserveBeneficiaryAsDefault;
-    bool transfersPausable;
-    bool useVotingUnits;
-    bool cantBeRemoved;
-    bool cantIncreaseDiscountPercent;
-    bool cantBuyWithCredits;
+    JB721TierConfigFlags flags;
     uint32 splitPercent;
     JBSplit[] splits;
 }

package/src/structs/JB721TierConfigFlags.sol

@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+/// @custom:member allowOwnerMint A boolean indicating whether the contract's owner can mint NFTs from this tier
+/// on-demand.
+/// @custom:member useReserveBeneficiaryAsDefault A boolean indicating whether this tier's `reserveBeneficiary` should
+/// be stored as the default beneficiary for all tiers. WARNING: Setting this to `true` overwrites the global
+/// `defaultReserveBeneficiaryOf` for the hook, which affects ALL existing tiers that do not have a tier-specific
+/// reserve beneficiary. Use with caution when calling `adjustTiers` on hooks with existing tiers.
+/// @custom:member transfersPausable A boolean indicating whether transfers for NFTs in this tier can be paused.
+/// @custom:member useVotingUnits A boolean indicating whether the `votingUnits` should be used to calculate voting
+/// power. If `useVotingUnits` is false, voting power is based on the tier's price.
+/// @custom:member cantBeRemoved If the tier cannot be removed once added.
+/// @custom:member cantIncreaseDiscountPercent If the tier cannot have its discount increased.
+/// @custom:member cantBuyWithCredits If true, this tier cannot be purchased using accumulated pay credits. Only fresh
+/// payment value counts toward this tier's price.
+// forge-lint: disable-next-line(pascal-case-struct)
+struct JB721TierConfigFlags {
+    bool allowOwnerMint;
+    bool useReserveBeneficiaryAsDefault;
+    bool transfersPausable;
+    bool useVotingUnits;
+    bool cantBeRemoved;
+    bool cantIncreaseDiscountPercent;
+    bool cantBuyWithCredits;
+}

package/src/structs/JB721TierFlags.sol

@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+/// @custom:member allowOwnerMint A boolean indicating whether the contract's owner can mint NFTs from this tier
+/// on-demand.
+/// @custom:member transfersPausable A boolean indicating whether transfers for NFTs in this tier can be paused.
+/// @custom:member cantBeRemoved A boolean indicating whether attempts to remove this tier will revert.
+/// @custom:member cantIncreaseDiscountPercent If the tier cannot have its discount increased.
+/// @custom:member cantBuyWithCredits If true, this tier cannot be purchased using accumulated pay credits.
+// forge-lint: disable-next-line(pascal-case-struct)
+struct JB721TierFlags {
+    bool allowOwnerMint;
+    bool transfersPausable;
+    bool cantBeRemoved;
+    bool cantIncreaseDiscountPercent;
+    bool cantBuyWithCredits;
+}

package/test/721HookAttacks.t.sol

@@ -3,6 +3,7 @@ pragma solidity 0.8.28;
 
 // forge-lint: disable-next-line(unaliased-plain-import)
 import "./utils/UnitTestSetup.sol";
+import {JB721TierConfigFlags} from "../src/structs/JB721TierConfigFlags.sol";
 
 /// @title 721HookAttacks
 /// @notice Adversarial security tests for JB721TiersHook and JB721TiersHookStore.
@@ -81,13 +82,15 @@ contract NFTHookAttacks is UnitTestSetup {
             encodedIPFSUri: tokenUris[0],
             category: 2,
             discountPercent: 0,
-            allowOwnerMint: false,
-            useReserveBeneficiaryAsDefault: false,
-            transfersPausable: false,
-            cantBeRemoved: false,
-            cantIncreaseDiscountPercent: false,
-            cantBuyWithCredits: false,
-            useVotingUnits: false,
+            flags: JB721TierConfigFlags({
+                allowOwnerMint: false,
+                useReserveBeneficiaryAsDefault: false,
+                transfersPausable: false,
+                useVotingUnits: false,
+                cantBeRemoved: false,
+                cantIncreaseDiscountPercent: false,
+                cantBuyWithCredits: false
+            }),
             splitPercent: 0,
             splits: new JBSplit[](0)
         });
@@ -116,7 +119,7 @@ contract NFTHookAttacks is UnitTestSetup {
     /// @notice Set discount to 100%, verify the effective price for the tier.
     function test_maxDiscountPercent_effectivePrice() public {
         defaultTierConfig.discountPercent = 0;
-        defaultTierConfig.cantIncreaseDiscountPercent = false;
+        defaultTierConfig.flags.cantIncreaseDiscountPercent = false;
 
         JB721TiersHook targetHook = _initHookDefaultTiers(1);
 
@@ -137,7 +140,7 @@ contract NFTHookAttacks is UnitTestSetup {
     /// @notice Try to increase discount when the flag forbids it.
     function test_cantIncreaseDiscountPercent_enforcement() public {
         defaultTierConfig.discountPercent = 10;
-        defaultTierConfig.cantIncreaseDiscountPercent = true;
+        defaultTierConfig.flags.cantIncreaseDiscountPercent = true;
 
         JB721TiersHook targetHook = _initHookDefaultTiers(1);
 
@@ -213,7 +216,7 @@ contract NFTHookAttacks is UnitTestSetup {
     function test_cashOutWeight_afterTierRemoval() public {
         defaultTierConfig.initialSupply = 100;
         defaultTierConfig.votingUnits = 10;
-        defaultTierConfig.useVotingUnits = true;
+        defaultTierConfig.flags.useVotingUnits = true;
 
         ForTest_JB721TiersHook targetHook = _initializeForTestHook(1);
         IJB721TiersHookStore hookStore = targetHook.STORE();
@@ -369,13 +372,15 @@ contract NFTHookAttacks is UnitTestSetup {
             encodedIPFSUri: tokenUris[0],
             category: 1,
             discountPercent: 0,
-            allowOwnerMint: true,
-            useReserveBeneficiaryAsDefault: false,
-            transfersPausable: false,
-            cantBeRemoved: false,
-            cantIncreaseDiscountPercent: false,
-            cantBuyWithCredits: false,
-            useVotingUnits: false,
+            flags: JB721TierConfigFlags({
+                allowOwnerMint: true,
+                useReserveBeneficiaryAsDefault: false,
+                transfersPausable: false,
+                useVotingUnits: false,
+                cantBeRemoved: false,
+                cantIncreaseDiscountPercent: false,
+                cantBuyWithCredits: false
+            }),
             splitPercent: 0,
             splits: new JBSplit[](0)
         });

package/test/E2E/Pay_Mint_Redeem_E2E.t.sol

@@ -20,6 +20,7 @@ import "../utils/TestBaseWorkflow.sol";
 // forge-lint: disable-next-line(unaliased-plain-import)
 import "../../src/interfaces/IJB721TiersHook.sol";
 import {MetadataResolverHelper} from "@bananapus/core-v6/test/helpers/MetadataResolverHelper.sol";
+import {JB721TierConfigFlags} from "../../src/structs/JB721TierConfigFlags.sol";
 
 contract Test_TiersHook_E2E is TestBaseWorkflow {
     using JBRulesetMetadataResolver for JBRuleset;
@@ -796,13 +797,15 @@ contract Test_TiersHook_E2E is TestBaseWorkflow {
                 encodedIPFSUri: tokenUris[i],
                 category: uint24(100),
                 discountPercent: uint8(0),
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false,
+                flags: JB721TierConfigFlags({
+                    allowOwnerMint: false,
+                    useReserveBeneficiaryAsDefault: false,
+                    transfersPausable: false,
+                    useVotingUnits: false,
+                    cantBeRemoved: false,
+                    cantIncreaseDiscountPercent: false,
+                    cantBuyWithCredits: false
+                }),
                 splitPercent: 0,
                 splits: new JBSplit[](0)
             });
@@ -889,13 +892,15 @@ contract Test_TiersHook_E2E is TestBaseWorkflow {
             encodedIPFSUri: tokenUris[0],
             category: uint24(100),
             discountPercent: _discountPercent,
-            allowOwnerMint: false,
-            useReserveBeneficiaryAsDefault: false,
-            transfersPausable: false,
-            useVotingUnits: false,
-            cantBeRemoved: false,
-            cantIncreaseDiscountPercent: false,
-            cantBuyWithCredits: false,
+            flags: JB721TierConfigFlags({
+                allowOwnerMint: false,
+                useReserveBeneficiaryAsDefault: false,
+                transfersPausable: false,
+                useVotingUnits: false,
+                cantBeRemoved: false,
+                cantIncreaseDiscountPercent: false,
+                cantBuyWithCredits: false
+            }),
             splitPercent: 0,
             splits: new JBSplit[](0)
         });