@bananapus/721-hook-v6 0.0.14 → 0.0.15

package/SKILLS.md

@@ -90,7 +90,7 @@ Tiered ERC-721 NFT hook for Juicebox V6 that mints NFTs when a project is paid a
 | `JB721TiersHookFlags` | `bool noNewTiersWithReserves`, `bool noNewTiersWithVotes`, `bool noNewTiersWithOwnerMinting`, `bool preventOverspending`, `bool issueTokensForSplits` | `initialize`, `recordFlags` |
 | `JB721TiersRulesetMetadata` | `bool pauseTransfers`, `bool pauseMintPendingReserves` | Packed into `JBRulesetMetadata.metadata` per-ruleset (bit 0 = pauseTransfers, bit 1 = pauseMintPendingReserves) |
 | `JBPayDataHookRulesetConfig` | `uint48 mustStartAtOrAfter`, `uint32 duration`, `uint112 weight`, `uint32 weightCutPercent`, `IJBRulesetApprovalHook approvalHook`, `JBPayDataHookRulesetMetadata metadata`, `JBSplitGroup[] splitGroups`, `JBFundAccessLimitGroup[] fundAccessLimitGroups` | `JB721TiersHookProjectDeployer` -- wraps core ruleset config with `useDataHookForPay: true` hardcoded |
-| `JBPayDataHookRulesetMetadata` | Same as `JBRulesetMetadata` minus `allowSetCustomToken` (hardcoded false) and `useDataHookForPay` (hardcoded true) and `dataHook` (set to deployed hook). Includes `ownerMustSendPayouts`. | `launchProjectFor`, `launchRulesetsFor`, `queueRulesetsOf` |
+| `JBPayDataHookRulesetMetadata` | Same as `JBRulesetMetadata` minus `useDataHookForPay` (hardcoded true) and `dataHook` (set to deployed hook). | `launchProjectFor`, `launchRulesetsFor`, `queueRulesetsOf` |
 | `JBLaunchProjectConfig` | `string projectUri`, `JBPayDataHookRulesetConfig[] rulesetConfigurations`, `JBTerminalConfig[] terminalConfigurations`, `string memo` | `launchProjectFor` |
 | `JBLaunchRulesetsConfig` | `uint56 projectId`, `JBPayDataHookRulesetConfig[] rulesetConfigurations`, `JBTerminalConfig[] terminalConfigurations`, `string memo` | `launchRulesetsFor` |
 | `JBQueueRulesetsConfig` | `uint56 projectId`, `JBPayDataHookRulesetConfig[] rulesetConfigurations`, `string memo` | `queueRulesetsOf` |
@@ -157,7 +157,7 @@ Each tier has configurable voting power:
 - **Reserve minting is permissionless** but governed by ruleset metadata. Anyone can call `mintPendingReservesFor` as long as `mintPendingReservesPaused` is not set in the current ruleset's metadata.
 - **Reserve + owner-mint mutual exclusion**: Tiers with `allowOwnerMint: true` cannot have a `reserveFrequency`. The store rejects this combination during `recordAddTiers`.
 - `setMetadata` uses `address(this)` as the sentinel for "no change" on `tokenUriResolver` (not `address(0)`). Passing `address(0)` will clear the resolver.
-- `JBPayDataHookRulesetConfig` hardcodes `allowSetCustomToken: false` and `useDataHookForPay: true` when wiring rulesets through the project deployer.
+- `JBPayDataHookRulesetConfig` hardcodes `useDataHookForPay: true` when wiring rulesets through the project deployer. All other metadata fields are passed through.
 - The `_update` override in `JB721TiersHook` checks `tier.transfersPausable` and consults the current ruleset's metadata for `transfersPaused`. Transfers to `address(0)` (burns) are never blocked.
 - **IERC2981 declared but not implemented**: `supportsInterface` returns `true` for `IERC2981`, but no `royaltyInfo` function is implemented. Callers querying `royaltyInfo` will get a revert. This appears intentional -- the interface is declared for future extension or to signal capability to marketplaces that may override behavior.
 - **Tier splits**: Each tier can route a percentage of its mint price to configured split recipients. `splitPercent` is out of `JBConstants.SPLITS_TOTAL_PERCENT` (1,000,000,000). Split group IDs are `uint256(uint160(hookAddress)) | (uint256(tierId) << 160)`.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bananapus/721-hook-v6",
-  "version": "0.0.14",
+  "version": "0.0.15",
   "license": "MIT",
   "repository": {
     "type": "git",

package/src/JB721TiersHookProjectDeployer.sol

@@ -256,7 +256,7 @@ contract JB721TiersHookProjectDeployer is ERC2771Context, JBPermissioned, IJB721
                     pausePay: payDataRulesetConfig.metadata.pausePay,
                     pauseCreditTransfers: payDataRulesetConfig.metadata.pauseCreditTransfers,
                     allowOwnerMinting: payDataRulesetConfig.metadata.allowOwnerMinting,
-                    allowSetCustomToken: false,
+                    allowSetCustomToken: payDataRulesetConfig.metadata.allowSetCustomToken,
                     allowTerminalMigration: payDataRulesetConfig.metadata.allowTerminalMigration,
                     allowSetTerminals: payDataRulesetConfig.metadata.allowSetTerminals,
                     allowSetController: payDataRulesetConfig.metadata.allowSetController,
@@ -324,7 +324,7 @@ contract JB721TiersHookProjectDeployer is ERC2771Context, JBPermissioned, IJB721
                     pausePay: payDataRulesetConfig.metadata.pausePay,
                     pauseCreditTransfers: payDataRulesetConfig.metadata.pauseCreditTransfers,
                     allowOwnerMinting: payDataRulesetConfig.metadata.allowOwnerMinting,
-                    allowSetCustomToken: false,
+                    allowSetCustomToken: payDataRulesetConfig.metadata.allowSetCustomToken,
                     allowTerminalMigration: payDataRulesetConfig.metadata.allowTerminalMigration,
                     allowSetTerminals: payDataRulesetConfig.metadata.allowSetTerminals,
                     allowSetController: payDataRulesetConfig.metadata.allowSetController,
@@ -390,7 +390,7 @@ contract JB721TiersHookProjectDeployer is ERC2771Context, JBPermissioned, IJB721
                     pausePay: payDataRulesetConfig.metadata.pausePay,
                     pauseCreditTransfers: payDataRulesetConfig.metadata.pauseCreditTransfers,
                     allowOwnerMinting: payDataRulesetConfig.metadata.allowOwnerMinting,
-                    allowSetCustomToken: false,
+                    allowSetCustomToken: payDataRulesetConfig.metadata.allowSetCustomToken,
                     allowTerminalMigration: payDataRulesetConfig.metadata.allowTerminalMigration,
                     allowSetTerminals: payDataRulesetConfig.metadata.allowSetTerminals,
                     allowSetController: payDataRulesetConfig.metadata.allowSetController,

package/src/structs/JBPayDataHookRulesetMetadata.sol

@@ -11,6 +11,8 @@ pragma solidity ^0.8.0;
 /// during the funding cycle.
 /// @custom:member allowOwnerMinting A flag indicating if the project owner or an operator with the `MINT_TOKENS`
 /// permission from the owner should be allowed to mint project tokens on demand during this ruleset.
+/// @custom:member allowSetCustomToken A flag indicating if the project owner can set the project's token to a custom
+/// ERC-20.
 /// @custom:member allowTerminalMigration A flag indicating if migrating terminals should be allowed during this
 /// ruleset.
 /// @custom:member allowSetTerminals A flag indicating if a project's terminals can be added or removed.
@@ -33,6 +35,7 @@ struct JBPayDataHookRulesetMetadata {
     bool pausePay;
     bool pauseCreditTransfers;
     bool allowOwnerMinting;
+    bool allowSetCustomToken;
     bool allowTerminalMigration;
     bool allowSetTerminals;
     bool allowSetController;

package/test/E2E/Pay_Mint_Redeem_E2E.t.sol

@@ -814,6 +814,7 @@ contract Test_TiersHook_E2E is TestBaseWorkflow {
             pausePay: false,
             pauseCreditTransfers: false,
             allowOwnerMinting: true,
+            allowSetCustomToken: false,
             allowTerminalMigration: false,
             allowSetTerminals: false,
             allowSetController: false,
@@ -908,6 +909,7 @@ contract Test_TiersHook_E2E is TestBaseWorkflow {
             pausePay: false,
             pauseCreditTransfers: false,
             allowOwnerMinting: true,
+            allowSetCustomToken: false,
             allowTerminalMigration: false,
             allowSetTerminals: false,
             allowSetController: false,

package/test/Fork.t.sol

@@ -239,6 +239,7 @@ contract Fork_721Hook_Test is Test {
             pausePay: false,
             pauseCreditTransfers: false,
             allowOwnerMinting: true,
+            allowSetCustomToken: false,
             allowTerminalMigration: false,
             allowSetTerminals: false,
             allowSetController: false,

package/test/fork/ERC20TierSplitFork.t.sol

@@ -205,6 +205,7 @@ contract ERC20TierSplitFork is Test {
             pausePay: false,
             pauseCreditTransfers: false,
             allowOwnerMinting: true,
+            allowSetCustomToken: false,
             allowTerminalMigration: false,
             allowSetTerminals: false,
             allowSetController: false,
@@ -280,6 +281,7 @@ contract ERC20TierSplitFork is Test {
             pausePay: false,
             pauseCreditTransfers: false,
             allowOwnerMinting: true,
+            allowSetCustomToken: false,
             allowTerminalMigration: false,
             allowSetTerminals: false,
             allowSetController: false,