@ballkidz/defifa 0.0.34 → 0.0.35

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.0.35 — Bump v6 deps to nana-core-v6 0.0.53 cohort
+
+- `@bananapus/core-v6`: `^0.0.48 → ^0.0.53` ([PR #145](https://github.com/Bananapus/nana-core-v6/pull/145)).
+- `@bananapus/721-hook-v6`: `^0.0.46 → ^0.0.50`.
+- `@bananapus/permission-ids-v6`: `^0.0.22 → ^0.0.25`.
+- All `JBRulesetMetadata` literals (src + test) patched to include `pauseCrossProjectFeeFreeInflows: false`.
+
 ## Scope
 
 This repo was not part of the deployed v5 ecosystem that the top-level changelog measures, so it is excluded from the ecosystem delta.
@@ -23,6 +30,7 @@ This file instead describes the current v6 repo at a high level and the broad mi
 ## Local review remediations
 
 - Reserve-minted NFTs are now excluded from refund calculations during MINT, REFUND, and NO_CONTEST phases. A public `isReserveMint` mapping tracks which tokens were created via tier reserve frequency rather than paid for. `beforeCashOutRecordedWith` subtracts their tier price from `cumulativeMintPrice`, preventing reserve beneficiaries from withdrawing funds they never contributed.
+- Reserve minting now caps `count` by `adjustedPendingReservesFor(tierId)` inside `DefifaHook.mintReservesFor`. Without the cap, a caller could request more reserves than the refund-adjusted pending balance, inflating `totalMintCost` from already-refunded mints and breaking the supply-vs-pending-reserves invariant that fee-token claims rely on.
 - One-tier games now revert at launch with `DefifaDeployer_InvalidGameConfiguration` if `scorecardTimeout == 0`. A one-tier game cannot reach quorum (the BWA multiplier reduces the sole tier's power to zero), so a zero timeout would leave funds permanently locked with no exit path. Enforcement moves this from a launcher-side responsibility (previously documented in `RISKS.md §8.6`) to a contract-level guarantee.
 - `DefifaHook.mintReservesFor` now reverts with `DefifaHook_ReservedTokenMintingBlockedInNoContest` while the game is in `NO_CONTEST`. Reserve mints inflate `totalMintCost` so reserved recipients can claim fee tokens; without the block, a game that failed `minParticipation` could be revived back to SCORING via free notional face value before `triggerNoContestFor` latches the failure.
 

package/foundry.toml

@@ -1,5 +1,6 @@
 [profile.default]
 solc = '0.8.28'
+bytecode_hash = "none"
 evm_version = 'cancun'
 via_ir = true
 optimizer_runs = 200

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ballkidz/defifa",
-  "version": "0.0.34",
+  "version": "0.0.35",
   "license": "MIT",
   "engines": {
     "node": "25.9.0"
@@ -31,10 +31,10 @@
     "remappings.txt"
   ],
   "dependencies": {
-    "@bananapus/721-hook-v6": "^0.0.46",
+    "@bananapus/721-hook-v6": "^0.0.50",
     "@bananapus/address-registry-v6": "^0.0.25",
-    "@bananapus/core-v6": "^0.0.48",
-    "@bananapus/permission-ids-v6": "^0.0.22",
+    "@bananapus/core-v6": "^0.0.53",
+    "@bananapus/permission-ids-v6": "^0.0.25",
     "@openzeppelin/contracts": "5.6.1",
     "@prb/math": "4.1.1",
     "scripty.sol": "2.1.1"

package/src/DefifaDeployer.sol

@@ -687,6 +687,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                 ownerMustSendPayouts: true,
                 holdFees: false,
                 scopeCashOutsToLocalBalances: true,
+                pauseCrossProjectFeeFreeInflows: false,
                 useDataHookForPay: true,
                 useDataHookForCashOut: true,
                 dataHook: metadata.dataHook,
@@ -850,6 +851,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                 ownerMustSendPayouts: false,
                 holdFees: false,
                 scopeCashOutsToLocalBalances: true,
+                pauseCrossProjectFeeFreeInflows: false,
                 useDataHookForPay: true,
                 useDataHookForCashOut: true,
                 dataHook: dataHook,
@@ -893,6 +895,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                     ownerMustSendPayouts: false,
                     holdFees: false,
                     scopeCashOutsToLocalBalances: true,
+                    pauseCrossProjectFeeFreeInflows: false,
                     useDataHookForPay: true,
                     useDataHookForCashOut: true,
                     dataHook: dataHook,
@@ -953,6 +956,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                 ownerMustSendPayouts: true,
                 holdFees: false,
                 scopeCashOutsToLocalBalances: true,
+                pauseCrossProjectFeeFreeInflows: false,
                 useDataHookForPay: true,
                 useDataHookForCashOut: true,
                 dataHook: dataHook,
@@ -1008,6 +1012,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                 ownerMustSendPayouts: false,
                 holdFees: false,
                 scopeCashOutsToLocalBalances: true,
+                pauseCrossProjectFeeFreeInflows: false,
                 useDataHookForPay: true,
                 useDataHookForCashOut: true,
                 dataHook: metadata.dataHook,

package/src/DefifaHook.sol

@@ -596,6 +596,11 @@ contract DefifaHook is JB721Hook, Ownable, IDefifaHook {
             });
         }
 
+        // Cap count by the refund-adjusted pending reserves to prevent inflating totalMintCost
+        // from already-refunded mints whose reserve liability no longer exists.
+        uint256 adjusted = adjustedPendingReservesFor(tierId);
+        if (count > adjusted) count = adjusted;
+
         // Record the minted reserves for the tier.
         uint256[] memory tokenIds = hookStore.recordMintReservesFor({tierId: tierId, count: count});