@ballkidz/defifa 0.0.32 → 0.0.35

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.0.35 — Bump v6 deps to nana-core-v6 0.0.53 cohort
+
+- `@bananapus/core-v6`: `^0.0.48 → ^0.0.53` ([PR #145](https://github.com/Bananapus/nana-core-v6/pull/145)).
+- `@bananapus/721-hook-v6`: `^0.0.46 → ^0.0.50`.
+- `@bananapus/permission-ids-v6`: `^0.0.22 → ^0.0.25`.
+- All `JBRulesetMetadata` literals (src + test) patched to include `pauseCrossProjectFeeFreeInflows: false`.
+
 ## Scope
 
 This repo was not part of the deployed v5 ecosystem that the top-level changelog measures, so it is excluded from the ecosystem delta.
@@ -23,6 +30,9 @@ This file instead describes the current v6 repo at a high level and the broad mi
 ## Local review remediations
 
 - Reserve-minted NFTs are now excluded from refund calculations during MINT, REFUND, and NO_CONTEST phases. A public `isReserveMint` mapping tracks which tokens were created via tier reserve frequency rather than paid for. `beforeCashOutRecordedWith` subtracts their tier price from `cumulativeMintPrice`, preventing reserve beneficiaries from withdrawing funds they never contributed.
+- Reserve minting now caps `count` by `adjustedPendingReservesFor(tierId)` inside `DefifaHook.mintReservesFor`. Without the cap, a caller could request more reserves than the refund-adjusted pending balance, inflating `totalMintCost` from already-refunded mints and breaking the supply-vs-pending-reserves invariant that fee-token claims rely on.
+- One-tier games now revert at launch with `DefifaDeployer_InvalidGameConfiguration` if `scorecardTimeout == 0`. A one-tier game cannot reach quorum (the BWA multiplier reduces the sole tier's power to zero), so a zero timeout would leave funds permanently locked with no exit path. Enforcement moves this from a launcher-side responsibility (previously documented in `RISKS.md §8.6`) to a contract-level guarantee.
+- `DefifaHook.mintReservesFor` now reverts with `DefifaHook_ReservedTokenMintingBlockedInNoContest` while the game is in `NO_CONTEST`. Reserve mints inflate `totalMintCost` so reserved recipients can claim fee tokens; without the block, a game that failed `minParticipation` could be revived back to SCORING via free notional face value before `triggerNoContestFor` latches the failure.
 
 ## Migration notes
 

package/RISKS.md

@@ -93,4 +93,16 @@ This is conservative, but it prevents users from front-running reserve dilution
 
 ### 8.6 One-tier games always resolve via no-contest
 
-A single-tier game cannot complete normal governance because the governance attestation model gives zero weight to holders of a tier that receives 100% of the scorecard, making quorum unreachable. This is expected: the game falls through to `NO_CONTEST` once `scorecardTimeout` elapses, and players recover their mint price via the permissionless `triggerNoContestFor()` refund path that queues a refund ruleset. This only works when `scorecardTimeout > 0`. A one-tier game launched with `scorecardTimeout = 0` disables the timeout path entirely, and funds become permanently locked with no exit. Game deployers must ensure `scorecardTimeout > 0` for single-tier configurations.
+A single-tier game cannot complete normal governance because the governance attestation model gives zero weight to holders of a tier that receives 100% of the scorecard, making quorum unreachable. This is expected: the game falls through to `NO_CONTEST` once `scorecardTimeout` elapses, and players recover their mint price via the permissionless `triggerNoContestFor()` refund path that queues a refund ruleset. This only works when `scorecardTimeout > 0` — a one-tier game launched with `scorecardTimeout = 0` would disable the timeout path entirely and leave funds permanently locked. `DefifaDeployer.launchGameWith` now enforces this at the contract level: a one-tier game with `scorecardTimeout == 0` reverts with `DefifaDeployer_InvalidGameConfiguration`. Two-tier games are still rounding-fragile in the same direction and should also be launched with a nonzero `scorecardTimeout`, but this is not enforced because some two-tier configurations can still reach quorum.
+
+### 8.7 Commitment splits are responsible for never reverting
+
+`DefifaDeployer.fulfillCommitmentsOf` calls `terminal.sendPayoutsOf` to distribute the commitment portion of the pot. Core processes splits inside a try/catch — when an individual split reverts (rejecting split hook, recipient terminal that does not accept the game token, fee project with a missing currency feed) the failed amount is silently re-credited to the game's terminal balance and the outer call succeeds. The unpaid commitment funds then remain available to game players via the cash-out path.
+
+This means **a single bad split cannot block the others from being paid**, and the unpaid funds are never lost — but it also means the recipient configured behind the failing split does not get paid through `fulfillCommitmentsOf` and must be settled separately if the game launcher cares. Game launchers are responsible for configuring commitment splits that will not revert under the game's terminal/currency setup. Recipients of commitment splits should treat split delivery as best-effort; the canonical post-game pot accounting still holds.
+
+`fulfilledCommitmentsOf[gameId]` always equals the requested commitment amount whenever any portion was attempted, regardless of whether every split succeeded. `currentGamePotOf(gameId, true)` adds this back to the remaining balance so the displayed pot represents the original pre-commitment value, but the actual on-terminal balance may be higher than the displayed pot when splits silently failed — by exactly the failed split amounts, which remain redeemable by game players. The bound therefore stays one-sided: real balance ≥ reported pot.
+
+### 8.8 Reserve minting is blocked during NO_CONTEST
+
+`DefifaHook.mintReservesFor` reverts with `DefifaHook_ReservedTokenMintingBlockedInNoContest` once `currentGamePhaseOf` reports `NO_CONTEST`. Reserve mints inflate `totalMintCost` so reserved recipients can claim a proportional share of fee tokens. Without this block, a game that failed `minParticipation` could be revived back into a SCORING-eligible state via free notional face value (reserves bump `totalMintCost` over the threshold) before `triggerNoContestFor()` latches the failure into a refund ruleset. The block tightens the §8.4 trust assumption that pending reserves are folded into governance and fee accounting: that remains true while the game is live, but once a game has already failed participation the reserve channel is closed so the no-contest outcome is final.

package/foundry.toml

@@ -1,5 +1,6 @@
 [profile.default]
 solc = '0.8.28'
+bytecode_hash = "none"
 evm_version = 'cancun'
 via_ir = true
 optimizer_runs = 200

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ballkidz/defifa",
-  "version": "0.0.32",
+  "version": "0.0.35",
   "license": "MIT",
   "engines": {
     "node": "25.9.0"
@@ -31,10 +31,10 @@
     "remappings.txt"
   ],
   "dependencies": {
-    "@bananapus/721-hook-v6": "0.0.46",
-    "@bananapus/address-registry-v6": "0.0.25",
-    "@bananapus/core-v6": "0.0.44",
-    "@bananapus/permission-ids-v6": "0.0.22",
+    "@bananapus/721-hook-v6": "^0.0.50",
+    "@bananapus/address-registry-v6": "^0.0.25",
+    "@bananapus/core-v6": "^0.0.53",
+    "@bananapus/permission-ids-v6": "^0.0.25",
     "@openzeppelin/contracts": "5.6.1",
     "@prb/math": "4.1.1",
     "scripty.sol": "2.1.1"

package/src/DefifaDeployer.sol

@@ -425,6 +425,20 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
             });
         }
 
+        // One-tier games cannot reach quorum (the BWA multiplier reduces the sole beneficiary tier's power to zero),
+        // so they must have a nonzero scorecardTimeout to resolve via NO_CONTEST. Without a timeout they would lock
+        // forever with no exit. Two-tier games are also rounding-fragile (see RISKS.md §8.6) and should set a
+        // scorecardTimeout, but this is not enforced at the contract level because some configurations can still
+        // reach quorum with luck-of-the-draw holder distributions.
+        if (launchProjectData.tiers.length == 1 && launchProjectData.scorecardTimeout == 0) {
+            revert DefifaDeployer_InvalidGameConfiguration({
+                start: launchProjectData.start,
+                mintPeriodDuration: launchProjectData.mintPeriodDuration,
+                refundPeriodDuration: launchProjectData.refundPeriodDuration,
+                tierCount: launchProjectData.tiers.length
+            });
+        }
+
         // Reject ERC-20 games with a zero currency. A zero baseCurrency would cause payout limit lookups
         // in fulfillCommitmentsOf to silently fail, skipping all commitment payouts.
         if (launchProjectData.token.token != JBConstants.NATIVE_TOKEN && launchProjectData.token.currency == 0) {
@@ -673,6 +687,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                 ownerMustSendPayouts: true,
                 holdFees: false,
                 scopeCashOutsToLocalBalances: true,
+                pauseCrossProjectFeeFreeInflows: false,
                 useDataHookForPay: true,
                 useDataHookForCashOut: true,
                 dataHook: metadata.dataHook,
@@ -836,6 +851,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                 ownerMustSendPayouts: false,
                 holdFees: false,
                 scopeCashOutsToLocalBalances: true,
+                pauseCrossProjectFeeFreeInflows: false,
                 useDataHookForPay: true,
                 useDataHookForCashOut: true,
                 dataHook: dataHook,
@@ -879,6 +895,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                     ownerMustSendPayouts: false,
                     holdFees: false,
                     scopeCashOutsToLocalBalances: true,
+                    pauseCrossProjectFeeFreeInflows: false,
                     useDataHookForPay: true,
                     useDataHookForCashOut: true,
                     dataHook: dataHook,
@@ -939,6 +956,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                 ownerMustSendPayouts: true,
                 holdFees: false,
                 scopeCashOutsToLocalBalances: true,
+                pauseCrossProjectFeeFreeInflows: false,
                 useDataHookForPay: true,
                 useDataHookForCashOut: true,
                 dataHook: dataHook,
@@ -994,6 +1012,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                 ownerMustSendPayouts: false,
                 holdFees: false,
                 scopeCashOutsToLocalBalances: true,
+                pauseCrossProjectFeeFreeInflows: false,
                 useDataHookForPay: true,
                 useDataHookForCashOut: true,
                 dataHook: metadata.dataHook,

package/src/DefifaHook.sol

@@ -57,6 +57,7 @@ contract DefifaHook is JB721Hook, Ownable, IDefifaHook {
     error DefifaHook_Overspending(uint256 leftoverAmount);
     error DefifaHook_CashoutWeightsAlreadySet(uint256 projectId);
     error DefifaHook_ReservedTokenMintingPaused(uint256 projectId, uint256 tierId);
+    error DefifaHook_ReservedTokenMintingBlockedInNoContest(uint256 projectId, uint256 tierId);
     error DefifaHook_TransfersPaused(uint256 projectId, uint256 tokenId, address from, address to);
     error DefifaHook_Unauthorized(uint256 tokenId, address owner, address caller);
 
@@ -568,6 +569,13 @@ contract DefifaHook is JB721Hook, Ownable, IDefifaHook {
             revert DefifaHook_ReservedTokenMintingPaused({projectId: PROJECT_ID, tierId: tierId});
         }
 
+        // Block reserve minting while the game is in NO_CONTEST. Reserve mints inflate `totalMintCost` (so reserved
+        // recipients can claim fee tokens), which would otherwise let a game that failed `minParticipation` revive
+        // back to SCORING via free notional face value before `triggerNoContestFor` latches the failure.
+        if (_currentGamePhaseOf(PROJECT_ID) == DefifaGamePhase.NO_CONTEST) {
+            revert DefifaHook_ReservedTokenMintingBlockedInNoContest({projectId: PROJECT_ID, tierId: tierId});
+        }
+
         // Cache the store reference in a local variable to avoid repeated SLOAD.
         IJB721TiersHookStore hookStore = store;
 
@@ -588,6 +596,11 @@ contract DefifaHook is JB721Hook, Ownable, IDefifaHook {
             });
         }
 
+        // Cap count by the refund-adjusted pending reserves to prevent inflating totalMintCost
+        // from already-refunded mints whose reserve liability no longer exists.
+        uint256 adjusted = adjustedPendingReservesFor(tierId);
+        if (count > adjusted) count = adjusted;
+
         // Record the minted reserves for the tier.
         uint256[] memory tokenIds = hookStore.recordMintReservesFor({tierId: tierId, count: count});