@ballkidz/defifa 0.0.28 → 0.0.29

package/CRYPTO_ECON.md

@@ -777,11 +777,11 @@ Defifa includes a comprehensive safety system — the **NO_CONTEST** mechanism
 
 #### 9.1.1 Trigger 1: Minimum Participation Threshold
 
-**Mechanism.** At game creation, the organizer sets `minParticipation` — a minimum treasury balance required for the game to proceed to scoring. The `currentGamePhaseOf()` function checks the treasury balance against this threshold before returning SCORING. If the balance is below the threshold, it returns NO_CONTEST.
+**Mechanism.** At game creation, the organizer sets `minParticipation` — a minimum token supply required for the game to proceed to scoring. The `currentGamePhaseOf()` function checks the total token supply (via `CONTROLLER.TOKENS().totalSupplyOf(gameId)`) against this threshold before returning SCORING. If the supply is below the threshold, it returns NO_CONTEST.
 
 **What it solves.** Ghost games with negligible participation skip directly to refundability without requiring any governance action. A 32-team World Cup game with `minParticipation = 1 ETH` won't enter scoring if only 50 people mint (0.5 ETH pot).
 
-**Attack surface.** An adversary who wants to force no-contest can refund enough tokens during the refund phase to push the balance below the threshold. Mitigation: set the threshold conservatively low relative to expected participation (e.g., 10% of the maximum expected pot).
+**Attack surface.** An adversary who wants to force no-contest can cash out enough tokens during the refund phase to push the supply below the threshold. Note that direct balance top-ups (via `addToBalanceOf`) cannot inflate participation since the check uses token supply, not treasury balance. Mitigation: set the threshold conservatively low relative to expected participation.
 
 **Configuration.** Set to 0 to disable. The threshold is set at launch before any minting occurs, so calibration depends on organizer judgment.
 
@@ -820,7 +820,7 @@ The phase resolution follows strict priority:
 
 2. **Explicit trigger is sticky.** Once `noContestTriggeredFor[gameId]` is set, the game stays in NO_CONTEST permanently (cannot transition to SCORING even if conditions change).
 
-3. **Both thresholds are checked independently.** A game can enter NO_CONTEST from either `minParticipation` (balance too low) or `scorecardTimeout` (time elapsed) — whichever condition is met first.
+3. **Both thresholds are checked independently.** A game can enter NO_CONTEST from either `minParticipation` (token supply too low) or `scorecardTimeout` (time elapsed) — whichever condition is met first.
 
 #### 9.1.5 The Default Attestation Delegate
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ballkidz/defifa",
-  "version": "0.0.28",
+  "version": "0.0.29",
   "license": "MIT",
   "engines": {
     "node": "25.9.0"

package/src/DefifaDeployer.sol

@@ -254,13 +254,12 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
         // Get the game's ops data for the safety mechanism checks. Cache to avoid repeated SLOAD.
         DefifaOpsData memory ops = _opsOf[gameId];
 
-        // Check minimum participation threshold: if the treasury balance is below the threshold, the game is
-        // NO_CONTEST.
+        // Check minimum participation threshold using token supply (not terminal balance).
+        // Token supply reflects actual minted participation — direct `addToBalanceOf` top-ups
+        // don't mint tokens and therefore can't bypass this check.
         if (ops.minParticipation > 0) {
-            IJBTerminal terminal = CONTROLLER.DIRECTORY().primaryTerminalOf({projectId: gameId, token: ops.token});
-            uint256 balance = IJBMultiTerminal(address(terminal)).STORE()
-                .balanceOf({terminal: address(terminal), projectId: gameId, token: ops.token});
-            if (balance < ops.minParticipation) return DefifaGamePhase.NO_CONTEST;
+            uint256 totalTokenSupply = CONTROLLER.TOKENS().totalSupplyOf(gameId);
+            if (totalTokenSupply < ops.minParticipation) return DefifaGamePhase.NO_CONTEST;
         }
 
         // Check scorecard ratification timeout: if enough time has passed without a ratified scorecard, the game is
@@ -427,13 +426,19 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
             revert DefifaDeployer_InvalidCurrency();
         }
 
-        // If a scorecard timeout is set, it must exceed the grace period + timelock duration.
+        // If a scorecard timeout is set, it must exceed the full ratification window:
+        // attestation delay (time from scoring start to attestation start) + grace period + timelock.
         // Otherwise the game would enter NO_CONTEST before a scorecard could ever reach SUCCEEDED.
-        if (
-            launchProjectData.scorecardTimeout > 0
-                && launchProjectData.scorecardTimeout
-                    <= launchProjectData.attestationGracePeriod + launchProjectData.timelockDuration
-        ) revert DefifaDeployer_InvalidGameConfiguration();
+        if (launchProjectData.scorecardTimeout > 0) {
+            // Attestation delay: how long after scoring starts before attestations can begin.
+            uint256 attestationDelay = launchProjectData.attestationStartTime > launchProjectData.start
+                ? launchProjectData.attestationStartTime - launchProjectData.start
+                : 0;
+            if (
+                launchProjectData.scorecardTimeout
+                    <= attestationDelay + launchProjectData.attestationGracePeriod + launchProjectData.timelockDuration
+            ) revert DefifaDeployer_InvalidGameConfiguration();
+        }
 
         // Reserve the game ID up front so permissionless project creations cannot invalidate hook deployment.
         gameId = CONTROLLER.PROJECTS().createFor(address(this));

package/src/DefifaTokenUriResolver.sol

@@ -282,9 +282,19 @@ contract DefifaTokenUriResolver is IDefifaTokenUriResolver, IJB721TokenUriResolv
         }
 
         // Concatenate the strings
-        return isEth
-            ? string(abi.encodePacked("\u039E", integerPart, ".", decimalPartStr))
-            : string(abi.encodePacked(integerPart, ".", decimalPartStr, " ", IERC20Metadata(token).symbol()));
+        if (isEth) {
+            return string(abi.encodePacked("\u039E", integerPart, ".", decimalPartStr));
+        }
+
+        // Try to get the token symbol; fall back to a truncated hex address if the call reverts.
+        string memory tokenSymbol;
+        try IERC20Metadata(token).symbol() returns (string memory s) {
+            tokenSymbol = _escapeSvg(s);
+        } catch {
+            tokenSymbol = Strings.toHexString(uint160(token), 20);
+        }
+
+        return string(abi.encodePacked(integerPart, ".", decimalPartStr, " ", tokenSymbol));
     }
 
     /// @notice Gets a substring.