@ballkidz/defifa 0.0.17 → 0.0.18

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ballkidz/defifa",
-  "version": "0.0.17",
+  "version": "0.0.18",
   "license": "MIT",
   "engines": {
     "node": ">=20.0.0"
@@ -13,7 +13,7 @@
     "url": "https://github.com/BallKidz/defifa-collection-deployer"
   },
   "dependencies": {
-    "@bananapus/721-hook-v6": "^0.0.28",
+    "@bananapus/721-hook-v6": "^0.0.30",
     "@bananapus/address-registry-v6": "^0.0.16",
     "@bananapus/core-v6": "^0.0.30",
     "@bananapus/permission-ids-v6": "^0.0.15",

package/references/operations.md

@@ -0,0 +1,27 @@
+# Defifa Operations
+
+## Deployment Surface
+
+- [`src/DefifaDeployer.sol`](../src/DefifaDeployer.sol) is the first stop for launch-time config, phase queueing, and post-ratification fulfillment.
+- [`script/Deploy.s.sol`](../script/Deploy.s.sol) is the deployment entry point when the task is about current wiring rather than game mechanics.
+- [`src/structs/`](../src/structs/) and [`src/enums/`](../src/enums/) define launch data, phase types, and other inputs that often drift from remembered assumptions.
+
+## Change Checklist
+
+- If you edit lifecycle timing, verify phase transitions, no-contest triggers, and the governor's attestation windows together.
+- If you edit hook settlement logic, re-check fee accounting and mint-cost invariants.
+- If you touch governance thresholds or attestation behavior, inspect the governor tests before assuming the change is local.
+- If you touch token metadata or rendering, verify whether the bug belongs in the resolver instead of settlement code.
+
+## Common Failure Modes
+
+- Game-state issue is blamed on the hook even though the deployer queued the wrong phase or timing.
+- Governance behavior looks wrong, but the real issue is stale launch configuration.
+- Settlement changes accidentally affect fee distribution or redemption accounting.
+- Resolver issues get misdiagnosed as hook or governor problems because they surface through NFTs.
+
+## Useful Proof Points
+
+- [`test/Fork.t.sol`](../test/Fork.t.sol) for live-integration assumptions.
+- [`test/TestAuditGaps.sol`](../test/TestAuditGaps.sol) and [`test/TestQALastMile.t.sol`](../test/TestQALastMile.t.sol) for pinned edge cases.
+- [`test/BWAFunctionComparison.t.sol`](../test/BWAFunctionComparison.t.sol) and [`test/DefifaUSDC.t.sol`](../test/DefifaUSDC.t.sol) when currency or accounting context matters.

package/references/runtime.md

@@ -0,0 +1,32 @@
+# Defifa Runtime
+
+## Contract Roles
+
+- [`src/DefifaDeployer.sol`](../src/DefifaDeployer.sol) launches games, manages phase progression, fulfills commitments, and triggers safety exits such as no-contest.
+- [`src/DefifaHook.sol`](../src/DefifaHook.sol) manages the NFT game pieces, delegation, and settlement-side cash-out behavior.
+- [`src/DefifaGovernor.sol`](../src/DefifaGovernor.sol) handles scorecard submission, attestation, quorum, and ratification.
+- [`src/DefifaTokenUriResolver.sol`](../src/DefifaTokenUriResolver.sol) renders game-card metadata.
+- [`src/DefifaProjectOwner.sol`](../src/DefifaProjectOwner.sol) is the ownership helper for the fee project.
+
+## Lifecycle
+
+1. Countdown before minting opens.
+2. Mint phase where players buy outcome NFTs and can delegate attestation power.
+3. Optional refund phase.
+4. Scoring phase where scorecards are submitted, attested, and ratified.
+5. Complete or no-contest settlement depending on governance and safety conditions.
+
+## High-Risk Areas
+
+- Scorecard ratification and quorum assumptions: changes here directly affect who can settle the pot.
+- No-contest and refund behavior: these paths are economic safety valves, not edge-case garnish.
+- Fee accounting and commitment fulfillment: payout ordering and accounting drift can change final redemption value.
+- Hook/governor/deployer coupling: many bugs come from changing one layer while assuming the others are passive.
+
+## Tests To Trust First
+
+- [`test/DefifaGovernor.t.sol`](../test/DefifaGovernor.t.sol) for governance flow.
+- [`test/DefifaNoContest.t.sol`](../test/DefifaNoContest.t.sol) for safety exits.
+- [`test/DefifaFeeAccounting.t.sol`](../test/DefifaFeeAccounting.t.sol) and [`test/DefifaMintCostInvariant.t.sol`](../test/DefifaMintCostInvariant.t.sol) for economic correctness.
+- [`test/DefifaHookRegressions.t.sol`](../test/DefifaHookRegressions.t.sol) and [`test/regression/`](../test/regression/) for pinned regressions.
+- [`test/DefifaSecurity.t.sol`](../test/DefifaSecurity.t.sol) and [`test/DefifaGovernanceHardening.t.sol`](../test/DefifaGovernanceHardening.t.sol) for adversarial cases.

package/src/DefifaDeployer.sol

@@ -7,6 +7,7 @@ import {
     JB721TiersRulesetMetadataResolver
 } from "@bananapus/721-hook-v6/src/libraries/JB721TiersRulesetMetadataResolver.sol";
 import {JB721TierConfig} from "@bananapus/721-hook-v6/src/structs/JB721TierConfig.sol";
+import {JB721TierConfigFlags} from "@bananapus/721-hook-v6/src/structs/JB721TierConfigFlags.sol";
 import {IJBAddressRegistry} from "@bananapus/address-registry-v6/src/interfaces/IJBAddressRegistry.sol";
 import {IJBController, JBRulesetConfig, JBTerminalConfig} from "@bananapus/core-v6/src/interfaces/IJBController.sol";
 import {IJBMultiTerminal} from "@bananapus/core-v6/src/interfaces/IJBMultiTerminal.sol";
@@ -471,13 +472,15 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                 encodedIPFSUri: defifaTier.encodedIPFSUri,
                 category: 0,
                 discountPercent: 0,
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: defifaTier.shouldUseReservedTokenBeneficiaryAsDefault,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: true,
-                cantIncreaseDiscountPercent: true,
-                cantBuyWithCredits: false,
+                flags: JB721TierConfigFlags({
+                    allowOwnerMint: false,
+                    useReserveBeneficiaryAsDefault: defifaTier.shouldUseReservedTokenBeneficiaryAsDefault,
+                    transfersPausable: false,
+                    useVotingUnits: false,
+                    cantBeRemoved: true,
+                    cantIncreaseDiscountPercent: true,
+                    cantBuyWithCredits: false
+                }),
                 splitPercent: 0,
                 splits: new JBSplit[](0)
             });

package/src/DefifaHook.sol

@@ -882,7 +882,7 @@ contract DefifaHook is JB721Hook, Ownable, IDefifaHook {
         uint256[] memory tokenIds;
 
         // Record the mint. The returned token IDs correspond to the tiers passed in.
-        // slither-disable-next-line reentrancy-benign
+        // slither-disable-next-line unused-return,reentrancy-benign
         (tokenIds, leftoverAmount,) = store.recordMint({
             amount: amount,
             tierIds: mintTierIds,
@@ -1083,7 +1083,7 @@ contract DefifaHook is JB721Hook, Ownable, IDefifaHook {
         // Transfers must not be paused (when not minting or burning).
         if (from != address(0)) {
             // If transfers are pausable, check if they're paused.
-            if (tier.transfersPausable) {
+            if (tier.flags.transfersPausable) {
                 // Get a reference to the project's current ruleset.
                 JBRuleset memory ruleset = rulesets.currentOf(PROJECT_ID);
 

package/src/interfaces/IDefifaDeployer.sol

@@ -1,8 +1,8 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 
-import {IJB721TokenUriResolver} from "@bananapus/721-hook-v6/src/interfaces/IJB721TokenUriResolver.sol";
 import {IJBAddressRegistry} from "@bananapus/address-registry-v6/src/interfaces/IJBAddressRegistry.sol";
+import {IJB721TokenUriResolver} from "@bananapus/721-hook-v6/src/interfaces/IJB721TokenUriResolver.sol";
 import {IJBController} from "@bananapus/core-v6/src/interfaces/IJBController.sol";
 import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
 
@@ -13,12 +13,30 @@ import {IDefifaHook} from "./IDefifaHook.sol";
 /// @notice Deploys and manages Defifa prediction games, including lifecycle phase transitions
 /// and commitment fulfillment.
 interface IDefifaDeployer {
+    /// @notice Emitted when a commitment payout fails during fulfillment.
+    /// @param gameId The ID of the game being fulfilled.
+    /// @param amount The amount that failed to pay out.
+    /// @param reason The revert reason bytes from the failed payout.
     event CommitmentPayoutFailed(uint256 indexed gameId, uint256 amount, bytes reason);
 
+    /// @notice Emitted when a split receives a portion of the game pot.
+    /// @param split The split that received funds.
+    /// @param amount The amount sent to the split.
+    /// @param caller The address that triggered the distribution.
     event DistributeToSplit(JBSplit split, uint256 amount, address caller);
 
+    /// @notice Emitted when a game's commitments have been fulfilled.
+    /// @param gameId The ID of the fulfilled game.
+    /// @param pot The total game pot that was fulfilled.
+    /// @param caller The address that triggered fulfillment.
     event FulfilledCommitments(uint256 indexed gameId, uint256 pot, address caller);
 
+    /// @notice Emitted when a new Defifa game is launched.
+    /// @param gameId The ID of the launched game.
+    /// @param hook The hook deployed for the game.
+    /// @param governor The governor responsible for scorecard ratification.
+    /// @param tokenUriResolver The token URI resolver used for the game's NFTs.
+    /// @param caller The address that launched the game.
     event LaunchGame(
         uint256 indexed gameId,
         IDefifaHook indexed hook,
@@ -27,10 +45,19 @@ interface IDefifaDeployer {
         address caller
     );
 
+    /// @notice Emitted when a game is queued into its no-contest phase.
+    /// @param gameId The ID of the game.
+    /// @param caller The address that queued the phase transition.
     event QueuedNoContest(uint256 indexed gameId, address caller);
 
+    /// @notice Emitted when a game is queued into its refund phase.
+    /// @param gameId The ID of the game.
+    /// @param caller The address that queued the phase transition.
     event QueuedRefundPhase(uint256 indexed gameId, address caller);
 
+    /// @notice Emitted when a game is queued into its scoring phase.
+    /// @param gameId The ID of the game.
+    /// @param caller The address that queued the phase transition.
     event QueuedScoringPhase(uint256 indexed gameId, address caller);
 
     /// @notice The fee divisor for base protocol fees (100 / fee percent).

package/src/interfaces/IDefifaGovernor.sol

@@ -8,6 +8,12 @@ import {DefifaTierCashOutWeight} from "../structs/DefifaTierCashOutWeight.sol";
 
 /// @notice Manages the ratification of Defifa scorecards through attestation-based governance.
 interface IDefifaGovernor {
+    /// @notice Emitted when governance is initialized for a game.
+    /// @param gameId The ID of the game.
+    /// @param attestationStartTime The timestamp when attestation begins.
+    /// @param attestationGracePeriod The grace period after attestation begins.
+    /// @param timelockDuration The timelock duration after quorum is met.
+    /// @param caller The address that initialized the game.
     event GameInitialized(
         uint256 indexed gameId,
         uint256 attestationStartTime,
@@ -16,10 +22,25 @@ interface IDefifaGovernor {
         address caller
     );
 
+    /// @notice Emitted when an account attests to a scorecard.
+    /// @param gameId The ID of the game.
+    /// @param scorecardId The ID of the scorecard being attested to.
+    /// @param weight The attestation weight applied.
+    /// @param caller The address that submitted the attestation.
     event ScorecardAttested(uint256 indexed gameId, uint256 indexed scorecardId, uint256 weight, address caller);
 
+    /// @notice Emitted when a scorecard is ratified.
+    /// @param gameId The ID of the game.
+    /// @param scorecardId The ID of the ratified scorecard.
+    /// @param caller The address that ratified the scorecard.
     event ScorecardRatified(uint256 indexed gameId, uint256 indexed scorecardId, address caller);
 
+    /// @notice Emitted when a scorecard is submitted for attestation.
+    /// @param gameId The ID of the game.
+    /// @param scorecardId The ID of the submitted scorecard.
+    /// @param tierWeights The proposed tier cash out weights.
+    /// @param isDefaultAttestationDelegate Whether the submitter is the default attestation delegate.
+    /// @param caller The address that submitted the scorecard.
     event ScorecardSubmitted(
         uint256 indexed gameId,
         uint256 indexed scorecardId,
@@ -28,6 +49,11 @@ interface IDefifaGovernor {
         address caller
     );
 
+    /// @notice Emitted when an attestation is revoked from a scorecard.
+    /// @param gameId The ID of the game.
+    /// @param scorecardId The ID of the scorecard.
+    /// @param account The address whose attestation was revoked.
+    /// @param weight The revoked attestation weight.
     event AttestationRevoked(uint256 indexed gameId, uint256 indexed scorecardId, address account, uint256 weight);
 
     /// @notice The number of attestations for a scorecard.

package/src/interfaces/IDefifaHook.sol

@@ -1,9 +1,9 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 
-import {IJB721Hook} from "@bananapus/721-hook-v6/src/interfaces/IJB721Hook.sol";
 import {IJB721TiersHookStore} from "@bananapus/721-hook-v6/src/interfaces/IJB721TiersHookStore.sol";
 import {IJB721TokenUriResolver} from "@bananapus/721-hook-v6/src/interfaces/IJB721TokenUriResolver.sol";
+import {IJB721Hook} from "@bananapus/721-hook-v6/src/interfaces/IJB721Hook.sol";
 import {JB721TierConfig} from "@bananapus/721-hook-v6/src/structs/JB721TierConfig.sol";
 import {JB721TiersMintReservesConfig} from "@bananapus/721-hook-v6/src/structs/JB721TiersMintReservesConfig.sol";
 import {IJBRulesets} from "@bananapus/core-v6/src/interfaces/IJBRulesets.sol";
@@ -17,6 +17,12 @@ import {IDefifaGamePotReporter} from "./IDefifaGamePotReporter.sol";
 /// @notice The hook interface for Defifa games, extending the 721 hook with game-specific attestation delegation,
 /// scorecard-based cash out weights, and token claiming.
 interface IDefifaHook is IJB721Hook {
+    /// @notice Emitted when an NFT is minted from a contribution.
+    /// @param tokenId The token ID of the minted NFT.
+    /// @param tierId The tier the NFT was minted from.
+    /// @param beneficiary The address that received the NFT.
+    /// @param totalAmountContributed The total amount contributed in the minting transaction.
+    /// @param caller The address that triggered the mint.
     event Mint(
         uint256 indexed tokenId,
         uint256 indexed tierId,
@@ -25,20 +31,43 @@ interface IDefifaHook is IJB721Hook {
         address caller
     );
 
+    /// @notice Emitted when a reserved token is minted.
+    /// @param tokenId The token ID of the minted reserved token.
+    /// @param tierId The tier the reserved token was minted from.
+    /// @param beneficiary The address that received the reserved token.
+    /// @param caller The address that triggered the mint.
     event MintReservedToken(
         uint256 indexed tokenId, uint256 indexed tierId, address indexed beneficiary, address caller
     );
 
+    /// @notice Emitted when a delegate's attestation balance changes for a tier.
+    /// @param delegate The delegate whose attestation balance changed.
+    /// @param tierId The tier whose attestation balance changed.
+    /// @param previousBalance The prior attestation balance.
+    /// @param newBalance The updated attestation balance.
+    /// @param caller The address that triggered the change.
     event TierDelegateAttestationsChanged(
         address indexed delegate, uint256 indexed tierId, uint256 previousBalance, uint256 newBalance, address caller
     );
 
+    /// @notice Emitted when a delegator changes delegates for a tier.
+    /// @param delegator The address changing its delegate.
+    /// @param fromDelegate The previous delegate.
+    /// @param toDelegate The new delegate.
     event DelegateChanged(address indexed delegator, address indexed fromDelegate, address indexed toDelegate);
 
+    /// @notice Emitted when claimable game tokens are claimed.
+    /// @param beneficiary The address receiving the claimed tokens.
+    /// @param defifaTokenAmount The amount of Defifa tokens claimed.
+    /// @param baseProtocolTokenAmount The amount of base protocol tokens claimed.
+    /// @param caller The address that triggered the claim.
     event ClaimedTokens(
         address indexed beneficiary, uint256 defifaTokenAmount, uint256 baseProtocolTokenAmount, address caller
     );
 
+    /// @notice Emitted when tier cash out weights are set.
+    /// @param tierWeights The cash out weights that were set for each tier.
+    /// @param caller The address that set the tier weights.
     event TierCashOutWeightsSet(DefifaTierCashOutWeight[] tierWeights, address caller);
 
     /// @notice The total amount redeemed from this game (refunds not counted).

package/CHANGE_LOG.md

@@ -1,164 +0,0 @@
-# defifa-collection-deployer-v6 Changelog (v5 → v6)
-
-This document describes the changes between `defifa-collection-deployer` (v5) and `defifa-collection-deployer-v6` (v6). Defifa is an on-chain prediction game framework built on Juicebox where players mint NFTs representing outcomes, a governor ratifies scorecard distributions, and winners burn NFTs to claim proportional shares.
-
-## Summary
-
-- **V6 hook migration**: All 721 hook interactions updated from `nana-721-hook-v5` to `nana-721-hook-v6`, including the new tier splits system and `splitPercent` field in `JB721TierConfig`.
-- **Dependency modernization**: Core, permission IDs, address registry, and ownable dependencies all updated to v6. New ecosystem dependencies on `croptop-core-v6` and `revnet-core-v6`.
-- **Error naming standardized**: Error names changed from bare names (e.g., `InvalidCashoutWeights`) to contract-prefixed names (e.g., `DefifaHook_InvalidCashoutWeights`).
-- **Cash out hook spec gains `noop` field**: `beforeCashOutRecordedWith` now returns `noop=false` in all specifications, ensuring the terminal always calls the hook callback.
-- **Compiler/tooling updated**: The v6 repo now builds and tests on Solidity `0.8.28`, matching the rest of the V6 ecosystem.
-- **Game lifecycle preserved**: The core game phases (COUNTDOWN → MINT → REFUND → SCORING → COMPLETE) and governance model (50% quorum, scorecard ratification) remain the same at the product level even though the underlying hook/controller integrations changed.
-
-## ABI Status
-
-This repo does have meaningful ABI migration surface. The main ABI-facing contracts for integrators are:
-- `IDefifaDeployer`
-- `IDefifaHook`
-- `IDefifaGovernor`
-
-The largest ABI risks are:
-- inherited 721-hook/core-v6 struct and return-shape changes flowing through Defifa interfaces;
-- event families now living on v6 interfaces/contracts with prefixed errors and updated dependent types;
-- hook return values that now include v6 `noop`-aware hook-spec structures.
-
----
-
-## 1. Breaking Changes
-
-### 1.1 Dependency Updates
-
-| Dependency | v5 | v6 |
-|------------|----|----|
-| `@bananapus/core` | `v5` | `v6` |
-| `@bananapus/721-hook` | `v5` | `v6` |
-| `@bananapus/address-registry` | `v5` | `v6` |
-| `@bananapus/permission-ids` | `v5` | `v6` (new dependency) |
-| `@openzeppelin/contracts` | `^5.4.0` | `5.2.0` (pinned) |
-| `@croptop/core` | N/A | `v6` (new) |
-| `@rev-net/core` | N/A | `v6` (new) |
-
-### 1.2 Error Naming Convention
-
-All custom errors now use a contract-name prefix:
-
-| v5 | v6 |
-|----|----|
-| `InvalidCashoutWeights` | `DefifaHook_InvalidCashoutWeights` |
-| `InvalidPhase` | `DefifaHook_InvalidPhase` |
-| (and similar for all other errors) | Contract prefix added throughout |
-
-### 1.3 `JBCashOutHookSpecification` Gains `noop` Field
-
-The v6 `JBCashOutHookSpecification` struct has a `noop` boolean field. `DefifaHook.beforeCashOutRecordedWith` returns `noop=false` in all specifications, ensuring the terminal always invokes `afterCashOutRecordedWith` for game-phase-aware cashout processing.
-
-### 1.4 Solidity Version
-
-- **v5:** `pragma solidity 0.8.23`
-- **v6:** `pragma solidity 0.8.28`
-
-### 1.5 721 Hook API Changes
-
-Inherited from `nana-721-hook-v6`:
-- `cashOutWeightOf()` and `totalCashOutWeight()` signatures simplified (removed `JBBeforeCashOutRecordedContext` parameter)
-- `pricingContext()` returns 2 values instead of 3
-- `JB721TierConfig` gained `splitPercent` and `splits` fields
-- `JB721TiersHookFlags` gained `issueTokensForSplits` field
-
-### 1.6 Function-Level Integration Changes
-
-These are the main V6 surface changes integrators should care about:
-- `beforeCashOutRecordedWith(...)` now returns a `JBCashOutHookSpecification` that includes the new `noop` field from core-v6.
-- Any integration constructing or decoding `JB721TierConfig` must account for the added `splitPercent` and `splits` fields.
-- Any integration reading pricing context from the inherited 721 hook must expect 2 return values, not 3.
-- Defifa deployer integrations should re-check `launchGameWith(...)`, `fulfillCommitmentsOf(...)`, `triggerNoContestFor(...)`, `nextPhaseNeedsQueueing(...)`, `safetyParamsOf(...)`, and `timesFor(...)` against the v6 ABIs and dependent core-v6 structs.
-
----
-
-## 2. Game Lifecycle (Unchanged)
-
-The core game phases remain identical between v5 and v6:
-
-```
-COUNTDOWN (ruleset 0) → MINT (ruleset 1) → REFUND (ruleset 2)
-    → SCORING (ruleset 3+) → COMPLETE (after ratification)
-```
-
-Safety mechanisms:
-- **NO_CONTEST**: Triggered if `minParticipation` not met or `scorecardTimeout` exceeded
-- **Scorecard governance**: 50% quorum, tier-delegated voting power with checkpointed snapshots
-- **Grace period**: Minimum 1 day for governance proposals
-
----
-
-## 3. Architecture
-
-### 3.1 Key Contracts
-
-| Contract | Role |
-|----------|------|
-| `DefifaDeployer` | Game factory -- launches projects with phased rulesets, manages fulfillment |
-| `DefifaHook` | ERC-721 hook with game logic, attestation, per-tier cashout weights |
-| `DefifaGovernor` | Shared singleton for scorecard submission/attestation/ratification |
-| `DefifaProjectOwner` | Proxy that receives project NFT and grants deployer permissions |
-| `DefifaTokenUriResolver` | On-chain SVG metadata with dynamic game state |
-
-### 3.2 Deployment Pattern
-
-DefifaHook instances are deployed as minimal proxy clones via `Clones.cloneDeterministic()`:
-- Salt includes `msg.sender` + nonce (prevents cross-caller collision)
-- One-time `initialize()` call per clone
-- Owned by DefifaGovernor for scorecard weight setting
-
-## 4. Events and Errors
-
-The most important integration-facing patterns are:
-- Errors are now consistently contract-prefixed (`DefifaHook_*`, `DefifaDeployer_*`, `DefifaGovernor_*`, `DefifaProjectOwner_*`) instead of using the older unprefixed style.
-- Defifa-specific events remain centered around game launch, phase transitions, fulfillment, scoring, minting, claims, and delegation, but they now live against the V6 hook/controller stack and should be indexed using the V6 ABIs.
-- `CommitmentPayoutFailed`, `LaunchGame`, `QueuedRefundPhase`, `QueuedScoringPhase`, `QueuedNoContest`, `GameInitialized`, `ScorecardSubmitted`, `ScorecardAttested`, `ScorecardRatified`, `Mint`, `MintReservedToken`, `ClaimedTokens`, and `TierCashOutWeightsSet` are the key integration events to watch across the deployer, governor, and hook.
-- Other hook-level events worth indexing for governance clients are `TierDelegateAttestationsChanged` and `DelegateChanged`.
-
-Key runtime errors now exposed by the v6 contracts include:
-- `DefifaDeployer_*` errors such as `DefifaDeployer_InvalidGameConfiguration`, `DefifaDeployer_TerminalNotFound`, `DefifaDeployer_SplitsDontAddUp`, `DefifaDeployer_CantFulfillYet`, and `DefifaDeployer_NoContestAlreadyTriggered`.
-- `DefifaHook_*` errors such as `DefifaHook_InvalidCashoutWeights`, `DefifaHook_InvalidTierId`, `DefifaHook_ReservedTokenMintingPaused`, `DefifaHook_TransfersPaused`, and `DefifaHook_Unauthorized(...)`.
-- `DefifaGovernor_*` errors such as `DefifaGovernor_AlreadyAttested`, `DefifaGovernor_AlreadyRatified`, `DefifaGovernor_DuplicateScorecard`, `DefifaGovernor_NotAllowed`, and `DefifaGovernor_UnknownProposal`.
-
----
-
-## 5. Migration Table
-
-| Aspect | v5 | v6 |
-|--------|----|----|
-| Core dependency | `@bananapus/core-v5` | `@bananapus/core-v6` |
-| 721 hook dependency | `@bananapus/721-hook-v5` | `@bananapus/721-hook-v6` |
-| Permission IDs | Not a direct dependency | `@bananapus/permission-ids-v6` |
-| Error naming | Bare names | Contract-prefixed names |
-| `JBCashOutHookSpecification` | No `noop` field | `noop=false` on all specs |
-| Solidity version | `0.8.23` | `0.8.28` |
-| Game lifecycle | COUNTDOWN->MINT->REFUND->SCORING->COMPLETE | Identical |
-| Governance model | 50% quorum, tier-delegated | Identical |
-
-> **Cross-repo impact**: Uses `nana-721-hook-v6` for all tier management and cashout weight distribution. The `nana-permission-ids-v6` ID shifts affect any hardcoded permission checks. `deploy-all-v6` now includes Defifa as Phase 10, so canonical deployments can source Defifa addresses from the top-level rollout.
-
----
-
-## 6. Post-Audit Fixes (Codex R2)
-
-### 6.1 H-1: Prevent same-block double attestation via checkpoint snapshot
-
-**File:** `DefifaGovernor.sol` -- `attestToScorecardFrom()`
-
-Previously, attestation weight was snapshot at `_scorecard.attestationsBegin`, which could equal `block.timestamp` during the same block as a transfer. This allowed a holder to attest, transfer the NFT, and have the recipient also attest in the same block -- both counting because `upperLookup(block.timestamp)` includes same-block checkpoints.
-
-**Fix:** Changed the checkpoint timestamp to `attestationsBegin - 1`, ensuring only state from before the attestation window opens is visible. Same-block transfer recipients now receive zero attestation weight. Note: NFTs minted in the same block as `attestationsBegin` have zero weight for attestation -- a negligible trade-off since attestation typically happens well after minting.
-
-### 6.2 H-2: Snapshot pending reserves at scorecard submission and include in denominators
-
-**Files:** `DefifaGovernor.sol` -- `submitScorecardFor()`, `getBWAAttestationWeight()`; `DefifaHook.sol` -- `afterCashOutRecordedWith()`
-
-Two related fixes to prevent gaming via pending reserve manipulation:
-
-**Governance (attestation weight):** Previously, `getBWAAttestationWeight()` read pending reserve counts live from the store. Minting reserves between scorecard submission and attestation could inflate a holder's BWA power by removing the pending-reserve dilution. **Fix:** `submitScorecardFor()` now snapshots `numberOfPendingReservesFor()` for every tier into `_pendingReservesSnapshotOf[gameId][scorecardId][tierId]`. `getBWAAttestationWeight()` reads from this snapshot instead of live state, locking the dilution in place regardless of subsequent reserve minting.
-
-**Cash-out (fee token distribution):** Previously, the fee token claim denominator (`_totalMintCost`) only counted minted tokens. Pending (unminted) reserve NFTs were excluded, allowing paid holders to cash out before reserves were minted and claim a disproportionate share of fee tokens ($DEFIFA/$NANA). **Fix:** `afterCashOutRecordedWith()` now passes `_totalMintCost + _pendingReserveMintCost()` as the denominator when distributing fee tokens. The new `_pendingReserveMintCost()` function iterates all tiers and sums `pendingReserves * tier.price`, ensuring pending reserves are accounted for in fee token distribution.