@ballkidz/defifa 0.0.15 → 0.0.17

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ballkidz/defifa",
-  "version": "0.0.15",
+  "version": "0.0.17",
   "license": "MIT",
   "engines": {
     "node": ">=20.0.0"
@@ -13,14 +13,14 @@
     "url": "https://github.com/BallKidz/defifa-collection-deployer"
   },
   "dependencies": {
-    "@bananapus/721-hook-v6": "^0.0.25",
+    "@bananapus/721-hook-v6": "^0.0.28",
     "@bananapus/address-registry-v6": "^0.0.16",
     "@bananapus/core-v6": "^0.0.30",
     "@bananapus/permission-ids-v6": "^0.0.15",
-    "@croptop/core-v6": "^0.0.25",
+    "@croptop/core-v6": "^0.0.26",
     "@openzeppelin/contracts": "^5.6.1",
     "@prb/math": "^4.1.1",
-    "@rev-net/core-v6": "^0.0.23",
+    "@rev-net/core-v6": "^0.0.24",
     "scripty.sol": "^2.1.1"
   },
   "devDependencies": {

package/src/DefifaDeployer.sol

@@ -317,6 +317,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
         if (pot == 0) {
             fulfilledCommitmentsOf[gameId] = 1;
             _queueFinalRuleset({gameId: gameId, metadata: metadata});
+            // slither-disable-next-line reentrancy-events
             emit FulfilledCommitments({gameId: gameId, pot: 0, caller: msg.sender});
             return;
         }
@@ -474,8 +475,9 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
                 useReserveBeneficiaryAsDefault: defifaTier.shouldUseReservedTokenBeneficiaryAsDefault,
                 transfersPausable: false,
                 useVotingUnits: false,
-                cannotBeRemoved: true,
-                cannotIncreaseDiscountPercent: true,
+                cantBeRemoved: true,
+                cantIncreaseDiscountPercent: true,
+                cantBuyWithCredits: false,
                 splitPercent: 0,
                 splits: new JBSplit[](0)
             });
@@ -489,6 +491,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
         }
 
         // Increment the nonce for this deployment.
+        // slither-disable-next-line reentrancy-benign
         uint256 currentNonce = ++_nonce;
 
         // Clone deterministically using sender and nonce to prevent front-running.
@@ -656,6 +659,7 @@ contract DefifaDeployer is IDefifaDeployer, IDefifaGamePhaseReporter, IDefifaGam
         if (totalAbsolutePercent > JBConstants.SPLITS_TOTAL_PERCENT) revert DefifaDeployer_SplitsDontAddUp();
 
         // Store the total absolute percent for use in fulfillCommitmentsOf.
+        // slither-disable-next-line reentrancy-benign
         _commitmentPercentOf[gameId] = totalAbsolutePercent;
 
         // Build the splits array: user splits + Defifa + NANA (NANA last to absorb rounding).

package/src/DefifaHook.sol

@@ -571,6 +571,7 @@ contract DefifaHook is JB721Hook, Ownable, IDefifaHook {
         // Note: reserved mints dilute existing fee token claimants because they increase the total mint cost
         // denominator without contributing new funds to the fee token balances. This is the intended design —
         // reserved recipients receive a proportional claim on fee tokens as if they had paid to mint.
+        // slither-disable-next-line reentrancy-benign
         _totalMintCost += tier.price * count;
 
         for (uint256 i; i < count;) {
@@ -667,6 +668,7 @@ contract DefifaHook is JB721Hook, Ownable, IDefifaHook {
         // Increment the amount redeemed if this is the complete phase.
         bool beneficiaryReceivedTokens;
         if (isComplete) {
+            // slither-disable-next-line reentrancy-benign
             amountRedeemed += context.reclaimedAmount.value;
 
             // Claim the $DEFIFA and $NANA tokens for the user.
@@ -686,6 +688,7 @@ contract DefifaHook is JB721Hook, Ownable, IDefifaHook {
         if (context.reclaimedAmount.value == 0 && !beneficiaryReceivedTokens) revert DefifaHook_NothingToClaim();
 
         // Decrement the paid mint cost by the cumulative mint price of the tokens being burned.
+        // slither-disable-next-line reentrancy-benign
         _totalMintCost -= cumulativeMintPrice;
     }
 
@@ -880,7 +883,7 @@ contract DefifaHook is JB721Hook, Ownable, IDefifaHook {
 
         // Record the mint. The returned token IDs correspond to the tiers passed in.
         // slither-disable-next-line reentrancy-benign
-        (tokenIds, leftoverAmount) = store.recordMint({
+        (tokenIds, leftoverAmount,) = store.recordMint({
             amount: amount,
             tierIds: mintTierIds,
             isOwnerMint: false // Not a manual mint