@ball-lang/engine 1.4.5 → 1.5.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ball-lang/engine",
-  "version": "1.4.5",
+  "version": "1.5.1",
   "description": "Ball language engine — interprets Ball programs in TypeScript/JavaScript. Runs in Node.js and browsers.",
   "type": "module",
   "main": "dist/index.js",

package/src/compiled_engine.ts

@@ -3726,7 +3726,7 @@ export class BallEngine {
       }
       else if ((__sw === 'reversed')) {
         if (!__ball_eq(rawList, null)) {
-          return [...rawList.reversed];
+          return this._manualReverse(rawList);
         }
       }
       else if ((__sw === 'keys')) {
@@ -6078,7 +6078,7 @@ export class BallEngine {
           return _wrapList(self.slice(this._toInt(arg0), (!__ball_eq(end, null) ? this._toInt(end) : null)));
         }
         else if ((__sw === 'reversed')) {
-          return _wrapList([...self.reversed]);
+          return _wrapList(this._manualReverse(self));
         }
         else if ((__sw === 'sort')) {
           if ((typeof arg0 === 'function')) {
@@ -7223,7 +7223,7 @@ export class BallEngine {
         return (() => { const __r: any[] = []; for (const idx of indices) { __r.push(__ball_index(list, idx)); } return __r; })();
       }), ['list_reverse']: ((i) => {
         const input = i;
-        return this._trackListCopy([...this._stdAsList(__ball_index(this._stdAsMap(i), 'list')).reversed]);
+        return this._trackListCopy(this._manualReverse(this._stdAsList(__ball_index(this._stdAsMap(i), 'list'))));
       }), ['list_slice']: ((i) => {
         const input = i;
         let m = this._stdAsMap(i);
@@ -8168,6 +8168,15 @@ export class BallEngine {
     return list;
   }
 
+  _manualReverse(list: any): any {
+    const input = list;
+    let result = [];
+    for (let i = __ball_sub(list.length, 1); (i >= 0); (i--)) {
+      result = (result.push(__ball_index(list, i)), result);
+    }
+    return result;
+  }
+
   _resolveMethod(typeName: any, methodName: any): any {
     let colonIdx = typeName.indexOf(':');
     let modPart = ((colonIdx >= 0) ? typeName.substring(0, colonIdx) : this._currentModule);

package/src/engine_setup.ts

@@ -786,8 +786,19 @@ export function createEngineSetup(mod: EngineModule) {
     _r('list_add', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; const v = m['value'] ?? m['element']; if (l instanceof Set) { l.add(v); return null; } if (Array.isArray(l)) l.push(v); return null; });
     _r('list_add_all', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; const o = m['other'] ?? m['elements'] ?? []; if (Array.isArray(l) && Array.isArray(o)) l.push(...o); return null; });
     _r('list_remove_at', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; const idx = Number(m['index'] ?? 0); return Array.isArray(l) ? l.splice(idx, 1)[0] : null; });
-    _r('list_insert', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; const idx = Number(m['index'] ?? 0); const v = m['value'] ?? m['element']; if (Array.isArray(l)) l.splice(idx, 0, v); return null; });
-    _r('list_clear', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; if (Array.isArray(l)) l.length = 0; return null; });
+    // Both mutate in place AND return the (mutated) list: the encoder wraps
+    // `list.insert(...)` / `list.clear()` statements in
+    // `assign(target: list, value: list_insert(...)/list_clear(...))`
+    // (`mutatingMethods` in encoder.dart), so returning `null` here — as a
+    // literal Dart-`void`-return translation would — reassigns the variable
+    // to `null` instead of the mutated list (issue #64 std-coverage gap:
+    // `385_list_insert_at_index` was the first fixture to actually exercise
+    // the non-cascade `list_insert` path on the TS self-host and caught
+    // this). `list_clear` has the identical bug shape but was previously
+    // only exercised via a cascade (`111_cascade_operator.dart`), which
+    // discards the mutating call's return value and never surfaced it.
+    _r('list_insert', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; const idx = Number(m['index'] ?? 0); const v = m['value'] ?? m['element']; if (Array.isArray(l)) l.splice(idx, 0, v); return l; });
+    _r('list_clear', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; if (Array.isArray(l)) l.length = 0; return l; });
     _r('list_contains', (i: any) => {
       const m = _m(i); const l = m['list'] ?? m['collection'] ?? []; const v = m['value'] ?? m['element'];
       if (l instanceof Set) { if (l.has(v)) return true; if (typeof v === 'number') return l.has(String(v)); if (typeof v === 'string') { const n = Number(v); if (!isNaN(n)) return l.has(n); } return false; }