@ball-lang/engine 1.4.4 → 1.5.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ball-lang/engine",
-  "version": "1.4.4",
+  "version": "1.5.0",
   "description": "Ball language engine — interprets Ball programs in TypeScript/JavaScript. Runs in Node.js and browsers.",
   "type": "module",
   "main": "dist/index.js",

package/src/compiled_engine.ts

@@ -1389,7 +1389,7 @@ export class BallEngine {
     this.moduleHandlers = moduleHandlers;
     this._validateProgramLimits();
     if (enableProfiling) {
-      this._callCounts = new Set();
+      this._callCounts = {};
     }
     for (const handler of this.moduleHandlers) {
       handler.init(this);
@@ -1428,7 +1428,7 @@ export class BallEngine {
   }
 
   profilingReport(): any {
-    return Map.unmodifiable((this._callCounts ?? new Set()));
+    return Map.unmodifiable((this._callCounts ?? {}));
   }
 
   callFunction(module: any, function_: any, input: any): any {
@@ -2212,7 +2212,7 @@ export class BallEngine {
         fields[entry.key] = entry.value;
       }
     }
-    return new BallObject({ typeName: typeName, superObject: __ball_index(instance, '__super__'), fields: fields, methods: (__ball_index(instance, '__methods__') ?? new Set()) });
+    return new BallObject({ typeName: typeName, superObject: __ball_index(instance, '__super__'), fields: fields, methods: (__ball_index(instance, '__methods__') ?? {}) });
   }
 
   async _invokeSuperConstructor(childCtor: any, superclass: any, resolvedParams: any): Promise<any> {
@@ -3726,7 +3726,7 @@ export class BallEngine {
       }
       else if ((__sw === 'reversed')) {
         if (!__ball_eq(rawList, null)) {
-          return [...rawList.reversed];
+          return this._manualReverse(rawList);
         }
       }
       else if ((__sw === 'keys')) {
@@ -4553,7 +4553,7 @@ export class BallEngine {
   _lazyFields(call: any): any {
     const input = call;
     if ((!hasInput(call) || !__ball_eq(whichExpr(call.input), Expression_Expr.messageCreation))) {
-      return new Set();
+      return {};
     }
     let result = {};
     for (const f of call.input.messageCreation.fields) {
@@ -5822,6 +5822,20 @@ export class BallEngine {
     throw new _FlowSignal('goto', { label: label });
   }
 
+  _gotoSignalLabel(signal: any): any {
+    const input = signal;
+    if ((signal instanceof _FlowSignal)) {
+      return (__ball_eq(signal.kind, 'goto') ? signal.label : null);
+    }
+    if ((typeof signal === 'string')) {
+      return signal;
+    }
+    if (((typeof signal === 'object' && signal !== null && !Array.isArray(signal) && !(signal instanceof BallDouble) && !(signal instanceof Set)) && __ball_eq(__ball_index(signal, 'kind'), 'goto'))) {
+      let l = __ball_index(signal, 'label');
+      return ((typeof l === 'string') ? l : null);
+    }
+  }
+
   async _evalLabel(call: any, scope: any): Promise<any> {
     let fields = this._lazyFields(call);
     let label = this._stringFieldVal(fields, 'name');
@@ -5838,13 +5852,13 @@ export class BallEngine {
       } catch (__ball_active_error) {
         const e = __ball_active_error;
         let signal = e;
-        if ((((signal instanceof _FlowSignal) && __ball_eq(signal.kind, 'goto')) && __ball_eq(signal.label, label))) {
+        if (__ball_eq(this._gotoSignalLabel(signal), label)) {
           repeat = true;
         } else {
           throw __ball_active_error;
         }
       }
-      if ((((!repeat && (result instanceof _FlowSignal)) && __ball_eq(result.kind, 'goto')) && __ball_eq(result.label, label))) {
+      if ((!repeat && __ball_eq(this._gotoSignalLabel(result), label))) {
         repeat = true;
       }
     }
@@ -6064,7 +6078,7 @@ export class BallEngine {
           return _wrapList(self.slice(this._toInt(arg0), (!__ball_eq(end, null) ? this._toInt(end) : null)));
         }
         else if ((__sw === 'reversed')) {
-          return _wrapList([...self.reversed]);
+          return _wrapList(this._manualReverse(self));
         }
         else if ((__sw === 'sort')) {
           if ((typeof arg0 === 'function')) {
@@ -7209,7 +7223,7 @@ export class BallEngine {
         return (() => { const __r: any[] = []; for (const idx of indices) { __r.push(__ball_index(list, idx)); } return __r; })();
       }), ['list_reverse']: ((i) => {
         const input = i;
-        return this._trackListCopy([...this._stdAsList(__ball_index(this._stdAsMap(i), 'list')).reversed]);
+        return this._trackListCopy(this._manualReverse(this._stdAsList(__ball_index(this._stdAsMap(i), 'list'))));
       }), ['list_slice']: ((i) => {
         const input = i;
         let m = this._stdAsMap(i);
@@ -8154,6 +8168,15 @@ export class BallEngine {
     return list;
   }
 
+  _manualReverse(list: any): any {
+    const input = list;
+    let result = [];
+    for (let i = __ball_sub(list.length, 1); (i >= 0); (i--)) {
+      result = (result.push(__ball_index(list, i)), result);
+    }
+    return result;
+  }
+
   _resolveMethod(typeName: any, methodName: any): any {
     let colonIdx = typeName.indexOf(':');
     let modPart = ((colonIdx >= 0) ? typeName.substring(0, colonIdx) : this._currentModule);
@@ -8320,7 +8343,8 @@ export class BallEngine {
       }
       if (__ball_eq(typeName, null)) {
         let parts = [];
-        for (const e of map.entries) {
+        let rawMap = (((typeof v === 'object' && v !== null && !Array.isArray(v) && !(v instanceof BallDouble) && !(v instanceof Set)) && !(false /* BallMap is Map in TS */)) ? v : map);
+        for (const e of rawMap.entries) {
           let k = await this._ballToStringAsync(e.key);
           let val = await this._ballToStringAsync(e.value);
           parts = (parts.push(((__ball_to_string(k) + ': ') + __ball_to_string(val))), parts);
@@ -9044,7 +9068,7 @@ export class BallEngine {
     }
     let list = this._stdAsList(fields);
     if (__ball_eq(list, null)) {
-      return new Set();
+      return {};
     }
     let result = {};
     let positional = 1;
@@ -10005,7 +10029,7 @@ function _ballToDouble(value: any): any {
 
 function _ballValueIsSet(v: any): any {
   const input = v;
-  return (((typeof v === 'object' && v !== null && !Array.isArray(v) && !(v instanceof BallDouble) && !(v instanceof Set)) && __ball_eq(v.length, 1)) && (_kBallSetTag in v));
+  return ((typeof v === 'object' && v !== null && !Array.isArray(v) && !(v instanceof BallDouble) && !(v instanceof Set)) && (_kBallSetTag in v));
 }
 
 function _ballIsInt(v: any): any {

package/src/engine_setup.ts

@@ -786,8 +786,19 @@ export function createEngineSetup(mod: EngineModule) {
     _r('list_add', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; const v = m['value'] ?? m['element']; if (l instanceof Set) { l.add(v); return null; } if (Array.isArray(l)) l.push(v); return null; });
     _r('list_add_all', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; const o = m['other'] ?? m['elements'] ?? []; if (Array.isArray(l) && Array.isArray(o)) l.push(...o); return null; });
     _r('list_remove_at', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; const idx = Number(m['index'] ?? 0); return Array.isArray(l) ? l.splice(idx, 1)[0] : null; });
-    _r('list_insert', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; const idx = Number(m['index'] ?? 0); const v = m['value'] ?? m['element']; if (Array.isArray(l)) l.splice(idx, 0, v); return null; });
-    _r('list_clear', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; if (Array.isArray(l)) l.length = 0; return null; });
+    // Both mutate in place AND return the (mutated) list: the encoder wraps
+    // `list.insert(...)` / `list.clear()` statements in
+    // `assign(target: list, value: list_insert(...)/list_clear(...))`
+    // (`mutatingMethods` in encoder.dart), so returning `null` here — as a
+    // literal Dart-`void`-return translation would — reassigns the variable
+    // to `null` instead of the mutated list (issue #64 std-coverage gap:
+    // `385_list_insert_at_index` was the first fixture to actually exercise
+    // the non-cascade `list_insert` path on the TS self-host and caught
+    // this). `list_clear` has the identical bug shape but was previously
+    // only exercised via a cascade (`111_cascade_operator.dart`), which
+    // discards the mutating call's return value and never surfaced it.
+    _r('list_insert', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; const idx = Number(m['index'] ?? 0); const v = m['value'] ?? m['element']; if (Array.isArray(l)) l.splice(idx, 0, v); return l; });
+    _r('list_clear', (i: any) => { const m = _m(i); const l = m['list'] ?? m['collection']; if (Array.isArray(l)) l.length = 0; return l; });
     _r('list_contains', (i: any) => {
       const m = _m(i); const l = m['list'] ?? m['collection'] ?? []; const v = m['value'] ?? m['element'];
       if (l instanceof Set) { if (l.has(v)) return true; if (typeof v === 'number') return l.has(String(v)); if (typeof v === 'string') { const n = Number(v); if (!isNaN(n)) return l.has(n); } return false; }