@bakery-framework/orm 1.2.3 → 2.0.0-alpha.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bakery-framework/orm",
-  "version": "1.2.3",
+  "version": "2.0.0-alpha.2",
   "description": "Bakery database layer: adapters, query builder, schema sync and backup.",
   "keywords": [
     "bakery",
@@ -54,6 +54,6 @@
     "bun": ">=1.3.14"
   },
   "dependencies": {
-    "@bakery-framework/core": "^1.0.0"
+    "@bakery-framework/core": "^1.2.3"
   }
 }

package/src/adapters/base.ts

@@ -768,14 +768,6 @@ export abstract class SQLAdapter {
     })
   }
 
-  /**
-   * A `CHECK (col IN (…))` clause restricting a column to a set of values.
-   *
-   * Takes the column name because a CHECK has to name it, which is why
-   * `colDef` grew an optional `column` argument. Values bind nowhere — this is
-   * DDL — so they are quoted the same way `formatDefault` quotes a string
-   * default, by doubling the single quote.
-   */
   /**
    * The declared width of a **sized** text column, or `undefined`.
    *
@@ -804,6 +796,13 @@ export abstract class SQLAdapter {
     return Number.isInteger(n) && n > 0 ? n : undefined
   }
 
+  /**
+   * A `CHECK (col IN (…))` clause restricting a column to a set of values.
+   *
+   * Takes the column name because a CHECK has to name it. Values bind nowhere —
+   * this is DDL — so they are quoted the same way `formatDefault` quotes a
+   * string default, by doubling the single quote.
+   */
   protected enumClause(column: string, values: string[]): string {
     const list = values
       .map(v => `'${String(v).replaceAll("'", "''")}'`)

package/src/orm/index.ts

@@ -12,9 +12,8 @@
  * `TypeError: undefined is not an object (evaluating 'Mutation.Insert')`.
  *
  * Biome's `organizeImports` sorts these alphabetically and puts `./mutation`
- * first. That happened during the 2026-08-09 sweep and cost 12 tests; the
- * compiler cannot see it, because the types are fine either way. Hence the
- * suppression.
+ * first. The compiler cannot see the breakage, because the types are fine
+ * either way. Hence the suppression.
  */
 // biome-ignore-all assist/source/organizeImports: cycle — see above
 import { DB } from './query'

package/src/orm/query.ts

@@ -1072,6 +1072,16 @@ export namespace DB {
     if (op === 'IS NULL' || op === 'IS NOT NULL') {
       return `${left} ${op}`
     }
+    // A bound NULL can never satisfy `=` or `<>` — three-valued logic makes
+    // both comparisons UNKNOWN for every row, so `where(col, null)` silently
+    // matched nothing while cheerfully reporting success. The caller who
+    // passes an explicit null means the SQL spelling of it. Only literal
+    // values: a column reference on the right is a different comparison and
+    // is left alone.
+    if (rightArg === null && !isRightColumn) {
+      if (op === '=') return `${left} IS NULL`
+      if (op === '!=' || op === '<>') return `${left} IS NOT NULL`
+    }
     if (op === 'BETWEEN' && Array.isArray(rightArg)) {
       const min = evalOperands(rightArg[0], params, false)
       const max = evalOperands(rightArg[1], params, false)

package/src/schema-registry.ts

@@ -36,18 +36,15 @@ import type { MapOf } from '@bakery-framework/core/types'
 
 // Augmented by the app; empty until then.
 //
-// **It has to be an `interface`, and the empty body is the point.** Biome's
 // **`interface`, not `type`, and the empty body is the point.** A type alias
 // cannot be declaration-merged, so rewriting this to `type X = {}` turns every
 // app's `declare module '@bakery-framework/orm/schema-registry'` into
 // `TS2300: Duplicate identifier` and the whole schema registry stops working.
 //
-// Biome's `noBannedTypes` proposed exactly that rewrite and called it a safe
-// fix; the 2026-08-09 sweep applied it and `bun run typecheck` was the only
-// thing that caught it. That rule is off repo-wide now — it had no true
-// positives here — but `noEmptyInterface` reaches the same construct and
-// offers the same fix, so the suppression stays. The compiler is the real
-// guard: change this line and `apps/starter` fails to typecheck.
+// Biome's `noBannedTypes` proposes exactly that rewrite and calls it a safe
+// fix. That rule is off repo-wide now, but `noEmptyInterface` reaches the same
+// construct and offers the same fix, so the suppression stays. The compiler is
+// the real guard: change this line and `apps/starter` fails to typecheck.
 // biome-ignore lint/suspicious/noEmptyInterface: must stay mergeable — above
 export interface SchemaRegistry {}
 

package/src/sync/builder.ts

@@ -503,21 +503,6 @@ ${body}`
     return `${result}  } as const;\n`
   }
 
-  /**
-   * The `orm/` folder layout's `schema.ts`: `table()` values and nothing else.
-   *
-   * The generator only ever emitted the `DBInfo` namespace, and for a folder
-   * project the write target is `orm/schema.ts` — which `orm/index.ts`
-   * re-exports. So a regeneration replaced every `table()` with a namespace
-   * *and* added a second `declare module '@bakery-framework/orm/schema-registry'` block
-   * colliding with the one in `index.ts`. It fired on `--choose=db` and, less
-   * visibly, after any sync involving `old()` wrappers.
-   *
-   * Tables only, deliberately: `index.ts` owns the re-exports and the schema
-   * registration, `indexes.ts` owns the index and unique declarations, and
-   * neither is the generator's to rewrite. That separation is the reason the
-   * folder layout exists (see `load.ts`).
-   */
   /**
    * The constraints key a `_references.table` names, or `undefined`.
    *
@@ -604,6 +589,16 @@ ${body}`
       : `Field.Foreign(${target})`
   }
 
+  /**
+   * The `orm/` folder layout's `schema.ts`: `table()` values and nothing else.
+   *
+   * Tables only, deliberately: `index.ts` owns the re-exports and the schema
+   * registration, `indexes.ts` owns the index and unique declarations, and
+   * neither is the generator's to rewrite. Emitting the single-file `DBInfo`
+   * namespace here instead would clobber both and leave two colliding
+   * `declare module '@bakery-framework/orm/schema-registry'` blocks. That
+   * separation is the reason the folder layout exists (see `load.ts`).
+   */
   private static buildTableModule(
     constraints: Record<string, any>,
     adapter: SQLAdapter,

package/src/sync/engine.ts

@@ -95,22 +95,14 @@ export const MESSAGES = messageLogger(logger, syncMsgs)
 /**
  * Whether a destructive sync in this process needs an explicit `--force-sync`.
  *
- * The second half used to read `process.env.PROD === 'true'`, which could
- * never be true: `core/init.ts` installs `PROD` on `process.env` with
- * `Object.defineProperties` as a getter returning a **boolean**, so the guard
- * on the most destructive operation the framework performs rested entirely on
- * `NODE_ENV`. `import.meta.env` is the same object as `process.env` and
- * `import.meta.env.PROD` is the framework's idiom for reading these flags.
- *
- * The dead term was **deleted rather than repaired**, and that is the whole
- * decision here. `import.meta.env.PROD` means only "`--dev` is absent", and
- * `db:sync` is a separate CLI invocation that never passes `--dev` — so for
- * this caller the flag is a constant `true`, carrying no information about the
- * environment at all. Activating it would not have made the guard smarter; it
- * would have made the `isProd` branch unconditional and left `handleSafetyChecks`'s
- * interactive `Proceed with sync?` unreachable for the one workflow it exists
- * for. That is dead code traded for different dead code, plus a silent UX
- * change to the documented way of applying a schema.
+ * **`NODE_ENV` is the only term, deliberately — do not add a `PROD` check back.**
+ * There used to be a `process.env.PROD === 'true'` half that could never be
+ * true, since `core/init.ts` installs `PROD` as a getter returning a *boolean*.
+ * Repairing it rather than deleting it would have been worse: `PROD` means only
+ * "`--dev` is absent", and `db:sync` is a separate CLI invocation that never
+ * passes `--dev`, so for this caller it is a constant `true`. That would make
+ * the `isProd` branch unconditional and leave `handleSafetyChecks`'s interactive
+ * `Proceed with sync?` unreachable for the one workflow it exists for.
  *
  * `NODE_ENV` is the only term that actually says "deployment", which is what
  * the guard is protecting against. Set it, and a destructive plan requires

package/src/sync/load.ts

@@ -1,8 +1,3 @@
-import { Case, fs } from '@bakery-framework/core/utils'
-import { Try } from '@bakery-framework/core/utils/common'
-import { collectConstraints } from '../define'
-import type * as SyncTypes from './types'
-
 /**
  * Where a project's data model lives, and how it is read.
  *
@@ -33,6 +28,12 @@ import type * as SyncTypes from './types'
  * a fresh one at the typo'd path while the real model sits untouched
  * somewhere else.
  */
+
+import { Case, fs } from '@bakery-framework/core/utils'
+import { Try } from '@bakery-framework/core/utils/common'
+import { collectConstraints } from '../define'
+import type * as SyncTypes from './types'
+
 /**
  * Which shape the generator must write back.
  *

package/src/sync/types.ts

@@ -60,14 +60,6 @@ export interface IndexConstraint {
   refCols?: string[]
 }
 
-/**
- * A foreign key as the database reports it.
- *
- * Identity is the tuple, not the name: SQLite's `PRAGMA foreign_key_list`
- * does not return a constraint name at all, so keying on one would make every
- * SQLite foreign key look new on every sync — the perpetual-rebuild failure
- * this project keeps hitting.
- */
 /**
  * Referential actions, normalised to the SQL spelling.
  *
@@ -83,6 +75,13 @@ export type ForeignKeyAction =
   | 'SET NULL'
   | 'SET DEFAULT'
 
+/**
+ * A foreign key as the database reports it.
+ *
+ * Identity is the tuple, not the name: SQLite's `PRAGMA foreign_key_list` does
+ * not return a constraint name at all, so keying on one would make every SQLite
+ * foreign key look new on every sync.
+ */
 export interface ForeignKeyInfo {
   table: string
   cols: string[]