@bahmutov/cy-grep 1.1.0 → 1.2.0

package/README.md

@@ -19,7 +19,7 @@ All other tests will be marked pending, see why in the [Cypress test statuses](h
 
 If you have multiple spec files, all specs will be loaded, and every test will be filtered the same way, since the grep is run-time operation and cannot eliminate the spec files without loading them. If you want to run only specific tests, use the built-in [--spec](https://on.cypress.io/command-line#cypress-run-spec-lt-spec-gt) CLI argument.
 
-Watch the video [intro to cypress-grep plugin](https://www.youtube.com/watch?v=HS-Px-Sghd8)
+Watch the video [intro to cypress-grep plugin](https://www.youtube.com/watch?v=HS-Px-Sghd8) and study my 🎓 Cypress course [Cypress Plugins](https://cypress.tips/courses/cypress-plugins).
 
 Table of Contents
 
@@ -81,7 +81,8 @@ yarn add -D @bahmutov/cy-grep
 **required:** load this module from the [support file](https://on.cypress.io/writing-and-organizing-tests#Support-file) or at the top of the spec file if not using the support file. You import the registration function and then call it:
 
 ```js
-// cypress/support/index.js
+// cypress/support/e2e.js
+
 // load and register the grep feature using "require" function
 // https://github.com/bahmutov/cy-grep
 const registerCypressGrep = require('@bahmutov/cy-grep')
@@ -90,7 +91,7 @@ registerCypressGrep()
 // if you want to use the "import" keyword
 // note: `./index.d.ts` currently extends the global Cypress types and
 // does not define `registerCypressGrep` so the import path is directly
-// pointed to the `support.js` file
+// pointed to the support file
 import registerCypressGrep from '@bahmutov/cy-grep/src/support'
 registerCypressGrep()
 
@@ -111,13 +112,14 @@ registerCypressGrep()
   e2e: {
     setupNodeEvents(on, config) {
       require('@bahmutov/cy-grep/src/plugin')(config);
+      // IMPORTANT: return the config object
       return config;
-  },
+    },
   }
 }
 ```
 
-Installing the plugin via `setupNodeEvents()` is required to enable the [grepFilterSpecs](#grepfilterspecs) feature.
+Installing the plugin via `setupNodeEvents()` is required to enable the [grepFilterSpecs](#pre-filter-specs-grepfilterspecs) feature.
 
 ## Usage Overview
 
@@ -353,9 +355,12 @@ $ npx cypress run --env grepTags=@smoke,grepFilterSpecs=true
 **Tip:** you can set this environment variable in the [config file](https://docs.cypress.io/guides/references/configuration) file to enable it by default and skip using the environment variable:
 
 ```js
+// config file
 {
-  "env": {
-    "grepFilterSpecs": true
+  "e2e": {
+    "env": {
+      "grepFilterSpecs": true
+    }
   }
 }
 ```
@@ -505,20 +510,23 @@ Once the tests finish, you can run just the failed tests from DevTools console
 
 **Tip:** use `Cypress.grep()` to reset and run all the tests
 
+📝 Read the blog post [Run Just The Failed Tests In Cypress](https://glebbahmutov.com/blog/run-failed-tests/).
+
 ## Debugging
 
-When debugging a problem, first make sure you are using the expected version of this plugin, as some features might be only available in the [later releases](https://github.com/cypress-io/cypress-grep/releases).
+When debugging a problem, first make sure you are using the expected version of this plugin, as some features might be only available in the [later releases](https://github.com/bahmutov/cy-grep/releases).
 
 ```
-# get the cypress-grep version using NPM
-$ npm ls cypress-grep
+# get the plugin's version using NPM
+$ npm ls @bahmutov/cy-grep
 ...
-└── cypress-grep@2.10.1
-# get the cypress-grep version using Yarn
-$ yarn why cypress-grep
+└── @bahmutov/cy-grep@1.1.0
+
+# get the plugin's version using Yarn
+$ yarn why @bahmutov/cy-grep
 ...
-=> Found "cypress-grep@2.10.1"
-info Has been hoisted to "cypress-grep"
+=> Found "@bahmutov/cy-grep@1.1.0"
+info Has been hoisted to "@bahmutov/cy-grep"
 info This module exists because it's specified in "devDependencies".
 ...
 ```

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bahmutov/cy-grep",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "Filter Cypress tests using title or tags",
   "main": "src/support.js",
   "scripts": {

package/src/plugin.js

@@ -1,6 +1,6 @@
 const debug = require('debug')('cypress-grep')
 const globby = require('globby')
-const { getTestNames } = require('find-test-names')
+const { getTestNames, findEffectiveTestTags } = require('find-test-names')
 const fs = require('fs')
 const { version } = require('../package.json')
 const { parseGrep, shouldTestRun } = require('./utils')
@@ -9,7 +9,7 @@ const { parseGrep, shouldTestRun } = require('./utils')
  * Prints the cypress-grep environment values if any.
  * @param {Cypress.ConfigOptions} config
  */
-function cypressGrepPlugin (config) {
+function cypressGrepPlugin(config) {
   if (!config || !config.env) {
     return config
   }
@@ -117,15 +117,14 @@ function cypressGrepPlugin (config) {
         const text = fs.readFileSync(specFile, { encoding: 'utf8' })
 
         try {
-          const testInfo = getTestNames(text)
-
+          const testTags = findEffectiveTestTags(text)
+          // we get back a single object with keys being full test titles
+          // and the values being arrays of effective test tags
           debug('spec file %s', specFile)
-          debug('test info: %o', testInfo.tests)
-
-          return testInfo.tests.some((info) => {
-            const shouldRun = shouldTestRun(parsedGrep, null, info.tags)
-
-            return shouldRun
+          debug('effective test tags %o', testTags)
+          return Object.keys(testTags).some((testTitle) => {
+            const effectiveTags = testTags[testTitle]
+            return shouldTestRun(parsedGrep, null, effectiveTags)
           })
         } catch (err) {
           console.error('Could not determine test names in file: %s', specFile)