@bacnh85/pi-serena 0.2.0 → 0.3.0

package/index.ts

@@ -3,6 +3,7 @@ import { Type } from "typebox";
 import { withFileMutationQueue } from "@earendil-works/pi-coding-agent";
 import path from "node:path";
 import { SerenaWorkerClient, type SerenaWorkerResponse } from "./worker";
+import { SEMANTIC_MISS_THRESHOLD, pathLooksLikeCode, pathLooksNonSemantic, commandLooksLikeSemanticCodeSearch } from "./lib/detect";
 
 const DEFAULT_CONTEXT = "ide";
 
@@ -209,56 +210,6 @@ function resultText(response: SerenaWorkerResponse): string {
 	return truncateText(text);
 }
 
-const CODE_FILE_EXTENSIONS = new Set([
-	".c",
-	".cc",
-	".cpp",
-	".cs",
-	".css",
-	".go",
-	".java",
-	".js",
-	".jsx",
-	".kt",
-	".lua",
-	".mjs",
-	".php",
-	".py",
-	".rb",
-	".rs",
-	".scala",
-	".sh",
-	".swift",
-	".ts",
-	".tsx",
-	".vue",
-]);
-
-const NON_SEMANTIC_FILE_EXTENSIONS = new Set([".json", ".jsonl", ".lock", ".md", ".txt", ".yaml", ".yml"]);
-
-function pathLooksLikeCode(value: unknown): boolean {
-	if (typeof value !== "string" || value.trim() === "") return false;
-	const cleanPath = value.split(/[?#]/, 1)[0].toLowerCase();
-	const dotIndex = cleanPath.lastIndexOf(".");
-	if (dotIndex < 0) return false;
-	return CODE_FILE_EXTENSIONS.has(cleanPath.slice(dotIndex));
-}
-
-function pathLooksNonSemantic(value: unknown): boolean {
-	if (typeof value !== "string" || value.trim() === "") return false;
-	const cleanPath = value.split(/[?#]/, 1)[0].toLowerCase();
-	const dotIndex = cleanPath.lastIndexOf(".");
-	if (dotIndex < 0) return false;
-	return NON_SEMANTIC_FILE_EXTENSIONS.has(cleanPath.slice(dotIndex));
-}
-
-function commandLooksLikeSemanticCodeSearch(command: string): boolean {
-	if (!/\b(rg|grep|fd|find)\b/.test(command)) return false;
-	if (/\b(SKILL\.md|README\.md|AGENTS\.md|package\.json|skill-registry\.json|skill-history\.jsonl)\b/i.test(command)) return false;
-	if (/\b(symbol|class|method|function|def|interface|references?|implementation|declaration|rename|refactor)\b/i.test(command)) return true;
-	return /\.(c|cc|cpp|cs|go|java|js|jsx|kt|lua|mjs|php|py|rb|rs|scala|sh|swift|ts|tsx|vue)\b/i.test(command);
-}
-
 export default function serenaToolsExtension(pi: ExtensionAPI) {
 	let worker: SerenaWorkerClient | undefined;
 	let semanticMissCount = 0;
@@ -575,23 +526,12 @@ export default function serenaToolsExtension(pi: ExtensionAPI) {
 		},
 	});
 
-	pi.on("before_agent_start", async (event) => {
-		const prompt = event.prompt.toLowerCase();
-		if (/\b(find references|rename|refactor|symbol|declaration|implementation|diagnostic|large repo|semantic|class|method|function|investigate|understand|explore|search for|look at|find where|navigate|trace|examine|where is|what does)\b/.test(prompt)) {
-			return {
-				systemPrompt:
-					event.systemPrompt +
-					"\n\nSerena semantic tools are available as Pi-native tools. For symbol lookup, references, semantic code navigation, whole-symbol edits, safe deletion, or cross-file renames, prefer serena_* tools before repeated grep/read/edit operations. Use normal Pi tools for small exact text edits and non-code files.",
-			};
-		}
-	});
-
-	// Unconditional Serena guidance on every session (like pi-subagent's agent-list hook)
+	// Unconditional Serena guidance on every session
 	pi.on("before_agent_start", async (event) => {
 		return {
 			systemPrompt:
 				event.systemPrompt +
-				"\n\nSerena semantic tools are available for code-symbol work: serena_find_symbol, serena_get_symbols_overview, serena_find_referencing_symbols, and more. Prefer these over repeated grep/read for exploring code structure, finding symbols, navigating references, and whole-symbol edits. Normal read/search tools remain appropriate for Markdown, JSON/YAML, docs, and exact text edits.",
+				"\n\nSerena semantic tools are available for code-symbol work. For finding symbols, references, declarations, implementations, and refactoring targets, prefer serena_find_symbol / serena_get_symbols_overview / serena_find_referencing_symbols over grep/read. Use grep/read for exact text searches, docs, configs, and non-code files.",
 		};
 	});
 
@@ -612,13 +552,13 @@ export default function serenaToolsExtension(pi: ExtensionAPI) {
 
 		if (!looksLikeSemanticMiss) return;
 		semanticMissCount += 1;
-		if (semanticMissCount >= 4) {
+		if (semanticMissCount >= 2) {
 			semanticMissCount = 0;
 			pi.sendMessage(
 				{
 					customType: "serena-reminder",
 					content:
-						"Reminder: Serena semantic tools are available for code-symbol work. If you are searching code for symbols, references, declarations, implementations, or refactor targets, switch to serena_find_symbol / serena_get_symbols_overview / serena_find_referencing_symbols instead of more grep/read calls. Normal read/search tools are still appropriate for Markdown, JSON/YAML, docs, and exact text edits.",
+						"Reminder: you are reading code files instead of using Serena semantic tools. For symbols, references, declarations, implementations, and refactoring, use serena_find_symbol / serena_get_symbols_overview / serena_find_referencing_symbols instead of more grep/read calls. Keep using read/grep for docs, configs, non-code files, and exact text searches.",
 					display: true,
 				},
 				{ deliverAs: "steer", triggerTurn: true },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bacnh85/pi-serena",
-  "version": "0.2.0",
+  "version": "0.3.0",
   "description": "Pi extension that provides Serena semantic code tools through a persistent worker.",
   "license": "MIT",
   "publishConfig": {
@@ -34,5 +34,11 @@
   "peerDependencies": {
     "@earendil-works/pi-coding-agent": "*",
     "typebox": "*"
+  },
+  "devDependencies": {
+    "@types/node": "^20.19.43",
+    "chai": "^4.5.0",
+    "mocha": "^10.8.2",
+    "tsx": "^4.22.4"
   }
 }